d232a3f
CustomerRepo::QueryKey and CustomerRepo#find_by_format
Click to expand commit body
Introduce objects representing the different kind of query keys that can be used
to look up a customer. These keys know how to use themselves to get
the (customer_id, jid) pair that is needed for an actual repo lookup. All
find_by_* methods are now just trivial wrappers over these objects that pass on
to find_inner.
This enables the easy creation of a new helper: QueryKey.for, used as
find_by_format which allows passing an xmpp: URI, or a properly formatted tel,
or a customer id, and will find by the correct one. This could cause a problem
if a customer id were to be a valid xmpp: URI or a formatted tel, so this method
does assume not using these formats for any customer id (which would be
ill-advised in any case).
This is based on a hotfix in prod. In this case someone appeared to have
talked to an @jmp.chat address directly. In normal circumstances this
shouldn't happen, but it's not technically disallowed, so we probably
shouldn't just crash.
653ad29
Do not deliver transcription if voicemail is less than 5 seconds
Click to expand commit body
Will suppress bogus messages transcribed from silence or a click, and in
general getting a transciption without getting a recording is just odd. If we
decided the recording is not worth sending, the transcript certainly isn't.
* overage-limit:
auto_top_up_amount and monthly_overage_limit from CustomerRepo
Move Bandwidth Tn remote operations to BandwidthTnRepo
Use value_semantics to DRY up CustomerRepo
Use NotFound exception for all customer not found cases
Stephen Paul Weber
created
0ef60a2
auto_top_up_amount and monthly_overage_limit from CustomerRepo
Click to expand commit body
Move load of auto_top_up_amount to the repo, and load monthly_overage_limit in
the same operation.
Stephen Paul Weber
created
d8cb419
Move Bandwidth Tn remote operations to BandwidthTnRepo
Stephen Paul Weber
created
e839e44
Use value_semantics to DRY up CustomerRepo
Stephen Paul Weber
created
110a040
Use NotFound exception for all customer not found cases
There's a bit extra info I wanted about users, so since I was doing this
anyway I figured I may as well port the existing forms to the new form
renderer.
Then, in order to fit within the guidelines I needed subforms, so
partials were added.
Some domains credit new users to the admin, some to no one. We still have to
show a form to get them to pick a plan, but otherwise skip most of the process,
activate them with 1 month and go to Finish.