Commit log

bcc532c Merge branch 'premium'

Click to expand commit body
* premium:
  Factor out BuyNumber
  Inject price
  Bill after charge
  Inline useless methods
  Remove unused method
  Fix test
  charge for premium nums
  refactor registration_test to use real Tn's
  two changes related to registration forms
  price functionality on Tns
  Remove legacy card charge behaviour
  two fixes related to eSIM nicks:
  Factor out reload customer, check balance, maybe bill
  Unify more invite code handling
  Remove mostly-unused final_message
  Remove legacy card charge behaviour

Stephen Paul Weber created

d9f0ee5 Factor out BuyNumber

Stephen Paul Weber created

6675b96 Inject price

Click to expand commit body
Since that's what we actually care about.

Also makes JustCharge more generic for future use

Stephen Paul Weber created

c80b2e2 Bill after charge

Click to expand commit body
instead of this blind retry

Stephen Paul Weber created

0dd26e5 Inline useless methods

Click to expand commit body
And use a better transaction id

Stephen Paul Weber created

cafd02f Remove unused method

Click to expand commit body
And move price method where it actually goes

Stephen Paul Weber created

bdc86ed Fix test

Stephen Paul Weber created

a03d9a3 charge for premium nums

Phillip Davis created

6bbf900 refactor registration_test to use real Tn's

Phillip Davis created

4ee67a4 two changes related to registration forms

Click to expand commit body
- new buy_number.rb form for premium nums
- change mail.rb to accept a @price

Phillip Davis created

5851ae1 price functionality on Tns

Click to expand commit body
0 unless LocalInventory, in which case price is fetched from postgres

Phillip Davis created

bc65412 Remove legacy card charge behaviour

Click to expand commit body
We used to have them add card in web then charge after, but these days
we charge them in web for this first tx to get 3DS, so this code path is
all but dead and we can remove it.

Stephen Paul Weber created

47bf2a2 two fixes related to eSIM nicks:

Click to expand commit body
1. actually expose nickanem at eSIM order-time
2. pass nickname to `SIMOrder.commit` as non-kw arg in eSIM sublcass

Phillip Davis created

e38ec7e Factor out reload customer, check balance, maybe bill

Stephen Paul Weber created

bec8d98 two fixes related to eSIM nicks:

Click to expand commit body
1. actually expose nickanem at eSIM order-time
2. pass nickname to `SIMOrder.commit` as non-kw arg in eSIM sublcass

Phillip Davis created

223ee6c Unify more invite code handling

Click to expand commit body
Using the optional field on Activation or the InviteCode flow now use
the same code and do the same things. Always check balance and proceed
to bill if we've used a parent code, otherwise never do that.

Fixes the subaccount-from-onboarding guard as well.

Stephen Paul Weber created

cf0db8d Remove mostly-unused final_message

Click to expand commit body
Was only being used for PayPal transitions (which are mostly done) and
only when transitioning to BTC (which they usually don't) and only
provided extra reinforcement of a message they've already seen by now.
Let's not complicate the code for that.

Stephen Paul Weber created

cf99029 Remove legacy card charge behaviour

Click to expand commit body
We used to have them add card in web then charge after, but these days
we charge them in web for this first tx to get 3DS, so this code path is
all but dead and we can remove it.

Stephen Paul Weber created

b02dc3a don't crash if field not present

Stephen Paul Weber created

83ab944 More verbose logs for no customer oubound call

Stephen Paul Weber created

cc20b99 Log for this outbound no customer problem

Stephen Paul Weber created

955baed safe navigator

Phillip Davis created

db6c6ba Fixes for new nickname edits

Stephen Paul Weber created

2e090b4 Cleanup new tests

Stephen Paul Weber created

5e10341 expose editing esim nicks

Click to expand commit body
name can be set at registration and bulk edited later as well

Phillip Davis created

1a552c0 Back to rate center for now, city is not there

Stephen Paul Weber created

89461dd Better error when not city

Click to expand commit body
Instead of raw sql issue

Stephen Paul Weber created

6a8ccd7 These aren't namespaced

Stephen Paul Weber created

88cb18b Use safe nav

Stephen Paul Weber created

46d9022 Merge branch '388-warn-about-top-up-limits' of https://git.sr.ht/~amolith/sgx-jmp

Click to expand commit body
* '388-warn-about-top-up-limits' of https://git.sr.ht/~amolith/sgx-jmp:
  feat(form): conditionally display max top-up amount
  test(credit-card-sale): add missing openstruct require
  style: wrap YARD comment lines
  refactor: remove duplicated logic from BuyAccountCreditForm
  refactor: set DeclinedError defaults to nil
  fix: raise and check for errors correctly
  refactor: protect max_declines
  fix: redo amount validation in the form
  docs: add Yard documentation to code we touched
  feat: add upper limit to top-ups based on trust level

Stephen Paul Weber created

32f038a feat(form): conditionally display max top-up amount

Click to expand commit body
Remove range from the form, but pass max_top_up_amount through and only display
it if the user isn't tombed.

Amolith created

09e0c80 test(credit-card-sale): add missing openstruct require

Click to expand commit body
Not entirely sure what was changed, but the test started failing until I added
the missing require.

Amolith created

3e2a08f style: wrap YARD comment lines

Amolith created

6ed0a2d refactor: remove duplicated logic from BuyAccountCreditForm

Amolith created

2185f8f refactor: set DeclinedError defaults to nil

Amolith created

d0ff2d5 fix: raise and check for errors correctly

Click to expand commit body
Replace incorrect `CreditCardSale::TooLowError` and
`CreditCardSale::TooHighError` with correct `AmountTooLowError` and
`AmountTooHighError` respectively.

Amolith created

29c2353 refactor: protect max_declines

Amolith created

e195e3d fix: redo amount validation in the form

Amolith created

51380d3 rate_center -> :city

Phillip Davis created

fc6e0a2 docs: add Yard documentation to code we touched

Click to expand commit body
Document methods and attributes in `BuyAccountCreditForm`, `CreditCardSale`
error classes, and the `TrustLevel` module subclasses.

Amolith created

318f293 feat: add upper limit to top-ups based on trust level

Amolith created

afa62c8 Fix copy now that BCH is supported

Stephen Paul Weber created

ef820c8 Add WA for bulk

Stephen Paul Weber created

d6b3ca1 Merge branch 'bulk-order-api'

Click to expand commit body
* bulk-order-api:
  New bulk order API

Stephen Paul Weber created

9a88e00 New bulk order API

Stephen Paul Weber created

04aedd4 insert number into tel_inventory on cancel

Click to expand commit body
instead of Bandwidth.move'ing it

Phillip Davis created

1b075f6 Send meaningful error on invalid cancel attempt

Click to expand commit body
invalid: adj., 1) not registered

Phillip Davis created

c60352c Add test for onboarding getting subaccount

Stephen Paul Weber created

3f3e707 fix(registration): ensure onboarding JIDs can't create subaccounts

Amolith created

a655acb obey the cop

Phillip Davis created