assistant: Remove feature flag for terminal inline assistant (#15432)

Bennet Bo Fenner created 1 year ago

This PR removes the feature flag for the terminal inline assistant,
making it available to everyone.

Release Notes:

- Use Ctrl+Enter to summon the inline assistant in the terminal, which
let's you generate terminal commands based on your description
([demo](https://twitter.com/thorstenball/status/1814241447383605329))

Change summary

Cargo.lock                                | 1 -
crates/assistant/Cargo.toml               | 1 -
crates/assistant/src/assistant_panel.rs   | 5 -----
crates/feature_flags/src/feature_flags.rs | 5 -----
4 files changed, 12 deletions(-)

Detailed changes

Cargo.lock

@@ -410,7 +410,6 @@ dependencies = [
  "ctor",
  "editor",
  "env_logger",
- "feature_flags",
  "fs",
  "futures 0.3.28",
  "fuzzy",

crates/assistant/Cargo.toml

@@ -34,7 +34,6 @@ collections.workspace = true
 command_palette_hooks.workspace = true
 completion.workspace = true
 editor.workspace = true
-feature_flags.workspace = true
 fs.workspace = true
 futures.workspace = true
 fuzzy.workspace = true

crates/assistant/src/assistant_panel.rs

@@ -644,11 +644,6 @@ impl AssistantPanel {
                 .focus_handle(cx)
                 .contains_focused(cx)
             {
-                use feature_flags::FeatureFlagAppExt;
-                if !cx.has_flag::<feature_flags::TerminalInlineAssist>() {
-                    return None;
-                }
-
                 if let Some(terminal_view) = terminal_panel
                     .read(cx)
                     .pane()

crates/feature_flags/src/feature_flags.rs

@@ -43,11 +43,6 @@ impl FeatureFlag for LanguageModels {
     const NAME: &'static str = "language-models";
 }
 
-pub struct TerminalInlineAssist {}
-impl FeatureFlag for TerminalInlineAssist {
-    const NAME: &'static str = "terminal-inline-assist";
-}
-
 pub struct GroupedDiagnostics {}
 impl FeatureFlag for GroupedDiagnostics {
     const NAME: &'static str = "grouped-diagnostics";