save-if is unnecessary

Piotr Osiewicz created 3 days ago

Change summary

.github/workflows/run_tests.yml            | 7 -------
tooling/xtask/src/tasks/workflows/steps.rs | 1 -
2 files changed, 8 deletions(-)

Detailed changes

.github/workflows/run_tests.yml

@@ -65,7 +65,6 @@ jobs:
     - name: steps::cache_rust_dependencies_namespace
       uses: namespacelabs/nscloud-cache-action@v1
       with:
-        save-if: ${{ github.ref == 'refs/heads/main' }}
         cache: rust
         path: |-
           /home/runner/.cargo/bin/cargo-nextest
@@ -156,7 +155,6 @@ jobs:
     - name: steps::cache_rust_dependencies_namespace
       uses: namespacelabs/nscloud-cache-action@v1
       with:
-        save-if: ${{ github.ref == 'refs/heads/main' }}
         cache: rust
         path: |-
           /home/runner/.cargo/bin/cargo-nextest
@@ -233,7 +231,6 @@ jobs:
     - name: steps::cache_rust_dependencies_namespace
       uses: namespacelabs/nscloud-cache-action@v1
       with:
-        save-if: ${{ github.ref == 'refs/heads/main' }}
         cache: rust
         path: |-
           /home/runner/.cargo/bin/cargo-nextest
@@ -284,7 +281,6 @@ jobs:
     - name: steps::cache_rust_dependencies_namespace
       uses: namespacelabs/nscloud-cache-action@v1
       with:
-        save-if: ${{ github.ref == 'refs/heads/main' }}
         cache: rust
         path: |-
           /home/runner/.cargo/bin/cargo-nextest
@@ -348,7 +344,6 @@ jobs:
     - name: steps::cache_rust_dependencies_namespace
       uses: namespacelabs/nscloud-cache-action@v1
       with:
-        save-if: ${{ github.ref == 'refs/heads/main' }}
         cache: rust
         path: |-
           /home/runner/.cargo/bin/cargo-nextest
@@ -389,7 +384,6 @@ jobs:
     - name: steps::cache_rust_dependencies_namespace
       uses: namespacelabs/nscloud-cache-action@v1
       with:
-        save-if: ${{ github.ref == 'refs/heads/main' }}
         cache: rust
         path: |-
           /home/runner/.cargo/bin/cargo-nextest
@@ -435,7 +429,6 @@ jobs:
     - name: steps::cache_rust_dependencies_namespace
       uses: namespacelabs/nscloud-cache-action@v1
       with:
-        save-if: ${{ github.ref == 'refs/heads/main' }}
         cache: rust
         path: |-
           /home/runner/.cargo/bin/cargo-nextest

tooling/xtask/src/tasks/workflows/steps.rs

@@ -119,7 +119,6 @@ pub(crate) fn cache_rust_dependencies_namespace() -> Step<Use> {
     ]
     .join("\n");
     named::uses("namespacelabs", "nscloud-cache-action", "v1")
-        .add_with(("save-if", "${{ github.ref == 'refs/heads/main' }}"))
         .add_with(("cache", "rust"))
         .add_with(("path", allowlisted_binaries))
 }