No need for outputs anymore

Conrad Irwin created

Change summary

.github/workflows/release.yml                     | 16 --------
.github/workflows/release_nightly.yml             | 16 --------
.github/workflows/run_bundling.yml                | 16 --------
tooling/xtask/src/tasks/workflows/run_bundling.rs | 34 +---------------
4 files changed, 3 insertions(+), 79 deletions(-)

Detailed changes

.github/workflows/release.yml 🔗 

@@ -213,9 +213,6 @@ jobs:
         name: zed-remote-server-linux-aarch64.gz
         path: target/zed-remote-server-*.gz
         if-no-files-found: error
-    outputs:
-      zed: zed-linux-aarch64.tar.gz
-      remote-server: zed-remote-server-linux-aarch64.gz
     timeout-minutes: 60
   bundle_linux_x86_64:
     needs:
@@ -256,9 +253,6 @@ jobs:
         name: zed-remote-server-linux-x86_64.gz
         path: target/zed-remote-server-*.gz
         if-no-files-found: error
-    outputs:
-      zed: zed-linux-x86_64.tar.gz
-      remote-server: zed-remote-server-linux-x86_64.gz
     timeout-minutes: 60
   bundle_mac_aarch64:
     needs:
@@ -305,9 +299,6 @@ jobs:
         name: zed-remote-server-macos-aarch64.gz
         path: target/zed-remote-server-macos-aarch64.gz
         if-no-files-found: error
-    outputs:
-      zed: Zed-aarch64.dmg
-      remote-server: zed-remote-server-macos-aarch64.gz
     timeout-minutes: 60
   bundle_mac_x86_64:
     needs:
@@ -354,9 +345,6 @@ jobs:
         name: zed-remote-server-macos-x86_64.gz
         path: target/zed-remote-server-macos-x86_64.gz
         if-no-files-found: error
-    outputs:
-      zed: Zed-x86_64.dmg
-      remote-server: zed-remote-server-macos-x86_64.gz
     timeout-minutes: 60
   bundle_windows_aarch64:
     needs:
@@ -395,8 +383,6 @@ jobs:
         name: Zed-aarch64.exe
         path: ${{ env.SETUP_PATH }}
         if-no-files-found: error
-    outputs:
-      zed: Zed-aarch64.exe
     timeout-minutes: 60
   bundle_windows_x86_64:
     needs:
@@ -435,8 +421,6 @@ jobs:
         name: Zed-x86_64.exe
         path: ${{ env.SETUP_PATH }}
         if-no-files-found: error
-    outputs:
-      zed: Zed-x86_64.exe
     timeout-minutes: 60
   upload_release_assets:
     needs:

.github/workflows/release_nightly.yml 🔗 

@@ -108,9 +108,6 @@ jobs:
         name: zed-remote-server-linux-aarch64.gz
         path: target/zed-remote-server-*.gz
         if-no-files-found: error
-    outputs:
-      zed: zed-linux-aarch64.tar.gz
-      remote-server: zed-remote-server-linux-aarch64.gz
     timeout-minutes: 60
   bundle_linux_x86_64:
     needs:
@@ -158,9 +155,6 @@ jobs:
         name: zed-remote-server-linux-x86_64.gz
         path: target/zed-remote-server-*.gz
         if-no-files-found: error
-    outputs:
-      zed: zed-linux-x86_64.tar.gz
-      remote-server: zed-remote-server-linux-x86_64.gz
     timeout-minutes: 60
   bundle_mac_aarch64:
     needs:
@@ -214,9 +208,6 @@ jobs:
         name: zed-remote-server-macos-aarch64.gz
         path: target/zed-remote-server-macos-aarch64.gz
         if-no-files-found: error
-    outputs:
-      zed: Zed-aarch64.dmg
-      remote-server: zed-remote-server-macos-aarch64.gz
     timeout-minutes: 60
   bundle_mac_x86_64:
     needs:
@@ -270,9 +261,6 @@ jobs:
         name: zed-remote-server-macos-x86_64.gz
         path: target/zed-remote-server-macos-x86_64.gz
         if-no-files-found: error
-    outputs:
-      zed: Zed-x86_64.dmg
-      remote-server: zed-remote-server-macos-x86_64.gz
     timeout-minutes: 60
   bundle_windows_aarch64:
     needs:
@@ -319,8 +307,6 @@ jobs:
         name: Zed-aarch64.exe
         path: ${{ env.SETUP_PATH }}
         if-no-files-found: error
-    outputs:
-      zed: Zed-aarch64.exe
     timeout-minutes: 60
   bundle_windows_x86_64:
     needs:
@@ -367,8 +353,6 @@ jobs:
         name: Zed-x86_64.exe
         path: ${{ env.SETUP_PATH }}
         if-no-files-found: error
-    outputs:
-      zed: Zed-x86_64.exe
     timeout-minutes: 60
   build_nix_linux_x86_64:
     needs:

.github/workflows/run_bundling.yml 🔗 

@@ -49,9 +49,6 @@ jobs:
         name: zed-remote-server-linux-aarch64.gz
         path: target/zed-remote-server-*.gz
         if-no-files-found: error
-    outputs:
-      zed: zed-linux-aarch64.tar.gz
-      remote-server: zed-remote-server-linux-aarch64.gz
     timeout-minutes: 60
   bundle_linux_x86_64:
     if: |-
@@ -92,9 +89,6 @@ jobs:
         name: zed-remote-server-linux-x86_64.gz
         path: target/zed-remote-server-*.gz
         if-no-files-found: error
-    outputs:
-      zed: zed-linux-x86_64.tar.gz
-      remote-server: zed-remote-server-linux-x86_64.gz
     timeout-minutes: 60
   bundle_mac_aarch64:
     if: |-
@@ -141,9 +135,6 @@ jobs:
         name: zed-remote-server-macos-aarch64.gz
         path: target/zed-remote-server-macos-aarch64.gz
         if-no-files-found: error
-    outputs:
-      zed: Zed-aarch64.dmg
-      remote-server: zed-remote-server-macos-aarch64.gz
     timeout-minutes: 60
   bundle_mac_x86_64:
     if: |-
@@ -190,9 +181,6 @@ jobs:
         name: zed-remote-server-macos-x86_64.gz
         path: target/zed-remote-server-macos-x86_64.gz
         if-no-files-found: error
-    outputs:
-      zed: Zed-x86_64.dmg
-      remote-server: zed-remote-server-macos-x86_64.gz
     timeout-minutes: 60
   bundle_windows_aarch64:
     if: |-
@@ -231,8 +219,6 @@ jobs:
         name: Zed-aarch64.exe
         path: ${{ env.SETUP_PATH }}
         if-no-files-found: error
-    outputs:
-      zed: Zed-aarch64.exe
     timeout-minutes: 60
   bundle_windows_x86_64:
     if: |-
@@ -271,8 +257,6 @@ jobs:
         name: Zed-x86_64.exe
         path: ${{ env.SETUP_PATH }}
         if-no-files-found: error
-    outputs:
-      zed: Zed-x86_64.exe
     timeout-minutes: 60
 concurrency:
   group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}

tooling/xtask/src/tasks/workflows/run_bundling.rs 🔗 

@@ -7,7 +7,6 @@ use crate::tasks::workflows::{
 
 use super::{runners, steps};
 use gh_workflow::*;
-use indexmap::IndexMap;
 
 pub fn run_bundling() -> Workflow {
     let bundle = ReleaseBundleJobs {
@@ -85,18 +84,7 @@ pub(crate) fn bundle_mac(
             .add_step(steps::upload_artifact(
                 &remote_server_artifact_name,
                 &format!("target/zed-remote-server-macos-{arch}.gz"),
-            ))
-            .outputs(
-                [
-                    ("zed".to_string(), artifact_name.to_string()),
-                    (
-                        "remote-server".to_string(),
-                        remote_server_artifact_name.to_string(),
-                    ),
-                ]
-                .into_iter()
-                .collect::<IndexMap<_, _>>(),
-            ),
+            )),
     }
 }
 
@@ -133,18 +121,7 @@ pub(crate) fn bundle_linux(
             .add_step(steps::upload_artifact(
                 &remote_server_artifact_name,
                 "target/zed-remote-server-*.gz",
-            ))
-            .outputs(
-                [
-                    ("zed".to_string(), artifact_name.to_string()),
-                    (
-                        "remote-server".to_string(),
-                        remote_server_artifact_name.to_string(),
-                    ),
-                ]
-                .into_iter()
-                .collect::<IndexMap<_, _>>(),
-            ),
+            )),
     }
 }
 
@@ -179,12 +156,7 @@ pub(crate) fn bundle_windows(
             .add_step(steps::upload_artifact(
                 &artifact_name,
                 "${{ env.SETUP_PATH }}",
-            ))
-            .outputs(
-                [("zed".to_string(), artifact_name.to_string())]
-                    .into_iter()
-                    .collect::<IndexMap<_, _>>(),
-            ),
+            )),
     }
 }