oops

Conrad Irwin created 5 days ago

Change summary

.github/workflows/compare_perf.yml                | 4 ++--
tooling/xtask/src/tasks/workflows/compare_perf.rs | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)

Detailed changes

.github/workflows/compare_perf.yml

@@ -24,12 +24,12 @@ jobs:
       run: echo ${{ inputs.base }} ${{ inputs.head }}
       shell: bash -euxo pipefail {0}
     - name: git checkout ${{ inputs.base }}
-      run: git checkout {ref_name}
+      run: git checkout ${{ inputs.base }}
     - name: compare_perf::run_perf::cargo_perf_test
       run: cargo perf-test -p gpui -- --json=${{ inputs.base }}
       shell: bash -euxo pipefail {0}
     - name: git checkout ${{ inputs.head }}
-      run: git checkout {ref_name}
+      run: git checkout ${{ inputs.head }}
     - name: compare_perf::run_perf::cargo_perf_test
       run: cargo perf-test -p gpui -- --json=${{ inputs.head }}
       shell: bash -euxo pipefail {0}

tooling/xtask/src/tasks/workflows/compare_perf.rs

@@ -25,11 +25,12 @@ pub fn run_perf(base: &Input, head: &Input) -> NamedJob {
     }
 
     fn cargo_perf_test(ref_name: String) -> Step<Run> {
+        // TODO: vim not gpui, and ideally allow args
         named::bash(&format!("cargo perf-test -p gpui -- --json={ref_name}"))
     }
 
     fn git_checkout(ref_name: String) -> Step<Run> {
-        Step::new(&format!("git checkout {ref_name}")).run("git checkout {ref_name}")
+        Step::new(&format!("git checkout {ref_name}")).run(&format!("git checkout {ref_name}"))
     }
 
     fn compare_runs(head: String, base: String) -> Step<Run> {