Recategorize a few items in the component preview (#35681)

Danilo Leal created 3 months ago

Release Notes:

- N/A

Change summary

crates/agent_ui/src/ui/end_trial_upsell.rs   | 10 ++++++----
crates/ai_onboarding/src/ai_onboarding.rs    | 10 +++++++++-
crates/ai_onboarding/src/ai_upsell_card.rs   |  2 +-
crates/component/src/component.rs            |  2 ++
crates/language_models/src/provider/cloud.rs | 10 +++++++++-
crates/onboarding/src/theme_preview.rs       | 12 ++++++++++++
crates/ui/src/components/banner.rs           |  2 +-
crates/ui/src/components/callout.rs          |  2 +-
crates/ui/src/components/tab.rs              |  2 +-
crates/ui/src/styles/animation.rs            |  2 +-
crates/ui/src/styles/color.rs                |  2 +-
11 files changed, 44 insertions(+), 12 deletions(-)

Detailed changes

crates/agent_ui/src/ui/end_trial_upsell.rs

@@ -94,18 +94,20 @@ impl RenderOnce for EndTrialUpsell {
 
 impl Component for EndTrialUpsell {
     fn scope() -> ComponentScope {
-        ComponentScope::Agent
+        ComponentScope::Onboarding
+    }
+
+    fn name() -> &'static str {
+        "End of Trial Upsell Banner"
     }
 
     fn sort_name() -> &'static str {
-        "AgentEndTrialUpsell"
+        "End of Trial Upsell Banner"
     }
 
     fn preview(_window: &mut Window, _cx: &mut App) -> Option<AnyElement> {
         Some(
             v_flex()
-                .p_4()
-                .gap_4()
                 .child(EndTrialUpsell {
                     dismiss_upsell: Arc::new(|_, _| {}),
                 })

crates/ai_onboarding/src/ai_onboarding.rs

@@ -368,7 +368,15 @@ impl RenderOnce for ZedAiOnboarding {
 
 impl Component for ZedAiOnboarding {
     fn scope() -> ComponentScope {
-        ComponentScope::Agent
+        ComponentScope::Onboarding
+    }
+
+    fn name() -> &'static str {
+        "Agent Panel Banners"
+    }
+
+    fn sort_name() -> &'static str {
+        "Agent Panel Banners"
     }
 
     fn preview(_window: &mut Window, _cx: &mut App) -> Option<AnyElement> {

crates/ai_onboarding/src/ai_upsell_card.rs

@@ -236,7 +236,7 @@ impl RenderOnce for AiUpsellCard {
 
 impl Component for AiUpsellCard {
     fn scope() -> ComponentScope {
-        ComponentScope::Agent
+        ComponentScope::Onboarding
     }
 
     fn name() -> &'static str {

crates/component/src/component.rs

@@ -318,8 +318,10 @@ pub enum ComponentScope {
     Notification,
     #[strum(serialize = "Overlays & Layering")]
     Overlays,
+    Onboarding,
     Status,
     Typography,
+    Utilities,
     #[strum(serialize = "Version Control")]
     VersionControl,
 }

crates/language_models/src/provider/cloud.rs

@@ -1267,8 +1267,16 @@ impl Render for ConfigurationView {
 }
 
 impl Component for ZedAiConfiguration {
+    fn name() -> &'static str {
+        "AI Configuration Content"
+    }
+
+    fn sort_name() -> &'static str {
+        "AI Configuration Content"
+    }
+
     fn scope() -> ComponentScope {
-        ComponentScope::Agent
+        ComponentScope::Onboarding
     }
 
     fn preview(_window: &mut Window, _cx: &mut App) -> Option<AnyElement> {

crates/onboarding/src/theme_preview.rs

@@ -299,6 +299,18 @@ impl RenderOnce for ThemePreviewTile {
 }
 
 impl Component for ThemePreviewTile {
+    fn scope() -> ComponentScope {
+        ComponentScope::Onboarding
+    }
+
+    fn name() -> &'static str {
+        "Theme Preview Tile"
+    }
+
+    fn sort_name() -> &'static str {
+        "Theme Preview Tile"
+    }
+
     fn description() -> Option<&'static str> {
         Some(Self::DOCS)
     }

crates/ui/src/components/banner.rs

@@ -131,7 +131,7 @@ impl RenderOnce for Banner {
 
 impl Component for Banner {
     fn scope() -> ComponentScope {
-        ComponentScope::Notification
+        ComponentScope::DataDisplay
     }
 
     fn preview(_window: &mut Window, _cx: &mut App) -> Option<AnyElement> {

crates/ui/src/components/callout.rs

@@ -158,7 +158,7 @@ impl RenderOnce for Callout {
 
 impl Component for Callout {
     fn scope() -> ComponentScope {
-        ComponentScope::Notification
+        ComponentScope::DataDisplay
     }
 
     fn description() -> Option<&'static str> {

crates/ui/src/components/tab.rs

@@ -179,7 +179,7 @@ impl RenderOnce for Tab {
 
 impl Component for Tab {
     fn scope() -> ComponentScope {
-        ComponentScope::None
+        ComponentScope::Navigation
     }
 
     fn description() -> Option<&'static str> {

crates/ui/src/styles/animation.rs

@@ -99,7 +99,7 @@ struct Animation {}
 
 impl Component for Animation {
     fn scope() -> ComponentScope {
-        ComponentScope::None
+        ComponentScope::Utilities
     }
 
     fn description() -> Option<&'static str> {

crates/ui/src/styles/color.rs

@@ -126,7 +126,7 @@ impl From<Hsla> for Color {
 
 impl Component for Color {
     fn scope() -> ComponentScope {
-        ComponentScope::None
+        ComponentScope::Utilities
     }
 
     fn description() -> Option<&'static str> {