project: Log errors when notifying JSON language server (#49480)

Xiaobo Liu and Kirill Bulatov created 1 month ago

Release Notes:

- N/A

---------

Signed-off-by: Xiaobo Liu <[e-mail]>
Co-authored-by: Kirill Bulatov <[e-mail]>

Change summary

crates/project/src/lsp_store/json_language_server_ext.rs | 14 +++++++--
1 file changed, 11 insertions(+), 3 deletions(-)

Detailed changes

crates/project/src/lsp_store/json_language_server_ext.rs

@@ -63,9 +63,17 @@ pub fn notify_schema_changed(lsp_store: Entity<LspStore>, uri: String, cx: &App)
         servers
     });
     for server in servers {
-        zlog::trace!(LOGGER => "Notifying server {:?} of schema change for URI: {:?}", server.server_id(), &uri);
-        // TODO: handle errors
-        server.notify::<SchemaContentsChanged>(uri.clone()).ok();
+        zlog::trace!(LOGGER => "Notifying server {NAME} (id {ID:?}) of schema change for URI: {uri:?}",
+            NAME = server.name(),
+            ID = server.server_id()
+        );
+        if let Err(error) = server.notify::<SchemaContentsChanged>(uri.clone()) {
+            zlog::error!(
+                LOGGER => "Failed to notify server {NAME} (id {ID:?}) of schema change for URI {uri:?}: {error:#}",
+                    NAME = server.name(),
+                    ID = server.server_id(),
+            );
+        }
     }
 }