warn when denoise is enabled on debug

David Kleingeld created 2 months ago

Change summary

Cargo.toml                         |  2 +-
crates/audio/src/audio_settings.rs | 13 ++++++++++---
2 files changed, 11 insertions(+), 4 deletions(-)

Detailed changes

Cargo.toml

@@ -780,8 +780,8 @@ codegen-units = 16
 codegen-units = 16
 
 [profile.dev.package]
+# Without optimizations we get audio artifacts (crackling)
 audio = { opt-level = 3 }
-denoise = { opt-level = 3 }
 taffy = { opt-level = 3 }
 cranelift-codegen = { opt-level = 3 }
 cranelift-codegen-meta = { opt-level = 3 }

crates/audio/src/audio_settings.rs

@@ -140,9 +140,16 @@ impl LiveSettings {
                 AudioSettings::get_global(cx).auto_speaker_volume,
                 Ordering::Relaxed,
             );
-            LIVE_SETTINGS
-                .denoise
-                .store(AudioSettings::get_global(cx).denoise, Ordering::Relaxed);
+
+            let denoise_enabled = AudioSettings::get_global(cx).denoise;
+            #[cfg(debug_assertions)]
+            if denoise_enabled {
+                log::warn!("Denoise does not work on debug builds, not enabling")
+            } else {
+                LIVE_SETTINGS
+                    .denoise
+                    .store(denoise_enabled, Ordering::Relaxed);
+            }
         })
         .detach();