f435af2
acp: Use unstaged style for diffs (#36674)
Click to expand commit body
Release Notes:
- N/A
Antonio Scandurra
created
c5ee3f3
Avoid suspending panicking thread while crashing (#36645)
Click to expand commit body
On the latest build @maxbrunsfeld got a panic that hung zed. It appeared
that the hang occured after the minidump had been successfully written,
so our theory on what happened is that the `suspend_all_other_threads`
call in the crash handler suspended the panicking thread (due to the
signal from simulate_exception being received on a different thread),
and then when the crash handler returned everything was suspended so the
panic hook never made it to the `process::abort`.
This change makes the crash handler avoid _both_ the current and the
panicking thread which should avoid that scenario.
Release Notes:
- N/A
Julia Ryan
created
7f1bd2f
remote: Fix toolchain RPC messages not being handled because of the entity getting dropped (#36665)
Follow-up of https://github.com/zed-industries/zed/pull/36557 that is
needed after https://github.com/zed-industries/zed/pull/36652
Release Notes:
- N/A
68f97d6
editor: Use `highlight_text` to highlight matching brackets, fix unnecessary inlay hint highlighting (#36540)
Click to expand commit body
Closes #35981
Release Notes:
- Fixed bracket highlights overly including parts of inlays when
highlighting
Before -
<img width="1480" height="602" alt="Screenshot from 2025-08-19 17-15-06"
src="https://github.com/user-attachments/assets/8e6b5ed8-f133-4867-8352-ed93441fbd8b"
/>
After -
<img width="1480" height="602" alt="Screenshot from 2025-08-19 17-24-26"
src="https://github.com/user-attachments/assets/1314e54e-ecf9-4280-9d53-eed6e96e393f"
/>
Sachith Shetty
created
5dcb908
Stop waiting for part of LSP responses on remote Collab clients' part (#36557)
Click to expand commit body
Instead of holding a connection for potentially long LSP queries (e.g.
rust-analyzer might take minutes to look up a definition), disconnect
right after sending the initial request and handle the follow-up
responses later.
As a bonus, this allows to cancel previously sent request on the local
Collab clients' side due to this, as instead of holding and serving the
old connection, local clients now can stop previous requests, if needed.
Current PR does not convert all LSP requests to the new paradigm, but
the problematic ones, deprecating `MultiLspQuery` and moving all its
requests to the new paradigm.
Release Notes:
- Improved resource usage when querying LSP over Collab
---------
Co-authored-by: David Kleingeld <git@davidsk.dev>
Co-authored-by: Mikayla Maki <mikayla@zed.dev>
Co-authored-by: David Kleingeld <davidsk@zed.dev>
Kirill Bulatov
,
David Kleingeld
,
Mikayla Maki
, and
David Kleingeld
created
Closes #36314
This PR takes inspiration from [Electron’s
implementation](https://github.com/electron/electron/blob/dd54e84a58531b52680f7f736f593ee887eff6a7/shell/common/platform_util_win.cc#L268-L314).
Before and after:
https://github.com/user-attachments/assets/53eec5d3-23c7-4ee1-8477-e524b0538f60
Release Notes:
- N/A
https://github.com/zed-industries/zed/pull/36633 relied on the prompt
request responding before cancel, but that's not guaranteed
Release Notes:
- N/A
Agus Zubiaga
created
c20233e
agent_ui: Fix signed-in check in Zed provider configuration (#36639)
Click to expand commit body
This PR fixes the check for if the user is signed in in the Agent panel
configuration.
Supersedes https://github.com/zed-industries/zed/pull/36634.
Release Notes:
- Fixed the user's plan badge near the Zed provider in the Agent panel
not showing despite being signed in.
This PR adds a temporary workaround to supress "Aborted" errors from
Gemini when cancelling generation. This won't be needed once
https://github.com/google-gemini/gemini-cli/pull/6656 is generally
available.
Release Notes:
- N/A
b0bef3a
agent2: Clean up tool descriptions (#36619)
Click to expand commit body
schemars was passing along the newlines from the doc comments. This
should make these closer to the markdown file versions we had in the old
agent.
Release Notes:
- N/A
Ben Brandt
created
2813073
message editor: Only allow types of content the agent can handle (#36616)
Click to expand commit body
Uses the new
[`acp::PromptCapabilities`](https://github.com/zed-industries/agent-client-protocol/blob/a39b7f635d67528f0a4e05e086ab283b9fc5cb93/rust/agent.rs#L194-L215)
to disable non-file mentions and images for agents that don't support
them.
Release Notes:
- N/A
- **clippy: Fix println-empty-string**
- **clippy: non-minimal-cfg**
Related to #36577
Release Notes:
- N/A
Piotr Osiewicz
created
b6722ca
Remove special case for singleton buffers from `MultiBufferSnapshot::anchor_at` (#36524)
Click to expand commit body
This may be responsible for a panic that we've been seeing with
increased frequency in agent2 threads.
Release Notes:
- N/A
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Release Notes:
- N/A
---------
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
Bennet Bo Fenner
and
Ben Brandt
created
d0fb612
Fix scrollbar flicker when streaming agent2 response (#36606)
Click to expand commit body
This was caused by calling `list_state.splice` on updated entries. We
don't need to splice the entry, as we'll recompute its measurements
automatically when we render it.
Release Notes:
- N/A
Antonio Scandurra
created
699f58a
Capture telemetry when requesting completions in agent2 (#36600)
de12633
Wait for agent2 feature flag before loading panel (#36583)
Click to expand commit body
Release Notes:
- N/A
Antonio Scandurra
created
6ed29fb
Enforce style lints which do not have violations (#36580)
Click to expand commit body
Release Notes:
- N/A
tidely
created
4ee565c
Fix mentions roundtrip from/to database and other history bugs (#36575)
Click to expand commit body
Release Notes:
- N/A
Antonio Scandurra
created
f80a0ba
Move clippy lints which aren't apart of the style category (#36579)
Click to expand commit body
Move lints which aren't apart of the style category.
Motivation: They might get accidentally get reverted when we turn the
style category on again and remove the manual lint enforcements.
Release Notes:
- N/A
This removes around 900 unnecessary clones, ranging from cloning a few
ints all the way to large data structures and images.
A lot of these were fixed using `cargo clippy --fix --workspace
--all-targets`, however it often breaks other lints and needs to be run
again. This was then followed up with some manual fixing.
I understand this is a large diff, but all the changes are pretty
trivial. Rust is doing some heavy lifting here for us. Once I get it up
to speed with main, I'd appreciate this getting merged rather sooner
than later.
Release Notes:
- N/A