Commit log

714734d Add whitespaces rendering

Kirill Bulatov created

2d8c88a Draw tabs with svg icons in editor code only

Kirill Bulatov created

f0a88b3 Make invisibles display configurable

Kirill Bulatov created

ad731ea Draft invisibles' tabs display

Kirill Bulatov created

4f86070 Add is_tab field to chunks

Click to expand commit body
Co-authored-by: Antonio Scandurra <antonio@zed.dev>

Max Brunsfeld and Antonio Scandurra created

cf304a0 Merge pull request #2452 from zed-industries/prevent-some-rounding-clipping

Click to expand commit body
Prevent some cases of clipping icons due to pixel coord rounding

Julia created

332b364 Prevent some cases of clipping icons due to pixel coord rounding

Julia created

235470b Merge pull request #2451 from zed-industries/kb/extra-deps

Click to expand commit body
Remove unused dependencies

Antonio Scandurra created

6cb0bc8 Remove unused dependencies

Kirill Bulatov created

0296974 Merge pull request #2441 from zed-industries/implicit-ancestry

Click to expand commit body
Determine view ancestry during layout

Antonio Scandurra created

5e16f70 :lipstick:

Antonio Scandurra created

080a1f0 Delay `focus_in` event for window activation till after layout

Antonio Scandurra created

b9ed327 Replace usages of `is_parent_view_focused` with `is_self_focused`

Click to expand commit body
Previously, this was used because we didn't have access to the current
view and `EventContext` was an element-only abstraction. Now that the
`EventContext` wraps the current view's `ViewContext` we can simply check
for the view's focus and avoid querying ancestors.

Antonio Scandurra created

80ad59a Make focusing the parent an effect to avoid querying ancestors

Antonio Scandurra created

c55a4c0 Merge pull request #2447 from zed-industries/fix-auto-update

Click to expand commit body
Do not use post_json() to auto update

Joseph T. Lyons created

3631b3a Merge pull request #2446 from zed-industries/fix-copilot-logged-out

Click to expand commit body
Fix copilot stuck in logged out state

Mikayla Maki created

89af803 Rearrange the state machine

Mikayla Maki created

137cbab Merge pull request #2445 from zed-industries/construct-text-buffer-in-background

Click to expand commit body
Construct text buffer in background

Julia created

eacea55 Fixup cases using buffer model handle id as buffer id

Julia created

1883e26 Offload `text::Buffer` construction to background worker

Click to expand commit body
Co-Authored-By: Antonio Scandurra <me@as-cii.com>

Julia and Antonio Scandurra created

7e06062 Store history base text as rope

Click to expand commit body
Co-Authored-By: Antonio Scandurra <me@as-cii.com>

Julia and Antonio Scandurra created

8313414 Do not use post_json() to auto update

Joseph Lyons created

d6b0569 Merge branch 'main' into implicit-ancestry

Antonio Scandurra created

f51425d Merge pull request #2444 from zed-industries/fix-clicking-sidebar-buttons

Click to expand commit body
Use `Workspace::toggle_sidebar_item` when clicking on sidebar button

Antonio Scandurra created

64e0c16 Use `Workspace::toggle_sidebar_item` when clicking on sidebar button

Click to expand commit body
Previously, we were mistakenly using `Sidebar::toggle_item`, which only
performs part of the toggle operation.

Antonio Scandurra created

cbae4e7 Merge pull request #2443 from zed-industries/fix-vim-mode-rename

Click to expand commit body
Avoid calling `update_window` twice in `blurred` event handler

Antonio Scandurra created

912a4cf Avoid calling `update_window` twice in `blurred` event handler

Click to expand commit body
This was preventing us from unhooking vim when performing a rename,
which prevented typing in the rename editor.

Antonio Scandurra created

0f93714 Merge pull request #2442 from zed-industries/filter-vim-commands

Click to expand commit body
Filter out vim commands when vim mode is disabled

Antonio Scandurra created

b1f5cfa Merge pull request #2440 from zed-industries/fix-navigate-to-definitions-panic

Click to expand commit body
Fix panic when opening multiple definitions in a multibuffer

Antonio Scandurra created

b3baebd Filter out vim commands when vim mode is disabled

Antonio Scandurra created

da19edc Merge branch 'main' into implicit-ancestry

Antonio Scandurra created

121264d Fix panic when opening multiple definitions in a multibuffer

Click to expand commit body
The editor is on the stack, so adding an item to the `Pane` containing
the editor will cause a double borrow and a consequent panic. This
commit fixes the issue by deferring the opening of the definitions.

Antonio Scandurra created

7e2a461 Merge pull request #2439 from zed-industries/fix-keystrokes-for-action

Click to expand commit body
Cache view's type id and keymap context into a separate map

Antonio Scandurra created

5cc6304 Verify keystrokes can be queried while views are on the stack

Antonio Scandurra created

3d679dd Avoid re-allocating `KeymapContext` after every view notification

Antonio Scandurra created

18e39ef Cache view's type id and keymap context into a separate map

Click to expand commit body
During `layout`, we now pass a mutable reference to the element's
parent view. This is a recursive process that causes the view to
be removed from `AppContext` and then re-inserted back into it once
the layout is complete.

As such, querying parent views during `layout` does not work as such
views will have been removed from `AppContext` and not yet re-inserted
into it. This caused a bug in `KeystrokeLabel`, which used the `keystrokes_for_action`
method to query its ancestors to determine their type id and keymap context.

Now, any time a view notifies, we will cache its keymap context so that
we don't need to query the parent view during `layout`.

Antonio Scandurra created

7b7a495 Remove stray `dbg!` statement

Antonio Scandurra created

f6f18be Remove `WindowContext::is_child_focused`

Antonio Scandurra created

67a3891 Make dispatch_event related methods public to the crate only

Antonio Scandurra created

92183e0 Ensure querying keystrokes or actions is safe

Click to expand commit body
This is achieved by moving `available_actions` into `AsyncAppContext` (where
we know no view/window is on the stack) and `keystrokes_for_action` into `LayoutContext`
where we'll fetch the previous frame's ancestors and notify the current view if those
change after we perform a layout.

Antonio Scandurra created

053b348 collab 0.11.0

Joseph Lyons created

653ea3a v0.86.x dev

Joseph Lyons created

c2c29d3 Merge pull request #2427 from zed-industries/copilot-disabled-globs

Click to expand commit body
Add copilot.disabled_globs setting

Max Brunsfeld created

9d41f83 Merge branch 'main' into copilot-disabled-globs

Max Brunsfeld created

040cc4d Allow notifying views when the ancestry of another view is outdated

Antonio Scandurra created

8eb1312 Add copilot menu item for enabling paths by glob

Max Brunsfeld created

7250754 Make dispatch_keystroke public to the crate only

Antonio Scandurra created

9e8f852 Remove `ViewContext::is_child`

Antonio Scandurra created

5157442 Fix integration test relying on deferred happening after focus

Click to expand commit body
Focus is now one of the last things that happens during `flush_effects`,
and we shouldn't have relied on `defer` in the first place to verify
focus changes.

Antonio Scandurra created

c65465b Ensure workspace gets rendered in collab integration tests

Antonio Scandurra created