Commit log

e9ed40d Remove the ability to retrieve the view's parent

Antonio Scandurra created

7f137ed Compute view ancestry at layout time

Antonio Scandurra created

7f345f8 Separate `Window::build_scene` into `layout` and `paint`

Antonio Scandurra created

3f037e5 Merge pull request #2437 from zed-industries/fix-joining-call

Click to expand commit body
Fix "IncomingCallNotification was dropped" error when accepting a call

Antonio Scandurra created

376aa12 Fix "IncomingCallNotification was dropped" error when accepting a call

Click to expand commit body
This was caused by accepting the call, which caused the notification to
be removed. When `active_call.accept_incoming()` finally completed, we
would try to get the app state from it in order to join the project, but
couldn't becuase the view would have already been dropped.

This commit fixes the bug by capturing a weak handle to the app state
when accepting the call as opposed to trying to read it from the view
when the accept completes.

Antonio Scandurra created

c3cf9e3 Merge pull request #2436 from zed-industries/close-window-end-call

Click to expand commit body
Move methods querying window state into `AsyncAppContext`

Antonio Scandurra created

f576586 Merge pull request #2435 from zed-industries/use-json-post-request-for-update-requests

Click to expand commit body
Use json_post() request for update requests

Joseph T. Lyons created

41d4454 Use post_json so that the Content-Type is set to application/json

Joseph Lyons created

69a4fff Update `post_json` to take in a bool for allowing for redirects

Joseph Lyons created

7f5afeb Merge pull request #2434 from zed-industries/add-download-and-uplodate-metadata-to-update-request

Click to expand commit body
Add download and upload metadata to update request

Joseph T. Lyons created

2b95aba Add download and upload metadata to update request

Joseph Lyons created

1398a12 More keybindings in macOs modals with buttons

Click to expand commit body
Closes https://github.com/zed-industries/community/issues/1095
by forcing the non-Cancel button to get a focus.
Due to the way macOs handles buttons on modals, the focus gain had to be
achieved via certain button addition order, rather than conventional
"setFocus"-ish API, see the related comment for details.

Co-authored-by: Antonio Scandurra <antonio@zed.dev>

Kirill Bulatov and Antonio Scandurra created

70f8cf4 Move methods querying window state into `AsyncAppContext`

Antonio Scandurra created

4f69397 Merge pull request #2432 from zed-industries/more-diagnostic-source

Click to expand commit body
Show diagnostic source in more places

Julia created

185c165 Show diagnostic source in inline diagnostic

Julia created

9108e41 Merge pull request #2431 from zed-industries/fix-broken-contact-finder

Click to expand commit body
Fix broken styling in contact finder

Antonio Scandurra created

94f1775 Fix broken styling in contact finder

Click to expand commit body
This regressed as part of #2372, where we forgot to theme the contact
finder picker differently from the rest of the app.

Antonio Scandurra created

e8f2d98 Merge pull request #2430 from zed-industries/fix-toggle-contacts-panic

Click to expand commit body
Fix panic when showing contacts popover via keybinding

Antonio Scandurra created

f985fac Fix panic when showing contacts popover via keybinding

Antonio Scandurra created

484cda5 Merge pull request #2429 from zed-industries/fix-debug-elements-panic

Click to expand commit body
Move `debug_elements` to `AsyncAppContext`

Antonio Scandurra created

f5278c4 Clarify GH Token scope requirements

Kirill Bulatov created

794446b Move `debug_elements` to `AsyncAppContext`

Click to expand commit body
Previously, `debug_elements` was available on `WindowContext`. If that
method was called while having a borrow out to a view, it would panic because
the view would already have been borrowed.

By moving it to an `AsyncAppContext` we ensure the method can't be called while
a view is being used.

Antonio Scandurra created

4c1cba6 Remove unnecessary `Element` impl for `RootElement`

Antonio Scandurra created

f7de0ad Show diagnostic source in diagnostic multibuffer headers

Julia created

c485fc8 Add copilot.disabled_globs setting

Max Brunsfeld created

f62ba2e use installation_id over device_id

Joseph T. Lyons created

5fb9d53 Merge pull request #2425 from zed-industries/trim-eslint-workspace-configuration

Click to expand commit body
Trim eslint workspace configuration & remove diagnostic source underline

Julia created

40ab5c1 Remove underline from diagnostic source

Julia created

4966a4a Reduce hardcoded ESLint workspace configuration

Julia created

a8084ad Merge pull request #2424 from zed-industries/constrain-programmatic-dispatch

Click to expand commit body
Allow programmatic action dispatch only via `AsyncAppContext`

Antonio Scandurra created

780ece5 Defer hiding the dock and going back/forward when Pane is on the stack

Antonio Scandurra created

e3b2407 Run until parked now that the command palette spawns to dispatch action

Antonio Scandurra created

6c931ab Inline test-only `AppContext` methods

Antonio Scandurra created

eb2cce9 Move `dispatch_action_any_action_at` to `AsyncAppContext`

Antonio Scandurra created

c4472b0 Remove `ViewContext::dispatch_action`

Antonio Scandurra created

d815fc8 Remove `ViewContext::dispatch_any_action`

Antonio Scandurra created

029538f Make `dispatch_global_action` private

Antonio Scandurra created

0f44648 Merge pull request #2423 from zed-industries/fix-panic-in-go-to-definition

Click to expand commit body
Fix panic when clicking on a definition

Antonio Scandurra created

e566929 Fix panic when clicking on a definition

Click to expand commit body
This was introduced with #2420 and was caused by re-entrantly updating
the workspace. Instead of passing the workspace reference from the outside,
we now define the definition navigation as a method on the editor which solves
the issue.

Note that we also needed to introduce a `defer` call when navigating to a definition
to prevent the workspace from reading the editor during `open_project_item`.

Antonio Scandurra created

ae5794d Merge pull request #2421 from zed-industries/metrics-2

Click to expand commit body
Rework telemetry code to support sending events to Clickhouse

Joseph T. Lyons created

32f26d1 Merge pull request #2422 from zed-industries/source-eslint-server-from-github

Click to expand commit body
Source ESLint server from Github rather than 3rd party NPM package

Julia created

1bf8521 Source ESLint server from Github rather than 3rd party NPM package

Julia created

6b0faa2 Rework telemetry code to support sending events to Clickhouse

Click to expand commit body
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>

Joseph Lyons and Max Brunsfeld created

dc999f7 Merge pull request #2420 from zed-industries/simplify-action-dispatch

Click to expand commit body
Remove `impl_internal_actions!` macro

Antonio Scandurra created

106ebeb Remove obsolete presenter modules

Antonio Scandurra created

489b1f6 Merge remote-tracking branch 'origin/main' into simplify-action-dispatch

Antonio Scandurra created

1c5376a Remove `impl_internal_actions` macro

Antonio Scandurra created

1d41a70 Remove internal actions from `terminal_button`

Antonio Scandurra created

33da9e5 Remove internal actions from `project_panel`

Antonio Scandurra created

e153573 Remove `DeployContextMenu` internal action

Antonio Scandurra created