This PR polishes off the channel buttons such that they behave as
expected.
The absolutely-positioned button container will now no longer take up
space—and thus obscure the channel name—when there are no notifications
and the channel entry is not hovered.
Release Notes:
- N/A
Marshall Bowers
created
b4a205b
Pane: Fix flicker when opening/closing tabs
Click to expand commit body
Tab bar was losing focus for one frame which led to it skipping rendering of tab controls & flickering. It also occured when opening new tabs.
Piotr Osiewicz
created
406edd2
Merge branch 'main' into refine-render-traits
1810824
Merge branch 'main' into completion-menu-detail-layout
Julia
created
017b25e
Add debounce time back to telemetry queue (#3856)
Click to expand commit body
After talking with Max, we decided to bring back the debounce time to
the telemetry queue, only, with a longer duration than before.
Release Notes:
- N/A
Joseph T. Lyons
created
2a73eb3
Add `icon_tooltip` for panel buttons rather than using persistent name (#3849)
Click to expand commit body
Fixes missing spaces in these tooltips
Release Notes:
- N/A
This reverts commit 09951208a78c9933159c68c6f8105eda40e8bd7e, reversing
changes made to 93a818d0186dce098cae4ae08dd368c23b895a4b.
I noticed an issue where context menus were appearing in the wrong
location (shifted to the right) as a result of this change.
Release Notes:
- N/A
Marshall Bowers
created
4b006cc
Use buffer font size for editor overlays and blocks
Click to expand commit body
Co-authored-by: Nathan <nathan@zed.dev>
Max Brunsfeld
and
Nathan
created
74468a8
Improve positioning of channel buttons (#3850)
Click to expand commit body
This PR is another pass at improving the positioning of channel buttons.
I had to employ some dirty hacks to get it to work, but I think it is
~mostly there.
Release Notes:
- N/A
Marshall Bowers
created
335e007
Add nightly environment for collab (#3848)
Click to expand commit body
For now, we'll need to deploy to `nightly` manually, using the same
scripts that we use to deploy to `preview` and `production`.
We've renamed the `deploy` script to `deploy-collab`, and added a new
script, `deploy-postgrest` that sets up the Postgrest database admin
API. We split that out, since it's not needed for environments that
share a database with prod.
Max Brunsfeld
created
14066c4
Add `icon_tooltip` for panel buttons rather than using persistent name
Also, move postgrest service + deployment into a separate manifest
file, which is deployed via a separate script, `deploy-postgrest`.
This way, we don't have unused postgrest instances in preview and
nightly, since those use the prod database.
Co-authored-by: Conrad <conrad@zed.dev>
Adds the infractucture for settings events and specifically tracks theme
settings. Currently, we only take note of the theme at app open and when
the user switches the theme with the theme selector. Changes at the
config file are ignored, as putting code that low leads to a lot of
chances of reporting theme events when the user hasn't done anything.
This change is done in both Zed 1 and Zed 2.
I'll open up a PR on zed.dev and adjust the database accordingly.
Release Notes:
- N/A
There was a hypothesis that this would fix border rendering.
It doesn't :D; but it does at least mean that they are always
consistently
broken, so it may be easier to fix.
Conrad Irwin
created
ce5855d
Render completion menu items using `ListItem`s
93a818d
Add additional status colors and style diagnostic popovers (#3846)
Click to expand commit body
This PR adds additional background and border colors for each of the
status colors to the theme.
These colors are then used to style the diagnostic popovers:
<img width="407" alt="Screenshot 2024-01-02 at 4 25 50 PM"
src="https://github.com/zed-industries/zed/assets/1486634/fbc64ea7-3dcd-43b7-8520-91f16304bfba">
<img width="396" alt="Screenshot 2024-01-02 at 4 26 05 PM"
src="https://github.com/zed-industries/zed/assets/1486634/6e4a44bf-4aac-4595-afff-7fbf8b2b9e1f">
Release Notes:
- N/A
Marshall Bowers
created
ae71d1a
Layout completion single-line documentation to the right of item
This PR fixes the spacing in the diagnostics tab.
#### Before
<img width="108" alt="Screenshot 2024-01-02 at 3 40 51 PM"
src="https://github.com/zed-industries/zed/assets/1486634/9508d867-5b5d-45b0-8b16-be35a23e3e7a">
#### After
<img width="121" alt="Screenshot 2024-01-02 at 3 40 54 PM"
src="https://github.com/zed-industries/zed/assets/1486634/33e665e7-2935-4d4f-b1d0-9cb655235867">
Release Notes:
- N/A
Marshall Bowers
created
d64d91a
Restore transparency to scroll bar handles (#3843)
Click to expand commit body
This PR restores the semi-transparency to the scroll bar handle colors
that were lost in #3842.
If we adjust the rendering of the scrollbar to draw the status
indicators on top of the scrollbar handle then we can remove the
transparency.
Release Notes:
- N/A
Marshall Bowers
created
8247be3
Use Zed1 Color Scheme to update Zed1 Theme Importer (#3842)
Click to expand commit body
Bring Zed1 themes closer to their old appearance using the `base_theme`
values.
This will inevitably re-introduce some outstanding design issues from
Zed 1 that we will need to solve (low contrasts in some places, etc.)
We'll work on some of these in a later PR.
Known issues introduced:
- Scrollbar thumb is incorrectly drawn in front of the indicators
- Borders aren't quite correct - will fix in a followup
- Titlebar/status bar buttons will now have low contrast states
- Keybinding background color blends with palette
There are likely more issues, add them to the product checklist as you
find them.
Release Notes:
- N/A
9996fbe
Absolutely position channel buttons (#3840)
Click to expand commit body
This PR absolutely positions the channel buttons on top of the channels.
This prevents the buttons from getting pushed off the edge of the panel
when the channel names are long.
Still needs some fine-tuning, but gets us closer to where we want to be.
Release Notes:
- N/A
30624b9
Fix anti-aliasing artifacts in GPUI 2 borders (#3818)
Click to expand commit body
Previously, we changed borders to be drawn after content, so they are no
longer part of the same quads as the background. In our change, we gave
the background quad a transparent black border and the border quads
transparent black backgrounds. However, this caused the other channels
to blend toward that black color before becoming fully transparent,
causing them to become darker.
In this PR, I source the "placeholder" color by duplicating the values
for the other channels and only adjust the alpha down to zero.
Release Notes:
- N/A
Nathan Sobo
created
68e7d99
Return impl IntoElement from RenderOnce::render
Click to expand commit body
This makes it a bit more approachable to implement.
This required converting the state of Component to AnyElement, which
costs an allocation. I'm hoping this will be ok performance-wise now
that AnyElements use bump allocation, but I need to benchmark still.
1b5c8b2
Return impl IntoElement from Render::render trait
Nathan Sobo
created
853192b
Map suggestion colors from Zed1 themes (#3835)
Click to expand commit body
This PR maps the suggestions colors from the Zed1 themes to the Zed2
themes.
Release Notes:
- N/A
Marshall Bowers
created
0f33775
Add general-purpose functions for sizing in viewport units (#3833)
Click to expand commit body
This PR adds general-purpose functions for obtaining a `Length` in
viewport units.
Previously in #3600 we had added specific variants of `w` and `h` that
took viewport units, but I think it makes more sense to just have a
primitive that can compose with any styling method that accepts a
`Length` or `Into<Length>`.
Release Notes:
- N/A
This PR adjusts the size of the chat and channel note icons in the
channel list to be smaller.
Release Notes:
- N/A
Marshall Bowers
created
f5b60ad
Increase outline picker max height (#3831)
Click to expand commit body
This PR increases the max height of the outline picker so that it can
take up a larger area of the screen when there are lots of results.
This behavior is similar to the way it was in Zed1.
Release Notes:
- N/A