c7933a6
Remove stray dbg
Antonio Scandurra created
Commit log
73682da
Provide mut access to allocated arena struct via non-cloneable ArenaBox
Click to expand commit body
This commit also allows turning an `ArenaBox` into an `ArenaRef` when non-mutable access is required, which makes `ArenaRef: Clone`. This fixes a bug that prevented the command palette from reading all the available actions while the `command_palette::Toggle` action was being dispatched.
Antonio Scandurra created
ca091f3
Fix layout issues with feedback modal (#3751)
Click to expand commit body
Release Notes: - N/A
Joseph T. Lyons created
036636e
Fix layout issues with feedback modal
Click to expand commit body
The feedback modal still needs a styling update
Joseph T. Lyons created
e5ce5e8
Clear pending keystrokes when an action is dispatched (#3750)
Click to expand commit body
This prevents the `cmd-k` keystroke, which clears the terminal, from staying around as a pending keystroke on the parent workspace. Release Notes: - N/A
Nathan Sobo created
4680aad
Correctly compute placeholder text for buffer search query editor (#3749)
Click to expand commit body
Rather than relying on the focused element, instead explicitly pass the focus handle for the query editor when determining the prev/next bindings. Only compute these values once. Release Notes: - N/A
Nathan Sobo created
5747c9b
Clear pending keystrokes when an action is dispatched
Nathan Sobo created
c56e7cd
Remove unused import
Nathan Sobo created
4f6bef5
Improve interaction between clicking and dragging (#3737)
Click to expand commit body
Once a drag starts, we won't fire click listeners or style any elements as active. - Don't fire click listeners or show active state once a drag is in progress - Don't show hover style when a drag is in progress - Draw borders above content - If borders are opaque, apply them to the content mask. This prevents hovers from firing on content underneath the border, which was creating issues where the drag handle was inside the border, so we'd flicker the hover when the mouse moved out of the drag handle and into the 1px border on the left dock. - Add a `block_mouse` helper which causes transparent elements to paint an "opaque" layer to prevent mouse events from falling through. We use this for the drag handle as well to disable hover, click, etc on items in the panel. Release Notes: - N/A
Nathan Sobo created
afbc655
Ensure that views' `on_release` callbacks are always called (#3747)
Click to expand commit body
* Ensure that views' on_release callbacks are always called (even if their window is gone), by passing them a `AppContext`, not a `WindowContext`. * Fix leaked handles to `CollabPanel`, `NotificationPanel`, and `ChatPanel` caused by captures in a `ListState` render callback. This fixes two issues we were seeing with following: * inability to rejoin a remote project after you closed it * following not working if a window had previously been closed
Max Brunsfeld created
87a1387
For file finder queries, match in all gitignored worktree entries (#3748)
Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/2347 Part of https://github.com/zed-industries/community/issues/1538 Now file finder will match all gitignored worktree entries. Zed does not traverse gitignored dirs by default, which means that not all gitignored files will be matches, but all that were toggled in project panel and all root non-directory gitignored entries will be now used, hopefully causing less questions. Release Notes: - Improved file finder to match all gitignored files that were added into worktrees (e.g. due to opening gitignored directories in project panel)
Kirill Bulatov created
24970c1
Fix view handle leaks in ListState callbacks
Max Brunsfeld created
2f56fe9
For file finder queries, search in all gitignored worktree entries
Kirill Bulatov created
42bdc11
Prune dead workspaces from WorkspaceStore on read
Click to expand commit body
Also, remove unnecessary window handle from Workspace.
Max Brunsfeld created
5e7c74c
Ensure that on_release callbacks are called even if view outlives its window
Max Brunsfeld created
d61cac6
Add `ToggleButton` for use in buffer search (#3746)
Click to expand commit body
This PR adds a new `ToggleButton` component: <img width="738" alt="Screenshot 2023-12-20 at 6 50 13 PM" src="https://github.com/zed-industries/zed/assets/1486634/9c5fb45b-0b55-4008-9336-b651a26a99ad"> We're using `ToggleButton`s for the search mode selection in the buffer search: <img width="842" alt="Screenshot 2023-12-20 at 6 47 57 PM" src="https://github.com/zed-industries/zed/assets/1486634/178a278f-172c-4c67-8572-83d59de2ed14"> Release Notes: - N/A
Marshall Bowers created
11807bb
Add large variant for buttons
Marshall Bowers created
93c8bee
Use `ToggleButton`s for search mode in buffer search
Marshall Bowers created
8238edb
Remove nightly from zed1 and use proper namespaces for nightly in zed2 manifest (#3745)
Click to expand commit body
Currently, I get 404 when trying to open links for nightly, like https://zed.dev/nightly/channel/Rooms-329 The PR ensures nightly has a separate protocol handler in zed2, removes nightly mentions from zed1. See also zed.dev change: https://github.com/zed-industries/zed.dev/pull/429 Release Notes: - N/A
Kirill Bulatov created
443b1dd
Add `ToggleButton` component
Marshall Bowers created
2cd7d2d
Remove nightly from zed1 and use proper namespaces for nightly in zed2 manifest
Kirill Bulatov created
56f2b96
Restore "reveal in project panel" and "search in directory" context menu actions (#3744)
Click to expand commit body
Release Notes: - N/A
Kirill Bulatov created
72c8bea
Restore "reveal in project panel" and "search in directory" context menu actions
Kirill Bulatov created
5272794
Refine toolbar and buffer search styling (#3743)
Click to expand commit body
This PR refines the toolbar styling, specifically around the buffer search. Spacing has been adjusted to feel less claustrophobic. Release Notes: - N/A
Marshall Bowers created
e5e8e88
Inline toggle replace button
Marshall Bowers created
2ac472e
Inline buttons
Marshall Bowers created
8a8b498
Style replace input
Marshall Bowers created
b493d8f
Improve spacing of items in buffer search bar
Marshall Bowers created
b9bc74a
Increase toolbar padding
Marshall Bowers created
53b6083
Don't apply the gap when we don't have any items in the first row
Marshall Bowers created
87ae21f
Merge remote-tracking branch 'origin/main' into cancel-clicks-on-drag
Nathan Sobo created
d499ccc
Only compute placeholder text once
Nathan Sobo created
bc479af
Style incoming call notification (#3742)
Click to expand commit body
This PR styles the incoming call notification. <img width="405" alt="Screenshot 2023-12-20 at 3 56 39 PM" src="https://github.com/zed-industries/zed/assets/1486634/9cfb89e7-ba5f-4463-bf53-a3f8a82e136f"> Release Notes: - N/A
Marshall Bowers created
7b51f73
Tighten up project share notifications
Marshall Bowers created
9a06b7e
Style incoming call notifications
Marshall Bowers created
9acb582
Compute the query editor placeholder text with a focus handle
Click to expand commit body
So we're not beholden to the current focus.
Nathan Sobo created
26fb67b
chore: Remove 'db' dependency from recent_projects2 (#3740)
Click to expand commit body
It was pulling in gpui1 into zed2 build. Release Notes: - N/A
Piotr Osiewicz created
c1df27c
Style notification panel (#3741)
Click to expand commit body
This PR makes a first pass at styling the notification panel. #### Signed out <img width="381" alt="Screenshot 2023-12-20 at 11 41 25 AM" src="https://github.com/zed-industries/zed/assets/1486634/f045fa17-4ebc-437f-a25b-d7695d47f18b"> #### No notifications <img width="380" alt="Screenshot 2023-12-20 at 11 44 23 AM" src="https://github.com/zed-industries/zed/assets/1486634/3a7543f2-8cd8-4788-8059-d5663f5f6b4c"> #### Notifications <img width="386" alt="Screenshot 2023-12-20 at 1 27 08 PM" src="https://github.com/zed-industries/zed/assets/1486634/13b81722-c47a-4c06-b37d-e6515cbfdb9d"> Release Notes: - N/A
Marshall Bowers created
15f16f0
Move application of content mask and z-index into Interactivity::paint
Click to expand commit body
This allows the content mask to correctly apply to bounds used in event handlers, which prevents content under opaque borders from being hovered in overflow hidden containers. Co-Authored-By: Antonio <antonio@zed.dev> Co-Authored-By: Max Brunsfeld <max@zed.dev>
Nathan Sobo , Antonio , and Max Brunsfeld created
da34dd4
Fix text wrapping issues with `overflow_hidden`
Click to expand commit body
This seems to influence sizing calculations in ways I don't fully understand.
Marshall Bowers created
4c0856e
collab 0.32.0
Joseph T. Lyons created
b0b4610
Fix positioning of right items
Marshall Bowers created
fffb30a
Add InteractiveElement::block_mouse which renders an "opaque" layer
Click to expand commit body
Co-Authored-By: Antonio <antonio@zed.dev> Co-Authored-By: Max Brunsfeld <max@zed.dev>
Nathan Sobo , Antonio , and Max Brunsfeld created
73b13b7
v0.119.x dev
Joseph T. Lyons created
a125610
Assign draw order to surfaces using plane splitter (#3739)
Click to expand commit body
It looks like we neglected to incorporate surfaces into the plane-splitting code path, which assigns each graphics primitive's draw order. This fixes an issue where screensharing frames were not visible when the screenshare tab was zoomed.
Max Brunsfeld created
87f879b
Add text wrapping to notifications
Marshall Bowers created
dc04743
Don't consider any element hovered when actively dragging
Click to expand commit body
Co-Authored-By: Antonio <antonio@zed.dev>
Nathan Sobo and Antonio created
9c4e869
Remove unneeded wrapping element
Marshall Bowers created
8f677cc
Assign draw order to surfaces using plane splitter
Max Brunsfeld created
e1a4e8e
Reintroduce LSP diagnostic/status message (#3728)
Click to expand commit body
Release Notes: - N/A
Julia created