Commit log

5359762 Document components/avatar

Click to expand commit body
Co-Authored-By: Antonio Scandurra <me@as-cii.com>

Nate Butler and Antonio Scandurra created

59f41ac Add a bunch of docs

Click to expand commit body
Co-Authored-By: Conrad <conrad@zed.dev>
Co-Authored-By: Mikayla <mikayla@zed.dev>

Nathan Sobo , Conrad , and Mikayla created

9747c10 Document UI modules

Click to expand commit body
Co-Authored-By: Antonio Scandurra <me@as-cii.com>

Nate Butler and Antonio Scandurra created

bcbfa7d Start documenting Theme crate

Click to expand commit body
Co-Authored-By: Antonio Scandurra <me@as-cii.com>

Nate Butler and Antonio Scandurra created

ab6cd1d chore: cfg(test) a test in rpc. (#3978)

Click to expand commit body
The test in particular should be included in our release binary at
present. :/
Release Notes:

- N/A

Piotr Osiewicz created

b801e0a Fix merge conflict

Conrad Irwin created

bebb528 Merge branch 'main' into migrations-on-server-start

Conrad Irwin created

824d06e Remove `Default` impl for `StatusColors` (#3977)

Click to expand commit body
This PR removes the `Default` impl for `StatusColors`.

Since we need default light and dark variants for `StatusColors`, we
can't use a single `Default` impl.

Release Notes:

- N/A

Marshall Bowers created

d374953 search: Remove newlines from query used for tab_content. (#3976)

Click to expand commit body
Fixes https://github.com/zed-industries/community/issues/2388
Release Notes:

- Fixed tab content of project search overflowing the tab for queries
with newlines.

Piotr Osiewicz created

f0ef63b gpui: Add `SharedUrl` type (#3975)

Click to expand commit body
This PR adds a `SharedUrl` type to GPUI.

It's just like a `SharedString`, but for denoting that the contained
value is a URL.

Mainlined from @nathansobo's GPUI blog post:
https://github.com/zed-industries/zed/pull/3968/files#diff-7ee75937e2daf7dd53f71b17698d8bd6d46993d06928d411781b9bd739b5f231R9-R12

Release Notes:

- N/A

Marshall Bowers created

fa53353 Rename `IconElement` to just `Icon` (#3974)

Click to expand commit body
This PR renames the `IconElement` component to just `Icon`.

This better matches the rest of our components, as `IconElement` was the
only one using this naming convention.

The `Icon` enum has been renamed to `IconName` to free up the name.

I was trying to come up with a way that would allow rendering an
`Icon::Zed` directly (and thus make the `IconElement` a hidden part of
the API), but I couldn't come up with a way to do this cleanly.

Release Notes:

- N/A

Marshall Bowers created

29ed067 Add a missing default value to docs (#3973)

Click to expand commit body
Release Notes:

- N/A

Piotr Osiewicz created

a0f9393 Remove some todo!'s from the code (#3972)

Click to expand commit body
Release Notes:

- N/A

Kirill Bulatov created

625c9d8 Remove some todo!'s

Kirill Bulatov created

aa1d2d2 Remove dbg! usage from tests

Kirill Bulatov created

0f7b47a Run migations on development server start

Conrad Irwin created

82f7dd9 Prototype cursor sharing (the inefficient way)

Click to expand commit body
I think this will be a key user experience driver, but we do need to
find a way to enable it without widening our vector clocks.

Conrad Irwin created

8669b08 Failing test for unmuting microphone

Conrad Irwin created

844d161 Allow adding write access to guests

Conrad Irwin created

4afa5fb Add stories for collab notifications (#3967)

Click to expand commit body
This PR adds some basic stories for collab notifications to make them
easier to work on:

<img width="1076" alt="Screenshot 2024-01-08 at 9 43 39 PM"
src="https://github.com/zed-industries/zed/assets/1486634/4a0adcfa-1134-49c2-b589-74ac1d52af4c">

I factored out a `CollabNotification` component that defines the general
structure for one of these notifications, and this is the component that
we use in the stories, with representative values passed to it to
simulate the different instances of the notification.

We can't use the actual notification components in the stories due to
their data dependencies.

Release Notes:

- N/A

Marshall Bowers created

27d4d72 Attempt to write test

Mikayla created

c40a7f3 Stop propagation when deploying the context menu for a project panel entry (#3965)

Click to expand commit body
This PR fixes an issue where right-click on any project panel entry
would cause the context menu on the root of the project panel
(introduced in #3954) to deploy.

We need to stop propagation in the handler on the inner project panel
list items so that the click event doesn't bubble up the tree.

Release Notes:

- Fixed an issue where the project panel was always deploying the root
context menu rather than on the clicked item.

Marshall Bowers created

6982b4b Fix off by 1 error when computing available key bindings (#3964)

Click to expand commit body
Fixes https://github.com/zed-industries/community/issues/2379

Release Notes:

- Fixed issue where keybindings in some context menus would not show
reliably.

Mikayla Maki created

0684369 Fix off by 1 error when computing available key bindings

Mikayla created

435b5ca Restore the terminal cursor settings (#3963)

Click to expand commit body
As it says on the tin

Release Notes:

- Restored the terminal cursor's I-beam and pointing hand settings

Mikayla Maki created

ec7db3f Restore the terminal cursor settings

Mikayla created

68e705d Restore the active pane magnification feature (#3961)

Click to expand commit body
As it says on the tin

Release Notes:

- Restored the active pane magnification setting.

Mikayla Maki created

ca0c06b Fix assets build (#3962)

Click to expand commit body
Release Notes:

- N/A

Conrad Irwin created

6f6fa5b Fix assets build

Conrad Irwin created

51caa74 Restore the active pane magnification feature

Mikayla created

4007b2f Tighten up feedback modal design (#3960)

Click to expand commit body
This PR tightens up the design of the feedback dialog:

<img width="680" alt="Screenshot 2024-01-08 at 6 20 50 PM"
src="https://github.com/zed-industries/zed/assets/1486634/8dc0e687-2459-4ab3-b69f-b610ce067ef1">

<img width="682" alt="Screenshot 2024-01-08 at 6 21 24 PM"
src="https://github.com/zed-industries/zed/assets/1486634/f0730710-16e0-4d61-a919-60874442186a">

Release Notes:

- Improved the design of the feedback dialog.

Marshall Bowers created

32cd956 Push branch before tag

Conrad Irwin created

e876262 collab 0.35.0

Conrad Irwin created

fac8ebf Fix error border color for email input in feedback dialog (#3959)

Click to expand commit body
This PR fixes the border color used when the email input in the feedback
dialog is invalid.

Previously this was hardcoded just to `red` instead of using the
appropriate color from the theme.

<img width="653" alt="Screenshot 2024-01-08 at 5 40 07 PM"
src="https://github.com/zed-industries/zed/assets/1486634/ea01cd76-d661-4512-b668-c82b8d00d84e">

Release Notes:

- Fixed the border color used for the email input in the feedback dialog
when an invalid email is entered.

Marshall Bowers created

475d91a guest acls (#3958)

Click to expand commit body
- First pass of real access control
- Check user is host for host-broadcasted project messages
- Only allow read-write users to update buffers

[[PR Description]]

Release Notes:

- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).

Conrad Irwin created

59a1648 Disallow creating files with '..' (#3156)

Click to expand commit body
Release Notes:

- Fixed a crash that could occur when creating files with '..' in the
path

Conrad Irwin created

d7c5d29 Only allow read-write users to update buffers

Conrad Irwin created

71149bc Fix relative path opening from project symbols

Click to expand commit body
Co-Authored-By: Max <max@zed.dev>

Conrad Irwin and Max created

ae6d09b chore: Extract `assets` module out of zed crate. (#3957)

Click to expand commit body
This essentially shaves off about 10% off of an incremental build after
project change and potentially more if you're changing stuff like
`welcome` that's very close to the `zed` crate in the dep graph. That's
because macro expansion takes place even in incremental builds it seems?
And zed (lib) + zed (bin) could take up to 4 seconds out of an
incremental build, which is a *lot* in a 10s build. In reality though it
shaves 1 second off of 5 seconds incremental 'welcome'/ 1s off of 10s
'project' builds.

Note that we had `assets` crate in the past (removed in #2575 /cc
@maxbrunsfeld), but this is a bit different, because `assets` is a
dependency of *just* zed and nothing else. We essentially cache macro
expansion results ourselves.

Release Notes:

- N/A

Piotr Osiewicz created

80f204f Style the chat panel message input (#3956)

Click to expand commit body
This PR styles the message input in the chat panel.

<img width="242" alt="Screenshot 2024-01-08 at 4 28 33 PM"
src="https://github.com/zed-industries/zed/assets/1486634/48e83692-878e-4891-8e40-8738cdeb23a8">

Release Notes:

- Improved the styling of the message editor in the chat panel.

Marshall Bowers created

c951b4c Fix prevention of cross-channel joins (#3949)

Click to expand commit body
Co-Authored-By: Max <max@zed.dev>

[[PR Description]]

Release Notes:

- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).

Conrad Irwin created

aed97f6 Use "test" consistently

Conrad Irwin created

667d901 Improve chat panel empty states (#3955)

Click to expand commit body
This PR improves the empty states for the chat panel:

- The signed-out state has been updated to match our other signed-out
panel states.
- A new state has been added to account for the case where a user is
signed in but doesn't have an active chat.

Release Notes:

- Improved the design of empty states in the chat panel.

Marshall Bowers created

ed76315 Fix prevention of cross-channel joins

Click to expand commit body
Co-Authored-By: Max <max@zed.dev>

Conrad Irwin and Max created

604fcd8 No .. paths...

Conrad Irwin created

a2a0628 Show context menu on project panel empty space right click (#3954)

Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/2383

Release Notes:

- Fixed context menu not shown when right clicking empty project panel
space

Kirill Bulatov created

35ce34c Show context menu on project panel empty space right click

Kirill Bulatov created

18b31f1 Check user is host for host-broadcasted project messages

Max Brunsfeld created

7235b3d Clean up outline selections when its modal gets closed (#3953)

Click to expand commit body
Release Notes:

- Fixed outline selections not being cleared on certain modal dismiss
actions

Kirill Bulatov created

2ca17bd Clean up outline selections when its modal gets closed

Kirill Bulatov created