dd73054
chore: Fix spurious rebuilds of Zed library and binary (#3952)
Click to expand commit body
Currently when one runs `cargo build` twice without changing anything,
zed lib and binary are gonna get rebuilt every time. I checked out cargo
logs and it turns out we were querying wrong path to `.git/logs/HEAD` in
our build.rs, causing it to rerun on every build and thus marking zed
lib as dirty.
See logs (`CARGO_LOG=cargo::core::compiler::fingerprint=trace cargo
build`):
```
0.501173792s INFO cargo::core::compiler::fingerprint: fingerprint dirty for zed v0.120.0 (/Users/hiro/Projects/zed/crates/zed)/RunCustomBuild/TargetInner { ..: custom_build_target("build-script-build", "/Users/hiro/Projects/zed/crates/zed/build.rs", Edition2021) }
0.501180417s INFO cargo::core::compiler::fingerprint: dirty: FsStatusOutdated(StaleItem(MissingFile("/Users/hiro/Projects/zed/crates/zed/.git/logs/HEAD")))
```
The path to .git directory is relative to crates/zed and not to the
workspace's root.
/cc @maxbrunsfeld
Release Notes:
- N/A
Piotr Osiewicz
created
8214a7f
Fix inconsistent sizing between the buffer search and the project search (#3951)
Click to expand commit body
This PR fixes the inconsistent sizing between the buffer search and the
project search when both elements have both a primary and secondary item
shown in the toolbar.
Release Notes:
- Fixed some inconsistent sizing in the buffer search and project search
when both have two rows of tools in the toolbar.
This PR removes a commented-out implementation for the `ActiveTheme`
trait on the `WindowContext`.
We don't need this implementation as we can go through the
`AppContext`'s implementation.
Release Notes:
- N/A
Updates Zed2 Copilot UI
- Introduces the `Headline` component for rendering large text
- Styles the 3 Copilot prompt states


Release Notes:
- Updated the connect Copilot modal UI.
Nate Butler
created
e4b1c76
Display setting documentation in settings.json (#3936)
Click to expand commit body
Let this screenshot of settings.json speak for itself:

Release Notes:
- Added code completion & on-hover documentation to Zed's settings.json
file.
---------
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Piotr Osiewicz
and
Marshall Bowers
created
5e401e4
Fix layout shift when renaming a channel (#3946)
Click to expand commit body
This PR fixes the layout shift that would occur in the channel list when
opening a rename editor for a channel.
Release Notes:
- Fixed layout shift when opening a rename editor for a channel.
Marshall Bowers
created
72de75d
Adjust spacing of extra call participant count indicator (#3945)
Click to expand commit body
This PR adjusts the spacing of the indicator showing the number of extra
call participants that appears after the facepile:
<img width="242" alt="Screenshot 2024-01-08 at 1 09 39 PM"
src="https://github.com/zed-industries/zed/assets/1486634/6d9cbefa-3b4e-4501-ab11-51026dfb5b6c">
Release Notes:
- Added more space between the call participant facepile and the number
indicating additional call participants.
I've missed a single run_until_parked call. mb
Release Notes:
- N/A
Piotr Osiewicz
created
46a99fe
Use correct color for folded diff indicator (#3942)
Click to expand commit body
This PR updates the indicator for changes within a fold to use the
correct color from the theme:
<img width="380" alt="Screenshot 2024-01-08 at 12 52 56 PM"
src="https://github.com/zed-industries/zed/assets/1486634/b8bf6bf3-6acc-43a4-8c4b-a02c975c7f02">
Release Notes:
- Updated the color of the indicator for a fold containing modified
lines.
Marshall Bowers
created
2f6bbde
Improve styling of tree branches in collab panel (#3941)
Click to expand commit body
This PR updates the styling of the tree branches in the current call
section of the collab panel:
- Fixed the gap between the notes and chat items.
- We now overdraw the tree branch on the notes item so it fills the gap.
- The tree branch lines are now thinner.
<img width="231" alt="Screenshot 2024-01-08 at 12 35 35 PM"
src="https://github.com/zed-industries/zed/assets/1486634/844c9e18-c2de-4163-9384-41d1577e23a0">
Note: I think the signature for `render_tree_branch` could use some
improvement. I don't like having the multiple `bool` parameters, but any
change I could think of was going to be a bit more invasive than I
wanted to take on in this PR.
Release Notes:
- Improved the style of the tree branches in current call details in the
collab panel.
Fixes some issues with the Checking icon I added last week.
- Use default text color for "Checking..." text and icon
- Always show text and icon while checks are running
I think we should probably remove the `✅` while checks are running as it
incorrectly indicates nothing is wrong when we don't yet know that – but
that is a larger change so I'll keep this fix contained.
Release Notes:
- Fixes "Checking" diagnostics icon only showing until the first
diagnostics item is found.
3541dd8
Tweak message role indicator in the assistant panel (#3938)
Click to expand commit body
This PR tweaks the message role indicator in the assistant panel.
Previously we added a negative margin in #3925 to align the indicator
with the text, but the result of this was the left side of the button
getting clipped on hover.
To remedy this, we now use the filled button style so that the
background always shows and maintains the visual alignment.
### Before
<img width="451" alt="Screenshot 2024-01-08 at 10 50 21 AM"
src="https://github.com/zed-industries/zed/assets/1486634/dd3ae3dc-13c5-4d81-abd7-8023aca496c8">
### After
<img width="401" alt="Screenshot 2024-01-08 at 10 54 42 AM"
src="https://github.com/zed-industries/zed/assets/1486634/c089a879-1c88-4d94-9532-4e9433a35828">
We could also do what we did in Zed1, where the hover style doesn't have
any padding and is flush with the left side of the text, but I don't
think this looks as polished.
The "Assistant" role now also uses a separate color from "System".
Release Notes:
- Updated the style of the message role indicator in the assistant
panel.
Marshall Bowers
created
42bd9ff
Use filled button style for role indicator in assistant panel
Click to expand commit body
This fixes the left side of the button getting clipped on hover.
Marshall Bowers
created
5866420
Use info color for assistant role indicator
Marshall Bowers
created
97aed8a
Restore ability to reset pane split size by double clicking drag handle. (#3937)
Click to expand commit body
Release notes
- Fixed double clicking on pane drag handle not resetting pane's split
size.
- Fixed pane group sizes not being serialized.
At present 3 tests still fail; 2 are related to keymap issues that (I
believe) @maxbrunsfeld is working on. The other one
(`test_open_paths_action`) I'll look into. edit: done
This PR also fixes workspace unregistration, as we've put the code to do
that behind `debug_assert`
(https://github.com/zed-industries/zed/pull/3907/files#diff-041673bbd1947a35d45945636c0055429dfc8b5985faf93f8a8a960c9ad31e28L649).
Release Notes:
- N/A
Piotr Osiewicz
created
d475f13
gpui: Further docs refinement & moved some reexports into 'private' module (#3935)
Click to expand commit body
This commit mostly fixes invalid URLs in docstrings. It also
encapsulates crates we reexport (serde stuff + linkme) into a public
module named "private" in order to reduce the API surfaced through docs.
Moreover, I fixed up a bunch of crates that were pulling serde_json in
through gpui explicitly instead of using Cargo manifest.
Release Notes:
- N/A
Piotr Osiewicz
created
eb9ddef
Always show full command on terminal tab hover (#3934)
Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/1856
Release Notes:
- Fixed terminal tab tooltip being truncated
Kirill Bulatov
created
d566a0d
Always show full command on terminal tab hover
Deals with https://github.com/zed-industries/community/issues/1317
Deals with https://github.com/zed-industries/community/issues/486
Reworks pane drag and drop code to support
* dropping external files into main pane (supports splits same as tabs
and project entries drop) — this will open the file dropped
* dropping external files, tabs and project entries drop into the
terminal — this will add file abs path into the terminal
Release Notes:
- Added a way to drag and drop external files into Zed main & terminal
panes; support tabs and project entries drop into terminal pane
# TODO
- [x] Fix busted tests
- [x] Check all events from actions on welcome screen
- [x] change theme
- [x] change keymap
- [x] install cli
- [x] enable vim
- [x] send metric data
- [x] send diagnostics
- [x] close welcome screen
- [X] Check all settings events
- [x] record theme change (in main and in selector)
- [x] record base keymap change (in main and in selector)
- [x] record metric data value
- [x] record diagnostics value
- [X] Triple check that telemetry settings still block events from being
sent, since we updated how we check for settings changes
- [X] Remove immediate flush mode and allow the flush method to be
called publicly
- [x] Remove references to clickhouse in the code (should be generic at
the client level)
Release Notes:
- N/A
Joseph T. Lyons
created
44bc5ae
Improve setting name consistency for welcome page
Joseph T. Lyons
created
1bcee19
Improve operation name consistency for welcome page
The client sends events to our end point, and the endpoint is what determines what analytics database is used to store the data. The client should be generic and not mention the name of the service being proxied to through our server.
dc7f9bb
gpui: Sweep through cargo doc output and mark dubious items as non-public (#3932)
Click to expand commit body
I essentially went through the publicly exported items and marked these
that are e.g. leaky reexports as pub(crate). I expect that'd be done on
Tuesday anyways.
Release Notes:
- N/A
Piotr Osiewicz
created
ec03572
Properly detect file finder label positions in paths (#3931)
Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/2367
Release Notes:
- Fixed file finder crashing on certain paths with multi-codepoint
characters
([#2367](https://github.com/zed-industries/community/issues/2367))
Kirill Bulatov
created
5dca1b5
Properly detect file finder label positions in paths