Commit log

36ff35f Change name of deploy action to indicate what scope it operates at

Mikayla created

52267a5 Adjust project search behavior to be isolated to a pane

Mikayla created

3d041f4 Fix overlapping block headers when using custom line height (#4071)

Click to expand commit body 
This fixes block headers overlapping over text in the buffer when using
a custom line height of 1.25.

It fixes the issue by making the parent container a v-flex,
vertically-justifying the content and moving from relative padding to
absolute padding for the header itself.

## Before/After

With setting:
```json
  "buffer_line_height": {
    "custom": 1.25
  },
```

### Before

![screenshot-2024-01-16-16 48
48@2x](https://github.com/zed-industries/zed/assets/1185253/8c3b977e-333f-403c-a4d3-0911f3fac5e0)

### After

![screenshot-2024-01-16-16 50
13@2x](https://github.com/zed-industries/zed/assets/1185253/2d854eba-c4c4-4bce-b60b-dd250856b08f)

### Release notes
Release Notes:

- Fixed headers in multi-buffers overlapping over content of the buffer

Thorsten Ball created

60b79ef Prevent content mask breaks from having the same z-index

Click to expand commit body 
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>

Julia and Antonio Scandurra created

4f25df6 Prevent div background/content/border from interleaving at same z-index

Click to expand commit body 
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>

Julia and Antonio Scandurra created

62f5bec Fix rustfmt by pulling out long string into constant

Thorsten Ball created

1cbdf2b Fix overlapping block headers when using custom line height

Click to expand commit body 
This fixes block headers overlapping over text in the buffer when using
a custom line height of 1.25.

It fixes the issue by making the parent container a v-flex,
vertically-justifying the content and moving from relative padding to
absolute padding for the header itself.

Co-authored-by: antonio <antonio@zed.dev>
Co-authored-by: julia <julia@zed.dev>
Co-authored-by: marshall <marshall@zed.dev>

Thorsten Ball , antonio , julia , and marshall created

47f2d55 Revert "Use taffy to retrieve the parent for a given layout node" (#4070)

Click to expand commit body 
This reverts commit 5904bcf1c20638d63b244a1b2b038ec9a664ba1c.

Release Notes:

- N/A

Antonio Scandurra created

4e0c8dc Revert "Use taffy to retrieve the parent for a given layout node"

Click to expand commit body 
This reverts commit 5904bcf1c20638d63b244a1b2b038ec9a664ba1c.

Co-Authored-By: Antonio Scandurra <antonio@zed.dev>

Julia and Antonio Scandurra created

0bf66e4 Call CGGetActiveDisplayList once to avoid panic (#4069)

Click to expand commit body 
This contains two changes in order to hopefully avoid the panic we saw
in #panics:

```
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value'
crates/gpui/src/platform/mac/display.rs:30
<backtrace::capture::Backtrace as core::fmt::Debug>::fmt
<backtrace::capture::Backtrace as core::fmt::Debug>::fmt
Zed::init_panic_hook::{closure#0}
std::panicking::rust_panic_with_hook
std::panicking::rust_panic_with_hook
std::sys_common::backtrace::output_filename
<std::panicking::begin_panic_handler::FormatStringPayload as core::panic::PanicPayload>::take_box
core::panicking::panic_fmt
core::panicking::panic
gpui::platform::mac::display::display_bounds_to_native
<gpui::platform::mac::window::MacWindow as gpui::platform::PlatformWindow>::bounds
<gpui::window::WindowContext>::window_bounds_changed
<gpui::window::Window>::new::{closure#1}
gpui::platform::mac::window::view_did_change_backing_properties
<gpui::platform::mac::platform::MacPlatform as gpui::platform::Platform>::run
Zed::main
<core::marker::PhantomData<core::option::Option<Zed::LocationData>> as serde::de::DeserializeSeed>::deserialize::<&mut serde_json::de::Deserializer<serde_json::read::StrRead>>
workspace::open_new::<Zed::restore_or_create_workspace::{closure#0}::{closure#0}::{closure#0}::{closure#2}::{closure#0}>::{closure#0}::{closure#0}
std::rt::lang_start_internal
serde_json::de::from_trait::<serde_json::read::StrRead, core::option::Option<Zed::Panic>>
```

Two changes:
* Reduce the number of calls to `CGGetActiveDisplayList` in the hopes
that this will also reduce chances of it returning an empty list.
Previously, in the worst case, we called it 6 times. Now the worst case
is that we call it 3 times.
* Instead of calling `CGGetActiveDisplayList` to get the primary display
we do what Chromium does and construct the primary display from
NSScreen.

Release Notes:

- Fixed a bug that caused a panic that could happen when Zed attempted
to render on a sleeping display.

Thorsten Ball created

f938bae Use NSScreen to fetch primary display

Click to expand commit body 
According to Chromium source, `NSScreen::screens` should always get us
one display.

We made this change because we ran into panics caused by the previous
`unwrap()` when `CGGetActiveDisplayList` might return an empty list.

Thorsten Ball created

03bfe3e Call CGGetActiveDisplayList once to avoid panic

Click to expand commit body 
Previously we called CGGetActiveDisplayList twice: once to get the
number of displays and then to get the displays.

We saw a panic due to no displays being returned here. As a first
attempt to fix the panic, we're reducing the amount of calls to
CGGetActiveDisplayList and just do one with the trade-off being that we
pre-allocate 32 pointers in a Vec.

Thorsten Ball created

ed78f70 Fix previous theme not being applied on startup (#4068)

Click to expand commit body 
Fixes `[2024-01-16T09:21:54Z ERROR util]
crates/theme/src/settings.rs:172: theme not found: One Light` error from
the log after
https://github.com/zed-industries/zed/commit/d84785f7e8519b30e474385e5a72f5726cf4783e

Release Notes:

- N/A

Kirill Bulatov created

0749664 Fix previous theme not being applied on startup

Kirill Bulatov created

ec3cfc3 Adds a way to select items under multiple carets (#4067)

Click to expand commit body 
Deals with https://github.com/zed-industries/community/issues/2374

Release Notes:

- Added a way to select items under multiple carets with
`editor::SelectNext` and `editor::SelectPrevious` commands

Kirill Bulatov created

25abe8f Fix the tests

Kirill Bulatov created

fbb363e Add tests

Kirill Bulatov created

dde0056 Use srgb, get mix and blend working

Nate Butler created

bdb06f1 Add a rudimentary state color builder

Nate Butler created

1873947 Clippy

Conrad Irwin created

036e637 Disallow self-management for admins

Conrad Irwin created

6223206 Close modals when focus leaves

Click to expand commit body 
This is more similar to zed1's behaviour, and allows us to work around
the difficulty in defining `on_mouse_down_out` for modals that have
overlays.

Conrad Irwin created

47971ec Add command palette action events (#4065)

Click to expand commit body 
Release Notes:

- N/A

Joseph T. Lyons created

268d156 Add command palette action events

Joseph T. Lyons created

deac172 Restore re-rendering of editors on buffer font size changes (#4064)

Click to expand commit body 
Now that views are cached, we need to explicitly `.notify()` text
editors when the buffer font size changes.

* [x] Notify editors when settings change, or adjusting buffer font size
* [x] Figure out why non-focused editors still do not re-render when
adjusting buffer font size
* [x] Reset buffer font size adjustment when the size is updated in the
user's settings

Max Brunsfeld created

d84785f Put back logic for resetting buffer font adjustment on settings change.

Max Brunsfeld created

1e755aa Notify global observers when removing a global

Max Brunsfeld created

8f1633e Iterate from leaf to root when marking views dirty in notify

Max Brunsfeld created

f220323 Fix fallback font (#4062)

Click to expand commit body 
As this is used if you mis-spell "buffer_font_family", it should be
monospace.

Also treat "Zed Mono" and "Zed Sans" as valid fonts

Follow up to #4045

Release Notes:

- Fixes font validation to allow "Zed Mono" as a valid font

Conrad Irwin created

8f26289 Notify editors on buffer font size changes

Max Brunsfeld created

e57c32e Avoid playing newly published audio tracks when deafened (#4040)

Click to expand commit body 
Release Notes:

- Fixed a bug where the 'deafen' button would only apply to audio from
the call's current participants, but not any participants who joined
after the button was pressed.
- Fixed a bug where after being granted write access to a channel, the
microphone icon appeared non-muted, even though audio was not shared.

Max Brunsfeld created

e90794d Add and enhance tests for muting/deafening, fix exposed logic errors

Max Brunsfeld created

8c9f3a7 init color crate

Nate Butler created

55671ea Select next/previous word for multiple carets if possible

Kirill Bulatov created

acf85db Add more open events (#4061)

Click to expand commit body 
Adds open events for

- Welcome page
- Project search
- Project diagnostics

Release Notes:

- N/A

Joseph T. Lyons created

b565c44 Avoid panicking when closing a dragged tab (#4057)

Click to expand commit body 
Release Notes:

- Fixed a panic that could occur when closing a tab while dragging it.

Antonio Scandurra created

f0ed80c Fix fallback font

Click to expand commit body 
As this is used if you mis-spell "buffer_font_family", it should be
monospace.

Also treat "Zed Mono" and "Zed Sans" as valid fonts

Conrad Irwin created

24db41f Remove debugs

Joseph T. Lyons created

355d1fc Remove button event function

Joseph T. Lyons created

148c294 Removed button event

Joseph T. Lyons created

ba9a9f4 Add more open events

Click to expand commit body 
project search
diagnostics
welcome page

Joseph T. Lyons created

9a70a89 Fix project panel being toggled on workspace startup. (#4059)

Click to expand commit body 
A sequence of events: Launch Zed -> Quit Zed -> Launch Zed would leave
you with a project panel in a a different state on each open (e.g. if it
is open on 1st one, 2nd run will have it closed). We were essentially
not tracking whether the deserialization took place.

Release Notes:

- Fixed project panel being toggled on/off on startup due to incorrect
tracking of serialization state (solves
https://github.com/zed-industries/community/issues/2406)

Piotr Osiewicz created

97047ff Enable Channels for everyone

Conrad Irwin created

e2f08a6 Add LSP logs into the end of the editor, not after its caret (#4060)

Click to expand commit body 
Also prevent tabs from being added in readonly editors

Release Notes:

- Fixed LSP logs being inserted into the editor incorrectly
- Fixed `editor::Tab` action inserting tabs in read-only files

Kirill Bulatov created

92add99 Add LSP logs into the end of the editor, not after its caret

Click to expand commit body 
Also prevent tabs from being added in readonly editors

Kirill Bulatov created

e60117d Avoid panicking when closing a dragged tab

Click to expand commit body 
Co-Authored-By: Max <max@zed.dev>
Co-Authored-By: Nathan <nathan@zed.dev>

Antonio Scandurra , Max , and Nathan created

1b35b93 Avoid retrieving layout bounds inside of right click menu event handler (#4056)

Click to expand commit body 
By the time the event handler is invoked, all information about the
rendered layout tree is gone.

Release Notes:

- N/A

Antonio Scandurra created

e4728b0 Preserve tooltips requested by cached views (#4055)

Click to expand commit body 
Release Notes:

- N/A

Antonio Scandurra created

a56265e Avoid retrieving layout bounds inside of right click menu event handler

Click to expand commit body 
Co-Authored-By: Nathan <nathan@zed.dev>
Co-Authored-By: Max <max@zed.dev>

Antonio Scandurra , Nathan , and Max created

69bbcba Preserve tooltips requested by cached views

Click to expand commit body 
Co-Authored-By: Nathan <nathan@zed.dev>
Co-Authored-By: Max <max@zed.dev>

Antonio Scandurra , Nathan , and Max created