Commit log

0578c1b Style notifications for notification panel (#4163)

Click to expand commit body
This PR styles the notifications for the notification panel.

These are the notification toasts you receive when you have a new
notification (e.g., a mention in chat):

<img width="423" alt="Screenshot 2024-01-19 at 11 39 16 AM"
src="https://github.com/zed-industries/zed/assets/1486634/a1fc7a67-5aad-4cb2-8dc9-35d302984fcb">

Release Notes:

- Improved the look of toasts for incoming notifications.

Marshall Bowers created

595428a Rename `show cursors` to `display cursor names`

Joseph T. Lyons created

01f06f9 Update tenses of doc comment summary lines (#4161)

Click to expand commit body
This PR updates the tenses used by the summary line of doc comments to
match the [Rust API documentation
conventions](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#summary-sentence).

Specifically:

> The summary line should be written in third person singular present
indicative form. Basically, this means write ‘Returns’ instead of
‘Return’.

I'm sure there are plenty occurrences that I missed.

Release Notes:

- N/A

Marshall Bowers created

cb1b791 Allow cursors to be shown via a command (#4153)

Joseph T. Lyons created

14863e9 Fix assistant panel header when viewing conversation history (#4160)

Click to expand commit body
This PR fixes the assistant panel header when in the conversation
history view to hide the irrelevant tools and/or the slots where they
would go.

Release Notes:

- Improved the assistant panel header when viewing conversation history.

Marshall Bowers created

e55e895 Cancel language server requests if request is dropped (#4159)

Click to expand commit body
Before this change, we would send requests to language servers without
canceling them even if we never wait for their response.

Example: when doing document highlights, we'd send a request (modulo
debouncing) whenever a change was made, ignoring previously sent
requests that might still be in-flight.

With this change, we now send a Cancel request (from the LSP spec) to
the language server in case no one listens to the response anymore
(which is what happens when the `Future` returned by `request_internal`)
is dropped.

Release Notes:

- Improved performance when interacting with language servers.

Thorsten Ball created

1a6cd73 Cancel language server requests if request is dropped

Click to expand commit body
Before this change, we would send requests to language servers without
canceling them even if we never wait for their response.

Example: when doing document highlights, we'd send a request (modulo
debouncing) whenever a change was made, ignoring previously sent
requests that might still be in-flight.

With this change, we now send a Cancel request (from the LSP spec) to
the language server in case no one listens to the response anymore
(which is what happens when the `Future` returned by `request_internal`)
is dropped.

Thorsten Ball created

f4e3c4a Remove VS Code config (#4151)

Click to expand commit body
Who uses VS Code anymore?

Release Notes:

- N/A

Marshall Bowers created

bcc13e1 Change struct field name

Joseph T. Lyons created

338dcd7 Center "Open Chat" button in chat panel (#4157)

Click to expand commit body
The layout of the chat panel wasn't correct but this visual glitch was
being masked by caching, because it seems like Taffy was rendering
things slightly differently when laying out the chat panel as a detached
layout node. This wasn't an issue with caching, but rather an
inconsistency with how Taffy lays things out.

Release Notes:

- N/A

Antonio Scandurra created

0b3923a Center "Open Chat" button in chat panel

Click to expand commit body
The layout of the chat panel wasn't correct but this visual glitch
was being masked by caching, because it seems like Taffy was rendering
things slightly differently when laying out the chat panel as a detached
layout node. This wasn't an issue with caching, but rather an inconsistency
with how Taffy lays things out.

Co-Authored-By: Thorsten <thorsten@zed.dev>
Co-Authored-By: Piotr <piotr@zed.dev>

Antonio Scandurra , Thorsten , and Piotr created

90c2da4 Reuse layout for view's element when it wasn't cached (#4156)

Click to expand commit body
Refs https://github.com/zed-industries/zed/pull/4131
Refs https://github.com/zed-industries/community/issues/2415

Previously, when a view cache miss occurred during paint, we would
either use the element produced during layout or create a new, detached
node layout node. In both cases, we would issue a call to `draw`.

The problem with this approach, however, is that `draw` would always
paint the element at the given `bounds.origin`, which was required when
the layout node was detached but harmful when the element was already
embedded in the layout tree and already knew its bounds. In this second
case, in fact, it was as if we were positioning the element "twice",
which caused content to jump.

Release Notes:

- N/A

Antonio Scandurra created

ad177a5 Show channel rename keybinding in the context menu (#4155)

Click to expand commit body
Deals with `Can't rename channels from keyboard` #product note.
We actually already have the action binding to rename the context menu
entries, but had no label entry to show that.

Release Notes:

- Added a channel rename keymap label on the collab panel context menu

Kirill Bulatov created

9446e57 Reuse layout for view's element when it wasn't cached

Antonio Scandurra created

070de14 Show channel rename keybinding in the context menu

Kirill Bulatov created

a4a0a02 Avoid gutter resizes on line number increase/decrease (#4135)

Kirill Bulatov created

0062cc0 Allow cursors to be shown via a command

Joseph T. Lyons created

4ce0c27 Remove more commented-out code (#4150)

Click to expand commit body
This PR removes some more commented-out code from various spots in the
codebase.

Release Notes:

- N/A

Marshall Bowers created

ebce622 Remove commented-out code in `auto_update` (#4149)

Click to expand commit body
This PR removes some commented-out code in the `auto_update` crate that
we no longer need.

Release Notes:

- N/A

Marshall Bowers created

fd726ad collab 0.38.0

Conrad Irwin created

d76bd10 Show cursors for remote participants (#4082)

Click to expand commit body
This PR enables cursors for remote participants.

They are shown for 2 seconds when you focus a buffer, and then on hover.

Release Notes:

- Added usernames next to remote cursors

Conrad Irwin created

87d60be Fix a double borrow error in window.open

Click to expand commit body
It seems that sometimes calling toggleFullScreen will cause the
display_layer callback of a different window to fire.

Conrad Irwin created

03826be Fix docs references in `ui` (#4147)

Click to expand commit body
This PR fixes some more references in the docs in the `ui` crate.

Release Notes:

- N/A

Marshall Bowers created

decf320 Rename `overflow_hidden_{x,y}` to `overflow_{x,y}_hidden` (#4146)

Click to expand commit body
This PR renames the `overflow_hidden_x` and `overflow_hidden_y` methods
to `overflow_x_hidden` and `overflow_y_hidden`, respectively.

This provides consistency with our `overflow_x_scroll` /
`overflow_y_scroll` methods, as well as better matches Tailwind's
naming.

Release Notes:

- N/A

Marshall Bowers created

9993418 Prevent diagnostics from overflowing the status bar (#4145)

Click to expand commit body
This PR makes it so long diagnostic messages no longer overflow the
status bar and push the right tools off-screen.

Here is an example with a long (placeholder) diagnostic message:

<img width="1136" alt="Screenshot 2024-01-18 at 9 47 07 PM"
src="https://github.com/zed-industries/zed/assets/1486634/18568527-c608-4d4a-9118-b84c6d81c13e">

Release Notes:

- Fixed long diagnostic messages overflowing the status bar.

Marshall Bowers created

f8081ed Revert "Improve panic logging" (#4144)

Click to expand commit body
This reverts commit 345b983c8edd18acc346845dcdd1266e144a05a9.

This seems to have caused only the first line of panics to be reported
in production builds.

Release Notes:

- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).

Conrad Irwin created

fbc693d Revert "Improve panic logging"

Click to expand commit body
This reverts commit 345b983c8edd18acc346845dcdd1266e144a05a9.

Conrad Irwin created

e278410 Make `FacePile` a component again (#4143)

Click to expand commit body
This PR turns `FacePile` back into a component.

Our usage of it seemed a little weird, with us calling `render`
manually.

We're now implementing `Styled` on `FacePile` through its inner `Div` so
that we can apply the `p_1` at the call site.

Release Notes:

- N/A

Marshall Bowers created

bac2e59 Fix popin for project panel by pre-resolving keybindings in the project panel (#4141)

Click to expand commit body
Also, factors out the fluent building APIs from IntoElement into their
own traits.

Also makes the project panel context menu initialization fluent:

<img width="1328" alt="Screenshot 2024-01-18 at 3 33 45 PM"
src="https://github.com/zed-industries/zed/assets/2280405/3468b6f2-07f0-48cf-bec1-ac0379333209">

Release Notes:

- Fixed pop in when right clicking on the project panel.

Mikayla Maki created

20b58fe Merge branch 'main' into fix-popin-for-project-panel

Mikayla Maki created

2760323 Fix overflow in hover handler

Conrad Irwin created

3542b99 Tweak the description of the `gpui` crate (#4142)

Click to expand commit body
This PR tweaks the description of the `gpui` crate, since it's now the
only version.

There can only be one!

Release Notes:

- N/A

Marshall Bowers created

f11d676 Remove missing docs warning for now

Max Brunsfeld created

0e8bdda ?????

Mikayla created

058f39c Document DiagnosticSet, SyntaxMap

Max Brunsfeld created

903176d Pull out fluent builder helpers into re-usable trait

Mikayla created

0691ad4 Make clicking `ListHeader` labels toggle the disclosure (#4140)

Click to expand commit body
This PR makes clicking the label inside of a `ListHeader` with a
disclosure also toggle the disclosure.

Release Notes:

- Added support for clicking the "Online", "Offline", and "Requests"
headers in the contact list to toggle their expansion.

Marshall Bowers created

a508451 Fix popin for project panel by pre-resolving keybindings in terms of the project panel

Mikayla created

b65cf6d Merge branch 'main' into language-api-docs

Max Brunsfeld created

e513020 Fine tune

Conrad Irwin created

f3a76c8 Remove VS Code themes (#4139)

Click to expand commit body
This PR removes the VS Code themes from the `assets/` directory, as
we're not currently using them (and it's unlikely we will in their
current state).

Release Notes:

- N/A

Marshall Bowers created

7860372 gpui: Always recompute layout on cache miss. (#4131)

Click to expand commit body
I'm not yet sure whether this is 100% correct, but it seems to alleviate
the following issue:
`When opening a dock, the panel doesn't appear right away. An empty dock
is briefly visible.`
Release Notes:

- Fixed panel layout being incorrect for a brief time after opening
(fixes https://github.com/zed-industries/community/issues/2415)

Max Brunsfeld created

93a567a Add Git `.mailmap` file (#4138)

Click to expand commit body
This PR adds a Git [`.mailmap`](https://git-scm.com/docs/gitmailmap)
file to canonicalize committer names/emails.

Release Notes:

- N/A

Marshall Bowers created

b0db384 Restore the colored background for collaborators that you are following (#4137)

Max Brunsfeld created

827a8da Send crash reports to Slack automatically (#4111)

Click to expand commit body
This uploads apples crash reports to our servers when telemetry is
enabled.

Rather than jumping via the website, it uploads to collab directly. (I'd
like
to update the panic handler to do this too to make it possible to work
on that end-to-end without zed.dev running).

Release Notes:

- Added reporting of crashes when telemetry is enabled

Conrad Irwin created

4b92a15 Restore the colored background for collaborators that you're following

Max Brunsfeld created

2443ee6 Account for titlebar when tiling windows in zed-local

Max Brunsfeld created

547aab2 Style the reset key state for the assistant panel (#4136)

Click to expand commit body
This PR styles the reset key state for the assistant panel.

Community issue: https://github.com/zed-industries/community/issues/2429

<img width="641" alt="Screenshot 2024-01-18 at 4 28 32 PM"
src="https://github.com/zed-industries/zed/assets/1486634/57377804-2867-45d3-906c-353130ec78e6">

Release Notes:

- Fixed the reset key screen for the assistant panel.

Marshall Bowers created

bf8e570 Avoid gutter resizes on line number increase/decrease

Click to expand commit body
Reserves 4 characters for the line number in the gutter to avoid editor bounds jumping when editing small files like commit messages.

Kirill Bulatov created

bfee008 Merge branch 'main' into cursors

Conrad Irwin created