29e74a6
When searching in visual mode switch to normal mode (#4178)
Click to expand commit body
This matches Neovim behaviour by setting the mode to `Normal` when using
search while in visual mode.
Release Notes:
- Fixed Vim mode not switching to normal mode from visual mode when
using search (`/`) while in visual mode.
Thorsten Ball
created
aa776bc
Add some initial testing to telemetry (#4182)
Click to expand commit body
This doesn't cover everything that should be tested in telemetry, but it
is a start. I'll add more over time.
Release Notes:
- N/A
Joseph T. Lyons
created
634f7f7
Merge branch 'main' into add-telemetry-tests
Joseph T. Lyons
created
decd689
Document the action, asset, color, element, canvas, and div modules (#4181)
Click to expand commit body
That took a while.
I also removed an instance of SmallVec leaking into the public GPUI
APIs.
Release Notes:
- N/A
Release Notes:
- Channels: Improved font sizes in chat
- Channels: Added a link preview when hovering over links in chat
- Channels: Fixed rendering of newlines in chat messages
- Added a new setting "use_autoclose" (defaulting to true) that lets you
disable autoclose per language.
([#1420](https://github.com/zed-industries/community/issues/1420))
([#1903](https://github.com/zed-industries/community/issues/1903))
In the process I also:
- Made the AsyncWindowContext slightly more ergonomic.
- Refactored the input handler traits to enable easy, non-view input
handlers
- Locked down the visibility on all mac-specific GPUI code
- Documented all remaining, public types
Release Notes:
- N/A
4fb3e6d
Ensure editors context menus get at least 3 lines of height
Max Brunsfeld
created
24de848
Prevent breadcrumbs from overflowing the toolbar (#4177)
Click to expand commit body
This PR prevents the breadcrumbs from overflowing the toolbar when its
contents are long:
<img width="1270" alt="Screenshot 2024-01-19 at 6 15 58 PM"
src="https://github.com/zed-industries/zed/assets/1486634/ecee7a42-51ef-43d4-99a1-9c3da784dede">
Release Notes:
- Fixed an issue where long breadcrumbs would overflow the toolbar.
Marshall Bowers
created
107b801
Fix hover popovers showing up over zoomed panels (#4176)
Click to expand commit body
Release Notes:
- Fixes a bug where open popovers would stay over top of zoomed panels,
if already open when the panel is zoomed.
- Fixes a bug where the terminal would create a selection when clicking
the status bar or title bar.
Mikayla Maki
created
25f78a2
Fix terminal selection firing when dragging anywhere
Mikayla
created
eaa0e93
Fix hover popovers showing up over zoomed panels
7620feb
Prevent many call participants from overflowing the title bar (#4173)
Click to expand commit body
This PR fixes an issue where having a lot of participants in a call
could cause the avatars/facepiles to overflow the title bar, pushing the
call controls off-screen.
The participant list will now scroll when it would otherwise exceed the
available space:
https://github.com/zed-industries/zed/assets/1486634/806c77e6-bd4c-4864-8567-92e0960734ee
Release Notes:
- Fixed participant list overflowing the title bar.
Marshall Bowers
created
ac350e9
Fix positioning of windows on secondary displays (#4169)
Click to expand commit body
CGDisplayBounds returns data in "global display coordinates" (which are
the same as Zed's coordinates), different from the NS APIs which use
"screen coordinates" (which have the Y axis inverted)
Also remove some transmutes while we're at it
Release Notes:
- Fixed position of notifications on secondary displays
Conrad Irwin
created
137e219
Don't toggle WHOLE_WORD in vim search (#4165)
Click to expand commit body
Fixes */# in visual mode, and avoids setting up irritating state.
[[PR Description]]
Release Notes:
- vim: Improved `*` and `#` to not toggle Zed's search state. Instead we
now use the regex to identify start and end of words (more like vim).
2 seconds feels a little jittery, lets try a bit longer
Release Notes:
- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).
Max Brunsfeld
,
Conrad
,
Nathan
, and
Marshall
created
cb84043
Merge branch 'main' into fix-notification-positioning
Conrad Irwin
created
1ceccdf
Move the details of completion-resolution logic into Project
Click to expand commit body
Co-authored-by: Conrad <conrad@zed.dev>
Max Brunsfeld
and
Conrad
created
00e46fd
Fix positioning of windows on secondary displays
Click to expand commit body
CGDisplayBounds returns data in "global display coordinates" (which are
the same as Zed's coordinates), different from the NS APIs which use
"screen coordinates" (which have the Y axis inverted)
Also remove some transmutes while we're at it
Conrad Irwin
created
df2b0f6
Add more terminal colors to the theme (#4168)
Click to expand commit body
This PR adds more terminal colors that were present in the Zed1 themes
to the Zed2 theme.
Namely, we now have the `dim_` variants for the various ANSI colors and
various `foreground` colors.
Release Notes:
- Improved terminal colors.
Marshall Bowers
created
1cc7f66
Fix documentation labels obscuring other content in completion menu (#4167)
Click to expand commit body
This PF fixes an issue where the documentation labels in the completion
menu could end up completing obscuring the primary content.
#### Before
<img width="691" alt="Screenshot 2024-01-19 at 1 42 19 PM"
src="https://github.com/zed-industries/zed/assets/1486634/187f2978-08be-4f5e-ba93-91ed09cd6e87">
#### After
<img width="704" alt="Screenshot 2024-01-19 at 1 39 45 PM"
src="https://github.com/zed-industries/zed/assets/1486634/e5929c04-bace-4336-b878-4ada5660d235">
Since this involved changes to the `ListItem`, I also made sure to test
the other problematic case that was fixed in #3845 to make sure we
didn't regress there:
<img width="665" alt="Screenshot 2024-01-19 at 1 39 11 PM"
src="https://github.com/zed-industries/zed/assets/1486634/14b72d44-b6a6-4aef-a708-37fb60b8875a">
I also tried to capture these cases in the `ListItem` stories to make it
easier to test all of them at once:
<img width="1141" alt="Screenshot 2024-01-19 at 1 40 03 PM"
src="https://github.com/zed-industries/zed/assets/1486634/333886ff-e394-4cba-89db-98352481c7f6">
Release Notes:
- Fixed an issue where documentation labels could obscure other content
in the editor completion menu
([#2419](https://github.com/zed-industries/community/issues/2419)).
Fix a panic caused by toggleFullScreen on one window untoggling
full-screen on
another.
I managed to reproduce this only once, which makes me sad, but this
change
should fix it regardless.
https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1705631681238979
Release Notes:
- Fixed an occasional panic when opening a new fullscreen window.