Closes #ISSUE
Release Notes:
- N/A
---------
Co-authored-by: Agus Zubiaga <agus@zed.dev>
Co-authored-by: Anthony Eid <hello@anthonyeid.me>
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
Conrad Irwin
,
Agus Zubiaga
,
Anthony Eid
, and
Ben Brandt
created
496bf0e
keymap_ui: Ensure keymap UI opens in local workspace (#34291)
Click to expand commit body
Closes #ISSUE
Use `workspace.with_local_workspace` to ensure the keymap UI is opened
in a local workspace, even in remote. This was tested by removing the
feature flag handling code, as with the feature flag logic the action
does not appear which is likely a bug.
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Ben Kunkle
created
c09f484
collab: Add ability to add tax ID during Stripe Checkout (#34246)
Click to expand commit body
### 1. **Added Tax ID Collection Types**
- Created a new `StripeTaxIdCollection` struct with an `enabled` field
- Added `tax_id_collection` field to `StripeCreateCheckoutSessionParams`
### 2. **Updated the Stripe Client Interface**
- Modified the real Stripe client to handle tax ID collection conversion
- Updated the fake Stripe client for testing purposes
- Added proper imports across all affected files
### 3. **Enabled Tax ID Collection in Checkout Sessions**
- Both `checkout_with_zed_pro` and `checkout_with_zed_pro_trial` methods
now enable tax ID collection
- The implementation correctly sets `tax_id_collection.enabled = true`
for all checkout sessions
### 4. **Key Implementation Details**
- Tax ID collection will be shown to new customers and existing
customers without tax IDs
- Collected tax IDs will be automatically saved to the customer's
`tax_ids` array in Stripe
- Business names will be saved to the customer's `name` property
- The existing `customer_update.name = auto` setting ensures
compatibility with tax ID collection
Release Notes:
- N/A
morgankrey
created
a58a75c
keymap_ui: Hide tooltips when context menu is shown (#34286)
Click to expand commit body
This PR ensures tooltips are dismissed/not shown once the context menu
is opened.
It also ensures the context menu is dismissed once the list is scrolled.
Release Notes:
- N/A
Finn Evers
created
d1a6c5d
keymap_ui: Hover tooltip for context (#34290)
Click to expand commit body
Closes #ISSUE
Ideally the tooltip would only appear if the context was overflowing
it's column, but for now, we just unconditionally show a tooltip so that
long contexts can be seen.
This PR also includes a change to the tooltip element, allowing for
tooltips with non-text contents which is used here for syntax
highlighting
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Co-authored-by: Anthony <anthony@zed.dev>
Ben Kunkle
and
Anthony
created
10028aa
Ensure *.json recognized as JSONC if checkout folder not `zed` (#34289)
Click to expand commit body
Follow-up to: https://github.com/zed-industries/zed/pull/33410
Release Notes:
- N/A
Peter Tripp
created
3b9bb52
keymap_ui: Only show conflicts between user bindings (#34284)
Click to expand commit body
Closes #ISSUE
This makes it so conflicts are only shown between user bindings. User
bindings that override bindings in the Vim, Base, and Default keymaps
are not identified as conflicts
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Co-authored-by: Anthony <anthony@zed.dev>
Ben Kunkle
and
Anthony
created
7eb739d
Add initial support for search by keystroke to keybinding editor (#34274)
Click to expand commit body
This PR adds preliminary support for searching keybindings by keystrokes
in the keybinding editor.
Release Notes:
- N/A
1538401
linux: Use `randr` as fallback for scale factor in X11 (#34265)
Click to expand commit body
Closes #14537
- Adds server-side scale factor detection via `randr` when client-side
detection fails using `xrdb/Xft.dpi`.
- Adds the `GPUI_X11_SCALE_FACTOR` flag to force a scale factor, which
can be a positive number for custom scaling or `randr` for server-side
scale factor detection.
Release Notes:
- Fixed an issue where the scale factor was not detected correctly on
X11 systems when `Xft.dpi` is not defined (mostly in cases involving
window managers).
Smit Barmase
created
8812e7c
windows: Fix an issue where dead keys that require holding `shift` didn’t work properly (#34264)
Click to expand commit body
Closes #34194
Release Notes:
- N/A
张小白
created
56d0ae6
Don't apply contrast adjustment to decorative chars (#34238)
Click to expand commit body
Closes #34234
Release Notes:
- Automatic contrast adjustment in terminal is no longer applied to
decorative characters used in block art.
Richard Feldman
created
d52f07b
lsp tool: Make "Restart All Servers" always visible (#34255)
Click to expand commit body
Next step is to have a "Restart Current Buffer Server(s)". 😬
Release Notes:
- N/A
Danilo Leal
created
089ce8f
agent: Allow clicking on the read file tool header to jump to the exact file location (#33161)
Click to expand commit body
Release Notes:
- Allow clicking on the header of the read file tool to jump to the
exact file location
When researching code or when the Agent analyzes context by reading
various project files, the read file tool is used. It usually includes
line numbers relevant to the current prompt or task. However, it’s often
frustrating that the read file header isn’t clickable to view the
corresponding code directly. This PR makes the header clickable,
allowing users to jump to the referenced file. If start and end lines
are specified, it will navigate directly to that exact location.
https://github.com/user-attachments/assets/b0125d0b-7166-43dd-924e-dc5585813b0b
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Max Frai
and
Danilo Leal
created
842ac98
git: Intercept signing prompt from GPG when committing (#34096)
Click to expand commit body
Closes #30111
- [x] basic implementation
- [x] implementation for remote projects
- [x] surface error output from GPG if signing fails
- [ ] ~~Windows~~
Release Notes:
- git: Passphrase prompts from GPG to unlock commit signing keys are now
shown in Zed.
Cole Miller
created
87362c6
Assign checksum seed in windows releases (#34252)
Click to expand commit body
This will allow windows releases to report panics and telemetry.
Release Notes:
- N/A
7915b9f
keymap_ui: Add ability to delete user created bindings (#34248)
Click to expand commit body
Closes #ISSUE
Adds an action and special handling in `KeymapFile::update_keybinding`
for removals. If the binding being removed is the last in a keymap
section, the keymap section will be removed entirely instead of left
empty.
Still to do is the ability to unbind/remove non-user created bindings
such as those in the default keymap by binding them to `NoAction`,
however, this will be done in a follow up PR.
Release Notes:
- N/A *or* Added/Fixed/Improved ...
41085f8
settings_ui: Inform about keybind conflicts in modal (#34205)
Click to expand commit body
This PR updates the keybinding editor modal so that conflicts are
already shown in the modal itself. Notably, this does not add validation
on every keystroke, the update still has to be confirmed. However, if
only a warning is present, on the second confirm the keybind will
actually be updated.
The change also includes a slight update to the displayment of errors,
since we now differentiate between errors and warnings.
| Error | Warning |
| --- | --- |
| <img width="543" height="332" alt="warning_keybind"
src="https://github.com/user-attachments/assets/867319be-eeb9-40d7-bf32-fbd44aacf0b5"
/> | <img width="543" height="310" alt="error_keybind"
src="https://github.com/user-attachments/assets/858a6c7c-8c9a-4a90-95af-a5103125676f"
/> |
Release Notes:
- N/A
9d2b7c8
agent: Dismiss the agent panel notification if window is closed (#34230)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/32951
Release Notes:
- agent: Fixed an issue where the agent panel notification would linger
on even after you closed the window.
Danilo Leal
created
c6603e4
Stop extensions' servers and message loops before removing their files (#34208)
Click to expand commit body
Fixes an issue that caused Windows to fail when removing extension's
directories, as Zed had never stop any related processes.
Now:
* Zed shuts down and waits until the end when the language servers are
shut down
* Adds `impl Drop for WasmExtension` where does
`self.tx.close_channel();` to stop a receiver loop that holds the "lock"
on the extension's work dir.
The extension was dropped, but the channel was not closed for some
reason.
* Does more unregistration to ensure `Arc<WasmExtension>` with the `tx`
does not leak further
* Tidies up the related errors which had never reported a problematic
path before
Release Notes:
- N/A
---------
Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
Co-authored-by: Smit <smit@zed.dev>
d6bff27
settings_ui: Ensure selected keymap entry is properly updated (#34229)
Click to expand commit body
This change ensures that we more reliably deploy the context menu in the
keymap editor as well as highlight the selected row quicker.
Release Notes:
- N/A
Finn Evers
created
cfc9cfa
language_models: Refresh the list of models when the LLM token is refreshed (#34222)
Click to expand commit body
This PR makes it so we refresh the list of models whenever the LLM token
is refreshed.
This allows us to add or remove models based on the plan in the new
token.
Release Notes:
- Fixed model list not refreshing when subscribing to Zed Pro.
---------
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Marshall Bowers
and
Bennet Bo Fenner
created
e2e529b
Remove redundant `autoscroll_horizontally` during editor prepaint (#34218)
Click to expand commit body
* Experimentally `scroll_manager.anchor()` appears to be the same before
and after this 2nd call of `autoscroll_horizontally`
* Nothing these depend on seem to be mutated between the calls (and
since this is prepaint, stuff within editor also shouldn't be mutated)
Release Notes:
- N/A
Co-authored-by: Finn <finn@zed.dev>
f8f8275
Remove default shell breadcrumbs on windows (#34198)
Click to expand commit body
Release Notes:
- N/A
localcc
created
36c325b
docs: Add GitHub Copilot Enterprise configuration example (#33902)
Click to expand commit body
### Context
This PR adds documentation for setting up GitHub Copilot Enterprise as
an edit prediction provider in Zed.
There was previously no documentation for this feature, which was
implemented in [PR
#32296](https://github.com/zed-industries/zed/pull/32296).
This follows up on [my
comment](https://github.com/zed-industries/zed/issues/22901#issuecomment-3034817471)
and the response from the[ Zed
team](https://github.com/zed-industries/zed/issues/22901#issuecomment-3034837282),
which clarified the required settings.
### What’s included
- Documents the `enterprise_uri` setting for Copilot Enterprise in
`edit-prediction.md`.
- Explains how to configure the setting and what to expect from the
sign-in flow.
### Notes
- This is a documentation-only change.
- No code or tests are affected.
Release Notes:
- N/A
---------
Co-authored-by: Peter Tripp <peter@zed.dev>
Nathan Brodin
and
Peter Tripp
created
f4106ad
collab: Send down new usage limits even when the user does not have any usage (#34217)
Click to expand commit body
This PR fixes an issue where the plan usage limits in Zed would not get
updated immediately after the plan has changed.
Previously we were only sending down the usage—which contains the
limits—if there was a usage record in the database. This would be absent
if the user had just changed their plan.
We now always send down the usage in order to update the limits on the
client side.
Release Notes:
- N/A
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Marshall Bowers
and
Bennet Bo Fenner
created
1583dd2
settings_ui: Ensure context menu is properly populated (#34213)
Click to expand commit body
This change fixes a small issue where the right-click context menu would
not be populdated on the first right click in the keymap editor and the
selection of the corresponding entry would be slightly delayed.
Release Notes:
- N/A
Finn Evers
created
d7fd924
settings_ui: Open keybinding editing modal on mouse double click (#34193)
Click to expand commit body
Whilst working on the keymap editor, I regularly find myself
double-clicking an entry just to find that nothing happens besides
selecting the given entry. This feels really unintuitive to me. I
checked back with VSCode and they also open the modal when
double-clicking an entry in the list.
Thus, this PR enables double-clicking an entry in the list to open the
editing modal.
Release Notes:
- N/A
51c24e2
Reorder items in the quick action bar (#34203)
Click to expand commit body
Namely, putting the diagnostics items in their own little section,
divider from the other "inline" and minimap/edit prediction items. I
feel like this is an easier to parse organization, even though all the
"inlines" made sense to be somewhat close together.
Release Notes:
- N/A
Danilo Leal
created
3169f06
windows: Don't show cmd window when remoting (#34187)
dc591fe
Hide unused extension types from the extension UI (#34166)
Click to expand commit body
This PR hides "slash commands" and "indexed docs providers" from the
extensions UI as these are virtually completely unused types of
extensions.
Release Notes:
- N/A
Danilo Leal
created
95784d5
agent: Fix edit bar's background color when zoomed in (#34163)
Click to expand commit body
When the panel was zoomed in, the edit bar's background color would have
a different color than the rest of the panel. This PR fixes it by using
the `panel_background` color token.
Release Notes:
- N/A
Danilo Leal
created
9b63ba6
gpui: Add `cx.intercept_keystrokes` API to intercept keystrokes before action dispatch (#34084)
Click to expand commit body
Closes #ISSUE
`cx.intercept_keystrokes` functions as a sibling API to
`cx.observe_keystrokes`. Under the hood the two API's are basically
identical, however, `cx.observe_keystrokes` runs _after_ all event
dispatch handling (including action dispatch) while
`cx.intercept_keystrokes` runs _before_. This allows for
`cx.stop_propagation()` calls within the `cx.intercept_keystrokes`
callback to prevent action dispatch.
The motivating example usage behind this API is also included in this
PR. It is used as part of a keystroke input component that needs to
intercept keystrokes before action dispatch to display them.
cc: @mikayla-maki
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Ben Kunkle
created
862e733
agent: Make all icons used for tool calls consistent (#34160)
Click to expand commit body
Starting to use the `Tool...` family of icons dedicated & designed for
the agent panel.
Release Notes:
- N/A