cb40677
Fix typo (#42559)
Click to expand commit body
Fixed a typo in the docs Release Notes: - N/A
Konstantinos Lyrakis created
cb40677
Fix typo (#42559)
Fixed a typo in the docs Release Notes: - N/A
Konstantinos Lyrakis created
1c625f8
Fix JSON Schema documentation for `code_actions_on_format` (#42128)
Closes #ISSUE Release Notes: - N/A *or* Added/Fixed/Improved ...
Ben Kunkle created
4adec27
Implement pretty TypeScript errors (#42494)
Closes #7844
This change uses tree-sitter highlights as a method of showing
typescript errors prettily, keeping regex as simple as possible:
<img width="832" height="446" alt="Screenshot 2025-11-11 at 3 40 24 PM"
src="https://github.com/user-attachments/assets/0b3b6cf1-4d4d-4398-b89b-ef5ec0df87ec"
/>
It covers three main areas:
1. Diagnostics
Diagnostics are now rendered with language-aware typescript, by
providing the project's language registry.
2. Vtsls
The LSP provider for typescript now implements the
`diagnostic_message_to_markdown` function in the `LspAdapter` trait, so
as to provide Diagnostics with \`\`\`typescript...\`\`\`-style code
blocks for any selection of typescript longer than one word. In the
single-word case, it simply wraps with \`\`
3. Typescript's `highlights.scm`
`vtsls` doesn't provide strictly valid typescript in much of its
messaging. Rather, it returns a message with snippets of typescript
values which are invalid. Tree-sitter was not properly highlighting
these snippets because it was expecting key-value formats. For instance:
```
type foo = { foo: string; bar: string; baz: number[] }
```
is valid, whereas simply
```
{ foo: string; bar: string; baz: number[] }
```
is not.
Therefore, highlights.scm needed to be adjusted in order to
pattern-match on literal values that might be returned from the vtsls
diagnostics messages. This was done by a) identifying arrow functions on
their own, and b) augmenting the `statment_block` pattern matching in
order to match on values which were clearly object literals.
This approach may not be exhaustive - I'm happy to work on any
additional cases we might identify from `vtsls` here - but hopefully
demonstrates an extensible approach to making these messages look nice,
without taking on the technical burden of extensive regex.
Release Notes:
- Show pretty TypeScript errors with language-aware Markdown.
KyleBarton created
e8daab1
debugger: Fix prevent creating breakpoints inside breakpoint editor (#42475)
Closes #38057 This PR fixes that you can no longer create breakpoints inside the breakpoint editor in code called `BreakpointPromptEditor`. As you can see, inside the after video, there is no breakpoint editor created anymore. **Before** https://github.com/user-attachments/assets/c4e02684-ac40-4176-bd19-f8f08e831dde **After** https://github.com/user-attachments/assets/f5b1176f-9545-4629-be12-05c64697a3de Release Notes: - Debugger: Prevent breakpoints from being created inside the breakpoint editor
Remco Smits created
6501b0c
zeta eval: Improve determinism and debugging ergonomics (#42478)
- Improves the determinism of the search step for better cache reusability - Adds a `--cache force` mode that refuses to make any requests or searches that aren't cached - The structure of the `zeta-*` directories under `target` has been rethought for convenience Release Notes: - N/A --------- Co-authored-by: Agus <agus@zed.dev>
Ben Kunkle and Agus created
6c0069c
zeta2: Improve error reporting and eval purity (#42470)
Closes #ISSUE
Improves error reporting for various failure modes of zeta2, including
failing to parse the `<old_text>`/`<new_text>` pattern, and the contents
of `<old_text>` failing to match.
Additionally, makes it so that evals are checked out into a worktree
with the _repo_ name instead of the _example_ name, in order to make
sure that the eval name has no influence on the models prediction. The
repo name worktrees are still namespaced by the example name like
`{example_name}/{repo_name}` to ensure evals pointing to the same repo
do not conflict.
Release Notes:
- N/A *or* Added/Fixed/Improved ...
---------
Co-authored-by: Agus <agus@zed.dev>
Ben Kunkle and Agus created
c8930e0
Allow multiple parked threads in tests (#42551)
Closes #ISSUE Release Notes: - N/A Co-Authored-By: Piotr <piotr@zed.dev>
Conrad Irwin and Piotr created
ab352f6
Gracefully handle `@mention`-ing large files with no outlines (#42543)
Closes #32098 Release Notes: - In the Agent panel, when `@mention`-ing large files with no outline, their first 1KB is now added to context
Richard Feldman created
e791882
fs: Fix wrong watcher trace log on Linux (#42544)
Follow-up to #40200 Release Notes: - N/A
Finn Evers created
ab62739
collab: Remove unused methods from `User` model (#42536)
This PR removes some unused methods from the `User` model. Release Notes: - N/A
Marshall Bowers created
cfbde91
terminal: Add setting for scroll multiplier (#39463)
Closes #5130 Release Notes: - Added setting option for scroll multiplier of the terminal --------- Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com> Co-authored-by: MrSubidubi <finn@zed.dev>
Marco Mihai Condrache and MrSubidubi created
80b32dd
gpui: Add 'Nearest' scrolling strategy to 'UniformList' (#41844)
This PR introduces `Nearest` scrolling strategy to `UniformList`. This is now used in completions menu and the picker to choose the appropriate scrolling strategy depending on movement direction. Previously, selecting the next element after the last visible item caused the menu to scroll with `ScrollStrategy::Top`, which scrolled the whole page and placed the next element at the top. This behavior is inconsistent, because using `ScrollStrategy::Top` when moving up only scrolls one element, not the whole page. https://github.com/user-attachments/assets/ccfb238f-8f76-4a18-a18d-bbcb63340c5a The solution is to introduce the `Nearest` scrolling strategy which will internally choose the scrolling strategy depending on whether the new selected item is below or above currently visible items. This ensures a single-item scroll regardless of movement direction. https://github.com/user-attachments/assets/8502efb8-e2c0-4ab1-bd8d-93103841a9c4 I also noticed that some functions in the file have different logic depending on `y_flipped`. This appears related to reversing the order of elements in the list when the completion menu appears above the cursor. This was a feature suggested in #11200 and implemented in #23446. It looks like this feature was reverted in #27765 and there currently seem to be no way to have `y_flipped` to be set to `true`. My understanding is that the opposite scroll strategy should be used if `y_flipped`, but since there is no way to enable this feature to test it and I don't know if the feature is ever going to be reintroduced I decided not to include it in this PR. Release Notes: - gpui: Add 'Nearest' scrolling strategy to 'UniformList'
Vasyl Protsiv created
53652cd
Bump Zed to v0.214 (#42539)
Release Notes: - N/A
Joseph T. Lyons created
1d75a9c
Reverts "add OpenExcerptsSplit and dispatches on click" (#42538)
Partially reverts https://github.com/zed-industries/zed/pull/42283 to restore the old behavior of excerpt clicking. Release Notes: - N/A
Smit Barmase created
c5ab1d4
Stop thread on Restore Checkpoint (#42537)
Closes #35142 In addition to cleaning up the terminals, also stops the conversation. Release Notes: - Restoring a checkpoint now stops the agent conversation.
Richard Feldman created
1fdd95a
Revert "editor: Improve multi-buffer header filename click to jump to the latest selection from that buffer" (#42534)
Reverts zed-industries/zed#42480 This panics on Nightly in cases where anchor might not be valid for that snapshot. Taking it back before the cutoff. Release Notes: - N/A
Smit Barmase created
49634f6
Miniprofiler (#42385)
Release Notes: - Added hang detection and a built in performance profiler
localcc created
2119ac4
git_panel: Fix partially staged changes not showing up (#42530)
Release Notes: - N/A
Jakub Konka created
e833d1a
vim: Fix change surround adding unwanted spaces with quotes (#42431)
Update `Vim.change_surround` in order to ensure that there's no overlapping edits by keeping track of where the open string range ends and ensuring that the closing string range start does not go lower than the open string range end. Closes #42316 Release Notes: - Fix vim's change surrounds `cs` inserting spaces with quotes by preventing overlapping edits --------- Co-authored-by: dino <dinojoaocosta@gmail.com>
Hans and dino created
7be76c7
Use `set -x` in `script/clear-target-dir-if-larger-than` (#42525)
Closes #ISSUE Release Notes: - N/A *or* Added/Fixed/Improved ...
Ben Kunkle created
c2980cb
remote_server: Bump fork to 0.4.0 (#42520)
Release Notes: - N/A
Piotr Osiewicz created
a0be53a
Wake up stalebot with an updated config (#42516)
- switch the bot from looking at the `bug/crash` labels which we don't use anymore to the Bug/Crash issue types which we do use - shorten the period of time after which a bug is suspected to be stale (with our pace they can indeed be outdated in 60 days) - extend the grace period for someone to come around and say nope, this problem still exists (people might be away for a couple of weeks). Release Notes: - N/A
Lena created
70feff3
Add a one-off cleanup script for GH issue types (#42515)
Mainly for historical purposes and in case we want to do something similar enough in the future. Release Notes: - N/A
Lena created
f46990b
extensions_ui: Add XML extension suggestion for XML files (#42514)
Closes #41798 Release Notes: - N/A
Finn Evers created
78f4665
vim: Fix empty selections panic in `insert_at_previous` (#42504)
Fixes ZED-15C Release Notes: - N/A *or* Added/Fixed/Improved ...
Lukas Wirth created
4f158c1
docs: Update basedpyright settings examples (#42497)
The [example](https://docs.basedpyright.com/latest/configuration/language-server-settings/#zed) on the official website of basedpyright is correct. Release Notes: - Update basedpyright settings examples
CnsMaple created
ddf762e
Revert "gpui: Unify the index_for_x methods (#42162)" (#42505)
This reverts commit 082b80ec89748bf238f0068da80e12211fb3c7d6.
This broke clicking, e.g. in snippets like
```rs
let x = vec![
1, 2, //
3,
];
```
clicking between `2` and `,` is quite off now.
Release Notes:
- N/A
Kirill Bulatov created
f2cadad
gpui: Fix `RefCell already borrowed` in `WindowsPlatform::run` (#42506)
Relands #42440 Fixes ZED-1VX Release Notes: - N/A *or* Added/Fixed/Improved ...
Lukas Wirth created
231d1b1
diagnostics: Close diagnosticsless buffers on refresh (#42503)
Release Notes: - N/A *or* Added/Fixed/Improved ...
Lukas Wirth created
2bcfc12
Absolutize LSP and DAP paths more conservatively (#42482)
Fixes a regression caused by #42135 where LSP and DAP binaries weren't being used from `PATH` env var Now we absolutize the path if (path is relative AND (path has multiple components OR path exists in worktree)). - Relative paths with multiple components might not exist in the worktree because they are ignored. Paths with a single component will at least have an entry saying that they exist and are ignored. - Relative paths with multiple components will never use the `PATH` env var, so they can be safely absolutized Release Notes: - N/A
Andrew Farkas created
cf6ae01
Show recommended models under normal category too (#42489)
<img width="395" height="444" alt="Screenshot 2025-11-11 at 4 04 57 PM" src="https://github.com/user-attachments/assets/8da68721-6e33-4d01-810d-4aa1e2f3402d" /> Discussed with @danilo-leal and we're going with the "it's checked in both places" design! Closes #40910 Release Notes: - Recommended AI models now still appear in their normal category in addition to "Recommended:"
Richard Feldman created
2ad7ecb
project_panel: Add `auto_open` settings (#40435)
- Based on #40234, and improvement of #40331 Release Notes: - Added granular settings to control when files auto-open in the project panel (project_panel.auto_open.on_create, on_paste, on_drop) <img width="662" height="367" alt="Screenshot_2025-10-16_17-28-31" src="https://github.com/user-attachments/assets/930a0a50-fc89-4c5d-8d05-b1fa2279de8b" /> --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
Miguel Cárdenas and Smit Barmase created
854c687
Revert "gpui: Fix `RefCell already borrowed` in `WindowsPlatform::run`" (#42481)
Reverts zed-industries/zed#42440 There are invalid temporaries in here keeping the borrows alive for longer
Lukas Wirth created
da94f89
Add support for multi-word snippet prefixes (#42398)
Supercedes #41126 Closes #39559, #35397, and #41426 Release Notes: - Added support for multi-word snippet prefixes --------- Co-authored-by: Agus Zubiaga <hi@aguz.me> Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com> Co-authored-by: Cole Miller <cole@zed.dev>
Andrew Farkas , Agus Zubiaga , Conrad Irwin , and Cole Miller created
f62bfe1
Use `enterprise_uri` for settings when provided (#42485)
Closes #34945 Release Notes: - Fixed `enterprise_uri` not being used for GitHub settings URL when provided
Richard Feldman created
a56693d
Fix panic when opening an invalid URL (#42483)
Now instead of a panic we see this: <img width="511" height="132" alt="Screenshot 2025-11-11 at 3 47 25 PM" src="https://github.com/user-attachments/assets/48ba2f41-c5c0-4030-9331-0d3acfbf9461" /> Release Notes: - Trying to open invalid URLs in a browser now shows an error instead of panicking
Richard Feldman created
b4b7a23
editor: Improve multi-buffer header filename click to jump to the latest selection from that buffer (#42480)
Closes https://github.com/zed-industries/zed/pull/42099 Regressed in https://github.com/zed-industries/zed/pull/42283 Release Notes: - Clicking the multi-buffer header file name or the "Open file" button now jumps to the most recent selection in that buffer, if one exists.
Smit Barmase created
0d56ed7
Only send unit eval failures to Slack for cron job (#42479)
Release Notes: - N/A
Richard Feldman created
e01e0b8
Avoid panics in LSP store path handling (#42117)
Release Notes: - Fixed incorrect journal paths handling
Lay Sheth created
908ef03
Split out cron and non-cron unit evals (#42472)
Release Notes: - N/A --------- Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Richard Feldman and Bennet Bo Fenner created
5f4d0db
Fix circular reference issue around PopoverMenu (#42461)
Follow up to https://github.com/zed-industries/zed/pull/42351 Release Notes: - N/A
feeiyu created
c50f821
docs: Fix typo in `configuring-zed.md` (#42454)
Fix a minor typo in the setting key: `auto_install_extension` should be `auto_install_extensions`. Release Notes: - N/A
brequet created
7e491ac
collab: Drop `embeddings` table (#42466)
This PR drops the `embeddings` table, as it is no longer used. Release Notes: - N/A
Marshall Bowers created
9e1e732
Use longer timeout on evals (#42465)
The GPT-5 ones in particular can take a long time! Release Notes: - N/A --------- Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Richard Feldman and Bennet Bo Fenner created
8335128
settings: Skip terminal env vars with substitutions in vscode import (#42464)
Closes https://github.com/zed-industries/zed/issues/40547 Release Notes: - Fixed vscode import creating faulty terminal env vars in terminal settings
Lukas Wirth created
03acbb7
collab: Remove unused embeddings queries and model (#42463)
This PR removes the queries and database model for embeddings, as they're no longer used. Release Notes: - N/A
Marshall Bowers created
0268b17
Add more secrets to eval workflows (#42459)
Release Notes: - N/A
Richard Feldman created
993919d
agent_ui: Add icon button to trigger the @-mention completions menu (#42449)
Closes https://github.com/zed-industries/zed/issues/37087 This PR adds an icon button to the footer of the message editor enabling to trigger and interact with the @-mention completions menu with the mouse. This is a first step towards making other types of context you can add in Zed's agent panel more discoverable. Next, I want to improve the discoverability of images and selections, given that you wouldn't necessarily know they work in Zed without a clear way to see them. But I think that for now, this is enough to close the issue above, which had lots of productive comments and discussion! <img width="500" height="540" alt="Screenshot 2025-11-11 at 10 46 3@2x" src="https://github.com/user-attachments/assets/fd028442-6f77-4153-bea1-c0b815da4ac6" /> Release Notes: - agent: Added an icon button in the agent panel that allows to trigger the @-mention menu (for adding context) now also with the mouse.
Danilo Leal created
8467a3d
agent_ui: Allow to uninstall agent servers from the settings view (#42445)
This PR also adds items within the "Add Agent" menu to: 1. Add more agent servers from extensions, opening up the extensions page with "Agent Servers" already filtered 2. Go to the agent server + ACP docs to learn more about them I feel like having them there is a nice way to promote this knowledge from within the product and have users learn more about them. <img width="500" height="540" alt="Screenshot 2025-11-11 at 10 46 3@2x" src="https://github.com/user-attachments/assets/9449df2e-1568-44d8-83ca-87cbb9eefdd2" /> Release Notes: - agent: Enabled uninstalled agent servers from the agent panel's settings view.
Danilo Leal created
ee2e690
agent_servers: Fix panic when setting default mode (#42452)
Closes ZED-35A Release Notes: - Fixed an issue where Zed would panic when trying to set the default mode for ACP agents
Bennet Bo Fenner created