Commits in gpui-components-and-views

Commit log

`b0facda` Fix tests: render log frame grouping tests + blink test update

Click to expand commit body

- All 6 render_log tests pass as plain #[test] (pure data logic)
- Fixed example_tests to use ExampleInputState (matching new API)
- Fixed blink test for focus-driven blink (test via typing, not init)
- Fixed test command in doc comment
- All 12 tests pass with: cargo test --example view_example -p gpui --features test-support

Mikayla Maki created 4 weeks ago

`0d93ff0` Render log: frame grouping with counters, collapse identical consecutive frames

Click to expand commit body

Rewrote RenderLog to group render() calls by frame:
- begin_frame() called at start of root render, finalizes previous frame
- log() records component name in current frame
- Consecutive frames with identical component sets collapse into one
  entry with a ×N counter (e.g. animation re-rendering Input+Editor
  30 times shows as one line with ×30)
- Display shows component names, repeat count, and timestamp

Added 6 unit tests for the frame grouping logic:
- Groups by frame, consecutive collapse, different frames don't collapse,
  collapse resumes after interruption, empty frames ignored, dedup
  within frame

Note: tests are plain #[test] (not gpui::test) since RenderLog logic
is pure data manipulation. The pre-existing example_tests.rs compilation
issue (TestAppContext not available in examples) prevents running them
via cargo test currently.

Mikayla Maki created 4 weeks ago

`c103131` Add focus-driven blink and render log

Click to expand commit body

Blink fix:
- ExampleEditor no longer starts a blink task unconditionally
- Registers on_focus/on_blur listeners in constructor (now takes Window)
- start_blink() spawns the timer, stop_blink() drops it
- Unfocused editors produce zero re-renders

Render log:
- New RenderLog entity + RenderLogPanel ComponentView
- Each component logs its render() call: ExampleInput, EditorInfo,
  ExampleTextArea, and ExampleEditor
- Panel displays last 20 entries with timestamps, dark terminal style
- No cx.notify() in log() — avoids infinite invalidation loop;
  panel updates passively when parent re-renders
- Replaces the static help text at the bottom of the example

Mikayla Maki created 4 weeks ago

`4af9073` Add EditorInfo: zero-wiring View over shared editor entity

Click to expand commit body

EditorInfo is a View that reads from the same ExampleEditor entity as
ExampleInput, demonstrating two completely different renderings of one
entity with automatic caching and no manual wiring:

- Returns the editor from entity() — that's the entire reactive hookup
- Reads editor.content, cursor, focus_handle in render()
- Caches automatically: typing updates it, but pressing Enter (flash
  border on input) leaves it cached since the editor didn't change
- 46 lines total, no observers, no subscriptions, no cx.notify()

The parent shares the editor handle by reading it from ExampleInputState:
  let input_editor = input_state.read(cx).editor.clone();
  EditorInfo::new(input_editor)

Mikayla Maki created 4 weeks ago

`f079aee` Refine View example: ExampleInput as View with own state, ExampleTextArea as ComponentView

Click to expand commit body

ExampleInput is now a proper View backed by ExampleInputState, which:
- Creates and owns its editor entity internally (cx.new in state constructor)
- Tracks focus via on_focus/on_blur listeners on its own state entity
- Never reads the editor entity during render — only reads its own state
- Gets an independent caching boundary from both parent and child editor

ExampleTextArea is now a ComponentView (stateless wrapper) where the inner
EntityView does the caching. This demonstrates the cheaper pattern for
components that don't need their own reactive boundary.

The parent (ViewExample) allocates ExampleInputState via use_state, which
internally chains to cx.new() for the editor. ExampleInput::new() is a
pure constructor taking just the state handle.

Design analysis documented in plan.md:
- use_state observer is necessary (non-view entities aren't in dispatch tree)
- View vs ComponentView vs EntityView taxonomy with clear use cases
- Entity reactivity taxonomy (view, component-local, shared-universal, shared-selective)
- V2 use_global API concept for theme/settings auto-reactivity

Mikayla Maki created 4 weeks ago