357e38b
workspace: Add right border to pinned tabs only on scroll (#29405)
Click to expand commit body
Before (scrolled state, bug):
<img width="392" alt="before - with scroll"
src="https://github.com/user-attachments/assets/5f62f050-41e0-4740-8f90-9822348eaa4b"
/>
After (scrolled state, bug fixed):
<img width="344" alt="after - with scroll"
src="https://github.com/user-attachments/assets/33003358-0009-4748-8a6e-642158114b82"
/>
Before (without scrolled state, as it is):
<img width="541" alt="before - without scroll"
src="https://github.com/user-attachments/assets/42487d61-7f7c-49a7-a087-da7faf5a0a89"
/>
After (without scrolled state, as it is):
<img width="462" alt="after - without scroll"
src="https://github.com/user-attachments/assets/738a4d24-3a89-466b-8976-2bf47cfeb0f5"
/>
cc @danilo-leal
Release Notes:
- N/A
Smit Barmase
created
ae37f3c
agent: Improve MCP tools compatibility with Gemini models (#29411)
49003d8
When hovering paths in terminal, search worktree entries for relative ones only (#29406)
Click to expand commit body
Follow-up of https://github.com/zed-industries/zed/pull/29274
Release Notes:
- N/A
Kirill Bulatov
created
9386283
assistant: Fix issue when using inline assistant with Gemini models (#29407)
Click to expand commit body
Closes #29020
Release Notes:
- assistant: Fix issue when using inline assistant with Gemini models
Bennet Bo Fenner
created
c39adc5
Select collab channel filter query upon focusing (#29383)
Click to expand commit body
In the process of implementing this I learned that you can also hit
escape to clear the query which is a decent workaround, but I think this
behavior more closely matches expectations. For example when you run the
"focus search" actions, those select the query.
Release Notes:
- N/A
Julia Ryan
created
ebb39d9
Add "upstream" as a hardcoded remote name (#29382)
Click to expand commit body
The ideal solution here would be the ability to pick a default remote
the first time you click on a PR or commit link from a blame, and then
store that state in the repo or project and allow you to change it
somehow.
Because that's complicated, and because the vast majority of users
follow the convention of using `upstream` and `origin`, this change just
adds `upstream` as a possible remote that takes precedence for
generating links. I've sometimes seen `origin` and `fork` used for the
same purposes, which will still work fine with this change.
Here are some sources recommending the `upstream`/`origin` convention:
-
https://www.atlassian.com/git/tutorials/comparing-workflows/forking-workflow
-
https://github.blog/open-source/git/git-2-5-including-multiple-worktrees-and-triangular-workflows/
- https://cli.github.com/manual/gh_repo_fork
The fact that the github cli renames them to those when you `gh repo
fork` is pretty strong evidence that it's worth supporting them even if
users can set arbitrary remote names or could actually want to open a PR
link on their fork.
Resolves #13511
Release Notes:
- Git blame links now prefer the `upstream` remote over `origin` if it
exists.
Julia Ryan
created
187f851
feature_flags: Add `FeatureFlag` suffix to feature flag types (#29392)
Click to expand commit body
This PR adds the `FeatureFlag` suffix to the feature flag types that
were missing them.
This makes the names easier to search in the codebase.
Release Notes:
- N/A
Marshall Bowers
created
a77db45
feature_flags: Remove `remoting` feature flag (#29390)
Click to expand commit body
This PR removes the `remoting` feature flag.
The feature is shipped, and we aren't referencing the flag anywhere
anymore.
Release Notes:
- N/A
Marshall Bowers
created
6bb6be8
language_models: Use `POST /completions` endpoint for Zed provider (#29389)
Click to expand commit body
This PR updates the Zed provider to use the `POST /completions`
endpoint.
There is no functional difference from `POST /completion`, but the
pluralized version reads better.
Release Notes:
- N/A
Marshall Bowers
created
7d9a55d
Bring back reload of agent context before sending message (#29385)
Click to expand commit body
Realized after merging #29233 that this behavior is desired
Release Notes:
- N/A
Michael Sloan
created
57d8397
Remove unnecessary fields from the tool schemas (#29381)
Click to expand commit body
This PR removes two fields from JSON schemas (`$schema` and `title`),
which are not expected by any model provider, but were spuriously
included by our JSON schema library, `schemars`.
These added noise to requests and cost wasted input tokens.
### Old
```json
{
"$schema": "http://json-schema.org/draft-07/schema#",
"title": "FetchToolInput",
"type": "object",
"required": [
"url"
],
"properties": {
"url": {
"description": "The URL to fetch.",
"type": "string"
}
}
}
```
### New:
```json
{
"properties": {
"url": {
"description": "The URL to fetch.",
"type": "string"
}
},
"required": [
"url"
],
"type": "object"
}
```
- N/A
Simplifies the data structures involved in agent context by removing
caching and limiting the use of ContextId:
* `AssistantContext` enum is now like an ID / handle to context that
does not need to be updated. `ContextId` still exists but is only used
for generating unique `ElementId`.
* `ContextStore` has a `IndexMap<ContextSetEntry>`. Only need to keep a
`HashSet<ThreadId>` consistent with it. `ContextSetEntry` is a newtype
wrapper around `AssistantContext` which implements eq / hash on a subset
of fields.
* Thread `Message` directly stores its context.
Fixes the following bugs:
* If a context entry is removed from the strip and added again, it was
reincluded in the next message.
* Clicking file context in the thread that has been removed from the
context strip didn't jump to the file.
* Refresh of directory context didn't reflect added / removed files.
* Deleted directories would remain in the message editor context strip.
* Token counting requests didn't include image context.
* File, directory, and symbol context deduplication relied on
`ProjectPath` for identity, and so didn't handle renames.
* Symbol context line numbers didn't update when shifted
Known bugs (not fixed):
* Deleting a directory causes it to disappear from messages in threads.
Fixing this in a nice way is tricky. One easy fix is to store the
original path and show that on deletion. It's weird that deletion would
cause the name to "revert", though. Another possibility would be to
snapshot context metadata on add (ala `AddedContext`), and keep that
around despite deletion.
Release Notes:
- N/A
Michael Sloan
created
d492939
Back off the eval to once a day for now (#29378)
Click to expand commit body
cc @maxbrunsfeld
Release Notes:
- N/A
Nathan Sobo
created
720dfee
Treat invalid JSON in tool calls as failed tool calls (#29375)
Click to expand commit body
Release Notes:
- N/A
---------
Co-authored-by: Max <max@zed.dev>
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
This fixes a bug where Zed wasn't closable via ctl-c in the shell it was
spawned in after starting a debug adapter
Release Notes:
- N/A
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
d3911e3
editor: Move blame popover from `hover_tooltip` to editor prepaint (#29320)
Click to expand commit body
WIP!
In light of having more control over blame popover from editor.
This fixes: https://github.com/zed-industries/zed/issues/28645,
https://github.com/zed-industries/zed/issues/26304
- [x] Initial rendering
- [x] Handle smart positioning (edge detection, etc)
- [x] Delayed hovering, release, etc
- [x] Test blame message selection
- [x] Fix tagged issues
Release Notes:
- Git inline blame popover now dismisses when the cursor is moved, the
editor is scrolled, or the command palette is opened.
Smit Barmase
created
87f85f1
Rename "Prompt Library" to "Rules Library" (#29349)
Click to expand commit body
There's probably more to do to fully make the transition, and we'll
still debate a bit internally whether this is the name, but just opening
this PR up now for visibility.
Release Notes:
- N/A
Danilo Leal
created
1a4dab9
docs: Remove redundant word in "Configuring Zed" (#29364)
Click to expand commit body
Release Notes:
- N/A
Dan Dascalescu
created
cd365b0
gemini: Fix issue when deserializing tool call (#29363)
Click to expand commit body
Fixes a regression introduced in #29322
Release Notes:
- N/A
Co-authored-by: Agus Zubiaga <hi@aguz.me>
Bennet Bo Fenner
and
Agus Zubiaga
created
58604fb
agent: Do not reuse assistant message across generations (#29360)
Click to expand commit body
#29354 introduced a bug where we would append tool uses to the last
assistant message even if it was from a previous request.
Release Notes:
- N/A
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Agus Zubiaga
and
Bennet Bo Fenner
created
b060927
ollama: Add DeepSeek v3 max token length (#29156)
Click to expand commit body
Add deepseek-v3 max token length for ollama
Release Notes:
- N/A
shenjack
created
a17807d
docs: Rust-analyzer example settings for alternate targets (#29353)
Click to expand commit body
Release Notes:
- N/A
Peter Tripp
created
f81e65a
agent: Do not create user messages for tool results in thread (#29354)
Click to expand commit body
We used to insert empty user messages into the `Thread::messages` `Vec`
when tools finished running and then we would attach the results when
creating the request. This approach was very easy to mess up during
state handling, leading to empty user messages displayed in the
conversation and API failures.
Instead, we will no longer insert actual user messages for tool results
to the `Thread`, and will only do this on the fly when creating the
model request. This simplifies a lot of code and show fix the mentioned
errors.
Release Notes:
- agent: Improve reliability of LLM requests when including tool results
---------
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Co-authored-by: Oleksiy Syvokon <oleksiy.syvokon@gmail.com>
Agus Zubiaga
,
Bennet Bo Fenner
, and
Oleksiy Syvokon
created
952fe34
anthropic: Remove list of supported countries (#29346)
Click to expand commit body
This PR removes the list of supported countries from the `anthropic`
crate, as it is no longer referenced in this repo.
Release Notes:
- N/A
Marshall Bowers
created
f527df6
google_ai: Remove list of supported countries (#29348)
Click to expand commit body
This PR removes the list of supported countries from the `google_ai`
crate, as it is no longer referenced in this repo.
Release Notes:
- N/A
Marshall Bowers
created
b54bbeb
open_ai: Remove list of supported countries (#29347)
Click to expand commit body
This PR removes the list of supported countries from the `open_ai`
crate, as it is no longer referenced in this repo.
Release Notes:
- N/A
Marshall Bowers
created
8bb7a1f
Remove `linked_edits` issue description from Elm doc (#29350)
Click to expand commit body
The known issue with `linked_edits` seems to be fixed in this PR:
https://github.com/elm-tooling/elm-language-server/pull/1364. This PR
removes the section from Zeds documentation to avoid confusion.
Release Notes:
- Remove known issues section from Elm documentation.
Vojtěch Hořánek
created
e70d8d4
agent: Simplify user message design more (#29326)
Click to expand commit body
Follow-up to https://github.com/zed-industries/zed/pull/29165 where the
user message design is simplified even more. The edit button is not
visible anymore, and you can click on the whole message block to edit a
message.
Release Notes:
- N/A
This PR removes the `RateLimiter` from the collab codebase, as it is no
longer used.
Release Notes:
- N/A
Marshall Bowers
created
fd8eeb5
Fix ctrl-enter opening inline-assistant in assistant text threads (#29313)
Click to expand commit body
Closes: https://github.com/zed-industries/zed/issues/24501
This has been broken for a while on linux (at least since Feb 8th!) for Assistant1.
It is also broken for Text Threads in Assitant2 (on macos and linux).
This should fix both.
Potentially related:
- https://github.com/zed-industries/zed/pull/29107
Release Notes:
- Fix for `ctrl-enter` shortcut in Assistant text threads incorrectly
opening inline assist instead of triggering Send.
Co-authored-by: Conrad Irwin <conrad@zed.dev>
Peter Tripp
and
Conrad Irwin
created
92f21ee
collab: Return current plan based on subscription status (#29341)
Click to expand commit body
This PR makes collab return the current plan based on subscription
status instead of based on the staff bit.
Release Notes:
- N/A
Marshall Bowers
created
fcfeea4
Allow creating entries when nothing is selected in the project panel (#29336)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/29249
Release Notes:
- Allowed creating entries when nothing is selected in the project panel
Kirill Bulatov
created
c0f8e0f
Fix context_stack race in KeyContextView (#29324)
Click to expand commit body
cc @notpeter
Before this change we used our own copy of `cx.key_context()` when
matching.
This led to races where the context queried could be either before (or
after) the
context used in dispatching.
To avoid the race, gpui now passes out the context stack actually used
instead.
Release Notes:
- Fixed a bug where the Key Context View could show the incorrect
context,
causing confusing results.
Closes #28135
Closes #4388
Closes #28136
Release Notes:
- diagnostics: Show the diagnostic code if available
---------
Co-authored-by: Neo Nie <nihgwu@live.com>
Co-authored-by: Zed AI <ai+claude-3.7@zed.dev>
This is to enable alternative streaming solutions at the application
layer. I'm not sure we really should have performed parsing of the input
at this layer. Either way I want to experiment with streaming approaches
in a separate crate on a branch, and this will help.
/cc @maxdeviant @bennetbo @rtfeldman
Closes #ISSUE
Release Notes:
- N/A
Nathan Sobo
created
f125353
Add tree-sitter example to the eval (#29321)
Click to expand commit body
Interesting things about this example:
* It's a useful, non-trivial change I made with the agent in Tree-sitter
* It runs fast
* It frequently showcases edit file errors
* It occasionally completely errors out due to errors parsing tool call
input JSON
Release Notes:
- N/A
Max Brunsfeld
created
fef2681
language_models: Count Google AI tokens through LLM service (#29319)
Click to expand commit body
This PR wires the counting of Google AI tokens back up.
It now goes through the LLM service instead of collab's RPC.
Still only available for Zed staff.
Release Notes:
- N/A
This PR significantly improves the quality of the initial file search
that occurs when the model doesn't yet know the full path to a file it
needs to read/edit.
Previously, the assertions in file_search often failed on main as the
model attempted to guess full file paths. On this branch, it reliably
calls `find_path` (previously `path_search`) before reading files.
After getting the model to find paths first, I noticed it would try
using `grep` instead of `path_search`. This motivated renaming
`path_search` to `find_path` (continuing the analogy to unix commands)
and adding system prompt instructions about proper tool selection.
Note: I know the command is just called `find`, but that seemed too
general.
In my eval runs, the `file_search` example improved from 40% ± 10% to
98% ± 2%. The only assertion I'm seeing occasionally fail is "glob
starts with `**` or project". We can probably add some instructions in
that regard.
Release Notes:
- N/A
Agus Zubiaga
created
2124b7e
agent: Encourage model to include displayed fields first (#29308)
Click to expand commit body
Instructs the model to include the fields that we display first in the
input object, so that e.g the user can see the path of a file while the
model generates the content.
Release Notes:
- N/A
This PR removes the `CountLanguageModelTokens` RPC message from collab.
We were only using this for Google AI models through the Zed provider
(which is only available to Zed staff).
For now we're returning `0`, but will bring back soon.
Release Notes:
- N/A
Marshall Bowers
created
ba3d826
ui: Add `inline_code` method to label (#29306)
Click to expand commit body
This makes it easy to have a label that looks like Markdown inline code
via the `inline_code(cx)` method.
Release Notes:
- N/A
Danilo Leal
created
ecc600a
collab: Remove code for embeddings (#29310)
Click to expand commit body
This PR removes the embeddings-related code from collab and the
protocol, as we weren't using it anywhere.
Release Notes:
- N/A
Marshall Bowers
created
2184967
debugger: Add support for inline value hints (#28656)
Click to expand commit body
This PR uses Tree Sitter to show inline values while a user is in a
debug session.
We went with Tree Sitter over the LSP Inline Values request because the
LSP request isn't widely supported. Tree Sitter is easy for
languages/extensions to add support to. Tree Sitter can compute the
inline values locally, so there's no need to add extra RPC messages for
Collab. Tree Sitter also gives Zed more control over how we want to show
variables.
There's still more work to be done after this PR, namely differentiating
between global/local scoped variables, but it's a great starting point
to start iteratively improving it.
Release Notes:
- N/A
---------
Co-authored-by: Piotr Osiewicz <peterosiewicz@gmail.com>
Co-authored-by: Anthony Eid <hello@anthonyeid.me>
Co-authored-by: Cole Miller <m@cole-miller.net>
Co-authored-by: Anthony <anthony@zed.dev>
Co-authored-by: Kirill <kirill@zed.dev>
Remco Smits
,
Piotr Osiewicz
,
Anthony Eid
,
Cole Miller
,
Anthony
, and
Kirill
created
d095bab
agent: Read the user's plan from the `UserStore` (#29305)
Click to expand commit body
This PR updates the Agent panel to read the user's plan from the
`UserStore` instead of hard-coding it.
Release Notes:
- N/A
Marshall Bowers
created
f8c3fe7
editor: Fix broken mouse scrolling on main (#29307)
Click to expand commit body
This PR is a quick follow-up to #29234 , which unfortunately broke
scrolling with the mouse in editors on main.
The linked PR introduced the possiblilty to completely disable scrolling
for editors. Unfortunately, it also disabled scrolling for editors by
default. This PR fixes this by re-enabling it by default.
This change also needs to be backported to v0.184.x. Otherwise, mouse
scrolling in the next preview release will not work!
Release Notes:
- N/A
Finn Evers
created
aa16107
agent: Add "copy to clipboard" button to error message popups (#29299)
Click to expand commit body
This change makes agent errors copy-able to clipboard:

Release Notes:
- N/A
Things this doesn't currently handle:
- [x] ~testing~
- ~we really need an snapshot test that takes a vscode settings file
with all options that we support, and verifies the zed settings file you
get from importing it, both from an empty starting file or one with lots
of conflicts. that way we can open said vscode settings file in vscode
to ensure that those options all still exist in the future.~
- Discussed this, we don't think this will meaningfully protect us from
future failures, and we will just do this as a manual validation step
before merging this PR. Any imports that have meaningfully complex
translation steps should still be tested.
- [x] confirmation (right now it just clobbers your settings file
silently)
- it'd be really cool if we could show a diff multibuffer of your
current settings with the result of the vscode import and let you pick
"hunks" to keep, but that's probably too much effort for this feature,
especially given that we expect most of the people using it to have an
empty/barebones zed config when they run the import.
- [x] ~UI in the "welcome" page~
- we're planning on redoing our welcome/walkthrough experience anyways,
but in the meantime it'd be nice to conditionally show a button there if
we see a user level vscode config
- we'll add it to the UI when we land the new walkthrough experience,
for now it'll be accessible through the action
- [ ] project-specific settings
- handling translation of `.vscode/settings.json` or `.code-workspace`
settings to `.zed/settings.json` will come in a future PR, along with UI
to prompt the user for those actions when opening a project with local
vscode settings for the first time
- [ ] extension settings
- we probably want to do a best-effort pass of popular extensions like
vim and git lens
- it's also possible to look for installed/enabled extensions with `code
--list-extensions`, but we'd have to maintain some sort of mapping of
those to our settings and/or extensions
- [ ] LSP settings
- these are tricky without access to the json schemas for various
language server extensions. we could probably manage to do translations
for a couple popular languages and avoid solving it in the general case.
- [ ] platform specific settings (`[macos].blah`)
- this is blocked on #16392 which I'm hoping to address soon
- [ ] language specific settings (`[rust].foo`)
- totally doable, just haven't gotten to it yet
~We may want to put this behind some kind of flag and/or not land it
until some of the above issues are addressed, given that we expect
people to only run this importer once there's an incentive to get it
right the first time. Maybe we land it alongside a keymap importer so
you don't have to go through separate imports for those?~
We are gonna land this as-is, all these unchecked items at the bottom
will be addressed in followup PRs, so maybe don't run the importer for
now if you have a large and complex VsCode settings file you'd like to
import.
Release Notes:
- Added a VSCode settings importer, available via a
`zed::ImportVsCodeSettings` action
---------
Co-authored-by: Mikayla Maki <mikayla@zed.dev>
Co-authored-by: Kirill Bulatov <kirill@zed.dev>
Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com>
Co-authored-by: Marshall Bowers <git@maxdeviant.com>
Julia Ryan
,
Mikayla Maki
,
Kirill Bulatov
,
Mikayla Maki
, and
Marshall Bowers
created
40b5a1b
agent: Improve feedback text and buttons wrapping (#29302)
Click to expand commit body
Just a little UI improvement here.
Release Notes:
- N/A
Danilo Leal
created
2d43818
rust-analyzer: Fix for deserialization error of CargoRunnableArgs (#29291)
Click to expand commit body
Fix for error:
```log
2025-04-23T13:02:14-04:00 INFO [lsp] starting language server process. binary path: "/Users/peter/Library/Application Support/Zed/languages/rust-analyzer/rust-analyzer-2025-04-21", working directory: "/Users/peter/zcode/zed", args: []
2025-04-23T13:02:16-04:00 ERROR [lsp] failed to deserialize response from language server: data did not match any variant of untagged enum RunnableArgs at line 1 column 199. response from language server: "[{\"label\":\"cargo check --workspace\",\"kind\":\"cargo\",\"args\":{\"cwd\":\"/Users/peter/zcode/zed/crates/gpui/src/platform/linux\",\"overrideCargo\":null,\"cargoArgs\":[\"check\",\"--workspace\"],\"executableArgs\":[]}}]"
2025-04-23T13:02:16-04:00 WARN [project::lsp_store] LSP Runnables via rust-analyzer failed: failed to deserialize response
2025-04-23T13:02:16-04:00 ERROR [*unknown*] LSP Runnables via rust-analyzer failed: failed to deserialize response
```
Object is missing `environment`:
```json
[
{
"label": "cargo check --workspace",
"kind": "cargo",
"args": {
"cwd": "/Users/peter/zcode/zed/crates/gpui/src/platform/linux",
"overrideCargo": null,
"cargoArgs": ["check", "--workspace"],
"executableArgs": []
}
}
]
```
Follow-up to: https://github.com/zed-industries/zed/pull/28359
Release Notes:
- N/A
---------
Co-authored-by: Kirill Bulatov <kirill@zed.dev>