80b32dd
gpui: Add 'Nearest' scrolling strategy to 'UniformList' (#41844)
Click to expand commit body
This PR introduces `Nearest` scrolling strategy to `UniformList`. This
is now used in completions menu and the picker to choose the appropriate
scrolling strategy depending on movement direction. Previously,
selecting the next element after the last visible item caused the menu
to scroll with `ScrollStrategy::Top`, which scrolled the whole page and
placed the next element at the top. This behavior is inconsistent,
because using `ScrollStrategy::Top` when moving up only scrolls one
element, not the whole page.
https://github.com/user-attachments/assets/ccfb238f-8f76-4a18-a18d-bbcb63340c5a
The solution is to introduce the `Nearest` scrolling strategy which will
internally choose the scrolling strategy depending on whether the new
selected item is below or above currently visible items. This ensures a
single-item scroll regardless of movement direction.
https://github.com/user-attachments/assets/8502efb8-e2c0-4ab1-bd8d-93103841a9c4
I also noticed that some functions in the file have different logic
depending on `y_flipped`. This appears related to reversing the order of
elements in the list when the completion menu appears above the cursor.
This was a feature suggested in #11200 and implemented in #23446. It
looks like this feature was reverted in #27765 and there currently seem
to be no way to have `y_flipped` to be set to `true`.
My understanding is that the opposite scroll strategy should be used if
`y_flipped`, but since there is no way to enable this feature to test it
and I don't know if the feature is ever going to be reintroduced I
decided not to include it in this PR.
Release Notes:
- gpui: Add 'Nearest' scrolling strategy to 'UniformList'
1d75a9c
Reverts "add OpenExcerptsSplit and dispatches on click" (#42538)
Click to expand commit body
Partially reverts https://github.com/zed-industries/zed/pull/42283 to
restore the old behavior of excerpt clicking.
Release Notes:
- N/A
Smit Barmase
created
c5ab1d4
Stop thread on Restore Checkpoint (#42537)
Click to expand commit body
Closes #35142
In addition to cleaning up the terminals, also stops the conversation.
Release Notes:
- Restoring a checkpoint now stops the agent conversation.
Richard Feldman
created
1fdd95a
Revert "editor: Improve multi-buffer header filename click to jump to the latest selection from that buffer" (#42534)
Click to expand commit body
Reverts zed-industries/zed#42480
This panics on Nightly in cases where anchor might not be valid for that
snapshot. Taking it back before the cutoff.
Release Notes:
- N/A
Update `Vim.change_surround` in order to ensure that there's no
overlapping edits by keeping track of where the open string range ends
and ensuring that the closing string range start does not go lower than
the open string range end.
Closes #42316
Release Notes:
- Fix vim's change surrounds `cs` inserting spaces with quotes by
preventing overlapping edits
---------
Co-authored-by: dino <dinojoaocosta@gmail.com>
Hans
and
dino
created
7be76c7
Use `set -x` in `script/clear-target-dir-if-larger-than` (#42525)
c2980cb
remote_server: Bump fork to 0.4.0 (#42520)
Click to expand commit body
Release Notes:
- N/A
Piotr Osiewicz
created
a0be53a
Wake up stalebot with an updated config (#42516)
Click to expand commit body
- switch the bot from looking at the `bug/crash` labels which we don't
use anymore to the Bug/Crash issue types which we do use
- shorten the period of time after which a bug is suspected to be stale
(with our pace they can indeed be outdated in 60 days)
- extend the grace period for someone to come around and say nope, this
problem still exists (people might be away for a couple of weeks).
Release Notes:
- N/A
Lena
created
70feff3
Add a one-off cleanup script for GH issue types (#42515)
Click to expand commit body
Mainly for historical purposes and in case we want to do something similar enough in the future.
Release Notes:
- N/A
Lena
created
f46990b
extensions_ui: Add XML extension suggestion for XML files (#42514)
Click to expand commit body
Closes #41798
Release Notes:
- N/A
Finn Evers
created
78f4665
vim: Fix empty selections panic in `insert_at_previous` (#42504)
The
[example](https://docs.basedpyright.com/latest/configuration/language-server-settings/#zed)
on the official website of basedpyright is correct.
Release Notes:
- Update basedpyright settings examples
CnsMaple
created
ddf762e
Revert "gpui: Unify the index_for_x methods (#42162)" (#42505)
Click to expand commit body
This reverts commit 082b80ec89748bf238f0068da80e12211fb3c7d6.
This broke clicking, e.g. in snippets like
```rs
let x = vec![
1, 2, //
3,
];
```
clicking between `2` and `,` is quite off now.
Release Notes:
- N/A
Kirill Bulatov
created
f2cadad
gpui: Fix `RefCell already borrowed` in `WindowsPlatform::run` (#42506)
2bcfc12
Absolutize LSP and DAP paths more conservatively (#42482)
Click to expand commit body
Fixes a regression caused by #42135 where LSP and DAP binaries weren't
being used from `PATH` env var
Now we absolutize the path if (path is relative AND (path has multiple
components OR path exists in worktree)).
- Relative paths with multiple components might not exist in the
worktree because they are ignored. Paths with a single component will at
least have an entry saying that they exist and are ignored.
- Relative paths with multiple components will never use the `PATH` env
var, so they can be safely absolutized
Release Notes:
- N/A
Andrew Farkas
created
cf6ae01
Show recommended models under normal category too (#42489)
Click to expand commit body
<img width="395" height="444" alt="Screenshot 2025-11-11 at 4 04 57 PM"
src="https://github.com/user-attachments/assets/8da68721-6e33-4d01-810d-4aa1e2f3402d"
/>
Discussed with @danilo-leal and we're going with the "it's checked in
both places" design!
Closes #40910
Release Notes:
- Recommended AI models now still appear in their normal category in
addition to "Recommended:"
- Based on #40234, and improvement of #40331
Release Notes:
- Added granular settings to control when files auto-open in the project
panel (project_panel.auto_open.on_create, on_paste, on_drop)
<img width="662" height="367" alt="Screenshot_2025-10-16_17-28-31"
src="https://github.com/user-attachments/assets/930a0a50-fc89-4c5d-8d05-b1fa2279de8b"
/>
---------
Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
Miguel Cárdenas
and
Smit Barmase
created
854c687
Revert "gpui: Fix `RefCell already borrowed` in `WindowsPlatform::run`" (#42481)
Click to expand commit body
Reverts zed-industries/zed#42440
There are invalid temporaries in here keeping the borrows alive for
longer
Lukas Wirth
created
da94f89
Add support for multi-word snippet prefixes (#42398)
Click to expand commit body
Supercedes #41126
Closes #39559, #35397, and #41426
Release Notes:
- Added support for multi-word snippet prefixes
---------
Co-authored-by: Agus Zubiaga <hi@aguz.me>
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Co-authored-by: Cole Miller <cole@zed.dev>
Andrew Farkas
,
Agus Zubiaga
,
Conrad Irwin
, and
Cole Miller
created
f62bfe1
Use `enterprise_uri` for settings when provided (#42485)
Click to expand commit body
Closes #34945
Release Notes:
- Fixed `enterprise_uri` not being used for GitHub settings URL when
provided
Richard Feldman
created
a56693d
Fix panic when opening an invalid URL (#42483)
Click to expand commit body
Now instead of a panic we see this:
<img width="511" height="132" alt="Screenshot 2025-11-11 at 3 47 25 PM"
src="https://github.com/user-attachments/assets/48ba2f41-c5c0-4030-9331-0d3acfbf9461"
/>
Release Notes:
- Trying to open invalid URLs in a browser now shows an error instead of
panicking
Richard Feldman
created
b4b7a23
editor: Improve multi-buffer header filename click to jump to the latest selection from that buffer (#42480)
Click to expand commit body
Closes https://github.com/zed-industries/zed/pull/42099
Regressed in https://github.com/zed-industries/zed/pull/42283
Release Notes:
- Clicking the multi-buffer header file name or the "Open file" button
now jumps to the most recent selection in that buffer, if one exists.
Smit Barmase
created
0d56ed7
Only send unit eval failures to Slack for cron job (#42479)
Click to expand commit body
Release Notes:
- N/A
Richard Feldman
created
e01e0b8
Avoid panics in LSP store path handling (#42117)
The GPT-5 ones in particular can take a long time!
Release Notes:
- N/A
---------
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Richard Feldman
and
Bennet Bo Fenner
created
8335128
settings: Skip terminal env vars with substitutions in vscode import (#42464)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/40547
Release Notes:
- Fixed vscode import creating faulty terminal env vars in terminal
settings
Lukas Wirth
created
03acbb7
collab: Remove unused embeddings queries and model (#42463)
Click to expand commit body
This PR removes the queries and database model for embeddings, as
they're no longer used.
Release Notes:
- N/A
Marshall Bowers
created
0268b17
Add more secrets to eval workflows (#42459)
Click to expand commit body
Release Notes:
- N/A
Richard Feldman
created
993919d
agent_ui: Add icon button to trigger the @-mention completions menu (#42449)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/37087
This PR adds an icon button to the footer of the message editor enabling
to trigger and interact with the @-mention completions menu with the
mouse. This is a first step towards making other types of context you
can add in Zed's agent panel more discoverable. Next, I want to improve
the discoverability of images and selections, given that you wouldn't
necessarily know they work in Zed without a clear way to see them. But I
think that for now, this is enough to close the issue above, which had
lots of productive comments and discussion!
<img width="500" height="540" alt="Screenshot 2025-11-11 at 10 46 3@2x"
src="https://github.com/user-attachments/assets/fd028442-6f77-4153-bea1-c0b815da4ac6"
/>
Release Notes:
- agent: Added an icon button in the agent panel that allows to trigger
the @-mention menu (for adding context) now also with the mouse.
Danilo Leal
created
8467a3d
agent_ui: Allow to uninstall agent servers from the settings view (#42445)
Click to expand commit body
This PR also adds items within the "Add Agent" menu to:
1. Add more agent servers from extensions, opening up the extensions
page with "Agent Servers" already filtered
2. Go to the agent server + ACP docs to learn more about them
I feel like having them there is a nice way to promote this knowledge
from within the product and have users learn more about them.
<img width="500" height="540" alt="Screenshot 2025-11-11 at 10 46 3@2x"
src="https://github.com/user-attachments/assets/9449df2e-1568-44d8-83ca-87cbb9eefdd2"
/>
Release Notes:
- agent: Enabled uninstalled agent servers from the agent panel's
settings view.
Danilo Leal
created
ee2e690
agent_servers: Fix panic when setting default mode (#42452)
Click to expand commit body
Closes ZED-35A
Release Notes:
- Fixed an issue where Zed would panic when trying to set the default
mode for ACP agents
Closes #42303
Ollama added tool call identifiers
(https://github.com/ollama/ollama/pull/12956) in its latest version
[v0.12.10](https://github.com/ollama/ollama/releases/tag/v0.12.10). This
broke our json schema and made all tool calls fail.
This PR fixes the schema and uses the Ollama provided tool call
identifier when available. We remain backwards compatible and still use
our own identifier with older versions of Ollama. I added a `TODO` to
remove the `Option` around the new field when most users have updated
their installations to v0.12.10 or above.
Note to reviewer: The fix to this issue should likely get cherry-picked
into the next release, since Ollama becomes unusable as an agent without
it.
Release Notes:
- Fixed tool calling when using the latest version of Ollama
tidely
created
a19d111
remote: Add more context to error logging in wsl (#42450)
Click to expand commit body
cc https://github.com/zed-industries/zed/issues/40892
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Lukas Wirth
created
38e2c7a
editor: Hide file blame on editor cancel (ESC) (#42436)
10d5d78
Improve error messages on extension loading (#42266)
Click to expand commit body
This pull request improves error message when extension loading goes
wrong.
Before:
```
2025-11-08T21:16:02+08:00 ERROR [extension_host::extension_host] failed to load arkts extension.toml
Caused by:
No such file or directory (os error 2)
```
Now:
```
2025-11-08T22:57:00+08:00 ERROR [extension_host::extension_host] failed to load arkts extension.toml, "/Users/user_name_placeholder/Library/Application Support/Zed/extensions/installed/arkts/extension.toml"
Caused by:
No such file or directory (os error 2)
```
Release Notes:
- N/A
liuyanghejerry
created
dfd7e85
Replace deprecated json.schemastore.org with www.schemastore.org (#42336)
Click to expand commit body
Release Notes:
- N/A
According to
[microsoft/vscode#254689](https://github.com/microsoft/vscode/issues/254689),
the json.schemastore.org domain has been deprecated and should now use
www.schemastore.org (or schemastore.org) instead.
This PR updates all occurrences of the old domain within the Zed
codebase,
including code, documentation, and configuration files.
Terra
created
b8fcd3e
gpui: Fix `RefCell already borrowed` in `WindowsPlatform::run` (#42440)
58db387
Find proper applicable chunks for visible ranges (#42422)
Click to expand commit body
Release Notes:
- Fixed inlay hints not being queried for certain long-ranged jumps
Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
Co-authored-by: Lukas Wirth <lukas@zed.dev>
Kirill Bulatov
,
Smit Barmase
, and
Lukas Wirth
created
f2ad0d7
zeta cli: Print log paths when running predict (#42396)
Click to expand commit body
Release Notes:
- N/A
Co-authored-by: Michael Sloan <mgsloan@gmail.com>
Co-authored-by: Ben Kunkle <ben@zed.dev>
Agus Zubiaga
,
Michael Sloan
, and
Ben Kunkle
created
777b465
auto_update: Ignore dir removal errors on windows (#42435)
Click to expand commit body
The auto update helper already removes these when successful, so these
will always fail in the common case.
Additional replaces a mutable const with a static as otherwise we'll
rebuild the job list on every access
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Lukas Wirth
created
b3dd515
docs: Fix broken links in docs with lychee (#42404)
Click to expand commit body
Lychee is a [Rust based](https://lychee.cli.rs) async parallel link
checker.
I ran it against the codebase to suss out stale links and fixed those
up.
There's currently 2 remaining cases that I don't know how to resolve:
1. https://flathub.org/apps/dev.zed.Zed - nginx is giving a 502 bad
gateway
2.
https://github.com/zed-industries/zed/actions/workflows/ci.yml/badge.svg
- I don't want to mess with the CI pipeline in this PR.
Once again, I'll punt to the Docs Czar to see if this gets incorporated
into CI later.
---
## Running `lychee` locally:
```
cargo binstall -y lychee
lychee .
```
---
Release Notes:
- N/A
Signed-off-by: mrg <miguelraz@ciencias.unam.mx>