9b518e5
finish the feature
Mikayla Maki created
9b518e5
finish the feature
Mikayla Maki created
5297bf3
Implement the feature: retain draft threads instead of resetting them
Mikayla Maki created
3d0d03b
Retain draft threads in the sidebar
Mikayla Maki created
6a95e29
git_panel: Fix space key being swallowed in branch picker (#52779)
## Context Fixes a regression where typing a space in the Git Panel's "Switch Branch" picker would make no response at all instead of inserting the character. The same picker in the title-bar Git Switcher was unaffected. Root cause: `PopoverMenu` links the opened menu's focus handle into the parent element's dispatch tree so that `contains_focused` returns `true` on the parent while the popover is open. `GitPanel::dispatch_context` uses `contains_focused` to decide whether to add the `ChangesList` key context, so that context is active while the branch picker is open. Because `Picker` and `Editor` have no binding for a bare `space`, dispatch fell through to the `"GitPanel && ChangesList"` binding, which maps `space` to `git::ToggleStaged`, consuming the keystroke before it could reach the text input. The fix narrows the context guard to `"GitPanel && ChangesList && !GitBranchSelector"`, so those bindings are skipped whenever the branch picker (or any other `GitBranchSelector` context) is focused inside the panel. The same change is applied to the vim keymap, which would have similarly intercepted `k`, `j`, `x`, and other letter keys typed in the picker, this behavior was observed in https://github.com/zed-industries/zed/issues/52617 and I made the same fix in https://github.com/zed-industries/zed/pull/52687 Closes #52771 and potentially https://github.com/zed-industries/zed/issues/52617 Video of the manual test of the fix below : [Screencast from 2026-03-31 00-01-54.webm](https://github.com/user-attachments/assets/76f64507-4f5a-4a8e-8582-4cdb9bec584c) ## How to Review - `assets/keymaps/default-linux.json`, `default-windows.json`, `default-macos.json`, `vim.json` : identical one-line change in each: I added `&& !GitBranchSelector` to the `"GitPanel && ChangesList"` . No Rust changes needed. ## Self-Review Checklist - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the UI/UX checklist - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed space and other keys being swallowed when typing in the Git Panel branch picker
saberoueslati created
7315aad
git_ui: Fix branch picker stealing vim keys in Git panel (#52687)
## Context
When `vim_mode` is enabled, opening the branch selector popover in the
Git panel and pressing `i`, `j`, `k`, or `x` triggered Git panel actions
(`FocusEditor`, `SelectNext`, `ToggleStaged`, etc.) instead of reaching
the picker's search field.
The `"GitPanel && ChangesList"` keybinding block in `vim.json` matched
whenever _any_ child of the git panel's focus handle was focused —
including the branch picker popover — because
`GitPanel::dispatch_context()` adds `ChangesList` based on
`focus_handle.contains_focused()`, which is true for all children, not
just the changes list itself.
The branch picker's root element already sets
`.key_context("GitBranchSelector")` (branch_picker.rs). GPUI's `Not`
predicate evaluates against the entire context path, so adding `&&
!GitBranchSelector` to the block's context suppresses all those bindings
whenever the picker is open, and restores them exactly as before once
it's closed.
Closes #52617
Video of the manual test of the fix below :
[Screencast from 2026-03-29
22-01-11.webm](https://github.com/user-attachments/assets/217e8e31-9bee-4e77-a7aa-0c094874ed9a)
## How to Review
- `assets/keymaps/vim.json` : changed the `"GitPanel && ChangesList"`
context string ,I added`&& !GitBranchSelector`.
## Self-Review Checklist
- [x] I've reviewed my own diff for quality, security, and reliability
- [ ] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the UI/UX checklist
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable
Release Notes:
- Fixed branch picker in the Git panel stealing vim keystrokes (`i`,
`j`, `k`, `x`) when vim mode is enabled
saberoueslati created
d22a39f
Hide other panels when clicking on sidebar threads (#52804)
This PR makes it so that clicking on sidebar threads behaves the same as the "focus agent panel" keybinding, namely it hides zoomed panels and brings focus to the agent panel. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
Mikayla Maki created
24613f5
Fix resizing bottom-docked terminal panel (#52803)
The terminal panel is now flexible by default, but only when in a left or right panel. This PR fixes a bug where resizing the terminal panel was incorrectly setting the flex value instead of the fixed size when the terminal panel was in the bottom dock and flexible. Release Notes: - N/A
Max Brunsfeld created
3e0a0e1
markdown: Skip linkify inside code blocks (#52762)
Profiling streamed agent responses showed `parse_markdown_with_options` consuming ~50% of CPU cycles. The hot path is `LinkFinder` scanning every `Text` event, including code block content, where detected URLs are never rendered as links. In the profiled case, the markdown had 235k+ URLs inside code blocks, making linkify extremely costly per-parse. This PR short-circuits the text-merging + linkify path for code block content. Release Notes: - N/A
Smit Barmase created
0857b41
docs: Update guide to remove user data on macOS when uninstalling Zed (#52631)
I recently encountered some issue on my mac and I tried to uninstall Zed completely. However the current guide to remove user data does not cover some configs that Zed uses. There are also some directories that should be removed according to the doc but never exist. So I have this pull request to make the user data directories more accurate, according to my own experience. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A: doc update --------- Co-authored-by: Christopher Biscardi <chris@christopherbiscardi.com>
Yifan Ruan and Christopher Biscardi created
7719d29
Simplify sidebar active state (#52799)
This changes the terminology from "focused entry" to "active entry", and adds 4 properties that rebuild_contents should maintain for the active entry: - We should always have an active_entry after rebuild_contents - The active entry's workspace should always be == to the active multiworkspace - If there's a thread, the active entry should always reflect that thread - There should always be exactly 1 active entry Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #ISSUE Release Notes: - N/A
Mikayla Maki created
2e44664
Implement sidebar serialization (#52795)
This PR implements basic sidebar deserialization. When the multiworkspace decides to save itself, it causes the sidebar to serialize as well. The sidebar can trigger this as well via an event. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
Mikayla Maki created
f3e672c
Implement work dir updating for active and background threads (#52793)
This PR changes things so that when the user mutates their current project (e.g. adding a folder), the thread entries now update the currently running threads to be pointing at this new set of folders. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable TODO: - [x] Manually test this case Release Notes: - N/A
Mikayla Maki created
dfafd62
Implement non-macos titlebars for the new sidebar (#52794)
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Icons aren't showing because I'm forcing the UI to be visible on macOS, but things look ok on the right sidebar: <img width="389" height="955" alt="Screenshot 2026-03-30 at 7 36 06 PM" src="https://github.com/user-attachments/assets/269fe9c9-1212-4c1e-b8d9-1694db70adf3" /> Release Notes: - N/A
Mikayla Maki created
fb87786
Automatically switch to unified diffs when diff view is narrower than a configurable "minimum split diff width" (#52781)
Release Notes: - The git diff diff view now automatically switches from split mode to unified mode when the pane is narrower than a configurable minimum column count. You can configure this via the new `minimum_split_diff_width` setting.
Max Brunsfeld created
e39d5c9
Remove easily derived sidebar state (#52790)
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #ISSUE Release Notes: - N/A
Mikayla Maki created
8b0d49f
Add existing user agent onboarding flow (#52787)
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #ISSUE Release Notes: - N/A
Mikayla Maki created
3d29a06
sidebar: Add debug action to dump multi-workspace state (#52785)
Add a debug-only (`cfg(debug_assertions)`) action `DumpWorkspaceInfo` that opens a read-only buffer with a dump of all workspace state. This is useful for debugging the sidebar's view of workspaces and threads, since the sidebar is currently the only way to see workspace-related state. For each workspace in the MultiWorkspace it shows: - **Workspace DB ID** — for cross-referencing with persistence - **All worktrees** with their paths, branches, and visibility - **Whether each worktree is a git linked worktree** and where it links to - **Active agent thread** with title, session ID, status, and entry count - **Background agent threads** with the same detail - **A warning** if the agent panel's workspace ID doesn't match the workspace Example output: ``` MultiWorkspace: 3 workspace(s) Active workspace index: 1 --- Workspace 0 --- Workspace DB ID: WorkspaceId(42) Worktrees: - /Users/eric/repo/scratch3 [branch: refs/heads/scratch3] [linked worktree -> /Users/eric/repo/scratch] Active thread: Git Worktree Path Consistency Check (session: 575b4349-...) [idle, 42 entries] --- Workspace 1 (active) --- Workspace DB ID: WorkspaceId(57) Worktrees: - /Users/eric/repo/worktrees/zed/my-branch/zed [branch: refs/heads/my-branch] [linked worktree -> /Users/eric/repo/zed] Active thread: Sidebar Not Displaying Git Worktree (session: 8f337c5c-...) [generating, 17 entries, awaiting confirmation] Background threads (1): - Previous Investigation (session: abc12345-...) [idle, 83 entries] --- Workspace 2 --- Workspace DB ID: WorkspaceId(63) Worktrees: - /Users/eric/repo/ex [branch: refs/heads/main] Active thread: (none) ``` ### Implementation The action and handler live in the `sidebar` crate (close to what they debug), following the same pattern as `language_tools` owning `OpenLanguageServerLogs` and `debugger_tools` owning `OpenDebugAdapterLogs`. The `zed` crate has only a one-line registration. Two small public accessors were added to `AgentPanel`: - `workspace_id()` — exposes the panel's workspace ID for mismatch detection - `background_threads()` — exposes retained background conversation views Release Notes: - N/A
Eric Holk created
c9e45fe
sidebar: Represent workspaces with no threads as a New Thread entry (#52778)
Workspaces with no threads weren't being shown in the sidebar which can make it easy to lose your sense of place. This PR works to address that by showing these workspaces as a "New Thread" button which also shows the work trees associated with that workspace. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
Eric Holk created
18ebc35
agent_settings: Add a way to set the layout settings en-masse (#52777)
Use `AgentSettings::get_layout(cx)` to retrieve the current, exact value of the user's layout settings, and `AgentSettings::set_layout(WindowLayout::agent())` or `AgentSettings::set_layout(cached_user_settings)` to write to them. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #ISSUE Release Notes: - N/A
Mikayla Maki created
6120452
Remove follow agent setting (#52775)
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #ISSUE Release Notes: - N/A
Mikayla Maki created
b922ef5
elixir: Disable Emmet by default (#52769)
The Emmet extension is enabled for Elixir files (`.ex`) because of the `~H` sigil, but this is a bit unexpected if you work exclusively with HEEx files (`.heex`) or you don't actually use Phoenix in any capacity With this change, the user must explicitly opt into Emmet for Elixir files, just like Tailwind Release Notes: - N/A
AltCode created
e12d3de
Add Xcode Instrument images to troubleshooting doc (#52768)
Merge first: https://github.com/zed-industries/zed.dev/pull/1861 Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
Joseph T. Lyons created
807207e
Own the workspace list in MultiWorkspace (#52546)
## Context TODO ## Self-Review Checklist <!-- Check before requesting review: --> - [ ] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable Release Notes: - N/A --------- Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Mikayla Maki and Max Brunsfeld created
b48dd02
Fix preserve settings during migrations (#52676)
## Context `update_settings_file` deletes unrelated settings when the settings file contains deprecated keys that need migration. For example, changing the model from the Agent Panel overwrites the entire `agent` block instead of just updating `default_model`. The root cause is that `edits_for_update` used `parse_json_with_comments` (strict parser), which returns `Err` on deprecated/unknown fields. The error is swallowed by `log_err()`, falling back to `Default::default()` (empty settings). The diff then sees everything as new and replaces the entire block. The fix switches to `parse_json` (the fallible/lenient parser), which returns `Some(parsed_value)` even when deprecated fields are present - the same pattern already used by `parse_and_migrate_zed_settings`. ## Fixes #41344 ## How to Review Single-file change in `settings_store.rs`, focus on `edits_for_update` . Compare with `parse_and_migrate_zed_settings` (line 702) which already uses the same `parse_json` approach. ## Self-Review Checklist - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable ## Video [Screencast from 2026-03-21 00-36-12.webm](https://github.com/user-attachments/assets/31bd584a-2674-4c91-bdb2-69ed8fa35e88) ### Note : Reopens previous work from closed PR #52081 (fork was deleted) Release Notes: - Fixed settings being overwritten when updating a single setting via UI while the settings file contains deprecated keys.
Om Chillure created
8dbef08
workspace: Stop middle-click event propagation on tab close (#49305)
## Summary - On Linux, middle-clicking a tab to close it also triggered a paste of the primary selection into the editor behind it, because the event bubbled to the editor's `mouse_up()` handler - Added `cx.stop_propagation()` in the `on_aux_click` handler in `pane.rs` after closing the tab, matching the pattern already used by the editor's own middle-click handler in `element.rs:1037` Closes #47381 ## Test plan - [x] `cargo test -p workspace` passes (124 tests, 0 failures) - [x] Select text in editor (filling primary selection), middle-click a tab to close it → tab closes, no paste in the editor behind - [x] Middle-click inside the editor area → still pastes from primary selection as expected Release Notes: - Fixed middle-click on a tab to close it also pasting into the editor on Linux.
Arthur Jean created
d74744a
Swap KVP store used for collab favorites (#52756)
We should generally prefer using the normal key value store Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
Mikayla Maki created
37cfeae
collab_panel: Fix overlapping list items (#52754)
Small UI tweak post the introduction of the favorite feature so that list items don't overlap each other. Release Notes: - N/A
Danilo Leal created
ce61450
sidebar: Remove `AgentSessionInfo` usage (#52732)
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A --------- Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com> Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Bennet Bo Fenner , Ben Brandt , and Danilo Leal created
06b5a15
docs: Add instructions for custom Expert builds (#52746)
Adds a section on how to configure Zed to use a custom Expert build. There's already [*some* docs](https://zed.dev/docs/configuring-languages#possible-configuration-options) on how to do this, but I think it's important to make it clear that the `--stdio` flag is also required for expert. Release Notes: - N/A
Dorgan created
a46858a
gpui: Add dithering to linear gradient shader (#51211)
Linear gradients in dark color ranges (5-15% lightness) show visible banding due to 8-bit quantization — only ~7 distinct values exist in that range, producing hard steps instead of smooth transitions. This affects every dark theme in Zed. ## What this does Adds triangular-distributed dithering after gradient interpolation in both the Metal and HLSL fragment shaders. The noise breaks up quantization steps at the sub-pixel level, producing perceptually smooth gradients. ## How it works Two hash-based pseudo-random values (seeded from fragment position x golden ratio) are summed to produce a triangular probability distribution. This is added to the RGB channels at +/-1/255 amplitude. - **Triangular PDF** — mean-zero, so no brightness shift across the gradient - **+/-1/255 amplitude** — below perceptual threshold, invisible on bright gradients where 8-bit precision is already sufficient - **Deterministic per-pixel** — seeded from position, no temporal flickering - **Zero-cost** — a couple of `fract`/`sin` per fragment, negligible vs. the existing gradient math ### Channel-specific amplitudes | Channel | Amplitude | Rationale | |---------|-----------|----------------------------------------------------------------------------------------------------| | RGB | ±2/255 | Breaks dark-on-dark banding where adjacent 8-bit values are perceptually close | | Alpha | ±3/255 | Alpha gradients over dark backgrounds need stronger noise — α × dark color = tiny composited steps | The higher alpha amplitude is necessary because when a semi-transparent gradient (e.g., 0.4 → 0.0 alpha) composites over a dark background, the effective visible difference per quantization step is smaller than the RGB case. ±3/255 is still well below the perceptual threshold on bright/opaque elements. ## Scope Two files changed, purely additive: | File | Change | |------|--------| | `crates/gpui_macos/src/shaders.metal` | 13 lines after `mix()` in `fill_color()` | | `crates/gpui_windows/src/shaders.hlsl` | 13 lines after `lerp()` in `gradient_color()` | No changes to Rust code, no API changes, no new dependencies. ## Screenshots <img width="1886" height="1003" alt="gradient_dithering_before" src="https://github.com/user-attachments/assets/f75ae93b-b142-4d0e-9b61-e08f30fe1758" /> _Before_ <img width="1902" height="1052" alt="gradient_dithering_after" src="https://github.com/user-attachments/assets/7aee9a36-f578-4e08-a846-44d092bcf043" /> _After_ ## Test plan This is a shader-level fix; no Rust test harness exists for visual output. Manual testing is appropriate here. Visual regression tests cover UI layout, not sub-pixel rendering quality. **Manual (macOS):** - [x] Dark gradients (5-13% lightness range) — banding eliminated - [x] Bright gradients — no visible difference (dither amplitude below precision threshold) - [x] Oklab and sRGB color spaces — both paths dithered - [x] Solid colours, pattern fills, checkerboard — unaffected (dither only applies to LinearGradient case) - [x] Alpha gradients (semi-transparent over dark bg) — banding eliminated with alpha dithering - [x] Path gradients (paint_path) — same fill_colour() function, dithering applies **Windows:** HLSL change is identical logic with HLSL built-ins (`frac`/`lerp` vs `fract`/`mix`) — not tested locally. Release Notes: - Improved linear gradient rendering by adding dithering to eliminate visible banding in dark color ranges Liam
iam-liam created
1b9f383
ui: Follow-up to ui crate teardown (#52747)
- **Remove some of the settings types from ui** - **drag settings-less ui across the line** Self-Review Checklist: - [ ] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable Closes #ISSUE Release Notes: - N/A --------- Co-authored-by: Lukas Wirth <me@lukaswirth.dev>
Piotr Osiewicz and Lukas Wirth created
c332be8
ep: Only fetch experiments if `cx.is_staff` (#52739)
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #ISSUE Release Notes: - N/A
Ben Kunkle created
22b71a8
Fix panic in restore_diff_hunks when base text changes async (#52743)
Read base_text from the `MultiBufferSnapshot` instead of the live `BufferDiff` entity in `prepare_restore_change`. The live entity's base_text may already reflect a newer git HEAD while the snapshot still holds old hunk byte ranges, causing `Rope::slice` to panic. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes ZED-64P Release Notes: - N/A
Oleksiy Syvokon created
8b7cc09
Allow agent and terminal panels to be either flexible or fixed (#52694)
This PR adds the ability to change both the terminal and agent panels between fixed and flexible sizing using the status bar button right click menu. The value persists in your settings, similar to the dock position. I've also slightly tweaked the styling of the "Dock Left" and "Dock Right" items in the right-click menu, adding the current value as an item with a check beside it, to make it clear that it's a selectable option. Release Notes: - N/A
Max Brunsfeld created
564d1fe
git: Implement branch diff line counts efficiently (#52582)
Previously we were iterating over all hunks across all diffs on every frame. Now we can read off the required information as a `SumTree` summary in constant time. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - git: Fixed bad performance in large branch diffs.
Cole Miller created
3dde315
agent panel: Fix keybindings on Linux (#52672)
## Context Fixes agent panel keybindings on Linux, mirroring the Windows fix from #43692. On Linux, `Ctrl+Y` (the previous `agent::AllowOnce` binding) is intercepted by the focused text input as "redo", so the shortcut did nothing when the message editor was focused. This is the same issue fixed for Windows in #43692. Changes (Linux and Windows): - `agent::AllowAlways`: added `shift-alt-q` (was unbound on all platforms) - `agent::AllowOnce`: `ctrl-y` → `shift-alt-a` (Linux); already `shift-alt-a` on Windows - `agent::RejectOnce`: `shift-alt-x` on both platforms — `shift-alt-z` conflicted with `agent::RejectAll` bound in other contexts, causing the keybinding hint to not appear in the UI - `agent::ToggleNavigationMenu`: `ctrl-shift-j` → `shift-alt-j` (Linux) - `agent::ToggleOptionsMenu`: `ctrl-alt-i` → `shift-alt-i` (Linux) Closes #52472 ## How to Review Two files changed: `assets/keymaps/default-linux.json` and `assets/keymaps/default-windows.json`. Check the `AgentPanel` context block in each. ## Self-Review Checklist - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Note : Reopens previous work from closed PR #52479 (fork was deleted) Release Notes: - Fixed agent panel `Allow`, `Always Allow`, and `Reject` keybindings not working when the message editor is focused on Linux e
Om Chillure created
f18c963
acp_thread: Clarify max token limit error message (#52724)
When generation stops due to the per-response output limit, Zed was surfacing "Max tokens reached", which implies the full context window was exhausted. In reality, `max_output_tokens` (the per-response cap) may have been hit a different condition. This change distinguishes between the two cases: if `output_tokens >= max_output_tokens`, it surfaces "Maximum output tokens reached"; otherwise it falls back to "Maximum tokens reached". Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the UI/UX checklist - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #50254 Note : Reopens #50372 suggested by @bennetbo Release Notes: - Fixed misleading "Max tokens reached" error by distinguishing between per-response output token limit and total context window limit. --------- Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Om Chillure and Bennet Bo Fenner created
8e19c74
eval: Remove deprecated eval crate and workflow (#52733)
This is replaced by eval_cli Release Notes: - N/A
Ben Brandt created
0d5504e
eval_cli: Make things a bit more resilient to different Docker envs (#52731)
Release Notes: - N/A
Ben Brandt created
6431558
Add the ability to reorder favorited collab channels (#52649)
Currently, if you try to re-order a favorite, the favorite will not reorder, but the actual channels will. https://github.com/user-attachments/assets/1fbab9ea-4ff4-473f-8de3-d3b60696c5a1 Additionally, a new bug seems to be that if you reorder channels, focus jumps to a favorite: https://github.com/user-attachments/assets/fa776ad2-8648-4e68-a253-a98f57bd4951 This PR allows for re-ordering of favorites independent of the actual channels, and fixes the focusing bug https://github.com/user-attachments/assets/977e575a-055c-4f26-8183-2744ff7f8f56 I didn't feel comfortable adding just the functionality/fixes alone, so I added a function to represent the state of the collab panel as a list of strings, like how testing around the project panel is, and wrote a few tests to ensure the behavior was pinned down. The tests cover testing: - Favoriting/unfavoriting - Reordering favorites without impacting order of channels in the channels list - Reordering channels in the channels list without impacting order of favorites Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #ISSUE Release Notes: - Added the ability to reorder favorited collab channels.
Joseph T. Lyons created
3aeef32
sidebar: Improve remote project icon display (#52726)
Follow up to https://github.com/zed-industries/zed/pull/52720 This PR renders the same icons we do in the title bar depending on the type of remote connection (SSH, WSL, etc.). Release Notes: - N/A
Danilo Leal created
94e90d9
docs: Add detailed tracy workflow to `performance.md` (#52574)
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Improved performance documentation in "Developing Zed" --------- Co-authored-by: Zed Zippy <234243425+zed-zippy[bot]@users.noreply.github.com>
Yara 🏳️⚧️ and Zed Zippy created
8269e98
windows: Bump WindowsTerminal (#52562)
Release Notes: - N/A or Added/Fixed/Improved ...
Lukas Wirth created
9649a72
Fix wrong selection in outline panel (#52673)
Fix the outline entry sort order to prefer the entry whose heading starts at the cursor position. Closes #52418 Release Notes: - Fixed Outline Panel selection being off-by-one in Markdown heading boundaries --------- Co-authored-by: dino <dinojoaocosta@gmail.com>
Om Chillure and dino created
bb14648
icons: Add EditorConfig file icon (#52705)
Release Notes: - Added file icon for EditorConfig (`.editorconfig`) --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Tom Zaspel and Danilo Leal created
0640e55
editor: Merge additional completion edits into primary undo transaction (#52699)
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #45986 Release Notes: - Fixed postfix snippets now creating 1 `undo` actions instead of 2.
HuaGu-Dragon created
2b4c217
editor: Fix LSP extension commands failing at end of file (#52651)
## Context Closes #51330 When the cursor is at the very end of a file, `find_specific_language_server_in_selection` in `crates/editor/src/lsp_ext.rs` silently skips the selection because the anchor's `buffer_id` is `None`. This causes `editor: switch source header` (clangd) and rust-analyzer extension commands (`expand macro`, `open docs`, `open playground`) to do nothing. The fix falls back to the singleton buffer's ID when the anchor has no `buffer_id`. ## How to Review Single file change in `crates/editor/src/lsp_ext.rs`. The diff is small — pre-compute the singleton buffer ID, then use it as fallback in the `filter_map` closure. An integration test verifies the fix. ## Self-Review Checklist - [x] Reviewed own diff for quality, security, and reliability - [x] No unsafe blocks - [x] Tests pass (639 editor tests, 0 failures) - [x] Manual testing: switch source header works at beginning, middle, and end of C++ file ## Test Plan - [x] New integration test: `test_find_language_server_at_end_of_file` — verifies `find_specific_language_server_in_selection` returns `Some` at both beginning and end of file - [x] Confirmed the test fails without the fix (assertion on "should find language server at end of file") - [x] Manual: open a C++ file with clangd, place cursor at very end, run `switch source header` — now correctly opens the header - [x] Manual: verify it still works at beginning and middle of file (non-regression) - [x] `cargo test -p editor` — 639 passed, 0 failed Release Notes: - Fixed `editor: switch source header` and other LSP extension commands not working when the cursor is at the very end of a file. --------- Co-authored-by: Florian Trehaut <florian.trehaut@hillcode.fr> Co-authored-by: Kirill Bulatov <kirill@zed.dev>
Florian TREHAUT , Florian Trehaut , and Kirill Bulatov created
4317359
agent_ui: Fix auto-scroll in subagent cards (#52719)
Due to the async nature of markdown parsing, sometimes subagent cards would not scroll fully to the bottom of the content because the `scroll_to_bottom` function was being called just while the agent was running... and sometimes, it'd finish running before the markdown had fully finished parsing. The solution is to remove the `is_running` conditional. Release Notes: - Agent: Improved auto-scroll of subagent content in preview cards, ensuring the content is always visible until the end.
Danilo Leal created
2c7ce42
sidebar: Clarify which projects are remote in the UI (#52720)
This PR adds a little server icon to the side of the project label to clarify that's a remote project. This is particularly useful when having the remote and non-remote version of a project open in the same multi-workspace/window. <img width="400" height="282" alt="Screenshot 2026-03-30 at 7 59@2x" src="https://github.com/user-attachments/assets/9bb3e02e-a64d-412e-88ef-57b18fb5e13d" /> Release Notes: - N/A
Danilo Leal created
6332655
collab_panel: Persist favorited channels in the global KV store (#52600)
Follow up to https://github.com/zed-industries/zed/pull/52541 Favorite channels weren't appearing on multiple windows because they were serialized in a given window's collab panel state. This PR moves them to the global key value store. Also, solved a little issue with non-unique ids which was making clicking on the original instance of a favorite channel do nothing. Release Notes: - N/A
Danilo Leal created