Commit log

2813073 message editor: Only allow types of content the agent can handle (#36616)

Click to expand commit body
Uses the new
[`acp::PromptCapabilities`](https://github.com/zed-industries/agent-client-protocol/blob/a39b7f635d67528f0a4e05e086ab283b9fc5cb93/rust/agent.rs#L194-L215)
to disable non-file mentions and images for agents that don't support
them.

Release Notes:

- N/A

Agus Zubiaga created

74ce543 clippy: println_empty_string & non_minimal_cfg (#36614)

Click to expand commit body
- **clippy: Fix println-empty-string**
- **clippy: non-minimal-cfg**

Related to #36577

Release Notes:
- N/A

Piotr Osiewicz created

b6722ca Remove special case for singleton buffers from `MultiBufferSnapshot::anchor_at` (#36524)

Click to expand commit body
This may be responsible for a panic that we've been seeing with
increased frequency in agent2 threads.

Release Notes:

- N/A

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>

Cole Miller and Conrad Irwin created

ec8106d Fix `clippy::println_empty_string`, `clippy::while_let_on_iterator`, `clippy::while_let_on_iterator` lint style violations (#36613)

Click to expand commit body
Related: #36577

Release Notes:

- N/A

Umesh Yadav created

41e28a7 Add tracked buffers for agent2 mentions (#36608)

Click to expand commit body
Release Notes:

- N/A

Cole Miller created

8334cdb agent2: Port feedback (#36603)

Click to expand commit body
Release Notes:

- N/A

---------

Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>

Bennet Bo Fenner and Ben Brandt created

d0fb612 Fix scrollbar flicker when streaming agent2 response (#36606)

Click to expand commit body
This was caused by calling `list_state.splice` on updated entries. We
don't need to splice the entry, as we'll recompute its measurements
automatically when we render it.

Release Notes:

- N/A

Antonio Scandurra created

699f58a Capture telemetry when requesting completions in agent2 (#36600)

Click to expand commit body
Release Notes:

- N/A

Antonio Scandurra created

1e6cefa Fix `clippy::len_zero` lint style violations (#36589)

Click to expand commit body
Related: #36577

Release Notes:

- N/A

---------

Signed-off-by: Umesh Yadav <git@umesh.dev>

Umesh Yadav created

92352f9 Fix `clippy::map_clone` lint violations (#36585)

Click to expand commit body
#36577

Release Notes:

- N/A

tidely created

eaf6b56 Miscellaneous UX fixes for agent2 (#36591)

Click to expand commit body
Release Notes:

- N/A

Antonio Scandurra created

85865fc agent2: New thread from summary (#36578)

Click to expand commit body
Release Notes:

- N/A

---------

Co-authored-by: Agus Zubiaga <agus@zed.dev>
Co-authored-by: Cole Miller <cole@zed.dev>

Bennet Bo Fenner , Agus Zubiaga , and Cole Miller created

c5040bd remote: Do not leave client hanging on unhandled proto message (#36590)

Click to expand commit body
Otherwise the client will wait for a response that never arrives,
causing the task to lock up

Release Notes:

- N/A

Lukas Wirth created

bc79076 Fix `clippy::manual_map` lint violations (#36584)

Click to expand commit body
#36577

Release Notes:

- N/A

tidely created

de12633 Wait for agent2 feature flag before loading panel (#36583)

Click to expand commit body
Release Notes:

- N/A

Antonio Scandurra created

6ed29fb Enforce style lints which do not have violations (#36580)

Click to expand commit body
Release Notes:

- N/A

tidely created

4ee565c Fix mentions roundtrip from/to database and other history bugs (#36575)

Click to expand commit body
Release Notes:

- N/A

Antonio Scandurra created

f80a0ba Move clippy lints which aren't apart of the style category (#36579)

Click to expand commit body
Move lints which aren't apart of the style category.

Motivation: They might get accidentally get reverted when we turn the
style category on again and remove the manual lint enforcements.

Release Notes:

- N/A

tidely created

7bdc99a Fix `clippy::redundant_clone` lint violations (#36558)

Click to expand commit body
This removes around 900 unnecessary clones, ranging from cloning a few
ints all the way to large data structures and images.

A lot of these were fixed using `cargo clippy --fix --workspace
--all-targets`, however it often breaks other lints and needs to be run
again. This was then followed up with some manual fixing.

I understand this is a large diff, but all the changes are pretty
trivial. Rust is doing some heavy lifting here for us. Once I get it up
to speed with main, I'd appreciate this getting merged rather sooner
than later.

Release Notes:

- N/A

tidely created

cf7c64d lints: A bunch of extra style lint fixes (#36568)

Click to expand commit body
- **lints: Fix 'doc_lazy_continuation'**
- **lints: Fix 'doc_overindented_list_items'**
- **inherent_to_string and io_other_error**
- **Some more lint fixes**
- **lints: enable bool_assert_comparison, match_like_matches_macro and
wrong_self_convention**


Release Notes:

- N/A

Piotr Osiewicz created

a32a264 agent2: Use correct completion intent when generating summary (#36573)

Click to expand commit body
Release Notes:

- N/A

Bennet Bo Fenner created

0a80209 agent2: Fix remaining update_model_request_usage todos (#36570)

Click to expand commit body
Release Notes:

- N/A

Bennet Bo Fenner created

83d361b Add more string and comment overrides (#36566)

Click to expand commit body
Follow-up to #36469

Part of the issue was that we hadn't defined comment and string
overrides for some languages. Hence, even after the fix edit predictions
would show up in comments for me in e.g. JSONC files.

This PR adds some more overrides where possible for this repo to ensure
this happens less frequently.

Release Notes:

- N/A

Finn Evers created

4290f04 agent2: Fix token count not updating when changing model/toggling burn mode (#36562)

Click to expand commit body
Release Notes:

- N/A

---------

Co-authored-by: Antonio Scandurra <me@as-cii.com>

Bennet Bo Fenner and Antonio Scandurra created

44941b5 Fix `clippy::for_kv_map` lint violations (#36493)

Click to expand commit body
Release Notes:

- N/A

tidely created

d4d049d agent2: Port more Zed AI features (#36559)

Click to expand commit body
Release Notes:

- N/A

---------

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>

Bennet Bo Fenner and Danilo Leal created

4c85a0d project: Register dynamic capabilities even when registerOptions doesn't exist (#36554)

Click to expand commit body
Closes #36482

Looks like we accidentally referenced
[common/formatting.ts#L67-L70](https://github.com/microsoft/vscode-languageserver-node/blob/d90a87f9557a0df9142cfb33e251cfa6fe27d970/client/src/common/formatting.ts#L67-L70)
instead of
[common/client.ts#L2133](https://github.com/microsoft/vscode-languageserver-node/blob/d90a87f9557a0df9142cfb33e251cfa6fe27d970/client/src/common/client.ts#L2133).

Release Notes:

- Fixed code not formatting on save in language servers like Biome.
(Preview Only)

Smit Barmase created

5d2bb24 ACP history mentions (#36551)

Click to expand commit body
- **TEMP**
- **Update @-mentions to use new history**

Closes #ISSUE

Release Notes:

- N/A

Conrad Irwin created

159b5e9 agent2: Port `user_modifier_to_send` setting (#36550)

Click to expand commit body
Release Notes:

- N/A

Danilo Leal created

1e1110e thread_view: Increase click area of the user rules links (#36549)

Click to expand commit body
Release Notes:

- N/A

Danilo Leal created

6096040 thread view: Refine the UI a bit (#36504)

Click to expand commit body
Release Notes:

- N/A

---------

Co-authored-by: Agus Zubiaga <agus@zed.dev>

Danilo Leal and Agus Zubiaga created

fbba6ad docs: Document `global_lsp_settings.button` and remove duplicate docs for `lsp_highlight_debounce` (#36547)

Click to expand commit body
Follow up to this discussion:
https://github.com/zed-industries/zed/pull/36337

Release Notes:

- N/A

This will (gracefully) break links to
https://zed.dev/docs/configuring-zed#lsp-highlight-debounce-1 I don't
see anything show up for that on google or github search and I don't
think its load bearing.

---------

Co-authored-by: zumbalogy <3770982+zumbalogy@users.noreply.github.com>

zumbalogy and zumbalogy created

d273aca agent_ui: Add check to prevent sending empty messages in MessageEditor (#36545)

Click to expand commit body
Release Notes:

- N/A

Ben Brandt created

ceec258 Some clippy fixes (#36544)

Click to expand commit body
These showed up today, so just applied the simplifications, which were
mostly switching matches to if let

Release Notes:

- N/A

Ben Brandt created

cac80e2 Silence a bucketload of logs (#36534)

Click to expand commit body
Closes #ISSUE

Release Notes:

- Silenced a bunch of logs that were on by default

Conrad Irwin created

b12d862 Rename acp flag (#36541)

Click to expand commit body
Release Notes:

- N/A

Agus Zubiaga created

3996587 Add version detection for CC (#36502)

Click to expand commit body
- Render a helpful message when the installed CC version is too old
- Show the full path for agent binaries when the version is not recent
enough (helps in cases where multiple binaries are installed in
different places)
- Add UI for the case where a server binary is not installed at all
- Refresh thread view after installing/updating server binary

Release Notes:

- N/A

Cole Miller created

7c70439 Improve claude tools (#36538)

Click to expand commit body
- Return unified diff from `Edit` tool so model can see the final state
- Format on save if enabled
- Provide `Write` tool
- Disable `MultiEdit` tool
- Better prompting

Release Notes:

- N/A

Agus Zubiaga created

714c36f claude: Include all mentions and images in user message (#36539)

Click to expand commit body
User messages sent to Claude Code will now include the content of all
mentions, and any images included.

Release Notes:

- N/A

Agus Zubiaga created

ce21643 Refactor ssh remoting - make ChannelClient type private (#36514)

Click to expand commit body
This PR is one step in a series of refactors to prepare for having
"remote" projects that do not use SSH. The main use cases for this are
WSL and dev containers.

Release Notes:

- N/A

Max Brunsfeld created

82ac8a8 collab: Make `stripe_subscription_id` and `stripe_subscription_status` nullable on `billing_subscriptions` (#36536)

Click to expand commit body
This PR makes the `stripe_subscription_id` and
`stripe_subscription_status` columns nullable on the
`billing_subscriptions` table.

Release Notes:

- N/A

Marshall Bowers created

757b37f Hide old Agent UI when ACP flag set (#36533)

Click to expand commit body
- **Use key value store instead of JSON**
- **Default NewThread to the native agent when flagged**

Closes #ISSUE

Release Notes:

- N/A *or* Added/Fixed/Improved ...

Conrad Irwin created

ecee674 Attach minidump errors to uploaded crash events (#36527)

Click to expand commit body
We see a bunch of crash events with truncated minidumps where they have
a valid header but no events. We think this is due to an issue
generating them, so we're attaching the relevant result to the uploaded
tags.

Release Notes:

- N/A

Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>

Julia Ryan and Max Brunsfeld created

88754a7 Rebuild recently opened threads for ACP (#36531)

Click to expand commit body
Closes #ISSUE

Release Notes:

- N/A

Conrad Irwin created

88c4a5c Suspend macOS threads during crashes (#36520)

Click to expand commit body
This should improve our detection of which thread crashed since they
wont be able to resume while the minidump is being generated.

Release Notes:

- N/A

Julia Ryan created

5fb68cb agent2: Token count (#36496)

Click to expand commit body
Release Notes:

- N/A

---------

Co-authored-by: Agus Zubiaga <agus@zed.dev>

Bennet Bo Fenner and Agus Zubiaga created

6825715 Another batch of lint fixes (#36521)

Click to expand commit body
- **Enable a bunch of extra lints**
- **First batch of fixes**
- **More fixes**

Release Notes:

- N/A

Piotr Osiewicz created

69b1c6d Fix `workspace::SendKeystrokes` example in docs (#36515)

Click to expand commit body
Closes: https://github.com/zed-industries/zed/issues/25683

Remove two bad examples from the key binding docs.
`cmd-shift-p` (command palette) and `cmd-p` (file finder) are async
operations and thus do not work properly with
`workspace::SendKeystrokes`.

Originally reported in
https://github.com/zed-industries/zed/issues/25683#issuecomment-3145830534

Release Notes:

- N/A

Peter Tripp created

05fc0c4 Fix a bunch of other low-hanging style lints (#36498)

Click to expand commit body
- **Fix a bunch of low hanging style lints like unnecessary-return**
- **Fix single worktree violation**
- **And the rest**

Release Notes:

- N/A

Piotr Osiewicz created

df9c2ae thread_view: Fix issues with images (#36509)

Click to expand commit body
- Clean up failed load tasks for mentions that require async processing
- When dragging and dropping files, hold onto added worktrees until any
async processing has completed; this fixes a bug when dragging items
from outside the project

Release Notes:

- N/A

Cole Miller created