ee9b60e
gpui: Fix inset being used in SSD on Wayland (#35151)
Click to expand commit body
Closes #31330
Second parts of https://github.com/zed-industries/zed/pull/31335
While the initial fix set the inset during drawing, that was after the
window was resized, resulting in needing to manually resize the window
for the change to properly take effect.
I updated the code to not make the Wayland renderer rely on
`client_inset` being updated by the API user to match with the
decoration mode (given it is supposed to only be used when using CSD).
I might later try to generalize that, and eventually make the
client_inset only defined on window creation (instead of inside
`client_side_decorations`, that would need testing on X) (and maybe also
allow configuration for shadow, but it’s not something I need).
Release Notes:
- Fixed switching from client side decoration to server side decoration
on Wayland
marius851000
created
2a0aad0
Docs: Fix invalid JSON syntax in Visual Customizations - Editor Scrollbar and Minimap (#35159)
Click to expand commit body
I was on the [Visual Customiztions - Editor
Scrollbar](https://zed.dev/docs/visual-customization#editor-scrollbar)
section of the docs, and copy and pasted the code block into my personal
Zed settings and saw there was a syntax error.
This is a PR to add a missing comma and fix the syntax error in the
docs.
First time contributing, please let me know if I missed any
steps/important info.
Release Notes:
- N/A
lowlandghost
created
e7b5d93
docs: Add more improvements to the AI docs (#35160)
Click to expand commit body
Follow-up to https://github.com/zed-industries/zed/pull/35133 with some
more findings upon re-reviewing it again.
Release Notes:
- N/A
Danilo Leal
created
c995d45
agent_servers: Include result text in Claude error messages (#35156)
Click to expand commit body
This will better surfaces issues that are classified as "success" but
actually have a more meaningful error message attached.
Release Notes:
- N/A
Ben Brandt
created
a5b7cfd
agent_servers: Use built-in interrupt handling for Claude sessions (#35154)
Click to expand commit body
We no longer have to stop and restart the entire process.
I left in the Start/Resume mode handling since we will likely need to
handle restarting Claude in other situations.
Release Notes:
- N/A
This PR refactors the extension capability checks to be centralized in
the `CapabilityGranter`.
Release Notes:
- N/A
Marshall Bowers
created
290f84a
docs: Restructure and improve AI configuration docs (#35133)
Click to expand commit body
Adding a number of settings that weren't documented, restructuring
things a bit to separate what is model-related settings from agent panel
usage-related settings, adding the recently introduced `disable_ai` key,
and more.
Release Notes:
- Improved docs around configuring and using AI in Zed
Danilo Leal
created
08402e2
ui: Fix scrollbar mouse down handler (#35131)
Click to expand commit body
Follow-up to https://github.com/zed-industries/zed/pull/35121 - in the
process of adding the check for the left mouse button to the guard
(which was practically already there before, just not in the mouse-down
listener), I accidentally removed the negation for the bounds check.
This PR fixes this.
Release Notes:
- N/A
This PR does some minor cleanup to the scrollbar component. Namely, it
removes some clones, reduces the amount of unnecessary notifies and
ensures the scrollbar hover state is more accurately updated.
Release Notes:
- N/A
Finn Evers
created
4854f83
agent: Fix settings view switch field about permissions for running commands (#35120)
Click to expand commit body
Follow-up to https://github.com/zed-industries/zed/pull/34866, where I
mistakenly didn't update the copy and id for this item.
Closes https://github.com/zed-industries/zed/issues/34850 — that's
because the edit tool runs by default, but the terminal tool does not. I
updated the original copy to reflect this, which should be enough to
close the issue, given that in terms of behavior, it is working
correctly.
Release Notes:
- agent: Fixed duplicated settings item in the agent panel as well as
improve copy for the setting to allow running commands without
permission.
Follow-up to https://github.com/zed-industries/zed/pull/35104, with some
tiny design updates.
Release Notes:
- N/A
Danilo Leal
created
43d0aae
languages: Fix Bash indentation issues with multi-cursors, newlines, and keyword outdenting (#35116)
Click to expand commit body
Closes #34390
This PR fixes several Bash indentation issues:
- Adding indentation or comment using multi cursors no longer breaks
relative indentation
- Adding newline now places the cursor at the correct indent
- Typing a valid keyword triggers context-aware auto outdent
It also adds tests for all of them.
Release Notes:
- Fixed various issues with handling indentation in Bash.
Smit Barmase
created
07252c3
git: Enable git stash in git panel (#32821)
Click to expand commit body
Related discussion #31484
Release Notes:
- Added a menu entry on the git panel to git stash and git pop stash.
Preview:

---------
Co-authored-by: Cole Miller <cole@zed.dev>
Alvaro Parker
and
Cole Miller
created
4d00d07
Render paths to a single fixed-size MSAA texture (#34992)
Click to expand commit body
This is another attempt to solve the same problem as
https://github.com/zed-industries/zed/pull/29718, while avoiding the
regression on Intel GPUs.
### Background
Currently, on main, all paths are first rendered to an intermediate
"atlas" texture, similar to what we use for rendering glyphs, but with
multi-sample antialiasing enabled. They are then drawn into our actual
frame buffer in a separate pass, via the "path sprite" shaders.
Notably, the intermediate texture acts as an "atlas" - the paths are
laid out in a non-overlapping way, so that each path could be copied to
an arbitrary position in the final scene. This non-overlapping approach
makes a lot sense for Glyphs (which are frequently re-used in multiple
places within a frame, and even across frames), but paths do not have
these properties.
* we clear the atlas every frame
* we rasterize each path separately. there is no deduping.
The problem with our current approach is that the path atlas textures
can end up using lots of VRAM if the scene contains many paths. This is
more of a problem in other apps that use GPUI than it is in Zed, but I
do think it's an issue for Zed as well. On Windows, I have hit some
crashes related to GPU memory.
In https://github.com/zed-industries/zed/pull/29718, @sunli829
simplified path rendering to just draw directly to the frame buffer, and
enabled msaa for the whole frame buffer. But apparently this doesn't
work well on Intel GPUs because MSAA is slow on those GPUs. So we
reverted that PR.
### Solution
With this PR, we rasterize paths to an intermediate texture with MSAA.
But rather than treating this intermediate texture like an *atlas*
(growing it in order to allocate non-overlapping rectangles for every
path), we simply use a single fixed-size, color texture that is the same
size as thew viewport. In this texture, we rasterize the paths in their
final screen position, allowing them to overlap. Then we simply blit
them from the resolved texture to the frame buffer.
### To do
* [x] Implement for Metal
* [x] Implement for Blade
* [x] Fix content masking for paths
* [x] Fix rendering of partially transparent paths
* [x] Verify that this performs well on Intel GPUs (help @notpeter 🙏 )
* [ ] Profile and optimize
Release Notes:
- N/A
---------
Co-authored-by: Junkui Zhang <364772080@qq.com>
Max Brunsfeld
and
Junkui Zhang
created
bf8e427
Add a CI check that Cargo.lock is up to date (#35111)
Click to expand commit body
Should catch cases like #33667 where a dependency was bumped in
Cargo.toml without a corresponding lockfile update. (This can happen
when committing from outside of Zed or if rust-analyzer isn't running.)
Passing `--frozen --workspace` should ensure this doesn't fail just
because there's a newer patch version of some third-party dependency,
and prevent it from taking long.
We only need to run this on macOS because Cargo.lock is
platform-independent.
Release Notes:
- N/A
This PR updates the `Cargo.lock` file, as it seems like it wasn't fully
updated in https://github.com/zed-industries/zed/pull/35103.
Release Notes:
- N/A
ff67f18
Bump livekit dep to try to fix flaky builds (#35103)
Click to expand commit body
Let's see if https://github.com/zed-industries/livekit-rust-sdks/pull/6
helps.
Release Notes:
- N/A
---------
Signed-off-by: Cole Miller <cole@zed.dev>
Cole Miller
created
4abe14f
keymap ui: Resize columns on double click improvement (#35095)
Click to expand commit body
This PR improves the behavior of resetting a column's size by
double-clicking on its column handle. We now shrink/grow to the side
that has more leftover/additional space.
We also improved the below
1. dragging was a couple of pixels off to the left because we didn't
take the column handle’s width into account.
2. Column dragging now has memory and will shift things to their exact
position when reversing a drag before letting the drag handle go.
3. Improved our test infrastructure.
4. Double clicking on a column's header resizes the column
Release Notes:
- N/A
---------
Co-authored-by: Ben Kunkle <ben@zed.dev>
2f812c3
agent_ui: Fix delay when loading keybindings in the Agent panel settings (#34954)
Click to expand commit body
Fixes a annoying lag in agent settings panel where the keybindings would
show up after a lag. Close to 1-2 secs. It was a simple fix previously
we were not passing the focus handler to context menu which made the
keybindings lookup slower compared to other parts like git panel and
title bar profile dropdown.
| Before | After |
|--------|--------|
| <video
src="https://github.com/user-attachments/assets/1f9c1861-d089-41d3-8a89-4334d7b2f43a"
controls preload></video> | <video
src="https://github.com/user-attachments/assets/fa33d58d-a1ae-48cf-bff7-8e0ee07ed4e1"
controls preload></video> |
Release Notes:
- Fix delay when loading keybindings in the Agent panel settings
Umesh Yadav
created
993d575
docs: Add a missing "," in the C/C++ debugger configuration (#35098)
Click to expand commit body
Release Notes:
- N/A
Haojian Wu
created
abb3ed1
git: Fix commit modal contents being searchable (#35099)
985350f
terminal: Support ~ in cwd field of task definitions (#35097)
Click to expand commit body
Closes #35022
Release Notes:
- Fixed `~` not being expanded correctly in `cwd` field of task
definitions.
Piotr Osiewicz
created
0e9d955
Hide Copilot commands when AI functionality is disabled (#35055)
Click to expand commit body
Follow-up of https://github.com/zed-industries/zed/pull/34896
Related to https://github.com/zed-industries/zed/issues/31346
cc @rtfeldman
Release Notes:
- Hide copilot commands when AI functionality is disabled
Justin Su
created
5de544e
Fix unnecessary Ollama model loading (#35032)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/35031
Similar solution as in https://github.com/zed-industries/zed/pull/30589
Release Notes:
- Fix unnecessary ollama model loading
etimvr
created
f21ba9e
lmstudio: Propagate actual error message from server (#34538)
Click to expand commit body
Discovered in this issue: #34513
Previously, we were propagating deserialization errors to users when
using LMStudio, instead of the actual error message sent from the
LMStudio server. This change will help users understand why their
request failed while streaming responses.
Release Notes:
- lmsudio: Display specific backend error messaging on failure rather
than generic ones
---------
Signed-off-by: Umesh Yadav <git@umesh.dev>
Co-authored-by: Peter Tripp <peter@zed.dev>
Umesh Yadav
and
Peter Tripp
created
a2408f3
Don't separately rebuild crates for the build platform (#35084)
Click to expand commit body
macos:
- `cargo build`: 1838 -> 1400
- `cargo build -r`1891 -> 1400
linux:
- `cargo build`: 1893 -> 1455
- `cargo build -r`: 1893 -> 1455
windows:
- `cargo build`: 1830 -> 1392
- `cargo build -r`: 1880 -> 1392
We definitely want this change for debug builds, for release builds it's
_possible_ that it pessimizes the critical path, but we'll see if it
impacts CI times before merging.
Release Notes:
- N/A
---------
Co-authored-by: Rahul Butani <rrbutani@users.noreply.github.com>
This triggers a crash that avoids our panic-handler, which is useful for
testing that our crash reporting works even when you don't get a panic.
Release Notes:
- N/A
Julia Ryan
created
57b463f
typescript: Fix handling of jest/vitest tests with regex characters in name (#35090)
Click to expand commit body
Closes #35065
Release Notes:
- JavaScript/TypeScript tasks: Fixed handling of Vitest/Jest tests with
regex-specific characters in their name.
Piotr Osiewicz
created
631f9a1
worktree: Improve performance with large # of repositories (#35052)
Click to expand commit body
In this PR we've reworked how git status updates are processed. Most
notable change is moving the processing into a background thread (and
splitting it across multiple background workers). We believe it is safe
to do so, as worktree events are not deterministic (fs updates are not
guaranteed to come in any order etc), so I've figured that git store
should not be overly order-reliant anyways.
Note that this PR does not solve perf issues wholesale - other parts of
the system are still slow to process stuff (which I plan to nuke soon).
Related to #34302
Release Notes:
- Improved Zed's performance in projects with large # of repositories
---------
Co-authored-by: Anthony Eid <hello@anthonyeid.me>
6e4f747
project_panel: Fix autoscroll to treat entries behind sticky items as out of viewport (#35067)
Click to expand commit body
Closes #34831
Autoscroll centers items only if they’re out of viewport. Before this
PR, entry behind sticky items was not considered out of viewport, and
hence actions like `reveal in project panel` or focusing buffer would
not autoscroll that entry into the view in that case.
This PR fixes that by using recently added `scroll_to_item_with_offset`
in https://github.com/zed-industries/zed/pull/35064.
Release Notes:
- Fixed issue where `pane: reveal in project panel` action was not
working if the entry was behind sticky items.
Smit Barmase
created
4ee5243
Do not subtract gutter margin twice from the editor width (#34564)
Click to expand commit body
Closes #33176
In auto-height layouts, horizontal autoscroll can occur right before
soft wrapping is triggered. This seems to be caused by gutter margin
being subtracted twice from the editor width.
If we subtract gutter width only once, the horizontal autoscroll
behavior goes away.
Before:
https://github.com/user-attachments/assets/03b6687e-3c0e-4b34-8e07-a228bcc6f798
After:
https://github.com/user-attachments/assets/84e54088-b5bd-4259-a193-d9fcf32cd3a7
Release Notes:
- Fixes issue with auto-height layouts where horizontal autoscroll is
triggered right before text wraps
---------
Co-authored-by: MrSubidubi <finn@zed.dev>
Daniel Sauble
and
MrSubidubi
created
f78a112
gpui: Add `scroll_to_item_with_offset` to `UniformListScrollState` (#35064)
Click to expand commit body
Previously we had `ScrollStrategy::ToPosition(usize)` which lets you
define the offset where you want to scroll that item to. This is the
same as `ScrollStrategy::Top` but imagine some space reserved at the
top.
This PR removes `ScrollStrategy::ToPosition` in favor of
`scroll_to_item_with_offset` which is the method to do the same. The
reason to add this method is that now not just `ScrollStrategy::Top` but
`ScrollStrategy::Center` can also uses this offset to center the item in
the remaining unreserved space.
```rs
// Before
scroll_handle.scroll_to_item(index, ScrollStrategy::ToPosition(offset));
// After
scroll_handle.scroll_to_item_with_offset(index, ScrollStrategy::Top, offset);
// New! Centers item skipping first x items
scroll_handle.scroll_to_item_with_offset(index, ScrollStrategy::Center, offset);
```
This will be useful for follow up PR.
Release Notes:
- N/A
Smit Barmase
created
66acc26
git_hosting_providers: Support GitHub remote URLs that start with a slash (#34134)
Click to expand commit body
Remote URLs like `git@github.com:/zed-industries/zed` are valid git
remotes, but currently Zed does not parse them correctly. The result is
invalid "permalink" generation, and presumably other bugs anywhere that
git remote urls are required for the current repository. This ensures
Zed will parse those URLs correctly.
Release Notes:
- Improved support for GitHub remote urls where the
username/organization is preceded by an extra `/` to match the behavior
of `git`, `gh` and `github.com`.
Co-authored-by: Peter Tripp <peter@zed.dev>
Zachary Hamm
and
Peter Tripp
created
707df51
Fix environment loading with tcsh (#35054)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/34973
Fixes an issue where environment variables were not loaded when the
user's shell was tcsh and instead a file named `0` was dumped in the
current working directory with a copy of your environment variables as
json.
Follow-up to:
- https://github.com/zed-industries/zed/pull/35002
- https://github.com/zed-industries/zed/pull/33599
Release Notes:
- Fixed a regression with loading environment variables in nushell
Peter Tripp
created
13df1dd
Increase the number of parallel request handlers per connection (#35046)
Click to expand commit body
Discussed this with @ConradIrwin. The problem we're having with collab
is that a bunch of LSP requests take a really long time to resolve,
particularly `RefreshCodeLens`. But Those requests are sharing a limited
amount of concurrency that we've allocated for all message traffic on
one connection. That said, there's not _that_ many concurrent requests
made at any one time. The burst traffic seems to top out in the low
hundreds for these requests. So let's just expand the amount of space in
the queue to accommodate these long-running requests while we work on
upgrading our cloud infrastructure.
Release Notes:
- N/A
Co-authored-by: finn <finn@zed.dev>
Mikayla Maki
and
finn
created
1f7ff95
Fix environment loading with nushell (#35002)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/34739
I believe this is a regression introduced here:
- https://github.com/zed-industries/zed/pull/33599
Release Notes:
- Fixed a regression with loading environment variables in nushell
This will prepare us for running the protocol over MCP
Release Notes:
- N/A
---------
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Co-authored-by: Richard Feldman <oss@rtfeldman.com>
Agus Zubiaga
,
Ben Brandt
,
Conrad Irwin
, and
Richard Feldman
created
45ddf32
Fix variable name in project type reporting (#35045)
Follow-up of https://github.com/zed-industries/zed/pull/33417
* adjust prettier mock LSP to handle `shutdown` and `exit` messages
* removed another `?.log_err()` backtrace from logs and improved the
logging info
* always handle the last parts of the shutdown logic even if the
shutdown response had failed
Release Notes:
- N/A