662e196
Calculate the range for each color family in a theme (#2738)
Release Notes: - N/A (Internal theme stuff)
Nate Butler created
49f1f1c
Remove window when closing workspace in test
Nathan Sobo created
2c570fb
Move option button rendering to search_bar
Piotr Osiewicz created
343e9d0
Finish migration to modes for buffer search
Piotr Osiewicz created
fecea03
Add modes to buffer search
Piotr Osiewicz created
0374fdf
Move mode cycling to mode module
Piotr Osiewicz created
7547fa2
Move mode rendering to a search_bar module
Piotr Osiewicz created
31a5672
Move nav buttons generation to search_bar
Piotr Osiewicz created
c53554e
Remove SearchOptions::REGEX.
A bit WIP as it awaits migration of buffer search to modes
Piotr Osiewicz created
0ca29e5
Update keybinds to use new names
Piotr Osiewicz created
d497f27
Move ButtonSide to new module
Piotr Osiewicz created
95891d2
Move SearchMode and SearchHistory to separate modules
Piotr Osiewicz created
1aff642
Do not highlgiht selections at all over the threshold
Piotr Osiewicz created
dba2fac
Remove window via handles
Nathan Sobo created
f0da6b0
Remove TestAppContext::add_view
Instead, we now call this on window handles.
Nathan Sobo created
0f33223
Remove unused method
Nathan Sobo created
d687c3d
Merge remote-tracking branch 'origin/main' into window-handles
Nathan Sobo created
f2be318
Move window-related methods from TestAppContext to AnyWindowHandle
Nathan Sobo created
0197d49
Move activation simulation to AnyWindowHandle
Nathan Sobo created
486f5bc
Get compiling
Nathan Sobo created
2999063
Change collab panel icon
Max Brunsfeld created
371c669
Address review feedback.
Rename selected_rows to background_highlight_row_ranges. Do not return any ranges if there are more than 50k results
Piotr Osiewicz created
b0fc6da
Use display maps
Piotr Osiewicz created
241d395
Remove redundant argument
Piotr Osiewicz created
42e1221
Add upper bound limit. Remove dbg! statements
Piotr Osiewicz created
fa71de8
Tune UX for context menus
Co-authored-by: max <max@zed.dev>
Mikayla and max created
bedf60b
Improve local collaboration script to accept a zed impersonate
Gate channels UI behind a flag co-authored-by: max <max@zed.dev>
Mikayla and max created
8980a9f
Add settings for removing the assistant and collaboration panel buttons
Add a not-logged-in state to the collaboration panel co-authored-by: max <max@zed.dev>
Mikayla and max created
e37e76f
Add context menu controls to the channel member management
co-authored-by: Max <max@zed.dev>
Mikayla and Max created
fa16895
Do not query start of range if it's end is the same as the previous hunk's
Piotr Osiewicz created
ca21626
Baseline: Improve selection rendering for large quantities from 270ms to 90ms
Piotr Osiewicz created
9913067
Remove admin and member button
Fix bug with invites in the member list Fix bug when there are network errors in the member related RPC calls co-authored-by: Max <max@zed.dev>
Mikayla and Max created
7288be4
Make LspAdapter::process_diagnostics synchronous (#2829)
When editing rust code, the project diagnostics view sometimes fails to update, so that you have to close the view and re-open it to see the correct state. This PR fixes one possible cause of that problem. There was an async step in between *receiving* diagnostics from the language server and updating the diagnostics, due to an async call to `LspAdapter::process_diagnostics`. This could cause the following sequence of events to happen: 1. Rust-analyzer sends us new diagnostics for a file `a.rs` 2. We call `process_diagnostics` with those diagnostics 3. Rust-analyzer sends us a `WorkDoneProgress` message, indicating that the "flycheck" (aka `cargo check`) process has completed 4. We update the project diagnostics view due to this message. 5. The `process_diagnostics` call for `a.rs` completes 6. 💥 We have the new diagnostics for `a.rs`, but do not update the project diagnostics view again. This PR fixes this bug by simply making `process_diagnostics` synchronous. There is no I/O or expensive computation happening in that method. If we need to make it asynchronous in the future, we need to introduce a queue that ensures that `publishDiagnostics` and `workDoneProgress` messages are processed serially. Release Notes: - Fixed a bug where the project diagnostics view would sometimes fail to update properly when using Rust-analyzer.
Max Brunsfeld created
d417993
Add syntax highlighting for Cargo.toml files (#2830)
Release Notes: - Added syntax highlighting for `Cargo.toml` files
Joseph T. Lyons created
dbf25ea
Add syntax highlighting for Cargo.toml files
Joseph T. Lyons created
580c2ea
Fix test name
Joseph T. Lyons created
4e33654
Make LspAdapter::process_diagnostics synchronous
Co-authored-by: Nathan <nathan@zed.dev>
Max Brunsfeld and Nathan created
90cdbe8
Fix modal click throughs and adjust height for channel modal
Mikayla created
f1957b1
Push focus and fix keybindings
Mikayla created
3e0d0e5
WIP
Nathan Sobo created
c537cf2
Merge branch 'main' into collab-panel
Max Brunsfeld created
19eb280
Fix selection background too
Refactor code to centralize the logic too
Conrad Irwin created
7a1f404
Add dismiss button to project search
Piotr Osiewicz created
d4d3261
WIP
Nathan Sobo created
adc5046
WIP
Nathan Sobo created
e3a4d17
Fix bash `path_suffixes `and add `cmd-/` line comment support (#2827)
<img width="1608" alt="SCR-20230806-cyrg" src="https://github.com/zed-industries/zed/assets/19867440/2491c4bc-5797-4417-9633-08c136b4e8fe"> I noticed we weren't highlghting bash files if the shebang line didn't exist. After checking, it looks like the `.` were accidentally added to the `path_suffixes` list. This PR fixes that and adds in support for `cmd-/` to trigger line comments. <img width="1608" alt="SCR-20230806-czxh" src="https://github.com/zed-industries/zed/assets/19867440/37dd0c8e-c4e7-49e2-9997-9dd8145f460e"> Release Notes: - Fixed a bug where shell files weren't syntax highlighted if a shebang didn't exist. - Added support for `cmd-/` to add line comments to shell files.
Joseph T. Lyons created
ef5b982
Fix bash path_suffixes and add line_comment
Joseph T. Lyons created
dcf8b00
WIP
Nathan Sobo created
7777d97
Expand empty selections to cover full word when doing case conversions and fix bugs (#2826)
When doing case conversions, specifically in the case of an empty selection, in both VS Code and Sublime, the cursor winds up being in a different place relative to where it started. In VS Code, the cursor maintains it position in the text, no matter if the text expands or shrinks https://github.com/zed-industries/zed/assets/19867440/b24f5d86-c315-4a72-9ed4-3732b490ea9a In Sublime, I have no idea what is going on: https://github.com/zed-industries/zed/assets/19867440/05f21303-6e42-47b2-b844-7accd0bf05d7 I thought it would be a better experience if, when doing an empty selection transformation, we simply expand the selection and park the cursor at the end of the newly-transformed text. https://github.com/zed-industries/zed/assets/19867440/833619ef-04e2-47b6-ad4e-e2b43d54fb2b This feels similar to us expanding the selection when doing line manipulations: https://github.com/zed-industries/zed/assets/19867440/c30c5332-787d-4cf0-a9ee-e66c3c159956 Selections are adjusted to match however each word expands and shrinks, even when there are multiple: https://github.com/zed-industries/zed/assets/19867440/d7073aac-8a59-4f2c-b0e5-1df37be1694c Release Notes: - Improved behavior of empty-selection case transformations by selecting resulting word. - Fixed some bugs with overflow
Joseph T. Lyons created
1abb6a0
Expand empty selections to cover full word and fix bugs
Joseph T. Lyons created