99b776b
Fix possibility of infinite loop in selections_with_autoclose_regions (#3138)
Click to expand commit body
Previously, that method could loop forever if the editor's autoclose
regions had unexpected selection ids.
Something must have changed recently that allowed this invariant to be
violated, but regardless, this code should not have relied on that
invariant to terminate like this.
* on opening a language server's logs, a new editor for server logs is
now created from `\n`-joined `VecDeque` elements instead of a buffer, as
before
* every `VecDeque` entry is a log line we receiver out of stderr or LSP
server, and their general amount is capped with `let
MAX_STORED_LOG_ENTRIES: usize = 2000;`
* currently opened editor with logs (`Editor::multi_line`) keeps getting
log lines appended and may get over this cap, but only last stored 2000
entries will be restored on reopen
* similarly, cap rpc message logs
Release Notes:
- Improved memory usage by storing less language LSP server and rpc logs
251cd22
Fix panic when following due to disconnected channel notes views (#3124)
Click to expand commit body
In addition to fixing a panic, this makes it slightly more convenient to
re-open disconnected channel notes views. I didn't make it automatic,
but it will at least replace the previous, disconnected view.
Release Notes:
- Fixed a crash that sometimes occurred when following someone with a
disconnected channel notes view open.
Max Brunsfeld
created
e63d86e
Update diagnostics indicator when diagnostics are udpated (#3128)
7a39455
Fix inclusion of spurious views from other projects in FollowResponse (#3116)
Click to expand commit body
A logic error in https://github.com/zed-industries/zed/pull/2993 caused
follow responses to sometimes contain extra views for other unshared
projects 😱 . These views would generally fail to deserialize on the
other end. This would create a broken intermediate state, where the
following relationship was registered on the server (and on the leader's
client), but the follower didn't have the state necessary for following
into certain views.
Release Notes:
- Fixed a bug where following would sometimes fail if the leader had
another unshared project open.
Max Brunsfeld
created
96d60ef
Fix inclusion of spurious views from other projects in FollowResponse
Max Brunsfeld
created
19f774a
Update channel rooms to be ephemeral (#3115)
Click to expand commit body
This fixes a bug that was introduced by
https://github.com/zed-industries/zed/pull/3093, which assumed that
rooms for channels where ephemeral, by making rooms for channels
ephemeral.
Release Notes:
- N/A
Remove redundant live kit initialization code
Fix bug in recent channel links changes where channel rooms would have the incorrect release set
co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
co-authored-by: Max <max@zed.dev>
This pull request essentially reverts #3067: we noticed that only using
the function signatures produces far worse results in codegen, and so
that feels like a regression compared to before. We should re-enable
this once we have a smarter approach to fetching context during codegen,
possibly when #3097 lands.
As a drive-by, we also fixed a longstanding bug that caused codegen to
include the final line of a selection even if the selection ended at the
start of the line.
Ideally, I'd like to hot fix this to preview so that it goes to stable
during the weekly release.
/cc: @KCaverly @nathansobo
Release Notes:
- N/A
Antonio Scandurra
created
b366592
Don't include start of a line when selection ends at start of line
Antonio Scandurra
created
5cf9298
Revert summarizing file content until we can be more intelligent about what we send
Release notes:
- `mute_on_join` setting now defaults to false.
- Right click on a channel to "Copy Channel Link", these links work to
open Zed and auto-join the channel
Blocked on: https://github.com/zed-industries/zed.dev/pull/388
Conrad Irwin
created
1db24e5
Omit history files with path that does not exist on disk anymore (#3113)
Kirill Bulatov
created
639ae67
Omit history files with path that does not exist on disk anymore
Kirill Bulatov
created
1a4e9ec
Truncate Discord release note text (#3112)
Click to expand commit body
Hopefully this works the first time 😅
Release Notes:
- N/A
6e98cd5
More small following-related fixes (#3110)
Max Brunsfeld
created
1d29709
Avoid possible panic in Room::most_active_project
Click to expand commit body
Participants' locations might momentarily reference projects that have already been unshared.
Max Brunsfeld
created
bdcbf9b
Add a Reconnect action, for simulating connection blips
Max Brunsfeld
created
b807b3c
Handle participants' participant index changing
Click to expand commit body
This normally doesn't happen, but it can happen if a participant
loses connection ungracefully, restarts their app, and then
explicitly joins again.
Max Brunsfeld
created
90b54a4
Log a warning when leader activates an unknown view
Max Brunsfeld
created
bb85d6f
Detect file paths that end with `:` (#3109)
Click to expand commit body
New rustc messages look like
```
thread 'tests::test_history_items_vs_very_good_external_match' panicked at crates/file_finder/src/file_finder.rs:1902:13:
assertion `left == right` failed: Only one history item contains collab_ui, it should be present and others should be filtered out
left: 0
right: 1
```
now and we fail to parse that `13:` bit properly, fix that.
One caveat is that we highlight the entire word including the trailing
`:`:
<img width="914" alt="image"
src="https://github.com/zed-industries/zed/assets/2690773/d653a8ff-3e6e-4e3d-b6ea-dad0c8db0f06">
this is unfortunate, but better than nothing (as now).
This is due to the fact, that we detect words with regex inside the
`terminal.rs` and send events to other place that's able to check paths
for existence (and whether that's a path at all), currently there's no
way to detect a path and sanitize it in `terminal.rs`
Release Notes:
- N/A
New rustc messages look like
```
thread 'tests::test_history_items_vs_very_good_external_match' panicked at crates/file_finder/src/file_finder.rs:1902:13:
assertion `left == right` failed: Only one history item contains collab_ui, it should be present and others should be filtered out
left: 0
right: 1
```
now and we fail to parse that `13:` bit properly, fix that.
Kirill Bulatov
created
6b710dc
Fix bug that allowed following multiple people in one pane (#3108)
Click to expand commit body
I've also simplified the representation of a workspace's leaders, so
that it encodes in the type that there can only be one leader per pane.
Release Notes:
- Fixed a bug where you could accidentally follow multiple collaborators
in one pane at the same time.
Max Brunsfeld
created
0823a18
Ignore history items' paths when matching search queries (#3107)
af90077
Add failing test for switching leaders in a pane
Max Brunsfeld
created
9cba459
Ignore history items' paths when matching search queries
Kirill Bulatov
created
29ccdb3
Unify the two local zed scripts, take a flag for an instance count (#3106)
Click to expand commit body
This PR introduces a new script for running Zed against a local collab
server, called `script/zed-local`. This script replaces the two existing
scripts that we had for this purpose: `script/zed-with-local-servers`
and `script/start-local-collaboration`.
By default, the script starts one single instance of Zed, but you can
pass a numeric flag to start 1, 2, 3 or 4 instances. So to start up two
instances side by side, (like `start-local-collaboration` script), you'd
do this:
```
script/zed-local -2
```
But you can also start *three* (or even four) instances, each taking up
a quarter of the screen, like this:
```
script/zed-local -3
```
Like before, you can pass other arguments to the script, and they will
be passed through to the first zed instance.
Also, unlike the `start-local-collaboration` script, this script now
requires a call to GitHub to determine your GitHub username. It just
logs you in as Nathan by default, unless you set `ZED_IMPERSONATE`
explicitly.
Max Brunsfeld
created
1e4f514
Update docs to refer to new zed-local script
Max Brunsfeld
created
a0ab9fe
Unify the 2 local zed scripts, take a flag for instance count
I just panicked and wanted to see the cause, but forgot that panic files
get deleted when Zed uploads them.
Release Notes:
- Panics are now written to `~/Library/Logs/Zed/Zed.log`
Max Brunsfeld
created
044701e
Add a `crate-dep-graph` script, remove a few unnecessary dependencies (#3103)
Click to expand commit body
This was motivated by me trying to decide which crate I should put a
`NotificationStore` in.
Run `script/crate-dep-graph` to generate an SVG showing the dependency
graph of our `crates` folder, and open it in a web browser.
After running this command, I noticed a couple of dependencies that
didn't make sense and were easy to remove.
Current dependency graph:
