Commit log

927d18b Add support for resizing splits and docks, as well as utilities (#3595)

Click to expand commit body 
Making this PR to upstream changes to util and GPUI2, resizing exists
but isn't working yet.

Release Notes:

- N/A

Mikayla Maki created

cb8109a Remove some debug styles

Mikayla created

4942b19 Moar tests

Conrad Irwin created

f03c0f6 Add double click handling

Mikayla created

d1805d8 First round of vim tests

Conrad Irwin created

f12510b Defer drawing the window until the CoreAnimation `displayLayer:` method is called (#3592)

Click to expand commit body 
GPUI (both 1 and 2) currently performs rendering, layout, and painting
at the end of every effect cycle. This leads to poor performance when
the app receives events more frequently than the display refreshes. Such
rapid events can come from a terminal, an LSP, or a mouse with a high
polling rate.

This PR changes GPUI so that we don't render until the OS notifies us
that the content will be presented, via the `displayLayer:` callback.

Because render, layout, and paint have side effects that are sometimes
relied on in tests, we currently keep the old behavior (drawing after
every effects cycle) in tests.

This is similar to what @ForLoveOfCats explored in
https://github.com/zed-industries/zed/pull/3542, but slightly simpler,
in that we're not using the display link. As a follow-up, we could use
the display link to start rendering earlier, to possibly reduce latency
further.

Max Brunsfeld created

41f55e4 Use `tab.inactiveForeground` from VS Code for muted text color (#3593)

Click to expand commit body 
This PR updates the `theme_importer` to pull in the
`tab.inactiveForeground` color from VS Code to use as the muted text
color.

Release Notes:

- N/A

Marshall Bowers created

fdcb413 Fix unused field warning

Max Brunsfeld created

f02a3e8 Fix inactive tab styles (the verbose way) (#3591)

Click to expand commit body 
This PR fixes the inactive tab style to properly show the label using
the muted text color.

I went about fixing this in the most direct way possible, but the
solution leaves a lot to be desired, IMO. I plan to explore some ideas
on how we can improve the state of styling the tab content without
having the same styles repeated all over the place and subsequently
out-of-sync.

Release Notes:

- N/A

Marshall Bowers created

fbfe108 Avoid double borrow in tests by drawing windows explicitly in `flush_effects`

Click to expand commit body 
Co-authored-by: Antonio <antonio@zed.dev>

Max Brunsfeld and Antonio created

fcbc18a vim-flight entertainment (#3574)

Click to expand commit body 
- vim2 compiling (but mostly commented out)
- More code written, similar lack of workingness so far

Still todo:
[ ] Figure out the focus/blur stuff
[ ] Uncoment more code
[ ] Fix VimTestContext
[ ] Uncomment the tests

Release Notes:

- N/A

Conrad Irwin created

9b94f14 Redraw the window at the end of `flush_effects` in tests

Click to expand commit body 
Co-Authored-By: Max Brunsfeld <max@zed.dev>

Antonio Scandurra and Max Brunsfeld created

906505f Fix rustfmt in feedback_modal.rs

Joseph T. Lyons created

f1ebad2 Defer drawing the scene until macOS's `display_layer` callback

Click to expand commit body 
Co-Authored-By: Max Brunsfeld <max@zed.dev>

Antonio Scandurra and Max Brunsfeld created

f35453c COmment out tests again for now

Conrad Irwin created

7f4d03f Fix color for selections in scrollbar (#3590)

Click to expand commit body 
This PR fixes an issue where we weren't using the right color for
displaying selections within the scrollbar.

Release Notes:

- N/A

Marshall Bowers created

22e9903 Use copy button for copy channel link (#3589)

Click to expand commit body 
Release Notes:

- N/A

Joseph T. Lyons created

3198eb6 Merge branch 'main' into splits

Mikayla created

9a36402 Use copy button for copy channel link

Joseph T. Lyons created

10b015c Style scrollbars with theme colors (#3588)

Click to expand commit body 
This PR updates the styling of scrollbars in the editor to use the theme
colors.

Release Notes:

- N/A

Marshall Bowers created

cd2abc7 Adjust nightly to build twice a day

Joseph T. Lyons created

8ed642d Clear out easy todo!()s

Conrad Irwin created

fe46459 Pull more scrollbar colors from VS Code

Marshall Bowers created

6add173 Style scrollbar when using diff markers

Marshall Bowers created

3271cf1 Map scrollbar colors from VS Code themes

Marshall Bowers created

89884d2 Pull scrollbar colors from theme

Marshall Bowers created

dd42adc Remove warnigns

Conrad Irwin created

b9bbc4a Extend theme colors (#3587)

Click to expand commit body 
[[PR Description]]

Title

Release Notes:

- N/A

Nate Butler created

af7c93b Merge branch 'main' into vim2

Conrad Irwin created

c97c9f9 Revert actions! changes

Conrad Irwin created

76cea3e Fire click event only when using left button (#3584)

Click to expand commit body 
Release Notes:

- N/A

Antonio Scandurra created

ea9a42b Add new colors to themes

Click to expand commit body 
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>

Nate Butler and Marshall Bowers created

59d0fea actions3 (#3586)

Click to expand commit body 
- Fix action registrations

Release Notes:

- N/A

Conrad Irwin created

b8f9918 Add new colors to One Dark

Click to expand commit body 
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>

Nate Butler and Marshall Bowers created

b66b491 Merge branch 'main' into vim2

Conrad Irwin created

6792a21 Add new color defs

Nate Butler created

d678efe Fix some action registrations

Conrad Irwin created

bc130fd Project search2 (#3585)

Click to expand commit body 
Semantic search and tests are gonna be shipped in a separate PR.

Release Notes:

- N/A

Piotr Osiewicz created

01ecbec Comment out the tests

Piotr Osiewicz created

ddbd5cf Merge branch 'main' into project_search2

Piotr Osiewicz created

40c1ef8 Add Editor::Tab and CycleMode actions

Piotr Osiewicz created

0b7072b Fire click event only when using left button

Antonio Scandurra created

9f1e7a1 fixup! Further warnings churn

Piotr Osiewicz created

d4a246c Further warnings churn

Piotr Osiewicz created

3c49011 Fix up warnings (automatic)

Piotr Osiewicz created

7330495 Make match index 1-based

Piotr Osiewicz created

3f87c35 Make the query editor expand in size less

Piotr Osiewicz created

66e0650 Forego using dispatch_action for click handlers

Piotr Osiewicz created

db39c3d Fix porting mistake that caused clicking on the editor to misbehave (#3583)

Click to expand commit body 
We used `width` instead of `height` in the "pixels-to-point" conversion
code, which would cause clicks to not work correctly when the width was
smaller than the `y` coordinate.

Release Notes:

- N/A

Antonio Scandurra created

fdc0ef8 Maintain focus correctly when activating panes in zed2 (#3582)

Click to expand commit body 
Previously, before emitting a `Focus` event from the pane inside of the
`focus_in` listener, we would erroneously check whether the pane's focus
handle was _not_ focused. However, by the time the pane was notified of
being "focused in", the focus handle would already be focused, which was
preventing the pane from ever emitting a `Focus` event. In turn, this
would cause the workspace to not maintain the active pane correctly.

This pull request maintains an explicit `was_focused` boolean as part of
the `Pane` state, which ensures we only emit the `Focus` event the first
time the pane receives focus.

As part of this, I also reworked how the outline view gets deployed to
allow clicking breadcrumbs even when the corresponding pane doesn't have
focus.

Release Notes:

- N/A

Antonio Scandurra created