ee8e145
Fix drag and drop logic in div's mouse handling
Click to expand commit body
* Attach mouse up and mouse move listeners immediately, not just when there
is already a drag in progress, because when starting a drag, these other
events may fire before the next frame.
* Remove bounds checks for handling mouse move and mouse events, since a
dragged object may be moved outside of its original container.
Co-authored-by: Nathan Sobo <nathan@zed.dev>
This PR styles the project share notification, so we're not staring a
red rectangle.
<img width="425" alt="Screenshot 2023-12-18 at 6 06 14 PM"
src="https://github.com/zed-industries/zed/assets/1486634/7ae9a2d3-d5d9-427c-9125-3a47df5f6a2f">
Release Notes:
- N/A
Marshall Bowers
created
912f7e6
Add ability to warn on missing theme values (#3705)
Click to expand commit body
This PR adds the ability to warn in the `theme_importer` when a theme is
missing values.
Providing the `--warn-on-missing` flag to the `theme_importer` will
print a warning for missing theme value when printing the theme.
```sh
cargo run -p theme_importer -- --warn-on-missing
```
Release Notes:
- N/A
Marshall Bowers
created
734bbfa
Use status colors for contact availability indicators (#3704)
Click to expand commit body
This PR updates the availability indicators in the contact list to use
the status colors from the theme.
Release Notes:
- N/A
This PR centers the text "Code at the speed of thought" on the welcome
screen.
Release Notes:
- N/A
Marshall Bowers
created
0aa690f
Always show channel toggle when collapsed (#3698)
Click to expand commit body
This PR makes the channel toggle disclosure always visible when a
channel tree is collapsed, as opposed to just being visible on hover.
This makes it possible to visually identify collapsed channel trees
without having to hover over each entry.
Release Notes:
- N/A
Marshall Bowers
created
f143467
Update collab panel signed out state (#3697)
Click to expand commit body
[[PR Description]]
Before:
After:
One known issue:
The "Sign in to enable collaboration" text below the button should be
centered, but it looks like label is reserving the full width. Need to
look in to that.
Release Notes:
- N/A
d72cd37
Fix implementation of full_width and icon_position in button
Nate Butler
created
5900b81
Remove unimplemented toggling for project search entries (#3695)
Click to expand commit body
This PR removes the unimplemented toggling of search results in the
project search.
This is new functionality that didn't exist in Zed1, and it's likely
that we won't be adding it before launch, so removing it for now.
Release Notes:
- N/A
[[PR Description]]
This PR styles wrap guides. Wrap guides weren't being added to the theme
in the theme importer, and they were also missing from One Dark.
One Dark:
Gruvbox:
Bad border (known importer issue):
No border (known importer issue):
Release Notes:
- N/A
4707248
Revert accidental merge of old version of workspace2 render function (#3694)
Click to expand commit body
Something happened with my local diff and
https://github.com/zed-industries/zed/pull/3691 somehow contained an old
version of workspace2's render function. Perhaps I rebased at some point
and borked it? Not sure 🤷♀️
Release Notes:
- N/A
Julia
created
a623929
Add backtrace hash to collab server panic api (#3692)
11e6578
Fix worktree panic for out-of-worktree files being opened (#3690)
Click to expand commit body
Fixes
https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1702865855729989
Release Notes:
- Fixed certain files excluded from worktrees causing panics when being
opened
Kirill Bulatov
created
7e21e0f
Do not panic on non-worktree file indexing
Kirill Bulatov
created
4e54454
Introduce an `Arena` to allocate and deallocate frame-related structs more cheaply (#3689)
Click to expand commit body
Picture worth a thousand words:
Note how having an area makes a substantial amount of frames between
0.5ms and 1ms faster (15-20% faster frames).
Release Notes:
- N/A
Antonio Scandurra
created
5a4e2e6
Use a closure to allocate structs onto the `Arena`
Click to expand commit body
This is a trick borrowed from Bumpalo that helps LLVM understand
it should instantiate the object directly on the heap, as opposed to
doing so on the stack and then moving it.
* Follow command didn't work, because follow task was dropped
* An extra div prevented titlebar facepiles from rendering correctly
Max Brunsfeld
created
b5ae2f0
Remove div around all avatars in titlebar facepile
Max Brunsfeld
created
a4cdf36
Fix accidental drop of following task. Add back FollowNextCollaborator
Max Brunsfeld
created
54eb452
Only apply scroll correction in `uniform_list` when already scrolled (#3687)
Click to expand commit body
This PR fixes an issue where the scroll correction added to the uniform
list in a35fdf45fc9de57b7696c4deacbc62c49b26a516 was being applied even
if the list wasn't scrolled at all.
This manifested in the project panel starting with an incorrect scroll
offset that would disappear once scrolled.
It seems like we should only need to apply this scroll correction when
the list is already scrolled.
Release Notes:
- N/A
This PR fixes the channel filter in the collab panel not showing up.
Release Notes:
- N/A
Marshall Bowers
created
c8e9186
Don't scroll List on scroll wheel events outside of its bounds (#3685)
Max Brunsfeld
created
149a718
Don't scroll List on scroll wheel events outside of its bounds
Max Brunsfeld
created
ee77728
Add `--release` flag to `script/zed-local` (#3684)
Click to expand commit body
This PR adds support for the `--release` flag to `script/zed-local`.
This allows you to run a local build of Zed in release mode, which can
be useful when needing to profile things or do other performance work.
Release Notes:
- N/A
* Fix a bug where a pane's leader info was not rendered if the pane was
part of a split
* Fix a crash when zooming a pane, due to duplicate render of that view.
Max Brunsfeld
created
170e332
Add support for `--release` flag to `zed-local` script