Commit log

ae32706 Fix tests

Antonio Scandurra created

ba0d7e3 Set window edited

Antonio Scandurra created

4b74f30 Properly restore termina current dir when deserializing the project

Kirill Bulatov created

2979eb9 Allow transparent divs to be considered "top layers"

Click to expand commit body 
This changes the meaning of `was_top_layer` so that it is checking that
nothing opaque is on top of the given layer. The layer in question
need not be opaque.

Max Brunsfeld created

b88370d Respect a div's own z-index when adding its event listeners

Max Brunsfeld created

ee8e145 Fix drag and drop logic in div's mouse handling

Click to expand commit body 
* Attach mouse up and mouse move listeners immediately, not just when there
  is already a drag in progress, because when starting a drag, these other
  events may fire before the next frame.
* Remove bounds checks for handling mouse move and mouse events, since a
  dragged object may be moved outside of its original container.

Co-authored-by: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

e6f3731 Fix position of right dock handle

Click to expand commit body 
Co-authored-by: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

91f1be2 Style project share notification (#3706)

Click to expand commit body 
This PR styles the project share notification, so we're not staring a
red rectangle.

<img width="425" alt="Screenshot 2023-12-18 at 6 06 14 PM"
src="https://github.com/zed-industries/zed/assets/1486634/7ae9a2d3-d5d9-427c-9125-3a47df5f6a2f">

Release Notes:

- N/A

Marshall Bowers created

912f7e6 Add ability to warn on missing theme values (#3705)

Click to expand commit body 
This PR adds the ability to warn in the `theme_importer` when a theme is
missing values.

Providing the `--warn-on-missing` flag to the `theme_importer` will
print a warning for missing theme value when printing the theme.

```sh
cargo run -p theme_importer -- --warn-on-missing
```

Release Notes:

- N/A

Marshall Bowers created

734bbfa Use status colors for contact availability indicators (#3704)

Click to expand commit body 
This PR updates the availability indicators in the contact list to use
the status colors from the theme.

Release Notes:

- N/A

Marshall Bowers created

64ceb61 Add pane dividers (#3703)

Click to expand commit body 
This PR adds dividers between panes in a split.

Release Notes:

- N/A

Marshall Bowers created

6da0fa9 Add toolbar spacing (#3702)

Click to expand commit body 
[[PR Description]]

Release Notes:

- N/A

Nate Butler created

a286ec4 Update toolbar.rs

Nate Butler created

9785481 Make `Disclosure` accept an ID (#3701)

Click to expand commit body 
This PR makes the `Disclosure` component accept an ID rather than using
a static ID for all disclosures.

Release Notes:

- N/A

Marshall Bowers created

9cd8e99 Update toolbar.rs

Nate Butler created

2ae39b7 Add left side padding

Nate Butler created

4fdf6a8 Wire up offline contact list (#3700)

Click to expand commit body 
This PR wires up the offline contact list.

Also enables toggling both the online and offline contact lists.

Release Notes:

- N/A

Marshall Bowers created

c9893ce Use flex_1 div instead of justify_center in toolbar

Nate Butler created

d058515 Use a different frame arena for each window (#3696)

Click to expand commit body 
This fixes a panic that was caused by sharing the same frame allocator
for different windows.

Release Notes:

- N/A

Nathan Sobo created

0000e68 Remove unused Arena::sized method

Max Brunsfeld created

37efe82 Use a different frame arena for all elements

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Max Brunsfeld <max@zed.dev>

Antonio Scandurra , Nathan Sobo , and Max Brunsfeld created

98f5a3d Center text on welcome screen (#3699)

Click to expand commit body 
This PR centers the text "Code at the speed of thought" on the welcome
screen.

Release Notes:

- N/A

Marshall Bowers created

0aa690f Always show channel toggle when collapsed (#3698)

Click to expand commit body 
This PR makes the channel toggle disclosure always visible when a
channel tree is collapsed, as opposed to just being visible on hover.

This makes it possible to visually identify collapsed channel trees
without having to hover over each entry.

Release Notes:

- N/A

Marshall Bowers created

f143467 Update collab panel signed out state (#3697)

Click to expand commit body 
[[PR Description]]

Before: 

![CleanShot 2023-12-18 at 13 10
14@2x](https://github.com/zed-industries/zed/assets/1714999/a0e536c3-b5bf-45e2-893b-89b1ae7b4c47)

After:

![CleanShot 2023-12-18 at 13 10
36@2x](https://github.com/zed-industries/zed/assets/1714999/5d66a4a9-cc19-420d-82c7-58ec5cd264e4)

One known issue:

The "Sign in to enable collaboration" text below the button should be
centered, but it looks like label is reserving the full width. Need to
look in to that.

Release Notes:

- N/A

Nate Butler created

9d014b0 Remove comment

Nate Butler created

89b231a Update collab panel signed out state

Nate Butler created

cef9aa3 Use a different frame arena for each window

Click to expand commit body 
Co-Authored-By: Max Brunsfeld <max@zed.dev>
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra , Max Brunsfeld , and Nathan Sobo created

eeaa1e5 Add github icon

Nate Butler created

d72cd37 Fix implementation of full_width and icon_position in button

Nate Butler created

5900b81 Remove unimplemented toggling for project search entries (#3695)

Click to expand commit body 
This PR removes the unimplemented toggling of search results in the
project search.

This is new functionality that didn't exist in Zed1, and it's likely
that we won't be adding it before launch, so removing it for now.

Release Notes:

-  N/A

Marshall Bowers created

5c7de10 Style wrap guides (#3693)

Click to expand commit body 
[[PR Description]]

This PR styles wrap guides. Wrap guides weren't being added to the theme
in the theme importer, and they were also missing from One Dark.

One Dark:

![CleanShot 2023-12-18 at 11 16
48@2x](https://github.com/zed-industries/zed/assets/1714999/5578127f-8d69-4f47-af60-c44de87331e0)

Gruvbox:

![CleanShot 2023-12-18 at 11 17
38@2x](https://github.com/zed-industries/zed/assets/1714999/a2ac5db9-e5bf-4452-9f9d-49f074231587)

Bad border (known importer issue):

![CleanShot 2023-12-18 at 11 17
49@2x](https://github.com/zed-industries/zed/assets/1714999/37d11e37-38b6-4001-aef0-19fc2d925425)

No border (known importer issue):

![CleanShot 2023-12-18 at 11 18
14@2x](https://github.com/zed-industries/zed/assets/1714999/3d74bd8c-514e-4e14-94db-425a39d057ab)


Release Notes:

- N/A

Nate Butler created

196df1c Start on collab panel empty state

Nate Butler created

4707248 Revert accidental merge of old version of workspace2 render function (#3694)

Click to expand commit body 
Something happened with my local diff and
https://github.com/zed-industries/zed/pull/3691 somehow contained an old
version of workspace2's render function. Perhaps I rebased at some point
and borked it? Not sure 🤷‍♀️

Release Notes:

- N/A

Julia created

a623929 Add backtrace hash to collab server panic api (#3692)

Click to expand commit body 
Release Notes:

- N/A

Joseph T. Lyons created

da7628c Style wrap guides for imported themes

Nate Butler created

b46f5be Style One Dark wrap guides

Nate Butler created

7cd6825 Add backtrace hash to collab server panic api

Joseph T. Lyons created

02bcc7b Add release channel to zed2 collab server

Joseph T. Lyons created

488073d Unbork project search focus (#3691)

Click to expand commit body 
I got a little too clever for my own good with these focus handles
originally lol

Release Notes:

- N/A

Julia created

b4042fe Unbork project search focus

Julia created

11e6578 Fix worktree panic for out-of-worktree files being opened (#3690)

Click to expand commit body 
Fixes
https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1702865855729989

Release Notes:

- Fixed certain files excluded from worktrees causing panics when being
opened

Kirill Bulatov created

7e21e0f Do not panic on non-worktree file indexing

Kirill Bulatov created

4e54454 Introduce an `Arena` to allocate and deallocate frame-related structs more cheaply (#3689)

Click to expand commit body 
Picture worth a thousand words:


![before-after](https://github.com/zed-industries/zed/assets/482957/0aa92baf-f1cd-485e-a234-6d8f8b63a79a)

Note how having an area makes a substantial amount of frames between
0.5ms and 1ms faster (15-20% faster frames).

Release Notes:

- N/A

Antonio Scandurra created

5a4e2e6 Use a closure to allocate structs onto the `Arena`

Click to expand commit body 
This is a trick borrowed from Bumpalo that helps LLVM understand
it should instantiate the object directly on the heap, as opposed to
doing so on the stack and then moving it.

Antonio Scandurra created

29c6061 Fix following bugs (#3688)

Click to expand commit body 
* Follow command didn't work, because follow task was dropped
* An extra div prevented titlebar facepiles from rendering correctly

Max Brunsfeld created

b5ae2f0 Remove div around all avatars in titlebar facepile

Max Brunsfeld created

a4cdf36 Fix accidental drop of following task. Add back FollowNextCollaborator

Max Brunsfeld created

54eb452 Only apply scroll correction in `uniform_list` when already scrolled (#3687)

Click to expand commit body 
This PR fixes an issue where the scroll correction added to the uniform
list in a35fdf45fc9de57b7696c4deacbc62c49b26a516 was being applied even
if the list wasn't scrolled at all.

This manifested in the project panel starting with an incorrect scroll
offset that would disappear once scrolled.

It seems like we should only need to apply this scroll correction when
the list is already scrolled.

Release Notes:

- N/A

Marshall Bowers created

5447c6d Fix channel filter input (#3686)

Click to expand commit body 
This PR fixes the channel filter in the collab panel not showing up.

Release Notes:

- N/A

Marshall Bowers created

c8e9186 Don't scroll List on scroll wheel events outside of its bounds (#3685)

Max Brunsfeld created