a3968c5
Fix rendering of diagnostic blocks (#4232)
Click to expand commit body
- Distinct colors to make it not confusing
- Avoid overflowing the edge of the editor when the message is long
Release Notes:
- Improved display of diagnostic blocks (F8)
Conrad Irwin
created
880d330
Clear selected index when updating file finder's matches
Max Brunsfeld
created
1b12437
Render file finder separator in a way that doesn't affect layout
Click to expand commit body
Previously, while typing, the separator appearing and disappeaering would
cause the layout of the items below to jump up and down.
Reverts zed-industries/zed#4226
Unfortunately there where some worse states possible after this PR.
Reverting until after the launch, as the problems it addresses are still
bad.

- Distinct colors to make it not confusing
- Avoid overflowing the edge of the editor when the message is long
Conrad Irwin
created
f2ff7fa
chore: Change AGPL-licensed crates to GPL (except for collab) (#4231)
Click to expand commit body
- [x] Fill in GPL license text.
- [x] live_kit_client depends on live_kit_server as non-dev dependency,
even though it seems to only be used for tests. Is that an issue?
Release Notes:
- N/A
Piotr Osiewicz
created
9f6072c
Revert "Improve completion, action and shared project popovers' layout"
Mikayla Maki
created
b20b1d4
Revert search in gitignored files in file finder (#4229)
Click to expand commit body
Reverts
https://github.com/zed-industries/zed/pull/3748/commits/2f56fe9129e98520ee9ffbc79c38f0d01ae4ca4d
since gitignored file indexing is inconsistent.
Release Notes:
- Removed the ability to search in gitignored files via file_finder for
now, as it's not consistent enough for good UX
Kirill Bulatov
created
e6573e9
Revert search in gitignored files in file finder
Kirill Bulatov
created
db22bab
CI: Do not run cargo check --tests before running the tests (#4228)
Click to expand commit body
This is a bit redundant, as cargo test does not reuse results of cargo
check, so we're essentially doing the cargo check unnecessarily.
Release Notes:
- N/A
Piotr Osiewicz
created
2d7d071
Use a different color for ignored files in the project panel (#4227)
Click to expand commit body

Release Notes:
- Fixed an issue where ignored files were not visually distinguished in
the project panel.
Max Brunsfeld
created
4e970e9
Use a different color for ignored files in the project panel
Max Brunsfeld
created
7ec68e0
Improve completion, action and shared project popovers' layout (#4226)
Click to expand commit body
Before:
* cutoff completion labels and docs
<img width="801" alt="image"
src="https://github.com/zed-industries/zed/assets/2690773/12fe39b2-a8a7-42d8-b697-e2a4fbd836b7">
* too long action labels start to introduce newlines and break the
layout
<img width="716" alt="image"
src="https://github.com/zed-industries/zed/assets/2690773/a0530f1e-4200-4cc4-8e0f-9a63d04e4d5c">
* too long completion proposals are cut off
<img width="1321" alt="image"
src="https://github.com/zed-industries/zed/assets/2690773/1ec154a1-9de5-4e47-9e9f-632b3e33f42a">
After:
* the docs are shifted, but both completions and docs are rendered
entirely now
<img width="1351" alt="image"
src="https://github.com/zed-industries/zed/assets/2690773/ddb0baa4-88b6-45e9-b3e1-496c0d6a0d0f">
*
<img width="750" alt="image"
src="https://github.com/zed-industries/zed/assets/2690773/102ed77c-d7d0-41d2-a4a0-a8c73285ea8a">
* completions are not jumping in sized anymore, with all elements
aligned to occupy max elements' width and height
<img width="1459" alt="image"
src="https://github.com/zed-industries/zed/assets/2690773/483e3534-b00a-423c-a848-3c4ca1199510">
Release Notes:
- Improved completion and action label layouts
Kirill Bulatov
created
bf35b78
Allow both action and completion lists to occupy max width and height of its element
This PR removes an unused screenshot from the `assets/` directory.
As a note, we should probably be careful about what kinds of extraneous
binary assets we're committing to the repo (especially ones not required
for Zed itself), as these can bloat the repo size.
Release Notes:
- N/A
Marshall Bowers
created
74bdb48
Make completions menu to occupy more space
Click to expand commit body
* make completion elements as wide as the longest element
* make completion docs scrollable
co-authored-by: Piotr <piotr@zed.dev>
Kirill Bulatov
and
Piotr
created
c4a028d
Make `was_top_layer_under_active_drag` more closely match logic of `was_top_layer` (#4222)
8ce7594
Drop active searchable item subscription when changing active item (#4220)
Click to expand commit body
We were leaking the previous active item's subscription, which meant
that we would receive the `MatchesInvalidated` event as many times as we
changed items.
Release Notes:
- Fixed a performance issue when switching the active item while the
search bar was open.
Antonio Scandurra
created
21d6751
Make `was_top_layer_under_active_drag` more closely match logic of `was_top_layer`
b151e12
Drop active searchable item subscription when changing active item
Click to expand commit body
We were leaking the previous active item's subscription, which meant
that we would receive the `MatchesInvalidated` event as many times as
we changed items.
Co-Authored-By: Thorsten Ball <thorsten@zed.dev>
Co-Authored-By: Mikayla Maki <mikayla@zed.dev>
Antonio Scandurra
,
Thorsten Ball
, and
Mikayla Maki
created
61dfec2
Add keymatch modes so terminal can have cmd-k (#4219)
Click to expand commit body
This isn't my favorite idea of a fix, but it does work for now, and it
seems likely the terminal will need to configure other aspects of action
dispatch in the future.
In the future we should explore making it possible to do this via the
keymap, either by making disabling bindings more robust; or by having a
way to indicate immediate mode per binding.
Release Notes:
- Fixed a bug where cmd-k in terminal took 1s
Conrad Irwin
created
21e6b09
Remove license-file from Cargo.toml as it is apparently redundant (#4218)
Click to expand commit body
Release Notes:
- N/A
Piotr Osiewicz
created
056da0a
Add keymatch modes so terminal can have cmd-k
Click to expand commit body
This isn't my favorite idea of a fix, but it does work for now, and it
seems likely the terminal will need to configure other aspects of action
dispatch in the future.
In the future we should explore making it possible to do this via the
keymap, either by making disabling bindings more robust; or by having a
way to indicate immediate mode per binding.
Conrad Irwin
created
5ea3119
Add missing license for derive_refineable (#4217)
- GPUI and all dependencies: Apache 2
- Everything else: AGPL
Here's a script that I've generated for it:
https://gist.github.com/osiewicz/6afdd6626e517da24a2092807e6f0b6e
Release Notes:
- N/A
---------
Co-authored-by: David <david@zed.dev>
Piotr Osiewicz
and
David
created
edfc2e8
Make scripts/histogram ignore lines without frame duration (#4214)
Click to expand commit body
Previously the script would choke on lines generated, for example, by
`cargo run`.
This just skips lines that don't contain `frame duration:`.
Release Notes:
- N/A
003073d
Fix scroll jitter by ignoring autoscroll events if following (#4216)
Click to expand commit body
When following someone else we saw jitter because
`ScrollPositionChanged` events were battling `SelectionsChanged` events,
both of which were scrolling the viewport.
This ignores the ScrollPositionChanged if autoscrolling is on.
Release Notes:
- Fixed jittery scrolling when following someone else that had a bigger
viewport.
Thorsten Ball
created
030b20a
Fix scroll jitter by ignoring autoscroll events if following
Click to expand commit body
When following someone else we saw jitter because
`ScrollPositionChanged` events were battling `SelectionsChanged` events,
both of which were scrolling the viewport.
This ignores the ScrollPositionChanged if autoscrolling is on.
Co-authored-by: Antonio <antonio@zed.dev>
Co-authored-by: Julia <julia@zed.dev>
Thorsten Ball
,
Antonio
, and
Julia
created
0db9c27
Make scripts/histogram ignore lines without frame duration
Click to expand commit body
Previously the script would choke on lines generated, for example, by
`cargo run`.
This just skips lines that don't contain `frame duration:`.
Co-authored-by: Antonio <antonio@zed.dev>
Thorsten Ball
and
Antonio
created
a802bb2
Fix horizontal scroll going too far to the left (#4213)
Click to expand commit body
Previously one could scroll infinitely to the left. This clams it to 0.
Release Notes:
- Fixed horizontal scroll possibly going too far to the left.
Antonio Scandurra
created
c8c605d
Fix horizontal scroll going too far to the left
Click to expand commit body
Previously one could scroll infinitely to the left. This clams it to 0.
Co-authored-by: Antonio <antonio@zed.dev>
Fixes
* LSP servers never being shut down on worktree release
* worktrees (and LSP servers) being re-created for settings files on
every opening
Also,
* removes `async` from `workspace_configuration` to simplify the code:
we only return static configurations now
Release Notes:
- Fixed excessive LSP server creation for Zed settings files
Kirill Bulatov
created
5e0cabc
Create a special worktree for settings files
Click to expand commit body
To avoid LSP server restarts/leaks when those are being opened
co-authored-by: Piotr <piotr@zed.dev>
Kirill Bulatov
and
Piotr
created
fc7458d
Trim diagnostic messages to fix rendering bug (#4210)
Click to expand commit body
Before this change a diagnostic message with a trailing newline (e.g.
`line1\nline2\n`) would be rendered in a `Block` with `line_height: 2`.
But the content we then display in this block had 3 "lines", which
pushed the content out of the block.
This fixes the issue by trimming the newlines at the end from the
diagnostics.
Release Notes:
- Fixed rendering multi-line diagnostic errors inside of the editor.
Thorsten Ball
created
accb4f8
Cache last used layer_id for StackingOrder (#4211)
Click to expand commit body
This optimizes rendering time by saving computation of the layer_id and
comparison when inserting it into the `BTreeMaps`.

Release Notes:
- Improved rendering performance when a lot of text is being displayed.