4e54454
Introduce an `Arena` to allocate and deallocate frame-related structs more cheaply (#3689)
Click to expand commit body
Picture worth a thousand words:

Note how having an area makes a substantial amount of frames between
0.5ms and 1ms faster (15-20% faster frames).
Release Notes:
- N/A
Antonio Scandurra
created
5a4e2e6
Use a closure to allocate structs onto the `Arena`
Click to expand commit body
This is a trick borrowed from Bumpalo that helps LLVM understand
it should instantiate the object directly on the heap, as opposed to
doing so on the stack and then moving it.
* Follow command didn't work, because follow task was dropped
* An extra div prevented titlebar facepiles from rendering correctly
Max Brunsfeld
created
b5ae2f0
Remove div around all avatars in titlebar facepile
Max Brunsfeld
created
a4cdf36
Fix accidental drop of following task. Add back FollowNextCollaborator
Max Brunsfeld
created
54eb452
Only apply scroll correction in `uniform_list` when already scrolled (#3687)
Click to expand commit body
This PR fixes an issue where the scroll correction added to the uniform
list in a35fdf45fc9de57b7696c4deacbc62c49b26a516 was being applied even
if the list wasn't scrolled at all.
This manifested in the project panel starting with an incorrect scroll
offset that would disappear once scrolled.
It seems like we should only need to apply this scroll correction when
the list is already scrolled.
Release Notes:
- N/A
This PR fixes the channel filter in the collab panel not showing up.
Release Notes:
- N/A
Marshall Bowers
created
c8e9186
Don't scroll List on scroll wheel events outside of its bounds (#3685)
Max Brunsfeld
created
149a718
Don't scroll List on scroll wheel events outside of its bounds
Max Brunsfeld
created
ee77728
Add `--release` flag to `script/zed-local` (#3684)
Click to expand commit body
This PR adds support for the `--release` flag to `script/zed-local`.
This allows you to run a local build of Zed in release mode, which can
be useful when needing to profile things or do other performance work.
Release Notes:
- N/A
* Fix a bug where a pane's leader info was not rendered if the pane was
part of a split
* Fix a crash when zooming a pane, due to duplicate render of that view.
Max Brunsfeld
created
170e332
Add support for `--release` flag to `zed-local` script
[[PR Description]]
TODO:
- [x] Style fold marker
- [x] Editor - Code action icon too large, should use muted color,
should have tooltip
- [ ] Style inline assistant
- Prompt text gets cut off veritcally
- [x] Line height on inline assist editor isn't tall enough
- Nate: This is my fault due to the line height (relative: 1) we are
setting on non-buffer editors. I'll look into this.
- [ ] Style diagnostic hover (right now it's an opaque box on some
themes)
- Nate: This needs status tints, we are working on it
- [ ] Hovering over a symbol shows a dialogue that appears underneath
the scroll-bar
Release Notes:
- N/A
This PR fixes an issue with the toolbar width introduced in #3666.
The lack of a flex container was making the toolbar contents not take up
the full width, and thus not positions items correctly along its main
axis.
Release Notes:
- N/A
487edcb
Rework collab panel rendering to use `gpui::list` (#3678)
Click to expand commit body
This PR reworks the rendering of the collab panel to use `gpui::list`,
so that we don't render any items that are not visible on the screen.
In the process we also fixed some bugs in the channel list:
- Fixed the context menu for channels not deploying when activated via
keyboard
- Fixed drag and drop for channels
- Made it so when navigating the collab panel via keyboard the list only
scrolls enough to reveal the next item when navigating to an item that
is currently off-screen
Release Notes:
- N/A
Also add the ability to unnest a channel by dragging it to the "Channels"
header. This is currently not working due to a collab server issue.
Co-authored-by: Max <max@zed.dev>
Marshall Bowers
and
Max
created
d0dbf8e
Fix bug where vim commands were copied on each update_matches
Click to expand commit body
In zed1, the array of commands was recalculated on every update_matches,
In zed2 it's cached before we change the focus.
Conrad Irwin
created
a40f04b
Only scroll enough to reveal the next channel if it isn't visible