Commit log

d147db1 Don't mark interactive element as active if default prevented

Antonio Scandurra created

5018072 Automatically transfer focus on mouse down in `Interactivity::paint`

Antonio Scandurra created

19e842b fix overlay positions (#3621)

Click to expand commit body 
- Fix typo in overlay positioning code
- Make overlay positioning more robust

Release Notes:

- N/A

Conrad Irwin created

e91ecec fix modal exchange (#3620)

Click to expand commit body 
- Fix opening GoToLine from Command
- Extend test to cover go_to_line behavior too

Release Notes:

- N/A

Conrad Irwin created

a055a4c Make overlay positioning more robust

Click to expand commit body 
Previously we would either switch anchor or snap, now we first try switching
anchor (if desired) and then snap to window regardless.

Conrad Irwin created

fa36adb Fix typo in overlay positioning code

Conrad Irwin created

979db25 Extend test to cover go_to_line behavior too

Click to expand commit body 
(It's also been broken and fixed a few times along the way)

Conrad Irwin created

a2f0acc Fix opening GoToLine from Command

Click to expand commit body 
This was broken because of the async hop introduced by should_dismiss.

Change that API to instead be syncronous, and require that implementors
(of which there is only one) to call dismiss again if they want to.

Conrad Irwin created

c94c661 vim2 (#3619)

Click to expand commit body 
Fix vim command tests by restoring the spawn in command palette's
confirm


Release Notes:

- N/A

Conrad Irwin created

630997d And restore the command palette spawn behaviour

Conrad Irwin created

b651294 vim2 (#3618)

Click to expand commit body 
- Uncomment editor event tests
- Uncomment vim search tests

Just command left

Release Notes:

- N/A

Conrad Irwin created

1a86e4f Fix vim toggle on welcome

Conrad Irwin created

a934926 hah, oops

Conrad Irwin created

573377d Fix workspace sizing (#3617)

Click to expand commit body 
This PR fixes the sizing of the workspace, specifically with regards to
the center pane.

This fixes the issue where the tab bar would get clipped when its width
exceeded the size of the screen.

<img width="1298" alt="Screenshot 2023-12-12 at 8 36 15 PM"
src="https://github.com/zed-industries/zed/assets/1486634/592d7c6d-6901-4bd4-b5e7-e30bcad67e21">

Release Notes:

- N/A

Marshall Bowers created

a656d11 Fix vim2 search tests

Conrad Irwin created

e09b07d Allow dragging tabs (#3616)

Max Brunsfeld created

6362221 Scroll the tab bar to show the active tab

Click to expand commit body 
Co-authored-by: Nathan <nathan@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld , Nathan , and Marshall created

a579713 Allow dragging and dropping tabs

Click to expand commit body 
Co-authored-by: Nathan <nathan@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld , Nathan , and Marshall created

a4a5016 Start work on dragging tabs

Max Brunsfeld created

2e00da5 zed2 notification panel (#3603)

Click to expand commit body 
Release Notes:

- N/A

Julia created

5f5b86e Use release channel display name for feedback (#3615)

Click to expand commit body 
Release Notes:

-  N/A

Joseph T. Lyons created

29413bc Fix defer handle double lease

Click to expand commit body 
Co-Authored-By: Conrad Irwin <conrad@zed.dev>

Julia and Conrad Irwin created

a63b4c5 Use release channel display name for feedback

Joseph T. Lyons created

3088cbe Uncomment vim search tests

Conrad Irwin created

c43969e Uncomment editor event tests

Conrad Irwin created

51ceb52 Fix borked layout

Julia created

c9aa4a0 Fix placeholder text

Joseph T. Lyons created

e489e2e Enable scrolling in tab bar (#3614)

Click to expand commit body 
This PR enables scrolling horizontally in the tab bar.

Currently this requires holding down <kbd>Shift</kbd> for the scroll to
activate. We'll need to look into this.

Scrolling also currently works when there is a split in the editor, as
the non-split view goes down a different rendering path that does not
constrain the pane width, which breaks a number of things.

Release Notes:

- N/A

Marshall Bowers created

01d4e71 Get notifications rendering in panel

Julia created

d3eff63 Panel showing up

Julia created

d2feaa4 Extract `TabBar` component (#3613)

Click to expand commit body 
This PR extracts a new `TabBar` component from the tab bar
implementation in the workspace.

Release Notes:

- N/A

Marshall Bowers created

31a4892 Avoid notifying editor when wrap width changes (#3612)

Click to expand commit body 
Wrap width is already assigned from within draw. It can be called
multiple times as taffy iteratively computes the layout.

This fixes a hang we were seeing in nightly when opening the chat panel.

Max Brunsfeld created

f5ca514 Avoid notifying editor when wrap width changes

Click to expand commit body 
Wrap width is already assigned from within draw. It can be called multiple
times as taffy iteratively computes the layout.

Co-authored-by: Nathan <nathan@zed.dev>

Max Brunsfeld and Nathan created

2a22208 Project search2 tests (#3611)

Click to expand commit body 
Release Notes:

- N/A

Piotr Osiewicz created

b3e1514 Avoid caching zed build script if git state has changed (#3610)

Click to expand commit body 
@as-cii and @SomeoneToIgnore noticed a bug where Zed nightly would
continuously report that an update was available. This nightly
auto-update logic depends on the `ZED_COMMIT_SHA` constant, which is
compiled into the app via an rustc environment variable that is assigned
in the `zed2` build script.

I think the bug was caused by the `zed2` build script's output being
cached on our CI, when building the nightly app bundle. The result was
that the `publish-nightly` action updated the "current SHA" for nightly,
but uploaded an artifact whose `ZED_COMMIT_SHA` was cached from an
earlier version.

I've added a line to the `build.rs` that triggers a rerun if the
`.git/logs/HEAD` file has been changed. I think this should prevent the
unwanted caching.

Max Brunsfeld created

52e72d9 Builds and runs

Julia created

e3ed3b8 Avoid caching zed build script if git state has changed

Max Brunsfeld created

fd6320b Finish fixing up Avatar using URI

Julia created

e53b9f5 Fix Div::active not working

Click to expand commit body 
Somehow a condition got inverted and caused the bug.

Antonio Scandurra created

3567036 Remove `focus_listeners` from `Interactive`

Click to expand commit body 
We're not using these anymore.

Antonio Scandurra created

44d4062 Start changing Avatar to use URI

Click to expand commit body 
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>

Julia and Antonio Scandurra created

cc97b04 Buffer search channel notes (#3608)

Click to expand commit body 
We were registering `deploy` only on editors, which did succeed for
channel notes; however, channel note does not have an associated
workspace (that we pulled from the editor). It made more sense to just
register these actions for a workspace, notwithstanding the editor.

This PR also fixes a bunch of cx.dispatch_action calls to call the
handler directly instead (e.g. instead of dispatching ReplaceNext we
just call buffer_search_bar.replace_next instead) as otherwise these
actions are not handled if the buffer search bar does not have the
focus.

Release Notes:

- N/A

Piotr Osiewicz created

a334a21 Prevent panes from overflowing the window (#3609)

Click to expand commit body 
This PR fixes an issues where it was possible for panes to overflow the
window (for instance, by having a large number of tabs in the tab bar).

Release Notes:

- N/A

Marshall Bowers created

c0846d6 Set cursor style only if we're the active window (#3607)

Click to expand commit body 
Release Notes:

- N/A

Antonio Scandurra created

13f9fec fixup! Move away from using cx.dispatch_action in buffer search

Piotr Osiewicz created

be57059 Move away from using cx.dispatch_action in buffer search

Piotr Osiewicz created

b87c45e Set cursor style only if we're the active window

Antonio Scandurra created

4684440 Fix focus issues with gpui2 docks (#3606)

Click to expand commit body 
* Fixed dock toggling not focusing the terminal element
* Fixed loosing focus on dock close (e.g. cmd-d on the last terminal in
the dock)
* Removed element stateless focus API since it would not work when the
element is not rendered, update all API usages to the stateful one via
`gpui::Subscription`

Release Notes:

- N/A

Kirill Bulatov created

0140bb8 Fix the tests

Click to expand commit body 
Co-authored-by: Antonio <antonio@zed.dev>

Kirill Bulatov and Antonio created

ca8e8d1 Finish removing all dangerous focus APIs

Kirill Bulatov created