Commit log

469b056 Fix a few identity mixups in GPUI

Click to expand commit body
co-authored-by: nathan <nathan@zed.dev>

Mikayla and nathan created

7e7a778 Move CallFactory into AppState

Click to expand commit body
Fix crash caused by double borrow of window handle

Piotr Osiewicz created

e557eb4 Fix no window showing up on startup

Click to expand commit body
co-authored-by: Marshall <marshall@zed.dev>

Mikayla and Marshall created

663bbb0 WIP

Mikayla created

abe5a9c Finish up decoupling workspace from call

Piotr Osiewicz created

a94cf54 Fix storybook (#3379)

Click to expand commit body
This PR fixes storybook and gets it back into a compiling and running
state.

Release Notes:

- N/A

Marshall Bowers created

ebccdb6 Move CallHandler impl into call2

Piotr Osiewicz created

170291f Start decoupling workspace and call crates

Piotr Osiewicz created

6fe7b22 UI refinements + Popover (#3377)

Click to expand commit body
[[PR Description]]

- Update default ui_font_size
- Update toolbar style
- Start on ui::Popover

Release Notes:

- N/A

Nate Butler created

1b05aad Extract `Story` into separate `story` crate (#3378)

Click to expand commit body
This PR extracts the `Story` component into a separate `story` crate so
that it can be shared among various crates that define stories.

Release Notes:

- N/A

---------

Co-authored-by: Nate Butler <iamnbutler@gmail.com>

Marshall Bowers and Nate Butler created

40a49e6 Update popover doc

Click to expand commit body
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>

Nate Butler and Marshall Bowers created

9a145a4 Correctly position popover aside, add list item states

Click to expand commit body
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>

Nate Butler and Marshall Bowers created

9f2e3ba Allow popover to take an aside

Click to expand commit body
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>

Nate Butler and Marshall Bowers created

dac7912 Start on popover

Nate Butler created

f4b4bdf ui2: Get component stories compiling again (#3376)

Click to expand commit body
This PR gets the component stories defined in `ui2` compiling again.

Release Notes:

- N/A

Marshall Bowers created

f04deeb Document InteractionState

Nate Butler created

f2c6378 Merge branch 'main' into editor2-autocomplete

Click to expand commit body
# Conflicts:
#	crates/editor2/src/editor.rs

Antonio Scandurra created

bec6112 Update toolbar.rs

Nate Butler created

6cd0bcc Fix panic when opening settings in zed2 (#3375)

Click to expand commit body
This PR fixes a panic that occurs when opening the settings in zed2.

We store the `ThemeRegistry` as a global without wrapping it in an
`Arc`, so we need to retrieve it the same way.

Release Notes:

- N/A

Marshall Bowers created

6d6aa3b Update default ui font settings

Nate Butler created

79c890f `ui2` cleanup (#3374)

Click to expand commit body
[[PR Description]]

Tidies up the `ui2` crate, removing all components we aren't using and
doing a bit of reorganization.

Release Notes:

- N/A

Nate Butler created

209fb10 Remove stories mod until it is re-enabled

Nate Butler created

8947438 Update elevation

Nate Butler created

453aa5f `TextColor` -> `Color`

Nate Butler created

56d45e7 Add Shape enum to avatar component, refactor UITextSize to styles/typography.rs

Nate Butler created

205607a Clean out UI

Nate Butler created

b427500 Search2 (#3332)

Click to expand commit body
This is just a buffer search (without project search), as the latter
needs a multibuffer from `editor`
Release Notes:

- N/A

Piotr Osiewicz created

361801e WIP: Remove V parameter on elements (#3366)

Click to expand commit body
This is an exploration of what it would take to remove the `V` generic
from the element type. Answer: less than I expected.

I added a new struct to GPUI2: `CallbackHandle<Event>`, and reworked the
interactivity related APIs to take this type. I also added a
`.callback()` function to `ViewContext` that can construct a
`CallbackHandle` to wrap our current `|&mut View, &Evt, &mut
ViewContext| {...}` based APIs. With these two changes, we can now
capture the context of the callsite of a click handler, allowing us to
capture all relevant types and data _before_ sending them into GPUI.
This lets us achieve a similar programing style to the existing system,
while also letting us remove all of the generics from the entire element
system. For an example of what this looks like in practice, here's a
side by side diff of the test in `interactive.rs` (which compiles and
passes):

<img width="1310" alt="Screenshot 2023-11-19 at 7 32 08 PM"
src="https://github.com/zed-industries/zed/assets/2280405/596f2a9a-9c8e-4158-bf6d-0003cf973015">

Note how the new arrangement of types is more amenable to rust's type
inference, allowing the code to be just as terse as before despite the
extra function call in the middle.

This approach also allows components to provide well typed APIs to
views, without ever knowing that view's type. This PR includes an
example rewrite of the button component in `ui2`, here's what it's
struct could look like now:

<img width="1105" alt="Screenshot 2023-11-19 at 7 24 28 PM"
src="https://github.com/zed-industries/zed/assets/2280405/fc98d3c2-6831-4c0f-a324-ab0fae33b0bc">

However, I have not yet ported the derive macro for Component to this
new structure, as I know @nathansobo is currently reworking that code.

Once that macro has been rewritten, it should be relatively easy to
rewrite the rest of Zed2 with this approach, the only major difference
that I can foresee is that the editor element would need to wrap it's
operations in an update callback. Though I can think of a few ways to
fix this with a new `ViewElement` trait, that does the wrapping for you.

Mikayla Maki created

2138715 Merge remote-tracking branch 'origin/callback-handles' into search2

Piotr Osiewicz created

a844bf7 Fix stories

Click to expand commit body
co-authored-by: Piotrek <piotr@zed.dev>

Mikayla and Piotrek created

3e32986 Brave new world awaits

Click to expand commit body
Co-authored-by: Mikayla <mikayla@zed.dev>

Piotr Osiewicz and Mikayla created

54a3b56 Merge remote-tracking branch 'origin/callback-handles' into search2

Piotr Osiewicz created

8049ec6 Fix last thing

Conrad Irwin created

5c0f2e7 Remove all the settings

Conrad Irwin created

3e2dba3 Merge branch 'main' into callback-handles

Conrad Irwin created

3096222 Add `deploy-docs` script (#3373)

Click to expand commit body
[[PR Description]]

Adds `script/deploy-docs`:
- If you don't already have it, it will clone the `zed-docs` repo into
`../zed-docs`
    - It will build the docs and output them in `../zed-docs`
    - Then it will open the docs.
- By default this "dry runs" (doesn't push) but you can pass `-p` to
push the changes.
    - If you add `-c` it will clean out the old docs before running.
    
If you run the script with `p` it will push up the changes, and vercel
will automatically deploy them.

Release Notes:

- N/A

Nate Butler created

8b6b7e6 borrow less

Conrad Irwin created

a83d626 Make the script a bit more resilient

Nate Butler created

2c4d83c WIP

Click to expand commit body
co-authored-by: conrad <conrad@zed.dev>
co-authored-by: Nathan <nathan@zed.dev>

Mikayla , conrad , and Nathan created

a87ffa5 Add more crates

Nate Butler created

3210d36 Create deploy-docs

Nate Butler created

652e3b0 Rename `ListEntry` to `ListItem` (#3371)

Click to expand commit body
This PR renames the `ListEntry` component to `ListItem` to better
reflect its intent.

Release Notes:

- N/A

Marshall Bowers created

daddb03 Remove comments

Joseph T. Lyons created

a0dcc96 Mark app event as `open` if we fail to get installation_id

Click to expand commit body
If we find a previous installation_id, then we send `open`. If we don't find a previous installation_id, then we sent as `first open`. If we fail, we mark it as `open` so that we don't accidentally bloat our `first open` stats.

Joseph T. Lyons created

db3f487 Fix zed2 compile error

Joseph T. Lyons created

0926db9 Add app events

Joseph T. Lyons created

4f4ef4a More fixes for zed nightly (#3370)

Click to expand commit body
When running `script/bundle` with the new `-2` flag, we needed to adjust
the fat-binary creation step to look for the binary called `Zed2`.

We also fixed a source of intermittent build failures in `script/bundle`
due to running multiple `swift build` processes concurrently for the
`live_kit_client2` crate, building for the two architectures.

Release Notes:

NA

Max Brunsfeld created

2731855 Fix error when building live_kit_client2 for two architectures concurrently

Click to expand commit body
Co-authored-by: Julia <julia@zed.dev>

Max Brunsfeld and Julia created

eb307b2 Rework `List` to use `children` (#3369)

Click to expand commit body
This PR reworks the `List` component to use `children` instead of
accepting a `Vec<ListItem>` in its constructor.

This is a step towards making the `List` component more open.

Release Notes:

- N/A

Marshall Bowers created

6985b70 fix gpui2

Mikayla created