90db278
Prevent `ArenaRef` from being cloned (#3738)
Click to expand commit body
This could cause multiple mutable references to be acquired for the same
arena element, which is unsafe. I didn't see it cause problems in
practice, but I realized this could have been a problem and fixed it
before it bit us.
Release Notes:
- N/A
Antonio Scandurra
created
636c12e
Style signed-out and empty states for the notification panel
Migrate project picker/vcs menu to use popover_menu.
Release Notes:
- N/A
Piotr Osiewicz
created
ed5a9eb
Fix sluggish experience when dragging tabs (#3731)
Click to expand commit body
The problem was caused by a missing call to `WindowContext::notify` when
moving the mouse. Actually, we *did* notify as part of a
`MouseMoveEvent` listener registered in `Interactivity` but that code
path was never exercised because we were clearing the
`pending_mouse_down`.
This pull request fixes the issue by automatically redrawing the window
in gpui when there is an active drag and the mouse moves.
Release Notes:
- N/A
Antonio Scandurra
created
00927db
Fix sluggish experience when dragging tabs
Click to expand commit body
The problem was caused by a missing call to `WindowContext::notify` when
moving the mouse. Actually, we *did* notify as part of a `MouseMoveEvent`
listener registered in `Interactivity` but that code path was never
exercised because we were clearing the `pending_mouse_down`.
This commit fixes the issue by automatically redrawing the window in gpui
when there is an active drag and the mouse moves.
Antonio Scandurra
created
dfed171
Ensure that new view observers are called by WindowContext::replace_root_view (#3730)
Click to expand commit body
This fixes a bug where the window got into a bad, non-interactive state
when opening a project from an empty window.
Max Brunsfeld
created
c81e89a
Ensure that new view observers are called by WindowContext::replace_root_view
Previously, all of the lines in a multi-line error message were painted
on top of each other. I also simplified the logic for highlighting
backtick-enclosed ranges in a diagnostic message.
This PR styles the pane drop targets using the `drop_target_background`
color from the theme.
We do have to adjust the alpha channel of the color so that it doesn't
obscure the contents of the buffer.
Release Notes:
- N/A
Marshall Bowers
created
547ad77
Style tab drop targets for project entries (#3725)
Click to expand commit body
This PR styles the drop targets when dragging a project entry onto a tab
or the tab bar.
I also adjusted the existing tab drop targets to use the
`drop_target_background` from the theme.
Release Notes:
- N/A