f67d4ce
Add more harness around nightly builds (#3562)
Click to expand commit body
Part of
https://zed-industries.slack.com/archives/C05SJGT0M33/p1702039430077589
The nightly job managed to pass successfully (build & upload nightly),
logged a proper commit sha that got into latest_sha on the nightly
bucket — but Zed version in about was wrong.
* Log Zed build sha in release builds to ensure CI uses the right one
* make curl to return non-zero code for non-200 nightly file uploads
Release Notes:
- N/A
Also ensure that curl commands for nightly uploads return 200 (fail otherwise).
Kirill Bulatov
created
133b1a8
Fix palette/picker colors for imported themes (#3560)
Click to expand commit body
This PR fixes the palette/picker colors for themes imported from VS
Code.
- We now use the `dropdown.background` to set the background color for
elevated surfaces
- We now pull in `list.activeSelectionBackground` to use as the color
for selected ghost elements
Release Notes:
- N/A
27501d2
Pull in colors for selected ghost elements
Marshall Bowers
created
77c8108
Use `dropdown.background` from VS Code for elevated surface background
Marshall Bowers
created
1c850f4
Use `breadcrumb.background` from VS Code for toolbar background (#3559)
Click to expand commit body
This PR changes the color we use for the toolbar background from the VS
Code theme to `breadcrumb.background`.
If this value isn't set then we fall back to the `editor.background`.
Release Notes:
- N/A
Marshall Bowers
created
1d35a81
Use `editorGroupHeader.tabsBackground` from VS Code as tab bar background (#3558)
Click to expand commit body
This PR changes the color we use for the tab bar background from the VS
Code theme to `editorGroupHeader.tabsBackground`.
Release Notes:
- N/A
This PR refines the imported themes further:
- Empty strings for color values in the VS Code theme are now ignored
- Pull Git status colors from VS Code themes
- Add `constant` colors as a fallback for `number` tokens
Release Notes:
- N/A
7a9f764
Add support for theme family-specific syntax mapping overrides (#3551)
Click to expand commit body
This PR adds support for adding a specific set of mappings from Zed
syntax tokens to VS Code scopes for a particular theme family.
We can use this as a fallback when we aren't otherwise able to rely on
the mappings in the theme importer, as sometimes it isn't possible to
make a specific enough matcher that works across all of the themes.
Release Notes:
- N/A
Marshall Bowers
created
5b96ffb
Set various bar backgrounds in imported themes (#3550)
Click to expand commit body
This PR updates the imported themes to set the background colors for the
various bars (title bar, toolbar, tab bar, status bar).
Release Notes:
- N/A
This PR improves the approach we use to match syntax tokens between Zed
and VS Code in the `theme_importer`.
We now use the list of scopes assigned to each Zed syntax token to rank
the possible candidates in the VS Code and then pick the candidate with
the highest rank.
So far this has proved to provide better colors across the board, but
we'll continue to refine the matching over time.
Release Notes:
- N/A