4f6bef5
Improve interaction between clicking and dragging (#3737)
Click to expand commit body
Once a drag starts, we won't fire click listeners or style any elements
as active.
- Don't fire click listeners or show active state once a drag is in
progress
- Don't show hover style when a drag is in progress
- Draw borders above content
- If borders are opaque, apply them to the content mask. This prevents
hovers from firing on content underneath the border, which was creating
issues where the drag handle was inside the border, so we'd flicker the
hover when the mouse moved out of the drag handle and into the 1px
border on the left dock.
- Add a `block_mouse` helper which causes transparent elements to paint
an "opaque" layer to prevent mouse events from falling through. We use
this for the drag handle as well to disable hover, click, etc on items
in the panel.
Release Notes:
- N/A
Nathan Sobo
created
afbc655
Ensure that views' `on_release` callbacks are always called (#3747)
Click to expand commit body
* Ensure that views' on_release callbacks are always called (even if
their window is gone), by passing them a `AppContext`, not a
`WindowContext`.
* Fix leaked handles to `CollabPanel`, `NotificationPanel`, and
`ChatPanel` caused by captures in a `ListState` render callback.
This fixes two issues we were seeing with following:
* inability to rejoin a remote project after you closed it
* following not working if a window had previously been closed
Max Brunsfeld
created
87a1387
For file finder queries, match in all gitignored worktree entries (#3748)
Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/2347
Part of https://github.com/zed-industries/community/issues/1538
Now file finder will match all gitignored worktree entries.
Zed does not traverse gitignored dirs by default, which means that not
all gitignored files will be matches, but all that were toggled in
project panel and all root non-directory gitignored entries will be now
used, hopefully causing less questions.
Release Notes:
- Improved file finder to match all gitignored files that were added
into worktrees (e.g. due to opening gitignored directories in project
panel)
Kirill Bulatov
created
24970c1
Fix view handle leaks in ListState callbacks
Max Brunsfeld
created
2f56fe9
For file finder queries, search in all gitignored worktree entries
Kirill Bulatov
created
42bdc11
Prune dead workspaces from WorkspaceStore on read
Click to expand commit body
Also, remove unnecessary window handle from Workspace.
Max Brunsfeld
created
5e7c74c
Ensure that on_release callbacks are called even if view outlives its window
Max Brunsfeld
created
d61cac6
Add `ToggleButton` for use in buffer search (#3746)
Click to expand commit body
This PR adds a new `ToggleButton` component:
<img width="738" alt="Screenshot 2023-12-20 at 6 50 13 PM"
src="https://github.com/zed-industries/zed/assets/1486634/9c5fb45b-0b55-4008-9336-b651a26a99ad">
We're using `ToggleButton`s for the search mode selection in the buffer
search:
<img width="842" alt="Screenshot 2023-12-20 at 6 47 57 PM"
src="https://github.com/zed-industries/zed/assets/1486634/178a278f-172c-4c67-8572-83d59de2ed14">
Release Notes:
- N/A
93c8bee
Use `ToggleButton`s for search mode in buffer search
Marshall Bowers
created
8238edb
Remove nightly from zed1 and use proper namespaces for nightly in zed2 manifest (#3745)
Click to expand commit body
Currently, I get 404 when trying to open links for nightly, like
https://zed.dev/nightly/channel/Rooms-329
The PR ensures nightly has a separate protocol handler in zed2, removes
nightly mentions from zed1.
See also zed.dev change:
https://github.com/zed-industries/zed.dev/pull/429
Release Notes:
- N/A
2cd7d2d
Remove nightly from zed1 and use proper namespaces for nightly in zed2 manifest
Kirill Bulatov
created
56f2b96
Restore "reveal in project panel" and "search in directory" context menu actions (#3744)
Click to expand commit body
Release Notes:
- N/A
Kirill Bulatov
created
72c8bea
Restore "reveal in project panel" and "search in directory" context menu actions
Kirill Bulatov
created
5272794
Refine toolbar and buffer search styling (#3743)
Click to expand commit body
This PR refines the toolbar styling, specifically around the buffer
search.
Spacing has been adjusted to feel less claustrophobic.
Release Notes:
- N/A
This PR makes a first pass at styling the notification panel.
#### Signed out
<img width="381" alt="Screenshot 2023-12-20 at 11 41 25 AM"
src="https://github.com/zed-industries/zed/assets/1486634/f045fa17-4ebc-437f-a25b-d7695d47f18b">
#### No notifications
<img width="380" alt="Screenshot 2023-12-20 at 11 44 23 AM"
src="https://github.com/zed-industries/zed/assets/1486634/3a7543f2-8cd8-4788-8059-d5663f5f6b4c">
#### Notifications
<img width="386" alt="Screenshot 2023-12-20 at 1 27 08 PM"
src="https://github.com/zed-industries/zed/assets/1486634/13b81722-c47a-4c06-b37d-e6515cbfdb9d">
Release Notes:
- N/A
Marshall Bowers
created
15f16f0
Move application of content mask and z-index into Interactivity::paint
Click to expand commit body
This allows the content mask to correctly apply to bounds used in event handlers,
which prevents content under opaque borders from being hovered in overflow hidden
containers.
Co-Authored-By: Antonio <antonio@zed.dev>
Co-Authored-By: Max Brunsfeld <max@zed.dev>
Nathan Sobo
,
Antonio
, and
Max Brunsfeld
created
da34dd4
Fix text wrapping issues with `overflow_hidden`
Click to expand commit body
This seems to influence sizing calculations in ways I don't fully understand.
a125610
Assign draw order to surfaces using plane splitter (#3739)
Click to expand commit body
It looks like we neglected to incorporate surfaces into the
plane-splitting code path, which assigns each graphics primitive's draw
order.
This fixes an issue where screensharing frames were not visible when the
screenshare tab was zoomed.
90db278
Prevent `ArenaRef` from being cloned (#3738)
Click to expand commit body
This could cause multiple mutable references to be acquired for the same
arena element, which is unsafe. I didn't see it cause problems in
practice, but I realized this could have been a problem and fixed it
before it bit us.
Release Notes:
- N/A
Antonio Scandurra
created
636c12e
Style signed-out and empty states for the notification panel