df1804b
Merge pull request #267 from zed-industries/fix-soft-wrap-disabled
Click to expand commit body
Avoid building up pending edits when soft wrapping is disabled
Nathan Sobo
created
0ed488d
Avoid building up pending edits when soft wrapping is disabled
Click to expand commit body
This was causing us to get slower over time as we stacked up hundreds of thousands of pending edits whenever soft wrap was disabled.
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Nathan Sobo
and
Antonio Scandurra
created
fcbd7f9
Merge pull request #266 from zed-industries/fix-go-to-line
Click to expand commit body
Use display coordinates for the highlighted row in "go to line"
Antonio Scandurra
created
2449834
Use display coordinates for the highlighted row in "go to line"
Antonio Scandurra
created
cb942a0
Merge pull request #265 from zed-industries/fix-collaborators-test
Click to expand commit body
Fix flaky contacts test
Nathan Sobo
created
a141216
Fix randomized test failures by waiting for client_b to be added to worktree_a
Click to expand commit body
We perform an async fetch of client_b's user data on worktree_a, which ends up holding a handle that prevents worktree_a from being released later in the test. By waiting for this fetch to finish before proceeding, we can be sure worktree_a actually gets released.
A more comprehensive fix would be some way to ensure we actually perform a release if an entity is fully dropped outside of an update cycle, but this fixes the issue for now.
Co-Authored-By: Max Brunsfeld <max@zed.dev>
Nathan Sobo
and
Max Brunsfeld
created
1a91aa8
Introduce a collections crate w/ deterministic hashmap, hashset in tests
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld
and
Nathan Sobo
created
5ec0035
Consolidate pending effects logic into MutableAppContext::update
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld
and
Nathan Sobo
created
4cc1556
Introduce weak_handle methods on ModelContext and ViewContext
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld
and
Nathan Sobo
created
29b616f
Merge pull request #263 from zed-industries/fix-highlighting-when-x-scrolled
Click to expand commit body
Paint highlighted lines correctly when horizontally scrolled
Max Brunsfeld
created
88e0fe6
Paint highlighted lines correctly when horizontally scrolled
Max Brunsfeld
created
7537c3b
Merge pull request #261 from zed-industries/setting-overrides
Click to expand commit body
Override soft-wrap settings for Markdown and Plain Text
6ce76ca
Render active worktree collaborator avatars in the titlebar
Nathan Sobo
created
4bd43e6
Introduce a TestClient and associate it with a PeerId
Click to expand commit body
This makes it easier to integration test peer interactions because now we know their PeerIds.
Nathan Sobo
created
b307a7e
Populate the user data of worktree collaborators
Click to expand commit body
This will make it possible for us to render their avatars. Previously we only had the user ids. During rendering, everything needs to be available synchronously. So now, whenever collaborators are added, we perform the async I/O to fetch their user data prior to adding them to the worktree.
Nathan Sobo
created
9930e92
WIP: Give worktrees a reference to the UserStore
Click to expand commit body
This will allow them to fetch user data when peers are added or removed. Still work to do though.
Nathan Sobo
created
21aba54
Introduce a worktree::Collaborator struct that holds the user_id
Click to expand commit body
We can use this to render avatars.
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Nathan Sobo
,
Max Brunsfeld
, and
Antonio Scandurra
created
Yeah, it's true they're people, but this is a more specific way in which they're people.
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Nathan Sobo
and
Antonio Scandurra
created
c8ad5b6
Rename collaborator_logins to authorized_logins
Click to expand commit body
Again, this is about reserving the concept of a "collaborator" for actual collaborators on a worktree.
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
This will allow us to use the word "collaborator" to describe users that are actively collaborating on a worktree.
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
This will help us render the collaborator avatars for the active worktree when we know its peers.
Nathan Sobo
created
f453928
Associate the project with an active worktree
Click to expand commit body
This is similar to the active entry, but it can remain assigned even if there is no active entry and we can potentially manipulate it in other scenarios such as interaction with the project browser. This prepares the ground to show the collaborators for the active worktree.
Nathan Sobo
created
74cdd32
Merge pull request #257 from zed-industries/go-to-line-plus-mouse
Click to expand commit body
Preserve selection when clicking on editor dismisses go-to-line dialog
Nathan Sobo
created
f8cf534
Merge pull request #256 from zed-industries/select-next
Click to expand commit body
Implement select next (cmd-d) and replace selection with next (cmd-k cmd-d)
Nathan Sobo
created
ad26362
Preserve selection when clicking on editor dismisses go-to-line dialog
Nathan Sobo
created
fc2ae42
Implement cmd-k cmd-d to replace selection with next
Nathan Sobo
created
d249618
Improve range-based selection queries to only resolve the requested selections