Commit log

b768a39 Add unit test reproducing a panic when refreshing selections

Antonio Scandurra created

7daa4b5 Don't return a `Result` in test-only method `select_display_ranges`

Antonio Scandurra created

a6dd9a2 Fix binding to dump element JSON

Nathan Sobo created

9602bc6 Remove stray dbg! calls

Max Brunsfeld created

5941f5f Upgrade tree-sitter-markdown

Max Brunsfeld created

5a889b0 Merge pull request #329 from zed-industries/fix-newline-in-multibuffer

Click to expand commit body 
Fix cursor position when inserting newlines on a repeated excerpt

Max Brunsfeld created

89ead1c Merge pull request #314 from zed-industries/auto-connect

Click to expand commit body 
Auto-connect to server on startup if credentials are on the keychain

Antonio Scandurra created

c168201 Fix cursor position when inserting newlines on a repeated excerpt

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Max Brunsfeld <max@zed.dev>

Antonio Scandurra , Nathan Sobo , and Max Brunsfeld created

58e45dd Merge pull request #328 from zed-industries/fix-multibuffer-anchors

Click to expand commit body 
Randomize test multibuffer anchors and fix resulting issues

Antonio Scandurra created

aa543a4 Ensure selections stay sorted after refreshing them

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

e70b728 Verify `Anchor::buffer_id` before resolving it or comparing it

Click to expand commit body 
This commit also verifies some properties about anchor resolution in the
multibuffer randomized test.

Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

2d5e722 Merge pull request #325 from zed-industries/fix-more-subscription-panics

Click to expand commit body 
Don't register an entity ID extractor for non-entity subscriptions

Antonio Scandurra created

d7fcb04 Don't register an entity ID extractor for non-entity subscriptions

Click to expand commit body 
This commit fixes a panic that could occur when registering N subscriptions for
N entities of the same kind. Before, when dropping the first of the
subscriptions, we would remove the entity ID extractor as well. This was,
however, used by all the other N - 1 subscriptions which would then start
losing messages. In addition, dropping yet another subscription of that kind
would result in a panic, because we wouldn't find the extractor in the map
upon invoking `Subscription::drop`.

With this change we will avoid removing the ID extractor when dropping a
subscription. Crucially, we also avoid inserting extractors for simple message
subscriptions. This enables these non-entity subscriptions to be dropped and
re-registered without seeing a "registered handler for the same message twice"
panic.

Antonio Scandurra created

2ea78c5 Merge pull request #320 from zed-industries/more-diagnostics-polish

Click to expand commit body 
Keep the cursor at the top when first opening the project diagnostics view

Max Brunsfeld created

a0a5583 In diagnostics editor, attempt to open excerpts in a different pane

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

747d9e8 Add files to project diagnostics view in order

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

c7eb6a6 Tweak color of share icon in titlebar

Max Brunsfeld created

7244fe9 Merge pull request #315 from zed-industries/fix-outdent-column-0

Click to expand commit body 
Fix outdent not working when cursor is at column 0

Max Brunsfeld created

8ee106e Merge pull request #316 from zed-industries/fix-subscription-panic

Click to expand commit body 
Fix `rpc::Client` subscription panics

Max Brunsfeld created

4992a8a :art:

Antonio Scandurra created

b44ae46 Fix panic if subscribing after dropping a subscription for the same message

Antonio Scandurra created

dff812b Don't panic when dropping a subscription in a subscription handler

Antonio Scandurra created

9f6c53b Fix dev dependencies in client/Cargo.toml

Antonio Scandurra created

b1de9a9 Fix outdent not working when cursor is at column 0

Antonio Scandurra created

e8bbd37 Auto-connect to server on startup if credentials are on the keychain

Antonio Scandurra created

8d7bb8b Merge pull request #313 from zed-industries/polish-project-diagnostics

Click to expand commit body 
Polish project diagnostics UX

Antonio Scandurra created

5c3ae88 Fix diagnostic unit test assertions

Antonio Scandurra created

eb35364 :art:

Antonio Scandurra created

a159757 Compare singleton buffers in `test_open_and_save_new_file`

Antonio Scandurra created

0742640 Correctly report line boundaries when a map contains both folds and wraps

Click to expand commit body 
This fixes the randomized test failures that were occurring on main.

Antonio Scandurra created

1a53d5b Use a new `Workspace::activate_item` API in project diagnostics

Click to expand commit body 
Previously, we would only activate the pane without switching the
pane's *active item*.

Antonio Scandurra created

f933d54 When selections lose their excerpts, move them to the next primary diagnostic

Max Brunsfeld created

ce6f3d7 Reuse views when moving between diagnostic view and editors

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

ea26382 Finish implementing ProjectDiagnostics::open_excerpts

Click to expand commit body 
* Build workspace item views with a reference to the workspace
* Add randomized test for MultiBuffer::excerpted_buffers and fix a small bug

Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

e5c520a Use `Buffer` handles instead of `MultiBuffer` as editor workspace items

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

794d214 Refactor opening workspace items

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

3cab32d WIP: Add keybinding to open buffers under cursors

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

cf62d26 Display a "Checking..." message when running disk-based diagnostics

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

e39be35 Show status bar item for project diagnostic summary

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

56496c2 Move back `diagnostic_summaries` into `Worktree`

Click to expand commit body 
This fixes an issue where updating the snapshot's entries would
override the diagnostic summaries received on the remote side.

Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

089542c Avoid removing diagnostics from `Worktree` after opening a buffer

Click to expand commit body 
This allows re-opening the same buffer and supplying the previous
diagnostics.

Antonio Scandurra created

67f672d Clear selections on other excerpted buffers when setting active selections

Antonio Scandurra created

94e9c7f Give a full-width background to the diagnostic headers

Max Brunsfeld created

2b36ab0 Introduce Expanded element

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

1f762e4 Unify Flexible and Expanded elements

Click to expand commit body 
We'll use the name Expanded for something else now.

Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

b19d92e Keep selections at the top of the project diagnostics view when it is first populated

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

9bbe67f Don't clobber diagnostics when getting new snapshot from background scanner

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

7357b3f Revert "Remove special handling of multi-line primary diagnostic messages and fix tests"

Click to expand commit body 
This reverts commit ce4142eab39118a2ecd43a0473a3e7035087191e.

Max Brunsfeld created

10548c2 Always group diagnostics the way they're grouped in the LSP message

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

943571a Report backtraces of pending conditions when deterministic executor illegally parks

Click to expand commit body 
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>

Nathan Sobo and Max Brunsfeld created