Commit log

d306b53 Add `label_for_completion` to extension API (#10175)

Click to expand commit body
This PR adds the ability for extensions to implement
`label_for_completion` to customize completions coming back from the
language server.

We've used the Gleam extension as a motivating example, adding
`label_for_completion` support to it.

Release Notes:

- N/A

---------

Co-authored-by: Max <max@zed.dev>
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>

Marshall Bowers , Max , and Max Brunsfeld created

0f1c2e6 Return back the ability to save non-dirty singleton buffers (#10174)

Kirill Bulatov created

0861cea Add `yield` keyword highlight for Rust (#10104)

Click to expand commit body
Release Notes:

- Added `yield` keyword highlight for Rust


Ref:

- https://github.com/rust-lang/rust-analyzer/pull/7209
-
https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/syntax_highlighting/highlight.rs#L177
-
https://doc.rust-lang.org/reference/keywords.html?highlight=yield#reserved-keywords


In VS Code:
 

![SCR-20240403-hrb](https://github.com/zed-industries/zed/assets/5518/ec3e84ce-ea9d-4b2d-832d-ecdfec0def91)

docs.rs:
https://docs.rs/async-stream/latest/async_stream/macro.try_stream.html


![SCR-20240403-gpk](https://github.com/zed-industries/zed/assets/5518/07010c2c-341d-4ae2-ba80-5f4eab4dbf60)

## Before

<img width="644" alt="image"
src="https://github.com/zed-industries/zed/assets/5518/da349187-57e6-4cea-b3e3-f628ce6a99e8">


## After update in Zed

![SCR-20240403-hqk](https://github.com/zed-industries/zed/assets/5518/44f1687b-ec38-42c2-984d-15177bed7e5b)

Jason Lee created

1c485a0 tasks: change placeholder text in a modal (#10166)

Click to expand commit body
Related to: #10132

Release Notes:

- N/A

Piotr Osiewicz created

7d1a5d2 zed-local: add --stable flag to zed-local (#10165)

Click to expand commit body
`--stable` makes all clients except for the first one use a stable
version of Zed (hardcoded to `/Applications/Zed/Contents/MacOS/zed` for
now).

That should make testing cross-channel collab changes a bit easier. /cc
@maxbrunsfeld @ConradIrwin

Release Notes:

- N/A

Piotr Osiewicz created

27165e9 channel chat: Set first loaded message ID when sending a message (#10034)

Click to expand commit body
Discovered while looking into #10024.

When clicking on a reply message text, the original message should be
highlighted accordingly. However this would not work when the channel
was just created and the user is the only one that sent messages.
 
Release Notes:

- Fixed highlighting of messages when clicking on the reply message text
in the chat and there were no other messages from other users

Bennet Bo Fenner created

1085642 Stricten Zed Task variable API (#10163)

Click to expand commit body
Introduce `VariableName` enum to simplify Zed task templating
management: now all the variables can be looked up statically and can be
checked/modified in a centralized way: e.g. `ZED_` prefix is now added
for all such custom vars.

Release Notes:

- N/A

Kirill Bulatov created

ee1b177 Document `formatter: code_actions` (#10157)

Click to expand commit body
This documents what was introduced in #10121 and shipped in 0.130.x

Release Notes:

- N/A

Thorsten Ball created

5b4ff74 collab ui: Dismiss project shared notifications when leaving room (#10160)

Click to expand commit body
When leaving a call/room in which a project was shared, the shared
project notification was not getting dismissed when the person that
shared the project left the room.
Although there was a `cx.emit(Event::Left)` call inside room, the event
was never received in the `project_shared_notification` module, because
the room is dropped before the event can be dispatched. Moving the
`cx.emit(Event::Left)` to the active call fixed the problem. Also
renamed `Event::Left` to `Event::RoomLeft` because the room join
equivalent is also called `Event::RoomJoined`.


Release Notes:

- Fixed project shared notification staying open, when the user that
shared the project left the room

Bennet Bo Fenner created

8e9543a Improve handling of prettier errors on format (#10156)

Click to expand commit body
When no formatter for a language is specified, Zed has the default
behaviour:

1. Attempt to format the buffer with `prettier`
2. If that doesn't work, use the language server.

The problem was that if `prettier` failed to format a buffer due to
legitimate syntax errors, we simply did a fallback to the language
server, which would then format over the syntax errors.

With JavaScript/React/TypeScript projects this could lead to a situation
where

1. Syntax error was introduced
2. Prettier fails
3. Zed ignores the error
4. typescript-language-server formats the buffer despite syntax errors

This would lead to some very weird formatting issues.

What this PR does is to fix the issue by handling `prettier` errors and
results in two user facing changes:

1. When no formatter is set (or set to `auto`) and if we attempted to
start a prettier instance to format, we will now display that error and
*not* fall back to language server formatting.
2. If the formatter is explicitly set to `prettier`, we will now show
errors if we failed to spawn prettier or failed to format with it.

This means that we now might show *more* errors than previously, but I
think that's better than not showing anything to the user at all.

And, of course, it also fixes the issue of invalid syntax being
formatted by the language server even though `prettier` failed with an
error.

Release Notes:

- Improved error handling when formatting buffers with `prettier`.
Previously `prettier` errors would be logged but ignored. Now `prettier`
errors are shown in the UI, just like language server errors when
formatting. And if no formatter is specified (or set to `"auto"`) and
Zed attempts to use `prettier` for formatting, then `prettier` errors
are no longer skipped. That fixes the issue of `prettier` not formatting
invalid syntax, but its error being skipped, leading to
`typescript-language-server` or another language server formatting
invalid syntax.

Thorsten Ball created

c0d1171 Fix clear reply to message and edit message state when you switch state (#10044)

Click to expand commit body
This pull request fixes the following issue #10042.

Release Notes:
- Fixed clear chat state when switching edit/reply message state.
([#10042](https://github.com/zed-industries/zed/issues/10042)).

Remco Smits created

9cbde74 Refactor selection expansion logic into a separate method (#10117)

Click to expand commit body
Release Notes:

- N/A

This commit introduces a new method `range` to calculate the target
range for selection expansion based on the current selection, movement
times, and other parameters. The `expand_selection` method is refactored
to use this new `range` method, simplifying the logic for expanding a
selection and making the code more modular and reusable. The `range`
method encapsulates the logic for calculating the new selection range,
including handling linewise selection and adjustments for surrounding
newlines, making it easier to understand and maintain the selection
expansion functionality.

---------

Co-authored-by: Thorsten Ball <mrnugget@gmail.com>

Hans and Thorsten Ball created

879f361 tasks: fix panic in render_match (#10137)

Click to expand commit body
Release Notes:

- Fixed panic in tasks modal (Preview only).

Piotr Osiewicz created

79272b7 extensions: Add author to the manifest (#10134)

Click to expand commit body
Related to #9910 
Also, this PR will add a release note, since I've missed that in the
original PR.
Release Notes:

- Added Emmet language extension to the extension store.

Piotr Osiewicz created

0ddec27 Add emmet-language-server support (#9910)

Click to expand commit body
Note that I want to move this into an extension before merging.

Fixes: #4992 

Release Notes:

- Added Emmet snippets support

Piotr Osiewicz created

ccb2d02 Remove datadog (#10133)

Click to expand commit body
Release Notes:

- N/A

Conrad Irwin created

fc08ea9 Fix undo in replace mode (#10086)

Click to expand commit body
Fixes: #10031

Co-Authored-By: Petros <petros@amignosis.com>

Release Notes:

- vim: Fix undo grouping in Replace mode
([#10031](https://github.com/zed-industries/zed/issues/10031)).

---------

Co-authored-by: Petros <petros@amignosis.com>

Conrad Irwin and Petros created

49c53bc Extract HTML support into an extension (#10130)

Click to expand commit body
This PR extracts HTML support into an extension and removes the built-in
HTML support from Zed.

Release Notes:

- Removed built-in support for HTML, in favor of making it available as
an extension. The HTML extension will be suggested for download when you
open a `.html`, `.htm`, or `.shtml` file.

Marshall Bowers created

256b446 Refactor LSP adapter methods to compute labels in batches (#10097)

Click to expand commit body
Once we enable extensions to customize the labels of completions and
symbols, this new structure will allow this to be done with a single
WASM call, instead of one WASM call per completion / symbol.

Release Notes:

- N/A

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld , Marshall Bowers , and Marshall created

ef3d04e v0.131.x dev

Joseph T. Lyons created

469be39 file_icons: Add license file (#10128)

Click to expand commit body
This PR adds a missing license file to the `file_icons` crate.

Release Notes:

- N/A

Marshall Bowers created

db5d53d clojure: Add license file (#10127)

Click to expand commit body
This PR adds a symlink to the `LICENSE-APACHE` file for the Clojure
extension.

I knew I was forgetting something 😓

Release Notes:

- N/A

Marshall Bowers created

b118b76 editor: Fix "Toggle comments" not respecting multiple line_comments in language config (#10126)

Click to expand commit body
This does not try to heuristically pick a comment style based on
surroundings anyhow. It does improve our story around uncommenting
though.

Fixes #10113.

Release Notes:

- Fixed "Toggle comment" action not working in presence of non-default
line comments such as doc comments in Rust
([#10113](https://github.com/zed-industries/zed/issues/10113)).

Piotr Osiewicz created

57a1b9b tab_switcher: Add tab close buttons (#9968)

Click to expand commit body
Support for closing tabs from Tab Switcher:

- Close button color matches the indicator color to preserve the
information that the buffer is dirty (as in SublimeText).
- `ctrl-backspace` closes the currently selected item.


https://github.com/zed-industries/zed/assets/2101250/8ea33911-2f62-4199-826d-c17556db8e9a

Release Notes:

- N/A

Andrew Lygin created

8eeecda Add `crate` keyword to Rust (#10110)

Click to expand commit body
Release Notes:

- Fixed `crate` keyword not being highlighted in Rust files.

Ref: #10104 

And I make a sort for them.

Jason Lee created

eb231d0 Add `code_actions` as `formatter` type (#10121)

Click to expand commit body
This fixes #8992 and solves a problem that ESLint/Prettier/... users
have been running into:

They want to format _only_ with ESLint, which is *not* a primary
language server (so `formatter: language server` does not help) and it
is not a formatter.

What they want to use is what they get when they have configured
something like this:

```json
{
  "languages": {
    "JavaScript": {
      "code_actions_on_format": {
        "source.fixAll.eslint": true
      }
    }
  }
}
```

BUT they don't want to run the formatter.

So what this PR does is to add a new formatter type: `code_actions`.

With that, users can only use code actions to format:

```json
{
  "languages": {
    "JavaScript": {
      "formatter": {
        "code_actions": {
          "source.fixAll.eslint": true
        }
      }
    }
  }
}
```

This means that when formatting (via `editor: format` or on-save) only
the code actions that are specified are being executed, no formatter.


Release Notes:

- Added a new `formatter`/`format_on_save` option: `code_actions`. When
configured, this uses language server code actions to format a buffer.
This can be used if one wants to, for example, format a buffer with
ESLint and *not* run prettier or another formatter afterwards. Example
configuration: `{"languages": {"JavaScript": {"formatter":
{"code_actions": {"source.fixAll.eslint": true}}}}}`
([#8992](https://github.com/zed-industries/zed/issues/8992)).

---------

Co-authored-by: JH Chabran <jh@chabran.fr>
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>

Thorsten Ball , JH Chabran , and Marshall Bowers created

654504d Remove `basic.conf` (#10120)

Click to expand commit body
This PR removes the `basic.conf` file.

In #10099 we suppressed some typo warnings that had cropped up in this
file, but it turns out we don't need the file at all.

Release Notes:

- N/A

Marshall Bowers created

08e8ffc docs: minor changes to ESLint docs (#10116)

Click to expand commit body
We allow more than just `shortenToSingleLine`, so let's document the
whole thing.

Release Notes:

- N/A

Thorsten Ball created

027897e Do not spawn oneshot tasks from blank prompts (#10115)

Kirill Bulatov created

c4ceeb7 Fix git blame not working correctly with submodules (#10114)

Click to expand commit body
This fixes #9958 by using the correct working directory in which to run
`git blame`.

This wasn't an issue for a single repository, because we could go from
`.git` one directory up, but it doesn't work for submodules.

Luckily there's a `workdir()` method on `self.repository` that does
exactly what we need.

In submodule:

![screenshot-2024-04-03-12 37
18@2x](https://github.com/zed-industries/zed/assets/1185253/67e89abb-d04c-4e9d-802f-5b8468e0962e)

Not in submodule:

![screenshot-2024-04-03-12 37
36@2x](https://github.com/zed-industries/zed/assets/1185253/cfe59f59-798b-43e1-980d-2225db4c0302)

Release Notes:

- N/A

Thorsten Ball created

58aec1d Do not push invisible local worktrees into recent documents (#10112)

Click to expand commit body
Follow-up of https://github.com/zed-industries/zed/pull/9919 that
removes invisible worktrees from the list, to avoid things like

![image](https://github.com/zed-industries/zed/assets/2690773/90ce1c29-a1dd-4a03-b09a-effdba620c8f)

Release Notes:

- N/A

Kirill Bulatov created

9aad30a Query code actions and hovers from all related local language servers (from remote clients) (#10111)

Click to expand commit body
Supersedes https://github.com/zed-industries/zed/pull/8634
Fixes https://github.com/zed-industries/zed/issues/7947 by continuing
https://github.com/zed-industries/zed/pull/9943 with the remote part.

Now, clients are able to issue collab requests, that query all related
language servers, not only the primary one.
Such mode is enabled for GetHover and GetCodeActions LSP requests only.

Release Notes:

- Added Tailwind CSS hover popovers for Zed in multi player mode
([7947](https://github.com/zed-industries/zed/issues/7947))

Kirill Bulatov created

3a0d3ce Compute scrollbar markers asynchronously (#10080)

Click to expand commit body
Refs #9647
Fixes https://github.com/zed-industries/zed/issues/9792

This pull request moves the computation of scrollbar markers off the
main thread, to prevent them from grinding the editor to a halt when we
have a lot of them (e.g., when there are lots of search results on a
large file). With these changes we also avoid generating multiple quads
for adjacent markers, thus fixing an issue where we stop drawing other
primitives because we've drawn too many quads in the scrollbar.

Release Notes:

- Improved editor performance when displaying lots of search results,
diagnostics, or symbol highlights in the scrollbar
([#9792](https://github.com/zed-industries/zed/issues/9792)).

---------

Co-authored-by: Antonio Scandurra <me@as-cii.com>
Co-authored-by: Nathan <nathan@zed.dev>

Thorsten Ball , Antonio Scandurra , and Nathan created

7dbcace Fix accidentally dropping shell environment variable (#10105)

Click to expand commit body
Previously this code would run the changed commend, take its output,
remove the `marker` from the front and then split on `0` byte.

Problem was that `echo` adds a newline, which we did *NOT* skip. So
whatever `env` printed as the first environment variable would have a
`\n` in front of it.

Instead of setting, say, `HOME`, Zed would set `\nHOME`.

This change fixes the issue by switching to `printf '%s' marker`, which
is more portable than using `echo -n`.

This is related to https://github.com/zed-industries/zed/issues/9786 but
I'm not sure yet whether that fixes it.

Release Notes:

- Fixed Zed sometimes missing environment variables from shell in case
they were the first environment variable listed by `/usr/bin/env`.

Thorsten Ball created

463c16a Allow users to configure ESLint's `problems` settings (#9981)

Click to expand commit body
Presently the only available setting under `problems` is
`shortenToSingleLine`, which defaults to `false`.

Example Zed `settings.json` to shorten eslint error squiggles to only
show on the first line of the problem:
```json
{
    "lsp": {
        "eslint": {
            "settings": {
                "problems": {
                    "shortenToSingleLine": true
                }
            }
        }
    }
}
```


Release Notes:

- Added support for configuring ESLint `problems` settings, ie. `{"lsp":
{"eslint": {"settings": {"problems": {"shortenToSingleLine": true}}}}}`

Demo:



https://github.com/zed-industries/zed/assets/2072378/379faa75-1f37-4fd1-85da-1510f1397d07

William Villeneuve created

5a2a85a Fix vim code working on display map chars (#10103)

Click to expand commit body
Release Notes:

- vim: Fixed motion bugs when softwrap, folds or inlay hints were used.

Conrad Irwin created

754547f Fix mention notifications are not updated after message change and not removed after a message is deleted (#9847)

Click to expand commit body
@ConradIrwin This is a followup for #9035 as agreed.

Release Notes:

- Fixed mention notifications are updated when channel message is
updated. And mention notifications are removed when message is removed.

---------

Co-authored-by: Bennet Bo Fenner <53836821+bennetbo@users.noreply.github.com>

Remco Smits and Bennet Bo Fenner created

fe7b12c fix rejoin after quit (#10100)

Click to expand commit body
Release Notes:

- collab: Fixed rejoining channels quickly after a restart

Conrad Irwin created

8958c9e Suppress typos in `basic.conf` (#10099)

Click to expand commit body
This PR updates the `typos` configuration to suppress some typos in
`basic.conf`.

AFAICT there must have been an update to `typos` that caused this new
warning to appear.

Release Notes:

- N/A

Marshall Bowers created

7d5048e Revert PR #6924 - go to reference when there's only one (#10094)

Click to expand commit body
This PR reverts #6924, for the reasons stated in
https://github.com/zed-industries/zed/pull/6924#issuecomment-2033076300.

It also fixes an issue were the `find_all_references_task_sources`
wasn't cleaned up in all cases.

Release Notes:

- N/A

---------

Co-authored-by: Marshall <marshall@zed.dev>
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>

Max Brunsfeld , Marshall , and Marshall Bowers created

65cde17 Fix collab logging (#10095)

Click to expand commit body
span! statically determines which fields are available, and record
silently fails if you write to a field that is not available :/

Release Notes:

- N/A

Conrad Irwin created

9317fe4 Revert "Revert "Revert dependency updates in #9836 (#10089)""

Click to expand commit body
This reverts commit c8b14ee2cb976ca48b6df5fdf068c18c1d04c7a8.

Conrad Irwin created

c8b14ee Revert "Revert dependency updates in #9836 (#10089)"

Click to expand commit body
This reverts commit 55c897d993e63f90645acd1b08a21d81ab402f16.

Conrad Irwin created

55c897d Revert dependency updates in #9836 (#10089)

Click to expand commit body
Due to: https://github.com/zed-industries/zed/issues/9985 and an
abundance of caution, I'm reverting the image and svg rendering updates
for now until we can debug the issue. cc: @niklaswimmer

Release Notes:

- N/A

Mikayla Maki created

6121bfc Extract Clojure support into an extension (#10088)

Click to expand commit body
This PR extracts Clojure support into an extension and removes the
built-in Clojure support from Zed.

Release Notes:

- Removed built-in support for Clojure, in favor of making it available
as an extension. The Clojure extension will be suggested for download
when you open a `.clj` or other Clojure-related files.

---------

Co-authored-by: Max <max@zed.dev>

Marshall Bowers and Max created

46544d7 Revert PR #8327 - Fix autocomplete completions being cut in half (#10084)

Click to expand commit body
This reverts https://github.com/zed-industries/zed/pull/8327

That PR introduced a regression where completions' syntax highlighting
would be corrupted in a non-deterministic way, such that it varied from
frame to frame:

In the screenshot below, many of the field names (e.g. `cursor`,
`depth`) are incorrectly colored as types instead of fields. The
`finished_states` field has highlighting that changes at the wrong
offset. All of these values changed from frame to frame, creating a
strange flickering effect:

<img width="599" alt="Screenshot 2024-04-01 at 5 56 36 PM"
src="https://github.com/zed-industries/zed/assets/326587/b6a48f02-f146-4f76-92e6-32fb417d86c0">

Release Notes:

- N/A

Max Brunsfeld created

8df888e task: Add "remove" button next to oneshot tasks (#10083)

Click to expand commit body
Release Notes:

- Added a "remove" button next to oneshot tasks in tasks modal.

Piotr Osiewicz created

a1cb677 Make conversions to `wasmtime::Result` postfix-friendly (#10082)

Click to expand commit body
This PR refactors the conversions to `wasmtime::Result` to use a trait
so that we can perform the conversions in a postfix-friendly way.

Release Notes:

- N/A

Marshall Bowers created

c62239e Include commit hash in Nightly & Dev builds (#10054)

Click to expand commit body
Release Notes:

- N/A

<img width="1338" alt="image"
src="https://github.com/zed-industries/zed/assets/16290753/c8442dbe-d293-46ef-abb1-ed8a6d9bf37d">

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>

moshyfawn and Marshall Bowers created

15ef3f3 Add Tailwind autocomplete for Vue (#10078)

Click to expand commit body
This fixes #4403 by adding TailwindLsp to .vue files too and
autocomplete aswell


![image](https://github.com/zed-industries/zed/assets/49145060/8b06a478-cade-4cbc-9da7-f31f5197f304)

Release Notes:

- Added Tailwind support in `.vue` files
([#4403](https://github.com/zed-industries/zed/issues/4403)).

René created