d1928f0
Remove TODO by defining constant (#10556)
Click to expand commit body
Release Notes: - N/A
Thorsten Ball created
d1928f0
Remove TODO by defining constant (#10556)
Release Notes: - N/A
Thorsten Ball created
ad22bdd
diagnostics: Update diagnostics more eagerly (#10560)
Here comes a lenghty explanation for a short commit: We've had feedback that our diagnostics tab often mismatches what's shown in the status bar. E.g: https://x.com/fasterthanlime/status/1778764747732594753 Let's dive into the lifetime of diagnostic tab first; it is actually spawned *just once per workspace*, the first time you click on the diagnostics status indicator. Even if you close this tab, we still reuse the same object under the hood later on. This has upsides, as it means that you can close a tab and then reopen it with your selections still in-tact and so on. However, this also leads to the perceived staleness. Crucially, the first time ever in a given session that you spawn the diagnostics tab, the status bar counts match the content of a tab. That is because we always call \`update_excerpts\` when we create diagnostics tab for the first time, but later on we have severe constraints on when we want to update the excerpts in diagnostics tab, mostly centered around presence of selections in an editor... but, since we reuse the diagnostic tab object under the hood, we're always gonna have at least one selection in an editor sans the first time you open it. The end result is that in order for diagnostic tab contents to be updated, we have to get a "on-disk-diagnostics-finished" notification from language server, which can take a long time. Another example of this property manifesting itself is that if you fix a diagnostic warning/error, it takes a while for diagnostic tab to reflect it. With this PR, I've afforded a bit of leniency in refreshing the contents of that tab. The old check that discarded updates when diagnostics editor had at least one selection has been updated to instead reject multicursors; this is still overly conservative, as I'm not yet sure how big of an issue is the cursor that's jumping around (as that's what the selections constraint is supposed to prevent). Release Notes: - Fixed diagnostics tab showing outdated entries before the language server is done with it's analysis.
Piotr Osiewicz created
da0d968
zig: Use env if using `zls` from shell env (#10559)
This fixes the problem of the Zig extension picking up `zls` from the shell env but `zls` then failing to launch because it cannot find `zig`. Scenario in which this happens: - `.envrc` in a project that sets `$PATH` up - in that `$PATH` there's `zls` and `zig` - Zed is started from Dock - Project is opened - Shell env from project directory is loaded and used to get to `zls` - `zls` is then started, without that environment set on the process - `zls` cannot find `zig` Release Notes: - N/A Co-authored-by: Marshall <marshall@zed.dev>
Thorsten Ball and Marshall created
200e363
Intersect content mask with hitbox bounds only during hit test (#10554)
This fixes a bug that caused the editor to be rendered incorrectly when its bounds extended outside the content mask. This is because the editor uses the returned `Hitbox` bounds to determine the origin of its elements. With this commit, we will now store a new `content_mask` field within the `Hitbox` struct which is captured when the hitbox is inserted. Then, the content mask is applied on the fly when performing a hit test to determine whether the hitbox is actually hovered. Release Notes: - N/A
Antonio Scandurra created
db48c75
Add basic bash and Python tasks (#10548)
Part of https://github.com/zed-industries/zed/issues/5141 * adds "run selection" and "run file" tasks for bash and Python. * replaces newlines with `\n` symbols in the human-readable task labels * properly escapes task command arguments when spawning the task in terminal Caveats: * bash tasks will always use user's default shell to spawn the selections, but they should rather respect the shebang line even if it's not selected * Python tasks will always use `python3` to spawn its tasks now, as there's no proper mechanism in Zed to deal with different Python executables Release Notes: - Added tasks for bash and Python to execute selections and open files in terminal
Kirill Bulatov created
1911a9f
Add a setting to control the vertical and horizontal scroll sensitivity (#10244)
Some people (like myself) use touchpads for development and I find Zed's default scroll sensitivity to be slower than I like. This change adds a scroll sensitivity multiplier that allows users to customize the speed of their scrolling. Release Notes: - Added a setting under "scroll_sensitivity" that allows user to control the scroll sensitivity. This value acts as a multiplier for the horizontal and vertical scroll speed.
Carter Olsen created
faebce8
Inline git blame (#10398)
This adds so-called "inline git blame" to the editor that, when turned
on, shows `git blame` information about the current line inline:

When the inline information is hovered, a new tooltip appears that
contains more information on the current commit:

The commit message in this tooltip is rendered as Markdown, is
scrollable and clickable.
The tooltip is now also the tooltip used in the gutter:

## Settings
1. The inline git blame information can be turned on and off via
settings:
```json
{
"git": {
"inline_blame": {
"enabled": true
}
}
}
```
2. Optionally, a delay can be configured. When a delay is set, the
inline blame information will only show up `x milliseconds` after a
cursor movement:
```json
{
"git": {
"inline_blame": {
"enabled": true,
"delay_ms": 600
}
}
}
```
3. It can also be turned on/off for the current buffer with `editor:
toggle git blame inline`.
## To be done in follow-up PRs
- [ ] Add link to pull request in tooltip
- [ ] Add avatars of users if possible
## Release notes
Release Notes:
- Added inline `git blame` information the editor. It can be turned on
in the settings with `{"git": { "inline_blame": "on" } }` for every
buffer or, temporarily for the current buffer, with `editor: toggle git
blame inline`.
Thorsten Ball created
573ba83
Merge Zed task context providing logic (#10544)
Before, `tasks_ui` set most of the context with `SymbolContextProvider` providing the symbol data part of the context. Now, there's a `BasicContextProvider` that forms all standard Zed context and it automatically serves as a base, with no need for other providers like `RustContextProvider` to call it as before. Also, stop adding `SelectedText` task variable into the context for blank text selection. Release Notes: - N/A
Kirill Bulatov created
97c5cff
Update contributing docs to point to extensions (#10537)
This PR updates the contributing docs to remove an outdated section about extension support and instead point to the extension authoring docs. Release Notes: - N/A
Marshall Bowers created
556ecd9
blade: Fix incorrect texture format (#10524)
Fixes image rendering Closes https://github.com/zed-industries/zed/issues/10505 Before:  After:  Release Notes: - N/A
apricotbucket28 created
3289188
linux: Simplify scrolling implementation (#10497)
This PR adjusts our scrolling implementation to delay the generation of ScrollWheel events until we receive a complete frame. Note that our implementation is still a bit off-spec, as we don't delay any other kind of events. But it's been working so far on a variety of compositors and the other events contain complete data; so I'll hold off on that refactor for now. Release Notes: - N/A
Mikayla Maki created
5e4f707
Change authors of lua extension
Max Brunsfeld created
5d7642d
Update netrw bindings for preview panes (#10492)
Release Notes: - N/A
Conrad Irwin created
e64ecdc
Add missing block.copy() (#10496)
https://crates.io/crates/block implies this is necessary, and we're still seeing segfaults in this method, so... Release Notes: - Fixed a panic when installing the CLI / registering for the zed:// protocol
Conrad Irwin created
ba9c592
Fix emojis when rendering with the system ui font (#10491)
Release Notes: - N/A
Conrad Irwin created
ad8dd17
lua: Fix extension version (#10490)
This PR fixes the Lua extension version to be v0.0.1 instead of v0.1.0 for the initial release. Release Notes: - N/A
Marshall Bowers created
cb6d063
Windows: Fix crash when trying to copy nothing to clipboard (#10405)
Release Notes: - N/A
usr created
065f15e
Use buffer font when rendering editor breadcrumbs and diagnostics (#10488)
Before: <img width="592" alt="Screenshot 2024-04-12 at 12 00 00 PM" src="https://github.com/zed-industries/zed/assets/2280405/3251743e-4f2c-4ca3-9bc5-88f37660f7b9"> After: <img width="673" alt="Screenshot 2024-04-12 at 12 11 37 PM" src="https://github.com/zed-industries/zed/assets/2280405/6a8ac597-261a-45d9-bf2a-a673b6f26b0e"> Release Notes: - N/A
Mikayla Maki created
1045581
windows: Update `WindowsDisplay::frequency()` (#10476)
A subsequent update introduced the `HMONITOR` value to the `WindowsDisplay` struct, eliminating the need for polling to retrieve this value. Release Notes: - N/A
张小白 created
4e6f24a
Only emit resize event when size changed (#10419)
Currently, terminal will emit resize event every seconds, even if the size not changed. this PR fixed only emit resize event when size is changed. Release Notes: - N/A
CharlesChen0823 created
f3a78f6
Extract Vue extension (#10486)
This PR extracts Vue support into an extension and removes the built-in C# support from Zed. Release Notes: - Removed built-in support for Vue, in favor of making it available as an extension. The Vue extension will be suggested for download when you open a `.vue` file. --------- Co-authored-by: Max <max@zed.dev>
Marshall Bowers and Max created
8bca9ce
Fix Auto folded dirs performance issues (#8556)
Fixed auto folded dirs which caused significant performance issues #8476 (#7674) Moved from iterating over snapshot entries to use `child_entries` function from `worktree.rs` by making it public @maxbrunsfeld Release Notes: - Fixed a bug where project panel settings changes would not be applied immediately. - Added a `project_panel.auto_fold_dirs` setting which collapses the nesting in the project panel when there is a chain of folders containing a single folder. <img width="288" alt="Screenshot 2024-04-12 at 11 10 58 AM" src="https://github.com/zed-industries/zed/assets/2280405/efd61e75-026c-464d-ba4d-90db5f68bad3"> --------- Co-authored-by: Mikayla <mikayla@zed.dev>
Yury Abykhodau and Mikayla created
2858606
Display more specific tasks above in the modal (#10485)
Kirill Bulatov created
49371b4
Semantic Index (#10329)
This introduces semantic indexing in Zed based on chunking text from files in the developer's workspace and creating vector embeddings using an embedding model. As part of this, we've created an embeddings provider trait that allows us to work with OpenAI, a local Ollama model, or a Zed hosted embedding. The semantic index is built by breaking down text for known (programming) languages into manageable chunks that are smaller than the max token size. Each chunk is then fed to a language model to create a high dimensional vector which is then normalized to a unit vector to allow fast comparison with other vectors with a simple dot product. Alongside the vector, we store the path of the file and the range within the document where the vector was sourced from. Zed will soon grok contextual similarity across different text snippets, allowing for natural language search beyond keyword matching. This is being put together both for human-based search as well as providing results to Large Language Models to allow them to refine how they help developers. Remaining todo: * [x] Change `provider` to `model` within the zed hosted embeddings database (as its currently a combo of the provider and the model in one name) Release Notes: - N/A --------- Co-authored-by: Nathan Sobo <nathan@zed.dev> Co-authored-by: Antonio Scandurra <me@as-cii.com> Co-authored-by: Conrad Irwin <conrad@zed.dev> Co-authored-by: Marshall Bowers <elliott.codes@gmail.com> Co-authored-by: Antonio <antonio@zed.dev>
Kyle Kelley , Nathan Sobo , Antonio Scandurra , Conrad Irwin , Marshall Bowers , and Antonio created
4b40e83
gpui: Fix window title special characters display on X11 (#9994)
Before:  After:  Release Notes: - Fixed window title special characters display on X11. --------- Co-authored-by: Mikayla Maki <mikayla@zed.dev>
Maxime Forveille and Mikayla Maki created
dffddae
Revert "Revert "language: Remove buffer fingerprinting (#9007)"" (#9671)
This reverts commit caed275fbf58af9c3ac89ef11229d0a6bd13016f. NOTE: this should not be merged until #9668 is on stable and the `ZedVersion#can_collaborate` is updated to exclude all clients without that change. Release Notes: - N/A --------- Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
Conrad Irwin and Piotr Osiewicz created
a4d6c5d
toml: Bump to v0.1.0 (#10482)
This PR bumps the TOML extension to v0.1.0. This version of the extension has been updated to use v0.0.6 of the `zed_extension_api`. Release Notes: - N/A
Marshall Bowers created
3ea1724
Adjust left movement when soft_wrap mode is used (#10464)
Release Notes: - Added/Fixed #10350
Hans created
e0e1103
zig: Bump to v0.1.0 (#10481)
This PR bumps the Zig extension to v0.1.0. This version of the extension has been updated to use v0.0.6 of the `zed_extension_api`. It also adds support for treating `.zig.zon` files as Zig files (#10012). Release Notes: - N/A
Marshall Bowers created
65c9e7d
php: Bump to v0.0.2 (#10480)
This PR bumps the PHP extension to v0.0.2. This version of the PHP extension adds the `language_ids` mappings from #10053. Release Notes: - N/A
Marshall Bowers created
b5b8726
Extract Terraform extension (#10479)
This PR extracts Terraform support into an extension and removes the built-in Terraform support from Zed. Release Notes: - Removed built-in support for Terraform, in favor of making it available as an extension. The Terraform extension will be suggested for download when you open a `.tf`, `.tfvars`, or `.hcl` file.
Marshall Bowers created
f4d9a97
preview tabs: Support find all references (#10470)
`FindAllReferences` will now open a preview tab, jumping to a definition will also open a preview tab. https://github.com/zed-industries/zed/assets/53836821/fa3db1fd-ccb3-4559-b3d2-b1fe57f86481 Note: One thing I would like to improve here is also adding support for reopening `FindAllReferences` using the navigation history. As of now the navigation history is lacking support for reopening items other then project files, which needs to be implemented first. Release Notes: - N/A
Bennet Bo Fenner created
7b01a29
preview tabs: Fix tab selection getting out of sync (#10478)
There was an edge case where the project panel selection would not be updated when opening a lot of tabs quickly using the preview tab feature. I spent way too long debugging this, thankfully @ConradIrwin spotted it in like 5 minutes 🎉 Release Notes: - N/A
Bennet Bo Fenner created
04e89c4
Use workspace `uuid` (#10475)
Release Notes: - N/A
张小白 created
0ab5a52
Fix overlap (#10474)
Although I liked the symmetry of the count in the middle of the arrows, it's tricky to make the buttons not occlude the count on hover, so go back to this arrangement. Release Notes: - N/A
Conrad Irwin created
cd5ddfe
chat panel: Add timestamp in tooltip to edited message (#10444)
Hovering over the `(edited)` text inside a message displays a tooltip with the timestamp of when the message was last edited:  --- Also removed the `fade_out` style for the `(edited)` text, as this was causing tooltips to fade out as well:  Instead it uses `theme().text_muted` now. Release Notes: - Hovering over an edited message now displays a tooltip revealing the timestamp of the last edit.
Bennet Bo Fenner created
0a4c348
Fix typo in README (#10471)
Fixes a typo in the README which I believe was accidentally committed yesterday in #10459 Release Notes: - N/A
Bennet Bo Fenner created
a1cbc23
task: use full task label to distinguish a terminal (#10469)
Spotted by @SomeoneToIgnore, in #10468 I've used a shortened task label, which might lead to collisions. Release Notes: - N/A
Piotr Osiewicz created
298e9c9
task: Allow Rerun action to override properties of task being reran (#10468)
For example:
```
"alt-t": [
"task::Rerun",
{ "reevaluate_context": true, "allow_concurrent_runs": true }
],
```
Overriding `allow_concurrent_runs` to `true` by itself should terminate
current instance of the task, if there's any.
This PR also fixes task deduplication in terminal panel to use expanded
label and not the id, which depends on task context. It kinda aligns
with how task rerun worked prior to #10341 . That's omitted in the
release notes though, as it's not in Preview yet.
Release Notes:
- `Task::Rerun` action can now override `allow_concurrent_runs` and
`use_new_terminal` properties of the task that is being reran.
Piotr Osiewicz created
6e1ba7e
Allow hovering over tooltips in `git blame` sidebar (#10466)
This introduces a new API on `StatefulInteractiveElement` to create a tooltip that can be hovered, scrolled inside, and clicked: `.hoverable_tooltip`. Right now we only use it in the `git blame` gutter, but the plan is to use the new hover/click/scroll behavior in #10398 to introduce new git-blame-tooltips. Release Notes: - N/A --------- Co-authored-by: Antonio <antonio@zed.dev>
Thorsten Ball and Antonio created
bc0c2e0
Extend Vim default keybindings (#10461)
This implements some of #10457. Release notes: - Added `g c c` and `g c` to Vim keybindings to toggle comments in normal and visual mode respectively. - Added `g ]` and `g [` to Vim keybindings to go to next and previous diagnostic error. - Changed `[ x` and `] x` (which select larger/smaller syntax node) in Vim mode to also work in visual mode.
Thorsten Ball created
29a5057
Add git blame error reporting with notification (#10408)
<img width="1035" alt="Screenshot 2024-04-11 at 13 13 44" src="https://github.com/zed-industries/zed/assets/13402668/cd0e96a0-41c6-4757-8840-97d15a75c511"> Release Notes: - Added a notification to show possible `git blame` errors if it fails to run. Caveats: - ~git blame now executes in foreground executor (required since the Fut is !Send)~ TODOs: - After a failed toggle, the app thinks the blame is shown. This means toggling again will do nothing instead of retrying. (Caused by editor.show_git_blame being set to true before the git blame is generated) - ~(Maybe) Trim error?~ Done --------- Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Mehmet Efe Akça and Thorsten Ball created
08786fa
Make BufferSearch less wide (#10459)
This also adds some "responsiveness" so that UI elements are hidden before everything has to be occluded Release Notes: - Improved search UI. It now works in narrower panes, and avoids scrolling the editor on open. <img width="899" alt="Screenshot 2024-04-11 at 21 33 17" src="https://github.com/zed-industries/zed/assets/94272/44b95d4f-08d6-4c40-a175-0e594402ca01"> <img width="508" alt="Screenshot 2024-04-11 at 21 33 45" src="https://github.com/zed-industries/zed/assets/94272/baf4638d-427b-43e6-ad67-13d43f0f18a2"> <img width="361" alt="Screenshot 2024-04-11 at 21 34 00" src="https://github.com/zed-industries/zed/assets/94272/ff60b561-2f77-49c0-9df7-e26227fe9225"> <img width="348" alt="Screenshot 2024-04-11 at 21 37 03" src="https://github.com/zed-industries/zed/assets/94272/a2a700a2-ce99-41bd-bf47-9b14d7082b0e">
Conrad Irwin created
f2d61f3
Add feature to display commands for vim mode (#10349)
Release Notes: - Added the current operator stack to the Vim status bar at the bottom of the editor. #4447 This commit introduces a new feature that displays the current partial command in the vim mode, similar to the behavior in Vim plugin. This helps users keep track of the commands they're entering.
Hans created
9853307
Use buffer font for search (#10455)
It's wierd to type code/regex in the UI font Release Notes: - Continue to use buffer font for search
Conrad Irwin created
27ba165
Organize Project Panel context menus (#10456)
This design polish PR brings the project panel context menu into better alignment with other editors, better follows system patterns and identifies focus shifting actions with the `…` indicator (like adding a new folder to a project, which will open a modal window.) ## Before & After: **Root level**  **Folder level**  **File level**  Note: That double divider in the after has been fixed 😅 --- Release Notes: - Improved ordering and organization of context menus in the project panel to bring them closer to those in similar applications.
Nate Butler created
32806b8
vim: Don’t allow edits in the read-only state (#10404)
Fix #8423 Release Notes: - vim: Fixed vim-surround motions editing read-only buffer (preview-only)
Hans created
3ab9700
Windows: Add missing delete key (#10422)
Add miss delete key in windows platform. Release Notes: - N/A
CharlesChen0823 created
9d96ae6
Redo linux state again (#10452)
With the recent Linux rewrite, I attempted to simplify the number of wrapper structs involved in the Linux code, following the macOS code as an example. Unfortunately, I missed a vital component: pointers to the platform state, held by platform data structures. As we hold all of the platform data structures on Linux, this PR reintroduces a wrapper around the internal state of both the platform and the window. This allows us to close and drop windows correctly. This PR also fixes a performance problem introduced by: https://github.com/zed-industries/zed/pull/10343, where each configure request would add a new frame callback quickly saturating the main thread and slowing everything down. Release Notes: - N/A
Mikayla Maki created
8d7f5ea
Extract Ocaml language support into an extension (#10450)
Release Notes: - Extracted Ocaml language support into an extension --------- Co-authored-by: Marshall <marshall@zed.dev>
Max Brunsfeld and Marshall created