Commit log

2a6f06f Merge pull request #359 from zed-industries/defer

Click to expand commit body 
Fix panic in ProjectDiagnosticsEditor::open_excerpts by introducing new defer feature to GPUI

Nathan Sobo created

e61a5b1 Defer pane interaction when opening excerpts in diagnostics view

Click to expand commit body 
Activating a new item causes the current item to be deactivated. We're the current item, but we're on the stack, so we panic if we try to do this synchronously. If we use defer to wait until we're off the stack it works.

Nathan Sobo created

b755b2d Add ViewHandle::defer

Click to expand commit body 
It's like update, but happens after the current effect instead of synchronously. Also, it doesn't allow the callback to return a value because there would be nothing to do with it.

Nathan Sobo created

8b04c5d Add a ViewContext::defer

Click to expand commit body 
This takes a closure that will be enqueued as an effect to ensure there are no entities on the stack.

Nathan Sobo created

b1931fb Merge pull request #358 from zed-industries/move-buffers-to-project

Click to expand commit body 
Move buffers to project

Nathan Sobo created

8341820 Assign diagnostics on buffer even if it doesn't have a language

Click to expand commit body 
This shouldn't be necessary in practice but makes testing easier.

Nathan Sobo created

8bf628c Update new buffers with existing diagnostics in Project – after assigning language

Nathan Sobo created

2773cab Simplify opening buffers in the Project and assign language synchronously

Antonio Scandurra created

31dfd01 Make `add_local_worktree` private and use `find_or_create_local_worktree`

Click to expand commit body 
The former always adds a worktree, even if we have one already in the
project and that could be misused. The public API should always search
for a local worktree containing the requested path first so that the
project can uphold invariants about which worktrees it has.

Antonio Scandurra created

622aff3 Get diagnostics crate's tests passing

Click to expand commit body 
Update diagnostics on project instead of on worktree

Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

2712cad Get integration tests passing

Click to expand commit body 
* Fix misuse of guest buffer's id as its remote id

Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

f1fc0bd Flush effects after every spawned future completes

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

34e42c0 Remove worktree_id from buffer-related RPC messages

Max Brunsfeld created

03dc1e5 Move main worktree structs adjacent to each other

Max Brunsfeld created

bd49a02 Move buffers from worktree to project

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

7de2630 Remove UserStore from Worktree

Max Brunsfeld created

6751bd9 Change integration tests to open buffers via the project

Max Brunsfeld created

a578d71 v0.13.0

Click to expand commit body 
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>

Nathan Sobo and Max Brunsfeld created

9506f21 Merge pull request #354 from zed-industries/go-to-definition

Click to expand commit body 
Go to definition

Nathan Sobo created

3ecb7e8 Remove panic when guest attempts to go to definition

Click to expand commit body 
We'll implement this soon but want to merge something stable to main.

Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>

Nathan Sobo and Max Brunsfeld created

19751e9 Merge remote-tracking branch 'origin/main' into go-to-definition

Nathan Sobo created

a73671e Revert "Replace `project_path` with `project_entry` in `workspace::{Item, ItemView}`"

Click to expand commit body 
This reverts commit 9c9a09cccb41c4ea2a3d06b32170876e77946ba1.

Nathan Sobo created

1d72e8f Remove source_range from definition

Click to expand commit body 
We don't use it now, and plan on dealing with it in a dedicated way when we need mouse hover interactions.

Co-Authored-By: Antonio Scandurra <me@as-cii.com>

Nathan Sobo and Antonio Scandurra created

4698d57 Add unit test for `Project::definition`

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

64f5a45 Hide weak worktrees in the file finder

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

2fcf1ae Remove weak handles when worktree gets dropped

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

e5662dd Allow observing the release of entities

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

6e7e86e Remove weak worktrees from project when nobody references them

Click to expand commit body 
Also, avoid showing them in the project panel as well as in the
contacts panel.

Antonio Scandurra created

ee95775 Unregister worktree when its last handle to it gets released

Antonio Scandurra created

9505d6c Disable the nav history when selecting a definition in a different buffer

Click to expand commit body 
When jumping between different buffers, we don't care about the cursor's previous location. When navigating backward, we want to jump directly to the site of the jump.

Nathan Sobo created

1c21b51 Merge pull request #355 from zed-industries/activate-existing-windows

Click to expand commit body 
Move window to the foreground when opening a path in an existing workspace

Nathan Sobo created

fbca283 When opening a path in an existing window, move it to the foreground

Nathan Sobo created

377e41a Make navigation history work with project diagnostics

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Max Brunsfeld <max@zed.dev>

Antonio Scandurra , Nathan Sobo , and Max Brunsfeld created

c450945 WIP

Antonio Scandurra created

fad5c98 Center selections when going to definition

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

b6685a5 Make "go to definition" work in project diagnostics

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

d92b404 Change `GoToDefinition` binding to `F12`

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

a53c87e :art:

Antonio Scandurra created

66734e1 WIP: Start on a `GoToDefinition` action for the editor

Antonio Scandurra created

cbbf739 Start on `Project::definition` that only works locally (for now)

Antonio Scandurra created

11a83d0 Advertise link capability in LSP

Antonio Scandurra created

6b1f989 Omit worktree id when emitting `Event::DiskBasedDiagnosticsUpdated`

Click to expand commit body 
Sometimes we will have more than one worktree associated with the same
language server and in that case it's unclear which worktree id we should
report an event for.

Antonio Scandurra created

71082d4 Return a `Task<Result<()>>` in `{ItemView,Buffer,MultiBuffer}::save`

Antonio Scandurra created

634340d Return a task from `Workspace::save_active_item`

Click to expand commit body 
This required changing our approach to OS prompts and this commit greatly
simplifies that. We now avoid passing a callback and return a simple future
instead. This lets callers spawn tasks to handle those futures.

Antonio Scandurra created

e56c043 Get tests passing, centralize more diagnostic logic in Project

Max Brunsfeld created

0992132 Always open buffers via the project

Max Brunsfeld created

f43dcd6 Move logic for starting language servers to the project

Max Brunsfeld created

10c64f5 WIP

Antonio Scandurra created

8052f90 Remove unused `languages` field from `LocalWorktree`

Antonio Scandurra created

ae284c2 Route `save_as` via the `Project`

Click to expand commit body 
Co-Authored-By: Max Brunsfeld <max@zed.dev>

Antonio Scandurra and Max Brunsfeld created