Commit log

0e55f0c Use Rust 2021 edition in all crates

Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

509d362 Avoid stripping newlines before opening backticks in error messages

Max Brunsfeld created

f1d6211 Dial back opacity of border.1 in dark themes

Max Brunsfeld created

76bbd10 Increase diagnostic editor's vertical scroll margin

Click to expand commit body
This way, the first path header will always be fully visible when
you move your cursor to the beginning of the multibuffer.

Max Brunsfeld created

9b9fcf6 Avoid showing selection strip on top of diagnostic headers

Max Brunsfeld created

51c34eb Alpha-blend borders with backgrounds in quad SDF

Click to expand commit body
Co-Authored-By: Max Brunsfeld <max@zed.dev>

Antonio Scandurra and Max Brunsfeld created

02baaa3 Bump the protocol version

Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

e585bc7 Add retries to rescan test that uses the real file system

Click to expand commit body
We could potentially use a fake file system, but this should avoid flaky tests in the short run.

Co-Authored-By: Antonio Scandurra <me@as-cii.com>

Nathan Sobo and Antonio Scandurra created

e54d6f6 Merge pull request #366 from zed-industries/style-project-diagnostics

Click to expand commit body
Style project diagnostics

Nathan Sobo created

0263ea2 Style diagnostic header's border in light and dark theme

Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

dedd5d6 Fix blending of quad's border with background

Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

3f6960b Position underlines at a distance proportional to the line descent

Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

b9b2556 Display squiggly underlines underneath text with diagnostics

Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

52594fe WIP: Start on squiggly underlines

Antonio Scandurra created

a890787 Render header blocks as horizontall fixed (like the gutter)

Click to expand commit body
Tweak editor layout to perform horizontal autoscroll before
laying out the blocks, so that they can access the scroll position.

Max Brunsfeld created

f199340 Account for editor's full scroll width when laying out blocks

Click to expand commit body
Compute the editor's scroll width earlier in layout and
store it on the layout state, rather than computing it repeatedly.

Max Brunsfeld created

cefb639 Tweak diagnostic header styling

Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

e04e929 Render diagnostic status bar icon with icons

Max Brunsfeld created

dbe9698 Show icons and counts in the project diagnostics tab

Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

c9b4bb7 Merge branch 'project-diagnostics-pinned-tab' into style-project-diagnostics

Max Brunsfeld created

78b57e4 Scale diagnostic header and message text with editor font

Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

0c6fd15 Scale diagnostic headers icons with editor font and right align w/ line numbers

Click to expand commit body
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>

Nathan Sobo and Max Brunsfeld created

121b45e Sanitize language server diagnostics coming from Rust

Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

7250974 Style block decorations

Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

65d4c33 Format messages within backticks using bold instead of with a background

Antonio Scandurra created

7e55353 Show error code in diagnostic header

Antonio Scandurra created

ec0ca2a Display icon next to primary message

Antonio Scandurra created

e7ec016 Restyle diagnostic headers

Antonio Scandurra created

b319bda Merge pull request #363 from zed-industries/remote-go-to-definition

Click to expand commit body
Make go-to-definition work for guests

Max Brunsfeld created

0cfb9ff Add random delays in FakeFs

Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

2b8685c Insert random delays when sending and receiving websocket messages in tests

Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

d241ab6 Don't store operations for remote buffers we haven't yet opened

Click to expand commit body
This used to be needed, but we think with our improvements to message ordering that we'll never miss operations that were applied after opening a remote buffer.

Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>

Nathan Sobo and Max Brunsfeld created

afa33c9 Clear shared buffers when unsharing projects

Click to expand commit body
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>

Nathan Sobo and Max Brunsfeld created

469ee55 Get most tests passing when respecting wake order for foreground tasks in Deterministic executor

Click to expand commit body
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>

Nathan Sobo and Max Brunsfeld created

b7314ef WIP: Start restructuring executor

Antonio Scandurra created

96b66dc Fix race condition when opening a buffer and getting a definition to it

Antonio Scandurra created

93125cb Remove `executor::Foreground::Test`

Click to expand commit body
All code paths have already transitioned to `Foreground::Deterministic`.

Antonio Scandurra created

dabab6e Verify simultaneously opening buffers via `definition` and `open_buffer`

Click to expand commit body
This fails because we don't yet handle this scenario.

Antonio Scandurra created

a762f57 Add remote worktree to project before it is fully deserialized

Click to expand commit body
This prevents a race condition where the host will send us messages and
responses about a worktree that we have seen but haven't yet finished loading.

Antonio Scandurra created

245490f Implement `Project::definition` when the buffer is remote

Antonio Scandurra created

528a4dd Fix regression causing guests to miss operations while opening a buffer

Antonio Scandurra created

5403ab3 Merge pull request #360 from zed-industries/improve-files

Click to expand commit body
Improve remote file handling

Antonio Scandurra created

f859d44 Don't show conflict indicator on remote buffer after a reload

Antonio Scandurra created

4372fe1 Maintain remote buffers via `UpdateBufferFile` messages sent by host

Antonio Scandurra created

da13d02 Send File protos as part of Buffer protos

Click to expand commit body
Use the File proto to build the File associated with the buffer rather than relying on the local entry.

Nathan Sobo created

66fce5e Introduce LocalFile trait

Click to expand commit body
If you want to call `abs_path` or `load`, the file needs to be local. You call `as_local` which returns `Option<dyn LocalFile>` with those local-only methods. I think this makes it more explicit what works only locally vs everywhere.

Nathan Sobo created

ea9c5b0 💄

Nathan Sobo created

506ce8e Introduce LocalSnapshot

Click to expand commit body
This allows us to remove the absolute path and scan-related state from the Snapshot. None of this data is relevant or valid on guests.

Nathan Sobo created

d192b6e Remove Worktree::abs_path

Click to expand commit body
I'd like to only have methods related to absolute paths on local worktrees, because it's not really possible to implement them on remote worktrees since we don't know the full path being shared and wouldn't have anything to do with it anyway if we did.

Nathan Sobo created

e2a2073 Remove worktree_path from File struct

Nathan Sobo created