Commit log

92c29be SSH Remoting: Fix reconnects (#19485)

Click to expand commit body
Before this change messages could be lost on reconnect, now they will
not be.

Release Notes:

- SSH Remoting: make reconnects smoother

---------

Co-authored-by: Nathan <nathan@zed.dev>

Conrad Irwin and Nathan created

1ae30f5 Show project panel symlink icons for remote clients (#19464)

Kirill Bulatov created

e820728 Refold updated patch only if the patch was already folded (#19462)

Click to expand commit body
Release Notes:

- N/A

Antonio Scandurra created

781fff2 Fix merging of an update of a symbol with an insert_before operation before the same symbol (#19450)

Click to expand commit body
When we insert before some text and then update that same text, we need
to preserve and concatenate the new text associated with both
operations.

Release Notes:

- N/A

Nathan Sobo created

d209eab Combine excerpt footer and header into a single block (#19441)

Click to expand commit body
This simplifies rendering of excerpt headers and footers, and removes
the need to store a `BlockDisposition` on these boundary blocks. It's a
step toward implementing "replace blocks", which we want to use in the
assistant panel.

We've also cleaned up the way heights are specified for headers and
footers and fixed some visual asymmetries between the "expand upward"
and "expand downward" buttons.

Release Notes:

- N/A

---------

Co-authored-by: Richard <richard@zed.dev>

Max Brunsfeld and Richard created

3e0c5c1 lsp: Handle unregistration "textDocument/rename" from a server (#19427)

Click to expand commit body
Hi. While working on https://github.com/zed-industries/zed/pull/19230 I
noticed that some servers send a request to unregistered the
`textDocument/rename` capability. I thought it would be good to handle
that message in Zed:

```plaintext
[2024-10-18T21:25:07+02:00 WARN  project::lsp_store] unhandled capability unregistration: Unregistration { id: "biome_rename", method: "textDocument/rename" }
```

So this pull request implements that. Thanks.

Release Notes:

- N/A

Vitaly Slobodin created

8a91272 Fix flakey SSH connection (#19439)

Click to expand commit body
Fixes a bug due to the `select!` macro tossing futures that had
partially read messages, causing us to desync our message reading with
the input stream.

Release Notes:

- N/A

---------

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Co-authored-by: conrad <conrad@zed.dev>

Mikayla Maki , Conrad Irwin , and conrad created

30e081b elixir: Bump to v0.1.1 (#19437)

Click to expand commit body
This PR bumps the Elixir extension to v0.1.1.

Changes:

- https://github.com/zed-industries/zed/pull/19135

Release Notes:

- N/A

Marshall Bowers created

a5492b3 Revert "SSH reconnect reliability (#19398)" (#19440)

Click to expand commit body
This reverts commit 98ecb43b2dac3d70f43d745ab32be5a3d4bf323b.

Tests fail on main?!

Closes #ISSUE

Release Notes:

- N/A

Conrad Irwin created

4738000 remote: Fix formatting (#19438)

Click to expand commit body
This PR fixes some formatting issues from #19398 that slipped past CI,
somehow.

Release Notes:

- N/A

Marshall Bowers created

98ecb43 SSH reconnect reliability (#19398)

Click to expand commit body
Release Notes:

- SSH Remoting: Fix message reliability across restarts

---------

Co-authored-by: Nathan <nathan@zed.dev>

Conrad Irwin and Nathan created

be474a6 docs: Update info on JDTLS install for Java (#19436)

Valentine Briese created

b44bed0 collab: Unconditionally execute billing checks (#19432)

Click to expand commit body
This PR removes the conditional checks around the billing-related
enforcement for LLM completions.

These were just in place to prevent executing any billing code before we
had rolled it out. Now that it is rolled out, we don't need this
conditional execution anymore.

Release Notes:

- N/A

Marshall Bowers created

11a82e3 Do not run CI on changes to community action config files (#19430)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

be81e29 Prefer users to open new issues if closed stale issue is valid (#19428)

Click to expand commit body
I no longer want to have to keep my ears and eyes open for GitHub
notifications that relate to someone requesting a closed stale issue be
reopened. As a community maintainer, I can get hundreds or even
thousands of notifications a week, and a lot of those are about activity
on closed issues. If everyone following an issue did not react fast
enough (7 days) to keep an issue flagged as `stale` open, let's instruct
them to open new issues, so we are forced to see it during next triage.

Release Notes:

- N/A

Joseph T. Lyons created

6a463be docs: Direct Java extension users to JDTLS initialization options (#19401)

Click to expand commit body
Continuation of #19390

Valentine Briese created

64a6e9c docs: Outline Jsonnet language (#19410)

Click to expand commit body
This PR adds a basic documentation about the Jsonnet language support.

Release Notes:

- N/A

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>

Vladimir Varankin and Marshall Bowers created

fa738ee vue: Extract to zed-extensions/vue repository (#19426)

Click to expand commit body
This PR extracts the Vue extension to the
[zed-extensions/vue](https://github.com/zed-extensions/vue) repository.

Release Notes:

- N/A

Marshall Bowers created

15449cd svelte: Extract to zed-extensions/svelte repository (#19425)

Click to expand commit body
This PR extracts the Svelte extension to the
[zed-extensions/svelte](https://github.com/zed-extensions/svelte)
repository.

Release Notes:

- N/A

Marshall Bowers created

2db9090 remote: Polish for connection progress & error dialogs (#19379)

Click to expand commit body
Before/after:

![err1-before](https://github.com/user-attachments/assets/43d959b3-c9d9-45dd-938e-42d34ec1cfc5)

![err1-after](https://github.com/user-attachments/assets/311d53e0-752c-4eb8-9816-64b1970c228d)

Before/after (I feel like text-wrapping would be more useful than
text-ellipsis here, but I don't see any wrap function):

![err2-before](https://github.com/user-attachments/assets/1626cda9-bf06-43fe-9b7d-3ec64f4db08a)

![err2-after](https://github.com/user-attachments/assets/749a6950-1409-4e75-808e-a1a96dbfc87e)

Before/after:

![prog-before](https://github.com/user-attachments/assets/f5f5a171-db42-4797-bab0-ad71c750bb20)

![prog-after](https://github.com/user-attachments/assets/b52a7694-36f6-4f7a-8a90-ceb223f12ec1)

Release Notes:

- N/A

Shish created

34b8655 Improve increment/decrement with leading zeros in vim mode (#18362)

Click to expand commit body
- Closes: 18360

Release Notes:

- Added support for incrementing and decrementing numbers with leading
zeros

Thomas created

5b745a8 reqwest_client: Fix `socks` proxy settings (#19123)

Click to expand commit body
Closes #19362

This pull request includes several updates to the `reqwest_client` crate
and its dependencies. The most important changes involve adding support
for SOCKS proxies, improving error handling for proxy URIs, and adding
tests for proxy functionality.

### Dependency Updates:
*
[`Cargo.toml`](diffhunk://#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542L394-R401):
Added support for SOCKS proxies in the `reqwest` dependency by including
the `socks` feature.

### Code Improvements:
*
[`crates/reqwest_client/src/reqwest_client.rs`](diffhunk://#diff-8e036b034e987390be2f57373864b75d6983f0cf84e85c43793eb431d13538f3L47-R52):
Improved error handling when parsing proxy URIs by logging errors
instead of directly panicking.

### Testing Enhancements:
*
[`crates/reqwest_client/src/reqwest_client.rs`](diffhunk://#diff-8e036b034e987390be2f57373864b75d6983f0cf84e85c43793eb431d13538f3R274-R317):
Added tests to verify the handling of various proxy URIs, including
valid and invalid cases.

Release Notes:

- N/A

张小白 created

c59a75d Update actions/upload-artifact digest to b4b15b8 (#19310)

Click to expand commit body
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[actions/upload-artifact](https://redirect.github.com/actions/upload-artifact)
| action | digest | `604373d` -> `b4b15b8` |

---

### Configuration

📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone
America/New_York, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

Release Notes:

- N/A

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMjAuMSIsInVwZGF0ZWRJblZlciI6IjM4LjEyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

renovate[bot] and renovate[bot] created

b3c9313 elixir: Support describe, test, setup, setup_all in outlines (#19135)

Click to expand commit body
Closes #9894 

Release Notes:

- N/A

### Before


![2024-10-12T204848@2x](https://github.com/user-attachments/assets/84b7f123-8845-4e6d-b1b1-444e54ea6599)

### After


![2024-10-12T204749@2x](https://github.com/user-attachments/assets/67fdcead-bad3-4967-9ac4-0b85f1da7bca)

David Baldwin created

73a6c54 vue: Bump to v0.1.1 (#19421)

Click to expand commit body
This PR bumps the Vue extension to v0.1.1.

Changes:

- https://github.com/zed-industries/zed/pull/19419

Release Notes:

- N/A

Marshall Bowers created

2cd6c19 svelte: Bump to v0.2.1 (#19420)

Click to expand commit body
This PR bumps the Svelte extension to v0.2.1.

Changes:

- https://github.com/zed-industries/zed/pull/19418

Release Notes:

- N/A

Marshall Bowers created

6f24c1d vue: Support `lang` attribute for `style` tag injections (#19419)

Click to expand commit body
This PR adds support for injecting languages into `<style>` tags using
`<style lang="...">` in Vue.

Extracted from https://github.com/zed-industries/zed/pull/18052.

Release Notes:

- N/A

Co-authored-by: Albert Marashi <albert@lumina.earth>

Marshall Bowers and Albert Marashi created

5508832 svelte: Adjust block keyword highlighting (#19418)

Click to expand commit body
This PR adjusts the highlights for `{#each ...}` and `{#if ...}`
expression blocks to use keyword highlighting.

Extracted from https://github.com/zed-industries/zed/pull/18052.

Release Notes:

- N/A

Co-authored-by: Albert Marashi <albert@lumina.earth>

Marshall Bowers and Albert Marashi created

35f2f2a Treat `.postcss` files as CSS (#19416)

Click to expand commit body
This PR makes it so `.postcss` files are recognized as CSS.

The `tree-sitter-css` grammar has basic support for PostCSS:
https://github.com/tree-sitter/tree-sitter-css/issues/17#issuecomment-1830349808.

Closes #18051.

Release Notes:

- `.postcss` files are now recognized as CSS.

Marshall Bowers created

9e27b66 keymap: Add cmd-o 'Go to symbol' for JetBrains MacOS key bindings (#19415)

Peter Tripp created

f5124c2 scrollbar: Fix horizontal scrollbar display overflow last item (#19403)

Click to expand commit body
currently, the laste item display is overflow by scrollbar, cause it
cannot clickable.
So remain one item height for display horizontal scrollbar,.
![Screenshot 2024-10-18
192352](https://github.com/user-attachments/assets/d686f0e8-93f8-426e-8816-6f00ed17a599)



Release Notes:

- N/A

CharlesChen0823 created

ea46001 ssh remoting: Undo the spawning of message handlers (#19409)

Click to expand commit body
I suspect that this might have something to do with saving files not
being possible after a while.

I want to merge this and bump nightly.

Release Notes:

- N/A

Thorsten Ball created

5168fc2 docs: More Java extension documentation (#19390)

Click to expand commit body
Follow up of: https://github.com/zed-industries/zed/pull/19113

Peter Tripp created

2bcf9fc Add `client::zed_urls` module for constructing zed.dev URLs (#19391)

Click to expand commit body
This PR adds a new `zed_urls` module to the `client` crate.

This module contains functions for constructing URLs to Zed properties,
such as zed.dev.

The URLs produced by this module will respect the server URL set via
settings or the `ZED_SERVER_URL` environment variable. This allows them
to correctly reflect the current environment (such as when testing Zed
against a local collab/zed.dev).

Release Notes:

- N/A

Marshall Bowers created

3c32f01 paths: Update doc comment (#19388)

Click to expand commit body
This PR updates a doc comment to use proper capitalization.

Also removes an unneeded `return`.

Release Notes:

- N/A

Marshall Bowers created

9d61cd5 ci: Check spelling separately from formatting (#19385)

Click to expand commit body
This PR moves the spelling check out of the `check_style` action, which
we can leave for just checking formatting.

We can't use the `crates-ci-typos` action as-is on the macOS runners due
to the absence of `wget`.

Release Notes:

- N/A

Marshall Bowers created

411f64b Restructure assistant edits to show all changes in a proposed-change editor (#18240)

Click to expand commit body
This changes the `/workflow` command so that instead of emitting edits
in separate steps, the user is presented with a single tab, with an
editable diff that they can apply to the buffer.

Todo

* Assistant panel
* [x] Show a patch title and a list of changed files in a block
decoration
* [x] Don't store resolved patches as state on Context. Resolve on
demand.
    * [ ] Better presentation of patches in the panel
    * [ ] Show a spinner while patch is streaming in
* Patches
* [x] Preserve leading whitespace in new text, auto-indent insertions
    * [x] Ensure patch title is very short, to fit better in tab
* [x] Improve patch location resolution, prefer skipping whitespace over
skipping `}`
    * [x] Ensure patch edits are auto-indented properly
* [ ] Apply `Update` edits via a diff between the old and new text, to
get fine-grained edits.
* Proposed changes editor
    * [x] Show patch title in the tab
    * [x] Add a toolbar with an "Apply all" button
* [x] Make `open excerpts` open the corresponding location in the base
buffer (https://github.com/zed-industries/zed/pull/18591)
* [x] Add an apply button above every hunk
(https://github.com/zed-industries/zed/pull/18592)
* [x] Expand all diff hunks by default
(https://github.com/zed-industries/zed/pull/18598)
    * [x] Fix https://github.com/zed-industries/zed/issues/18589
* [x] Syntax highlighting doesn't work until the buffer is edited
(https://github.com/zed-industries/zed/pull/18648)
* [x] Disable LSP interaction in Proposed Changes editor
(https://github.com/zed-industries/zed/pull/18945)
* [x] No auto-indent? (https://github.com/zed-industries/zed/pull/18984)
* Prompt
    * [ ] make sure old_text is unique

Release Notes:

- N/A

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Co-authored-by: Antonio <antonio@zed.dev>
Co-authored-by: Richard <richard@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>
Co-authored-by: Nate Butler <iamnbutler@gmail.com>
Co-authored-by: Antonio Scandurra <me@as-cii.com>
Co-authored-by: Richard Feldman <oss@rtfeldman.com>

Max Brunsfeld , Marshall Bowers , Antonio , Richard , Marshall , Nate Butler , Antonio Scandurra , and Richard Feldman created

4ae2f93 ci: Improve GitHub Action modularity (#18861)

Click to expand commit body
- Closes: https://github.com/zed-industries/zed/issues/19351
- Switch to using the official [typos GitHub Action](https://github.com/crate-ci/typos/blob/master/docs/github-action.md)
- Move the typos check into `actions/check_style`
- Move Squawk Postgres migration check out of `actions/check_style` file into ci.yml
- `actions/check_style` can now be run on stateless/linux runners (previous required self-hosted MacOS runner)
- ci.yml: Split old `style` into checks into those that can run statelessly (linux) and everything else into a new `migration` group which benefit from the full git checkout available on the MacOS runners.
- ci.yml: Move `Check unused dependencies` from style to `linux_tests`
- Add `if: github.repository_owner == 'zed-industries'` to all jobs so they won't try and run on GitHub forks.

Peter Tripp created

65fb278 Always have cmd-o open a local project (#19376)

Click to expand commit body
Release Notes:

- Fixed `cmd-o` in an SSH project to always open a local project

Conrad Irwin created

e6b9a8e ssh remoting: Handle OpenNewBuffer request (#19373)

Click to expand commit body
Release Notes:

- N/A

Thorsten Ball created

398d039 workspace: Fix inconsistent paths order serialization (#19232)

Click to expand commit body
Release Notes:

- Fixed inconsistent serialization of workspace paths order

Elliot Thomas created

e9e4c77 Update all occurrences of `option_as_meta` to new default value (#19369)

Click to expand commit body
This PR is a quick follow-up to #19364 which updates some left-out
occurrences of `option_as_meta` to the new default value (`false`).

Finn Evers created

4be9da2 remote ssh: Make "get permalink to line" work (#19366)

Click to expand commit body
This makes the `editor: copy permalink to line` and `editor: copy
permalink to line` actions work in SSH remote projects.

Previously it would only work in local projects.

Demo:


https://github.com/user-attachments/assets/a8012152-b631-4b34-9ff2-e4d033c97dee




Release Notes:

- N/A

Thorsten Ball created

c186e99 ssh remote: Reset missed heartbeats on connection activity (#19368)

Click to expand commit body
Ran into this this morning. At least I suspect I ran into it. In any
case: we need to reset the missed hearbeats to 0 in case we got any
connection activity.

Release Notes:

- N/A

Thorsten Ball created

4df882c Make terminal.option_as_meta=false in default settings (#19364)

Click to expand commit body
- This reverts the change I made in https://github.com/zed-industries/zed/pull/15535 which set `option_as_meta` to `true` in the default settings.
- `true` is a reasonable default for US Keyboards, but is terrible for many others which rely on `alt+<key>` for totally normal keystroke combinations.

Peter Tripp created

17f2929 collab: Anchor new subscription's billing cycle to the first of the month (#19367)

Click to expand commit body
This PR makes it so new subscriptions will have their billing cycle
anchored to the first of the month.

When someone signs up today, they will be billed starting on the first
of next month.

Release Notes:

- N/A

Co-authored-by: Antonio <antontio@zed.dev>
Co-authored-by: Richard <richard@zed.dev>

Marshall Bowers , Antonio , and Richard created

5ad3920 Support uppercase extensions in image preview (#19304)

Peter Tripp created

8c91054 Subtract FREE_TIER_MONTHLY_SPENDING_LIMIT from reported monthly spend (#19358)

Click to expand commit body
Release Notes:

- N/A

Antonio Scandurra created

455f241 Introduce a new /billing/monthly_spend API (#19354)

Click to expand commit body
Fixes https://github.com/zed-industries/zed/issues/19353

Release Notes:

- N/A

Antonio Scandurra created

498ecd6 Fetch more than one page when polling stripe events (#19343)

Click to expand commit body
This fixes a bug that was causing most users to be unable to use the
LLMs via Zed. It was caused by not using pagination and, instead, always
querying the very first page of stripe events.

Note that we're also allowing processing events generated in the last 24
hours (before, this was only 1 hour). I did this so that we can process
the backlog of events that the aforementioned bug was skipping.

Release Notes:

- N/A

Antonio Scandurra created