Commit log

970f8db ssh: Don't erase the connection input on escape key (#19550)

Click to expand commit body
This PR changes the behavior of pressing the `Esc` key on the connection
input. Now, if you hit it, the address inserted into the input won't be
erased. Effectively, escape now only cancels the connection process
instead of doing both (clearing the input _and_ cancelling the
connection).

Release Notes:

- N/A

Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>

Danilo Leal and Piotr Osiewicz created

bc9086c ssh: Fix file picker not getting focus when it's opened for the first time (#19546)

Click to expand commit body
Release Notes:

- N/A

Co-authored-by: Danilo <danilo@zed.dev>

Piotr Osiewicz and Danilo created

a367c6d ssh remote: Only send a single FlushBufferedMessages (#19541)

Click to expand commit body
Release Notes:

- N/A

---------

Co-authored-by: Bennet <bennet@zed.dev>

Thorsten Ball and Bennet created

27d1a56 ssh remoting: Emit Disconnected when reconnected exhausted (#19540)

Click to expand commit body
Release Notes:

- N/A

---------

Co-authored-by: Bennet <bennet@zed.dev>

Thorsten Ball and Bennet created

4f52077 Better error handling for SSH (#19533)

Click to expand commit body
Before this change we sometimes showed errors inline, sometimes in
alerts.
Sometimes we closed the window, someimtes we didn't.

Now they always show as prompts and we never close windows.

Co-Authored-By: Mikayla <mikayla@zed.dev>

Release Notes:

- SSH Remoting: Improve error handling

Conrad Irwin created

6e48545 Rename dev servers to remote projects in UI (#19527)

Click to expand commit body
Release Notes:

- N/A

Co-authored-by: Mikayla <mikayla@zed.dev>

Conrad Irwin and Mikayla created

9bae93c SSH Remoting: Fix yes/no/fingerprint prompt (#19526)

Click to expand commit body
Release Notes:

- SSH Remoting: fix SSH fingerprint prompt

Co-authored-by: Mikayla <mikayla@zed.dev>

Conrad Irwin and Mikayla created

1a4b253 collab: Add support for a custom monthly allowance for LLM usage (#19525)

Click to expand commit body
This PR adds support for setting a monthly LLM usage allowance for
certain users.

Release Notes:

- N/A

Marshall Bowers created

89f6b65 docs: Add missing link to jsonnet.md in the summary (#19522)

Click to expand commit body
This is a fixup for #19410.

Apparently, `mdbook` requires a reference to the document from the
`SUMMARY.md`. This fixes the 404
(https://zed.dev/docs/languages/jsonnet.html) and also adds the Jsonnet
to the docs' navigation.

Release Notes:

- N/A

Vladimir Varankin created

a2c6b4a Fix empty keystroke with simulated IME (#19414)

Click to expand commit body
Closes #19181

When the keystroke was empty ("") the `ime_key` was converted from
`None` to `Some("")` when `with_simulated_ime` was called. That was
leading to not intentional behavior when an empty keystroke was combined
with `shift-up` in a keybinding `["workspace::SendKeystrokes", "shift-up
"]`.

By adding a `key.is_empty()` we make sure the `ime_key` keeps as `None`.

This was manually tested. 

Release Notes:

- Fixed empty keystroke with simulated ime

Signed-off-by: Bruno Calza <brunoangelicalza@gmail.com>

Bruno Calza created

6b7d85b SSH Remoting: Fix Save As (#19517)

Click to expand commit body
Co-Authored-By: Mikayla <mikayla@zed.dev>

Closes #ISSUE

Release Notes:

- SSH Remoting: Fix SaveAs to pick the file on the remote

Co-authored-by: Mikayla <mikayla@zed.dev>

Conrad Irwin and Mikayla created

cb3eb75 Fix block-wise autoindent when editing adjacent ranges (#19521)

Click to expand commit body
This fixes problems where auto-indent wasn't working correctly for
assistant edits.

Release Notes:

- Fixed a bug where auto-indent didn't work correctly when pasting with
multiple cursors on adjacent lines

Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld and Marshall created

bae85d8 SSH Remoting: Fix reload/save race (#19519)

Click to expand commit body
Release Notes:

- N/A

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>

Mikayla Maki and Conrad Irwin created

755fd69 editor: Move hunk controls to the right (#19515)

Click to expand commit body
This PR moves the hunk controls over to the right so we can see how they
feel over there.

Git:

<img width="1068" alt="Screenshot 2024-10-21 at 10 27 34 AM"
src="https://github.com/user-attachments/assets/71556e22-024a-4bdf-8a99-fe28430b9155">

Live diffs:

<img width="1060" alt="Screenshot 2024-10-21 at 10 27 28 AM"
src="https://github.com/user-attachments/assets/681ff409-dc55-4b63-87d7-7e39016417d2">


Release Notes:

- Moved hunk controls to the right of the header.

Marshall Bowers created

74e25c1 Fix incorrect checkbox placement in Markdown preview (#19383)

Click to expand commit body
- Closes #12515

Before fix:
<img width="1506" alt="Screenshot 2024-10-17 at 09 50 19"
src="https://github.com/user-attachments/assets/250f50cb-0119-4b96-bc9b-7258aa83247c">

After fix:
<img width="1027" alt="Screenshot 2024-10-17 at 09 52 36"
src="https://github.com/user-attachments/assets/c2eb7e4a-3c03-466c-b215-7fcc22eed024">

Testing:
- Manual testing 
- Added unit test

Test results, these tests fail on the main branch for my setup as well,
I have docker running but still had some failures:
```
failures:
    tests::integration_tests::test_context_collaboration_with_reconnect
    tests::integration_tests::test_formatting_buffer
    tests::integration_tests::test_fs_operations
    tests::integration_tests::test_git_branch_name
    tests::integration_tests::test_git_diff_base_change
    tests::integration_tests::test_git_status_sync
    tests::integration_tests::test_join_after_restart
    tests::integration_tests::test_join_call_after_screen_was_shared
    tests::integration_tests::test_joining_channels_and_calling_multiple_users_simultaneously
    tests::integration_tests::test_leaving_project
    tests::integration_tests::test_leaving_worktree_while_opening_buffer
    tests::integration_tests::test_local_settings
    tests::integration_tests::test_lsp_hover
    tests::integration_tests::test_mute_deafen
    tests::integration_tests::test_open_buffer_while_getting_definition_pointing_to_it
    tests::integration_tests::test_pane_split_left
    tests::integration_tests::test_prettier_formatting_buffer
    tests::integration_tests::test_preview_tabs
    tests::integration_tests::test_project_reconnect
    tests::integration_tests::test_project_search
    tests::integration_tests::test_project_symbols
    tests::integration_tests::test_propagate_saves_and_fs_changes
    tests::integration_tests::test_references
    tests::integration_tests::test_reloading_buffer_manually
    tests::integration_tests::test_right_click_menu_behind_collab_panel
    tests::integration_tests::test_room_location
    tests::integration_tests::test_room_uniqueness
    tests::integration_tests::test_server_restarts
    tests::integration_tests::test_unshare_project
    tests::notification_tests::test_notifications
    tests::random_project_collaboration_tests::test_random_project_collaboration
    tests::remote_editing_collaboration_tests::test_sharing_an_ssh_remote_project

test result: FAILED. 156 passed; 32 failed; 0 ignored; 0 measured; 0 filtered out; finished in 100.98s
```
Comments:
I do not have a ton of rust knowledge, so very open to feedback. TYSM

Release Notes:

- Fix Incorrect checkbox placement in Markdown preview

---------

Co-authored-by: Bennet Bo Fenner <bennet@zed.dev>

Daniel Eichman and Bennet Bo Fenner created

b355a6f Fix markdown preview handling of empty list items (#19449)

Click to expand commit body
Before this change, `parse_block` was consuming events that it doesn't
handle. This was fine in its use in `parse_document`, but in its use in
`parse_list` this broke when there is an empty list item, causing it to
consume list end tags / list item starts / etc.

Release Notes:

- Fixed markdown preview rendering of empty list items.

Michael Sloan created

6341ad2 docs: Correct link to Vue extension (#19508)

Click to expand commit body
Closes -

Release Notes:

- N/A

reslear created

d3cb08b Support .editorconfig (#19455)

Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/8534
Supersedes https://github.com/zed-industries/zed/pull/16349

Potential concerns:
* we do not follow up to the `/` when looking for `.editorconfig`, only
up to the worktree root.
Seems fine for most of the cases, and the rest should be solved
generically later, as the same issue exists for settings.json
* `fn language` in `AllLanguageSettings` is very hot, called very
frequently during rendering. We accumulate and parse all `.editorconfig`
file contents beforehand, but have to go over globs and match these
against the path given + merge the properties still.
This does not seem to be very bad, but needs more testing and
potentially some extra caching.


Release Notes:

- Added .editorconfig support

---------

Co-authored-by: Ulysse Buonomo <buonomo.ulysse@gmail.com>

Kirill Bulatov and Ulysse Buonomo created

d95a4f8 Update swatinem/rust-cache digest to 82a92a6 (#19318)

Click to expand commit body
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [swatinem/rust-cache](https://redirect.github.com/swatinem/rust-cache)
| action | digest | `23bce25` -> `82a92a6` |

---

### Configuration

📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone
America/New_York, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

Release Notes:

- N/A

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMjAuMSIsInVwZGF0ZWRJblZlciI6IjM4LjEyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

renovate[bot] and renovate[bot] created

44dc693 docs: Update C# and C++ configuration pages (#19500)

Click to expand commit body
- Update C# configuration page.
- Fix typo in C++ configuration page.

Release Notes:

- N/A

Alvaro Gaona created

92c29be SSH Remoting: Fix reconnects (#19485)

Click to expand commit body
Before this change messages could be lost on reconnect, now they will
not be.

Release Notes:

- SSH Remoting: make reconnects smoother

---------

Co-authored-by: Nathan <nathan@zed.dev>

Conrad Irwin and Nathan created

1ae30f5 Show project panel symlink icons for remote clients (#19464)

Kirill Bulatov created

e820728 Refold updated patch only if the patch was already folded (#19462)

Click to expand commit body
Release Notes:

- N/A

Antonio Scandurra created

781fff2 Fix merging of an update of a symbol with an insert_before operation before the same symbol (#19450)

Click to expand commit body
When we insert before some text and then update that same text, we need
to preserve and concatenate the new text associated with both
operations.

Release Notes:

- N/A

Nathan Sobo created

d209eab Combine excerpt footer and header into a single block (#19441)

Click to expand commit body
This simplifies rendering of excerpt headers and footers, and removes
the need to store a `BlockDisposition` on these boundary blocks. It's a
step toward implementing "replace blocks", which we want to use in the
assistant panel.

We've also cleaned up the way heights are specified for headers and
footers and fixed some visual asymmetries between the "expand upward"
and "expand downward" buttons.

Release Notes:

- N/A

---------

Co-authored-by: Richard <richard@zed.dev>

Max Brunsfeld and Richard created

3e0c5c1 lsp: Handle unregistration "textDocument/rename" from a server (#19427)

Click to expand commit body
Hi. While working on https://github.com/zed-industries/zed/pull/19230 I
noticed that some servers send a request to unregistered the
`textDocument/rename` capability. I thought it would be good to handle
that message in Zed:

```plaintext
[2024-10-18T21:25:07+02:00 WARN  project::lsp_store] unhandled capability unregistration: Unregistration { id: "biome_rename", method: "textDocument/rename" }
```

So this pull request implements that. Thanks.

Release Notes:

- N/A

Vitaly Slobodin created

8a91272 Fix flakey SSH connection (#19439)

Click to expand commit body
Fixes a bug due to the `select!` macro tossing futures that had
partially read messages, causing us to desync our message reading with
the input stream.

Release Notes:

- N/A

---------

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Co-authored-by: conrad <conrad@zed.dev>

Mikayla Maki , Conrad Irwin , and conrad created

30e081b elixir: Bump to v0.1.1 (#19437)

Click to expand commit body
This PR bumps the Elixir extension to v0.1.1.

Changes:

- https://github.com/zed-industries/zed/pull/19135

Release Notes:

- N/A

Marshall Bowers created

a5492b3 Revert "SSH reconnect reliability (#19398)" (#19440)

Click to expand commit body
This reverts commit 98ecb43b2dac3d70f43d745ab32be5a3d4bf323b.

Tests fail on main?!

Closes #ISSUE

Release Notes:

- N/A

Conrad Irwin created

4738000 remote: Fix formatting (#19438)

Click to expand commit body
This PR fixes some formatting issues from #19398 that slipped past CI,
somehow.

Release Notes:

- N/A

Marshall Bowers created

98ecb43 SSH reconnect reliability (#19398)

Click to expand commit body
Release Notes:

- SSH Remoting: Fix message reliability across restarts

---------

Co-authored-by: Nathan <nathan@zed.dev>

Conrad Irwin and Nathan created

be474a6 docs: Update info on JDTLS install for Java (#19436)

Valentine Briese created

b44bed0 collab: Unconditionally execute billing checks (#19432)

Click to expand commit body
This PR removes the conditional checks around the billing-related
enforcement for LLM completions.

These were just in place to prevent executing any billing code before we
had rolled it out. Now that it is rolled out, we don't need this
conditional execution anymore.

Release Notes:

- N/A

Marshall Bowers created

11a82e3 Do not run CI on changes to community action config files (#19430)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

be81e29 Prefer users to open new issues if closed stale issue is valid (#19428)

Click to expand commit body
I no longer want to have to keep my ears and eyes open for GitHub
notifications that relate to someone requesting a closed stale issue be
reopened. As a community maintainer, I can get hundreds or even
thousands of notifications a week, and a lot of those are about activity
on closed issues. If everyone following an issue did not react fast
enough (7 days) to keep an issue flagged as `stale` open, let's instruct
them to open new issues, so we are forced to see it during next triage.

Release Notes:

- N/A

Joseph T. Lyons created

6a463be docs: Direct Java extension users to JDTLS initialization options (#19401)

Click to expand commit body
Continuation of #19390

Valentine Briese created

64a6e9c docs: Outline Jsonnet language (#19410)

Click to expand commit body
This PR adds a basic documentation about the Jsonnet language support.

Release Notes:

- N/A

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>

Vladimir Varankin and Marshall Bowers created

fa738ee vue: Extract to zed-extensions/vue repository (#19426)

Click to expand commit body
This PR extracts the Vue extension to the
[zed-extensions/vue](https://github.com/zed-extensions/vue) repository.

Release Notes:

- N/A

Marshall Bowers created

15449cd svelte: Extract to zed-extensions/svelte repository (#19425)

Click to expand commit body
This PR extracts the Svelte extension to the
[zed-extensions/svelte](https://github.com/zed-extensions/svelte)
repository.

Release Notes:

- N/A

Marshall Bowers created

2db9090 remote: Polish for connection progress & error dialogs (#19379)

Click to expand commit body
Before/after:

![err1-before](https://github.com/user-attachments/assets/43d959b3-c9d9-45dd-938e-42d34ec1cfc5)

![err1-after](https://github.com/user-attachments/assets/311d53e0-752c-4eb8-9816-64b1970c228d)

Before/after (I feel like text-wrapping would be more useful than
text-ellipsis here, but I don't see any wrap function):

![err2-before](https://github.com/user-attachments/assets/1626cda9-bf06-43fe-9b7d-3ec64f4db08a)

![err2-after](https://github.com/user-attachments/assets/749a6950-1409-4e75-808e-a1a96dbfc87e)

Before/after:

![prog-before](https://github.com/user-attachments/assets/f5f5a171-db42-4797-bab0-ad71c750bb20)

![prog-after](https://github.com/user-attachments/assets/b52a7694-36f6-4f7a-8a90-ceb223f12ec1)

Release Notes:

- N/A

Shish created

34b8655 Improve increment/decrement with leading zeros in vim mode (#18362)

Click to expand commit body
- Closes: 18360

Release Notes:

- Added support for incrementing and decrementing numbers with leading
zeros

Thomas created

5b745a8 reqwest_client: Fix `socks` proxy settings (#19123)

Click to expand commit body
Closes #19362

This pull request includes several updates to the `reqwest_client` crate
and its dependencies. The most important changes involve adding support
for SOCKS proxies, improving error handling for proxy URIs, and adding
tests for proxy functionality.

### Dependency Updates:
*
[`Cargo.toml`](diffhunk://#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542L394-R401):
Added support for SOCKS proxies in the `reqwest` dependency by including
the `socks` feature.

### Code Improvements:
*
[`crates/reqwest_client/src/reqwest_client.rs`](diffhunk://#diff-8e036b034e987390be2f57373864b75d6983f0cf84e85c43793eb431d13538f3L47-R52):
Improved error handling when parsing proxy URIs by logging errors
instead of directly panicking.

### Testing Enhancements:
*
[`crates/reqwest_client/src/reqwest_client.rs`](diffhunk://#diff-8e036b034e987390be2f57373864b75d6983f0cf84e85c43793eb431d13538f3R274-R317):
Added tests to verify the handling of various proxy URIs, including
valid and invalid cases.

Release Notes:

- N/A

张小白 created

c59a75d Update actions/upload-artifact digest to b4b15b8 (#19310)

Click to expand commit body
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[actions/upload-artifact](https://redirect.github.com/actions/upload-artifact)
| action | digest | `604373d` -> `b4b15b8` |

---

### Configuration

📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone
America/New_York, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

Release Notes:

- N/A

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMjAuMSIsInVwZGF0ZWRJblZlciI6IjM4LjEyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

renovate[bot] and renovate[bot] created

b3c9313 elixir: Support describe, test, setup, setup_all in outlines (#19135)

Click to expand commit body
Closes #9894 

Release Notes:

- N/A

### Before


![2024-10-12T204848@2x](https://github.com/user-attachments/assets/84b7f123-8845-4e6d-b1b1-444e54ea6599)

### After


![2024-10-12T204749@2x](https://github.com/user-attachments/assets/67fdcead-bad3-4967-9ac4-0b85f1da7bca)

David Baldwin created

73a6c54 vue: Bump to v0.1.1 (#19421)

Click to expand commit body
This PR bumps the Vue extension to v0.1.1.

Changes:

- https://github.com/zed-industries/zed/pull/19419

Release Notes:

- N/A

Marshall Bowers created

2cd6c19 svelte: Bump to v0.2.1 (#19420)

Click to expand commit body
This PR bumps the Svelte extension to v0.2.1.

Changes:

- https://github.com/zed-industries/zed/pull/19418

Release Notes:

- N/A

Marshall Bowers created

6f24c1d vue: Support `lang` attribute for `style` tag injections (#19419)

Click to expand commit body
This PR adds support for injecting languages into `<style>` tags using
`<style lang="...">` in Vue.

Extracted from https://github.com/zed-industries/zed/pull/18052.

Release Notes:

- N/A

Co-authored-by: Albert Marashi <albert@lumina.earth>

Marshall Bowers and Albert Marashi created

5508832 svelte: Adjust block keyword highlighting (#19418)

Click to expand commit body
This PR adjusts the highlights for `{#each ...}` and `{#if ...}`
expression blocks to use keyword highlighting.

Extracted from https://github.com/zed-industries/zed/pull/18052.

Release Notes:

- N/A

Co-authored-by: Albert Marashi <albert@lumina.earth>

Marshall Bowers and Albert Marashi created

35f2f2a Treat `.postcss` files as CSS (#19416)

Click to expand commit body
This PR makes it so `.postcss` files are recognized as CSS.

The `tree-sitter-css` grammar has basic support for PostCSS:
https://github.com/tree-sitter/tree-sitter-css/issues/17#issuecomment-1830349808.

Closes #18051.

Release Notes:

- `.postcss` files are now recognized as CSS.

Marshall Bowers created

9e27b66 keymap: Add cmd-o 'Go to symbol' for JetBrains MacOS key bindings (#19415)

Peter Tripp created