Commit log

a210062 Refresh diagnostics and code actions more selectively

Antonio Scandurra created

cbe93af Reduce number of iterations on `test_editing_while_guest_opens_buffer`

Click to expand commit body 
I think this was mistakenly increased as part of some other change.

Antonio Scandurra created

ca052b4 Make `test_propagate_saves_and_fs_changes` more robust

Click to expand commit body 
...by using a condition that awaits on the actual paths as opposed
to the simple file counts.

Antonio Scandurra created

e354133 Remove stray log statements

Antonio Scandurra created

f2b4a06 Fix integration test verifying the rename behavior

Click to expand commit body 
Specifically, the test now ensures that the host's worktree observes a/file1's
change event *before* the rename occurs, otherwise when interpreting the change
event it will mistakenly think that the file has been deleted (because its path
has changed) and will subsequently fail to detect the rename, causing the test
to fail.

Antonio Scandurra created

7b9ff42 Apply worktree updates in the order they were received

Antonio Scandurra created

5a7d391 Ensure response barrier is always dropped, even if request is canceled

Antonio Scandurra created

174c9d7 Adjust multibuffer history test to reflect new behavior

Max Brunsfeld created

8d65048 Reduce logging in lsp tests

Max Brunsfeld created

d84fc3b Remove Buffer::apply_lsp_edits

Click to expand commit body 
Always use `edits_from_lsp`.

Max Brunsfeld created

d4b9d9e Inline MultiBuffer::format

Click to expand commit body 
Put all the logic in Editor. Add an `all_buffers` method so the editor can
format all of the buffers by itself.

Max Brunsfeld created

06bb8d2 Fix panic when canceling with a pending selection

Max Brunsfeld created

01664d4 Restructure fake language server to setup request handlers in advance

Click to expand commit body 
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld , Antonio Scandurra , and Nathan Sobo created

680d1fe Always call set_selections in mouse selection methods

Click to expand commit body 
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld , Antonio Scandurra , and Nathan Sobo created

947fe84 Make multibuffer anchor's buffer_id optional

Click to expand commit body 
Avoid using 0 for a buffer id on Anchor::min and max

Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld , Antonio Scandurra , and Nathan Sobo created

fa194c8 Pass the pending selection to update_selections and set_selections

Click to expand commit body 
This helps us preserve our invariant of always having at least a pending selection in set_selections when comparing old and new cursor positions.

Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>

Nathan Sobo and Max Brunsfeld created

ad9a0e2 Revert "Ensure there's always at least one selection in the editor"

Click to expand commit body 
This reverts commit b1a44b5816eeb021efbd5bb49cd5a60573cf508a.

Nathan Sobo created

612a331 Allow toggling of code actions

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

7b28418 Allow deployment of code actions from indicator

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

b1a44b5 Ensure there's always at least one selection in the editor

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

a41725d Render code actions indicator

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

2fcdcac Fetch code actions on cursor movement instead of on-demand

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

763d57c Don't return error when definition, completions, etc. are unavailable

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

3fc3e51 Fix panic when trying to render a diagnostic that has no message

Antonio Scandurra created

4929b8c Move `Buffer::format` to `Project::format`

Antonio Scandurra created

645df73 Finish implementing Buffer::edits_from_lsp

Max Brunsfeld created

3a1f9bb Start work on applying LSP edits via a diff

Click to expand commit body 
Co-Authored-By: Antonio Scandurra <me@as-cii.com>

Max Brunsfeld and Antonio Scandurra created

424b352 Don't open a multibuffer when code actions's edits are contained in the current editor

Click to expand commit body 
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld , Antonio Scandurra , and Nathan Sobo created

5049c1b Make Editor::newest_anchor_selection return a non-optional value

Click to expand commit body 
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>

Nathan Sobo , Antonio Scandurra , and Max Brunsfeld created

93eb005 Correctly redo all undone edits after undoing in multi-buffer

Click to expand commit body 
When undoing edits performed in the multi-buffer, we also undo subsequent edits that may have occurred outside of the multi-buffer. This commit makes us redo those edits as well.

Co-Authored-By: Antonio Scandurra <me@as-cii.com>

Nathan Sobo and Antonio Scandurra created

c5b0b5f Store the oldest transaction id for each excerpted buffer in multi-buffer transactions

Click to expand commit body 
Co-Authored-By: Antonio Scandurra <me@as-cii.com>

Nathan Sobo and Antonio Scandurra created

9936bb2 Undo subsequent edits when undoing in multi-buffer

Click to expand commit body 
When undoing in the multi-buffer, don't preserve edits that occurred outside the multi-buffer after the edit being undone.

Co-Authored-By: Antonio Scandurra <me@as-cii.com>

Nathan Sobo and Antonio Scandurra created

d1f1563 Push transaction into multi-buffer to allow undoing of a code action

Antonio Scandurra created

dd223f9 Allow editor to be saved when in multi-buffer mode

Click to expand commit body 
Also, this commit enables the customization of the title in a multi-buffer.
When specified, it will take precedence over a filename (or "untitled").

Antonio Scandurra created

9ea5359 Fix `push_excerpts_with_context_lines` when ranges overlap

Antonio Scandurra created

9749fea Start work on MultiBuffer::push_excerpts_with_context_lines

Click to expand commit body 
Use it in Editor::confirm_code_action

Max Brunsfeld created

471c23e Allow inserting multiple excerpts in a batch

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

aa7dfbd Remove ExcerptProperties struct

Click to expand commit body 
Pass buffer and range as separate parameters

Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

b67be5d Add MultiBufferItemHandle

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

ca697e1 Add BufferSnapshot::edited_ranges_for_transaction

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created

1ee15e1 Add and remove excerpts in randomized FoldMap and WrapMap tests

Max Brunsfeld created

5b4c0d6 Get tests passing and project diagnostics view working w/ new excerpt headers

Max Brunsfeld created

3d9c39d Silence warnings

Max Brunsfeld created

fc70c6d Fix BlockMap's handling of trailing empty excerpt updates with other edits

Click to expand commit body 
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld , Antonio Scandurra , and Nathan Sobo created

cbf59ff Handle replacing trailing empty excerpt with another empty excerpt

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Max Brunsfeld <max@zed.dev>

Antonio Scandurra , Nathan Sobo , and Max Brunsfeld created

fab6f0c Add/remove excerpts in BlockMap randomized tests and fix resulting errors

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Max Brunsfeld <max@zed.dev>

Antonio Scandurra , Nathan Sobo , and Max Brunsfeld created

8d95dbe Render path headers in editor element

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

f1e3d52 Fix randomized test failures on `BlockMap` with excerpt headers

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Antonio Scandurra and Nathan Sobo created

0e1318d WIP: Make `editor` crate compile again

Click to expand commit body 
Tests are still failing though.

Antonio Scandurra created

c7e2fae WIP - Add excerpt headers as a built-in feature of BlockMap

Click to expand commit body 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Max Brunsfeld and Nathan Sobo created