Commit log

4b24411 Merge branch 'main' into v0.173.x

Marshall Bowers created

2197ccf Revert "edit prediction: Do not render jump cursor until line layout is ready (#24226)"

Click to expand commit body
This reverts commit 722fd59d9cbba1c4c109f571a44c551a43845fb1.

Marshall Bowers created

8fd2067 Revert "edit prediction: Fix jump cursor position when scrolled (#24230)"

Click to expand commit body
This reverts commit bc67f990ae374a96e81ab5e1afa8540a9bf1c13a.

Marshall Bowers created

598abb5 Revert "zed 0.173.1"

Click to expand commit body
This reverts commit 57d09d2fd3ec37745476251029372ef5f9762644.

Marshall Bowers created

be8a2b2 Revert "edit prediction: Allow enabling OSS data collection with no project open (#24265)"

Click to expand commit body
This reverts commit 1748fbeec86cd22fb9bbc87a7193680c59ba3cfc.

Marshall Bowers created

c2c9187 Revert "edit predictions: Onboarding funnel telemetry (#24237)"

Click to expand commit body
This reverts commit 45f9192137d6487e1f5e94aa86f0787ba7de7f96.

Marshall Bowers created

59b382a Revert "Accept edit predictions with `alt-tab` in addition to `tab` (#24272)"

Click to expand commit body
This reverts commit eafad7d9db9dead3561e19070ff71a93f26f602a.

Marshall Bowers created

c532d95 Revert "Fix panic when deleting an empty line after a deleted hunk (cherry-pick #24255) (#24282)"

Click to expand commit body
This reverts commit 79714fca98124d85b4f759196c4f5e8c75bcd4ca.

Marshall Bowers created

55720ff Revert "Implement character index for point (cherry-pick #23989) (#24284)"

Click to expand commit body
This reverts commit 8ed71b2dd0f1b595b235f56f0e720bbffc02e20d.

Marshall Bowers created

e893c32 Revert "edit prediction: Improve UX around `disabled_globs` and `show_inline_completions` (#24207)"

Click to expand commit body
This reverts commit 68b4f9ee1d8b8800b5adb885844d6111e387bc3b.

Marshall Bowers created

904c395 Revert "Revert recent anti-aliasing improvements (cherry-pick #24289) (#24291)"

Click to expand commit body
This reverts commit af0f36de7b5eeb2f7a068c9343efb3cb5fa9931a.

Marshall Bowers created

c00a1fb Revert "edit prediction: Fix license detection error logging + check for different spellings (#24281)"

Click to expand commit body
This reverts commit 9f825ca3cfd15a84f4aaae3a4153f650d1a991fa.

Marshall Bowers created

a9c33f3 Revert "Fix the worktree's repository_for_path (cherry-pick #24279) (#24292)"

Click to expand commit body
This reverts commit 0542019e2572a15b23fe5ad40586525ee04b423f.

Marshall Bowers created

91e99b3 Revert "zed 0.173.2"

Click to expand commit body
This reverts commit d54f6f97a760e2cf8a4880daa1145c3b5941c21e.

Marshall Bowers created

e280f96 Revert "gpui: Render SVGs at 2x size when rendered in an `img` (cherry-pick #24332) (#24336)"

Click to expand commit body
This reverts commit 58834b4e3a3543206edf9c55713521a6eb49e3e2.

Marshall Bowers created

997c121 Revert "Bump to 0.173.3 for @maxdeviant"

Click to expand commit body
This reverts commit 95062b363e71c1a10ef82560dc5e9b4891e7a432.

Marshall Bowers created

17a4705 Revert "assistant_context_editor: Fix patch block not rendering due to window reborrow (cherry-pick #24461) (#24463)"

Click to expand commit body
This reverts commit e7f64c7d98a289e0e6b11b86397ba90838738651.

Marshall Bowers created

ab392fc Revert "Bump to 0.173.4 for @maxdeviant"

Click to expand commit body
This reverts commit af67af86da1e417eb17ee8184a49c712c6c30f98.

Marshall Bowers created

fd7fa87 edit predictions: Restore red dot in status buttons when pending ToS (#24408)

Click to expand commit body
In one of the recent changes to the edit predictions status bar menu, we
lost the red dot that is displayed when the user has Zed as the provider
but hasn't accepted terms of service. Note: All the checks were still in
place, just the visual indicator was missing.

![CleanShot 2025-02-06 at 20 22
21@2x](https://github.com/user-attachments/assets/da8f25dd-5ed2-4bf9-8453-10b80f00bf63)


Release Notes:

- N/A

---------

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>

Agus Zubiaga and Danilo Leal created

a7a14e5 edit predictions: Clarify `disabled_globs` documentation (#24460)

Click to expand commit body
This PR clarifies how the `disabled_globs` work.

Release Notes:

- N/A

---------

Co-authored-by: Bennet Bo Fenner <53836821+bennetbo@users.noreply.github.com>

Danilo Leal and Bennet Bo Fenner created

af67af8 Bump to 0.173.4 for @maxdeviant

Zed Bot created

e7f64c7 assistant_context_editor: Fix patch block not rendering due to window reborrow (cherry-pick #24461) (#24463)

Click to expand commit body
Cherry-picked assistant_context_editor: Fix patch block not rendering
due to window reborrow (#24461)

This PR fixes an issue where the Assistant patch block was not being
rendered when using "Suggest Edits".

The issue was that the `BlockContext` already has a borrow of the
`Window`, so we can't use `update_in` to reborrow the window.

The fix is to reuse the existing `&mut Window` reference from the
`BlockContext` so we don't need to `update_in`.

Closes #24169.

Release Notes:

- Assistant: Fixed an issue where the patch block was not being rendered
when using "Suggest Edits".

---------

Co-authored-by: Max <max@zed.dev>

Co-authored-by: Marshall Bowers <git@maxdeviant.com>
Co-authored-by: Max <max@zed.dev>

gcp-cherry-pick-bot[bot] , Marshall Bowers , and Max created

8ff8dbd assistant_context_editor: Fix patch block not rendering due to window reborrow (#24461)

Click to expand commit body
This PR fixes an issue where the Assistant patch block was not being
rendered when using "Suggest Edits".

The issue was that the `BlockContext` already has a borrow of the
`Window`, so we can't use `update_in` to reborrow the window.

The fix is to reuse the existing `&mut Window` reference from the
`BlockContext` so we don't need to `update_in`.

Closes #24169.

Release Notes:

- Assistant: Fixed an issue where the patch block was not being rendered
when using "Suggest Edits".

---------

Co-authored-by: Max <max@zed.dev>

Marshall Bowers and Max created

44c6a54 pane: Improve close active item to better handle pinned tabs (#23488)

Click to expand commit body
Closes #22247

- [x] Do not close pinned tab on keyboard shortcuts like `ctrl+w` or
`alt+f4`
- [x] Close pinned tab on context menu action, menu bar action, or vim
bang
- [x] While closing pinned tab via shortcut (where it won't close),
instead activate any other non-pinned tab in same pane
- [x] Else, if any other pane contains non-pinned tab, activate that
- [x] Tests

Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>

Release Notes:

- Pinned tab now stay open when using close shortcuts, auto focuses to
any other non-pinned tab instead.

smit created

f0565b4 edit prediction: Do not show icon as disabled when there is no buffer open (#24458)

Click to expand commit body
Release Notes:

- N/A

Bennet Bo Fenner created

a6e15dd Make it a bit clearer when people are running dev builds (#24457)

Click to expand commit body
Release Notes:

- Include an indicator in About/CopySystemSpecs when running in debug mode

Conrad Irwin created

144487b theme: Implement icon theme reloading (#24449)

Click to expand commit body
Closes #24353 

This PR implements icon theme reload to ensure file icons are properly
updated whenever an icon theme extension is upgraded or uninstalled.

Currently, on both upgrade and uninstall of an icon theme extension the
file icons from the previously installed version will stay visibile and
will not be updated as shown in the linked issue. With this change, file
icons will properly be updated on extension upgrade or reinstall.

The code is primarily a copy for reloading the current color theme
adapted to work for icon themes. Happy for any feedback!


Release Notes:

- Fixed file icons not being properly updated upon icon theme upgrade or
uninstall.

Finn Evers created

2d57e43 docs: Emphasize that Rust must be installed via rustup (#24447)

Click to expand commit body
Just tried installing a dev extension and kept getting "error: failed to install dev extension".

Turns out this was because I had rust installed via homebrew and not rust. Once I switched to rustup, it worked perfectly fine.

Release Notes:

- N/A

Wilhelm Klopp created

c484374 Make OpenKeyContextView open to the right (#24452)

Click to expand commit body
Match the behavior of OpenSyntaxTreeView logs and OpenLanguageServerLogs

Release Notes:

- Make `debug::OpenSyntaxTreeView` automatically open in split to the
right

Peter Tripp created

8114d17 google_ai: Add support for Gemini 2.0 models (#24448)

Click to expand commit body
Add support for the newly released Gemini 2.0 models from Google announced this new family of models earlier this week (2025-02-05).

Release Notes:

- Added support for Google's new Gemini 2.0 models.

IaVashik created

c7cd5b0 file_icons: Use separate icon key for JSON files (#24432)

Click to expand commit body
This PR updates the file icon mappings for JSON (`.json`) file map to
the`json` key. Also, updates `.json` icon from `storage` to `code`.

This allows for the JSON file icons to be replaced in icon themes.

Release Notes:

- Icon themes: Added the ability to change the file icon for JSON
(`.json`) files.

---------

Co-authored-by: Marshall Bowers <git@maxdeviant.com>

Sanjeev Shrestha and Marshall Bowers created

0792922 migrator: Sort dependencies in `Cargo.toml` (#24455)

Click to expand commit body
This PR sorts the dependencies in the `Cargo.toml` for the `migrator`
crate.

Release Notes:

- N/A

Marshall Bowers created

00c2a30 Migrate keymap and settings + edit predictions rename (#23834)

Click to expand commit body
- [x] snake case keymap properties
- [x] flatten actions
- [x] keymap migration + notfication
- [x] settings migration + notification
- [x] inline completions -> edit predictions 

### future: 
- keymap notification doesn't show up on start up, only on keymap save.
this is existing bug in zed, will be addressed in seperate PR.

Release Notes:

- Added a notification for deprecated settings and keymaps, allowing you
to migrate them with a single click. A backup of your existing keymap
and settings will be created in your home directory.
- Modified some keymap actions and settings for consistency.

---------

Co-authored-by: Piotr Osiewicz <piotr@zed.dev>
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>

smit , Piotr Osiewicz , and Max Brunsfeld created

a1544f4 Fix incorrect assumption about `Path.extension()` (#24443)

Click to expand commit body
Release Notes:

- N/A

Ben Kunkle created

4f65cfa Fix `editor::GoToDiagnostics` cycle (#24446)

Click to expand commit body
https://github.com/user-attachments/assets/45f665f0-473a-49bd-b013-b9d1bdb902bd


After activating 2nd diagnostics group, `find_map` code for next
diagnostics did not skip the previous group for the same place.

Release Notes:

- Fixed `editor::GoToDiagnostics` action stuck when multiple diagnostics
groups belong to the same place

Kirill Bulatov created

b6b06cf lsp: Send DidOpen notifications when changing selections in multi buffer (#22958)

Click to expand commit body
Fixes #22773

Release Notes:

- Fixed an edge case with multibuffers that could break language
features within them.

Piotr Osiewicz created

f700268 Improve vim interactions with edit predictions (#24418)

Click to expand commit body
* When an edit prediction is present in non-insertion modes, hide it but
show `tab Jump to edit`.
* Removes discarding of edit predictions when going from insert mode to
normal mode, instead just hide them in non-insertion modes.
* Removes zeta-specific showing of predictions in normal mode. This
behavior was only happening in special cases anyway - where the discard
of completions wasn't happening due to some other thing taking
precedence in `dismiss_menus_and_popups`.

Release Notes:

- N/A

---------

Co-authored-by: Conrad <conrad@zed.dev>
Co-authored-by: Mikayla <mikayla@zed.dev>

Michael Sloan , Conrad , and Mikayla created

92c21a2 Fix undismissed app notifications appearing on new workspaces (#24437)

Click to expand commit body
Bug in #23817

Release Notes:

- N/A

Michael Sloan created

1f9d026 Fixes to commit button in Git Panel (#24425)

Click to expand commit body
Git Panel updates:

* Fixes commit/commit all button to work (and be disabled correctly in
merge conflict status)
* Updates keyboard shortcuts and sets focus on the button (enter now
does the same as click; tab cycles between editor and change list)


Closes #ISSUE

Release Notes:

- N/A *or* Added/Fixed/Improved ...

---------

Co-authored-by: Cole Miller <cole@zed.dev>

Conrad Irwin and Cole Miller created

6534e0b linux: Fix crash when NoKeymap event is received on Wayland (#24379)

Click to expand commit body
Closes #24139

For weird reasons, Sway on few linux distoros sends `NoKeymap` event when
switching windows. Zed crashes due to assertion on this event to be `XkbV1`.

To fix this, we ignore `NoKeymap` event instead crashing Zed.

Release Notes:

- Fixed a crash in Wayland-based compositors like Sway when switching windows via the keyboard.

smit created

5ffacb9 Revert "Move git status updates to a background thread (#24307)" (#24415)

Click to expand commit body
This reverts commit 980ce5fbf2d0de7e954c32dd982268d3b58dfccc.

Release Notes:

- N/A

---------

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>

Cole Miller and Conrad Irwin created

864c1ff Use `commondir` from libgit2 instead of walking fs (#22028)

Click to expand commit body
Release Notes:

- N/A

Michael Sloan created

35ef269 Fix build of remote_server when not in git repo (#24424)

Click to expand commit body
Followup to #24258

Release Notes:

- N/A

Michael Sloan created

d97adfc Fix pairs of almost-adjacent hunks toggling together (#24355)

Click to expand commit body
Release Notes:

- Fixed a bug where toggling a diff hunk that immediately precedes
another hunk would act on both hunks

Cole Miller created

a42e040 Remove use of `use_key_equivalents` from linux keymap as it does nothing (#24422)

Click to expand commit body
`use_key_equivalents` does nothing on linux, as key equivalents are only
supported on mac. While it could be sensible to anticipate support,
right now it is only used in these few spots, so removing it.

Release Notes:

- N/A

Michael Sloan created

8646d37 vim: Replace with Register (#24326)

Click to expand commit body
Closes #18813

Release Notes:

- vim: Add `gr` for [replace with
register](https://github.com/vim-scripts/ReplaceWithRegister)

Conrad Irwin created

d83c316 Fix Project Panel `select_next_git_entry` action (#24217)

Click to expand commit body
## Context

I noticed that the project panel `select_next_git_entry` wasn't behaving
correctly. Turns out it was searching in reverse, which caused the
action to select itself or the last entry.

This PR corrects the behavior and adds a unit test that should stop
regressions.

Note: Since select next/prev git entry uses the same function as select
next/prev diagnostic, the test partially works for that as well.

Release Notes:

- Fix bug where `select_next_git_entry` project panel action would only
select a previous entry or the currently selected entry.

---------

Co-authored-by: Mikayla Maki <mikayla@zed.dev>

Anthony Eid and Mikayla Maki created

c591389 gpui: Fix `text-align` with nowrap mode (#24116)

Click to expand commit body
Release Notes:

- N/A


------

- Continue #24090 to fix text align for when used `whitespace_nowrap`.
- Fix wrapped line length calculation.

And add example

```
cargo run -p gpui --example text_layout
```

<img width="760" alt="image"
src="https://github.com/user-attachments/assets/a087c300-0e0e-4a80-98c6-90161a9b0905"
/>

---------

Co-authored-by: Owen Law <owenlaw222@gmail.com>

Jason Lee and Owen Law created

e689c8c markdown: Use parsed text (#24388)

Click to expand commit body
Fixes #15463

Release Notes:

- Fixed display of symbols such as `&nbsp;` in hover popovers

Stanislav Alekseev created

888a2df Sort `Cargo.toml`s (#24417)

Click to expand commit body
This PR sorts the dependencies in a number of `Cargo.toml` files.

Release Notes:

- N/A

Marshall Bowers created