Commit log

42571e4 Ensure inlay hint toggling with modifiers happens fast (#25852)

Click to expand commit body
Follow-up of https://github.com/zed-industries/zed/pull/25766 
Fixes the bugs found:

* modifier toggle not happening instantly due to `edit_debounce_ms`
considered
* hint update race that ignored the cache clear

Release Notes:

- N/A

Kirill Bulatov created

2d61a51 Diff View: Scroll to center of hunks when reviewing (#25846)

Click to expand commit body
When reviewing hunks, scroll to put them at the center of the screen
so you can better see the context around that hunk.

The field `center_cursor` was added to the actions `editor::GoToHunk`
and `editor::GoToPrevHunk`, this was set to `false` by default in
keymaps, as it wouldn't help with in-editor navigation.

The field is set to `true` for when you trigger `git::StageAndNext`
and `git::UnstageAndNext`, this is also `true` for the buttons in the
Diff View toolbar.

Release Notes:

- N/A

João Marcos created

a2876f5 Support hunk-wise `StageAndNext` and `UnstageAndNext` (#25845)

Click to expand commit body
This PR adds the `whole_excerpt` field to the actions:

- `git::StageAndNext`
- `git::UnstageAndNext`

Which is set by false by default, effectively, now staging and unstaging
with these actions is done hunk-by-hunk, this also affects the `Stage`
and
`Unstage` buttons in the Diff View toolbar.

A caveat: with this PR, there is no way to configure the buttons in the
Diff
View toolbar to restore the previous behavior, if we want, I think we
can make
it a setting, but let's see if anyone really wants that.

Release Notes:

- N/A

João Marcos created

13deaa3 Fix new git panel buttons (#25844)

Click to expand commit body
Release Notes:

- N/A

Cole Miller created

694afd1 Fix buffer search options not resetting when dismissed after Vim mode search then reopened with `buffer: deploy search` (#25838)

Click to expand commit body
Closes #25315

Release Notes:

- Fixes an issue where the buffer search options would not be reset when
using `buffer: deploy search` after using Vim search (`*` & `#`) which
enable all search options

Ben Kunkle created

eb648dd Follow-up tweaks to new git panel footer (#25832)

Click to expand commit body
- Use a popover for the branch picker
- Don't deploy a repository selector if there's only one repo

Release Notes:

- N/A

Cole Miller created

1c4c568 Allow unfolding deleted buffers in project diff w/ keyboard (#25835)

Click to expand commit body
Release Notes:

- N/A

Max Brunsfeld created

ec88a68 Fix active pane modifiers applying to parent pane axis if child pane is active (#25836)

Click to expand commit body
Closes #25304

Release Notes:

- Fixed an issue where `active_pane_modifiers` settings would be applied
to a parent pane if one of it's child panes was active

Ben Kunkle created

7fb1697 chore: Extract PromptStore out of prompt_library (#25837)

Click to expand commit body
One step closer to removing long pole with assistant/assistant2 builds

Release Notes:

- N/A

Piotr Osiewicz created

53b2792 Improve script/mitm-proxy.sh to support podman (#25834)

Peter Tripp created

760d087 Update bundled JSON schemas (2025-02-28) (#25826)

Click to expand commit body
Updated JSON schemas to
[SchemaStore/schemastore@b107b83](https://github.com/SchemaStore/schemastore/tree/b107b83a50bad9ac06dd171201dc870901f92ca8)
(2025-02-28)

-
[tsconfig.json](https://github.com/SchemaStore/schemastore/commits/master/src/schemas/json/tsconfig.json)
@
[b107b83](https://raw.githubusercontent.com/SchemaStore/schemastore/b107b83a50bad9ac06dd171201dc870901f92ca8/src/schemas/json/tsconfig.json)
-
[package.json](https://github.com/SchemaStore/schemastore/commits/master/src/schemas/json/package.json)
@
[b107b83](https://raw.githubusercontent.com/SchemaStore/schemastore/b107b83a50bad9ac06dd171201dc870901f92ca8/src/schemas/json/package.json)

Previously:
- https://github.com/zed-industries/zed/pull/20910

Release Notes:

- Updated bundled JSON schemas for package.json and tsconfig.json

Peter Tripp created

71866d6 assistant2: Include some text in the tool result messages (#25825)

Click to expand commit body
This PR makes it so we include some textual content in the user messages
that as used to send up tool results.

I observed that when sending up the tool results with no text, it would
lead the model to start replying with no text, which would then result
in an error when attaching later tool results.

I think there's a deeper issue at play here, but for now we just include
some text to keep the model on track.

Release Notes:

- N/A

Marshall Bowers created

0c2bbb3 Optimistically update hunk states when staging and unstaging hunks (#25687)

Click to expand commit body
This PR adds an optimistic update when staging or unstaging diff hunks.
In the process, I've also refactored the logic for staging and unstaging
hunks, to consolidate more of it in the `buffer_diff` crate.

I've also changed the way that we treat untracked files. Previously, we
maintained an empty diff for them, so as not to show unwanted
entire-file diff hunks in a regular editor. But then in the project diff
view, we had to account for this, and replace these empty diffs with
entire-file diffs. This form of state management made it more difficult
to store the pending hunks, so now we always use the same
`BufferDiff`/`BufferDiffSnapshot` for untracked files (with a single
hunk spanning the entire buffer), but we just have a special case in
regular buffers, that avoids showing that entire-file hunk.

* [x] Avoid creating a long queue of `set_index` operations when
staging/unstaging rapidly
* [x] Keep pending hunks when diff is recalculated without base text
changes
* [x] Be optimistic even when staging the single hunk in added/deleted
files
* Testing

Release Notes:

- N/A

---------

Co-authored-by: Cole Miller <m@cole-miller.net>

Max Brunsfeld and Cole Miller created

9d8a163 git_ui: New panel design (#25821)

Click to expand commit body
This PR updates the ui of the git panel. It removes the header from the
panel and unifies the repository, branch and commit controls in the
bottom section.

It also adds a secondary menu to the primary button giving access to a
variety of actions for managing local and remote changes:

![CleanShot 2025-02-28 at 12 18
15@2x](https://github.com/user-attachments/assets/0260c122-405f-46fc-8cc8-d6beac782b9d)

Known issues (will be fixed in a later pr)
- Spinner showing git operation progress was removed, will be re-added
- Clicking expand with the panel editor focused will commit (due to
shared action name. Already tracked)

Before | After

![CleanShot 2025-02-28 at 12 22
18@2x](https://github.com/user-attachments/assets/4c1e4ac9-b975-487f-bf4e-8815a8da4f4f)

(Also adds `component`, `linkme` to cargo-machete ignore as they are
used in the `IntoComponent` proc-macro and will always be incorrectly
flagged as unused)

Release Notes:

- N/A

---------

Co-authored-by: Cole Miller <m@cole-miller.net>
Co-authored-by: Cole Miller <53574922+cole-miller@users.noreply.github.com>
Co-authored-by: Cole Miller <cole@zed.dev>

Nate Butler , Cole Miller , Cole Miller , and Cole Miller created

8a22a07 git: Adjust rendering of git hunks (#25824)

Click to expand commit body
- Light themes get their own values (creating better contrast and a
better distinction between staged and unstaged hunks in light themes.)
- Scrollbar git hunks indicators now use the correct colors

Before:

![CleanShot 2025-02-28 at 14 31
29@2x](https://github.com/user-attachments/assets/038fe11c-7163-4f1b-92b8-56b24c8e9443)

After:

![CleanShot 2025-02-28 at 14 32
04@2x](https://github.com/user-attachments/assets/869d33d9-d925-4cbe-84bd-e54caf971431)


Release Notes:

- Fixed an issue where git hunk indicators in editor scrollbars used the
incorrect colors.

Nate Butler created

fad4df5 editor: Add Organize Imports Action (#25793)

Click to expand commit body
Closes #10004

This PR adds support for the organize imports action. Previously, you
had to manually configure it in the settings and then use format to run
it.

Note: Default key binding will be `alt-shift-o` which is similar to
VSCode's organize import. Also, because `cmd-shift-o` is taken by
outline picker.

Todo:

- [x] Initial working
- [x] Handle remote
- [x] Handle multi buffer
- [x] Can we make it generic for executing any code action?

Release Notes:

- Added `editor:OrganizeImports` action to organize imports (sort,
remove unused, etc) for supported LSPs. You can trigger it by using the
`alt-shift-o` key binding.

smit created

e4e758d Rust 1.85 (#25272)

Click to expand commit body
Closes #ISSUE

Release Notes:

- N/A *or* Added/Fixed/Improved ...

---------

Co-authored-by: Anthony Eid <hello@anthonyeid.me>

Piotr Osiewicz and Anthony Eid created

fc52b43 assistant2: Factor out tool use into its own module (#25819)

Click to expand commit body
This PR factors out the concerns related to tool use out of `Thread` and
into their own module.

Release Notes:

- N/A

Marshall Bowers created

b445e4c assistant2: Rework how tool results are stored and referred to (#25817)

Click to expand commit body
This PR reworks how we store tool results and refer to them later.

We now maintain a mapping of the tool uses to their corresponding
results, with separate mappings for the messages and the tool uses they
correspond to.

Release Notes:

- N/A

Marshall Bowers created

508b581 assistant: Refine settings view's instruction visuals (#25812)

Click to expand commit body
I've been bothered by using simple hyphens for bullet lists here for a
while; it kinda looked cheap and not well-formatted. So, in this PR, I'm
adding a new, custom UI component in the `language_models` crate, called
`InstructionListItem`, based off the `ListItem` that's somewhat
mimic'ing what a `<li>` would be on the web.

It does have a "rigid" structure as in it's always a label followed by a
button (which is optional), but that seems okay given it has been the
overall shape of the copy we've been using here. Also, never really
loved that we were pasting URLs directly, that kinda felt cheap, too. I
could see an argument where it's just clearer, but it looks too
cluttered, as URLs aren't super pretty, necessarily.

| Before | After |
|--------|--------|
| <img
src="https://github.com/user-attachments/assets/ffd1ac27-b1f4-450d-abf5-079285fc9877"
width="700px" /> | <img
src="https://github.com/user-attachments/assets/28fb9d0d-205d-45d8-9e43-1aaa947adc96"
width="700px" /> |

Release Notes:

- N/A

Danilo Leal created

c9aba6c windows: Use a clippy script instead of `xtask` (#25807)

Click to expand commit body
Closes #ISSUE

Match the behaviour of our macOS and Linux tests

Release Notes:

- N/A *or* Added/Fixed/Improved ...

张小白 created

5740fec Ensure search input always has regex language synced with search_options state (#25811)

Click to expand commit body
Follow-up to https://github.com/zed-industries/zed/pull/25797

Release Notes:

- N/A

Kirill Bulatov created

22220ed windows: Remove unnecessary code in #25412 (#25805)

Click to expand commit body
Closes #ISSUE

Release Notes:

- N/A *or* Added/Fixed/Improved ...

张小白 created

7440833 Add a way to toggle inlay hints with modifiers #2 (#25766)

Click to expand commit body
https://github.com/zed-industries/zed/pull/25752 with fixes on top

* Ensures no flickering happens for all modifiers `: false` case
* Dismisses the toggled state on focus out
* Reworks cache state so that "enabled" and "toggled by modifiers" are
different states with their own lifecycle

Release Notes:

- N/A

Kirill Bulatov created

bb3aef1 Reset buffer language on buffer search redeploy (#25797)

Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/25792

Release Notes:

- Fixed search input regex highlight not going away after redeploy

Kirill Bulatov created

ece1818 docs: Add documentation for use_smartcase_search (#25786)

Click to expand commit body
Closes #24795

Added missing documentation for `use_smartcase_search`. 

Release Notes:

- N/A

Devzeth created

604eb91 logging: Add runtime log replace upon max size limit (#25768)

Click to expand commit body
Closes #25638

We currently only check the log size limit at startup and move `Zed.log`
to `Zed.log.old`. If a user runs Zed for an extended period, there's no
runtime restriction on the log file size, which can cause it to grow to
several gigabytes.

This PR fixes that by tracking the log file size while writing. If it
exceeds a certain threshold, we perform the same log replace and
continue logging.

Release Notes:

- Fixed an issue where `Zed.log` could grow excessively large during
long sessions of Zed.

smit created

472dde5 Capitalize default slash command description (#25794)

Click to expand commit body
Update default slash command to use description constant format from
https://github.com/zed-industries/zed/pull/18595.

|Before|After|
|---|---|

|![image](https://github.com/user-attachments/assets/107a321e-0e91-40dd-8c38-4d55fd4f6d28)|![image](https://github.com/user-attachments/assets/f487a518-15bb-45c4-b524-25e6373a5886)|

^ This is when you type slash in the assistant panel.

Release Notes:

- N/A

5brian created

212c8f4 html: Bump to v0.1.6 (#25791)

Click to expand commit body
Includes:
- #25130

Release Notes:

- N/A

Nathan Igo created

6092918 assistant: Improve Amazon Bedrock configuration instructions (#25699)

Shardul Vaidya created

a5f9690 Update to suggest commit message based on file staging (#25790)

Click to expand commit body
Currently, you only get a suggested commit message if you have a single
changed file in the repository. After the PR, the suggest happens per
single-staged file.

https://github.com/user-attachments/assets/4cc19fe6-099c-4690-967d-898b8ca7540b

Release Notes:

- N/A

Joseph T. Lyons created

b15aa5e rust: Fix test/doctest tasks showing up outside of tests (#25787)

Click to expand commit body
Closes #ISSUE

Release Notes:

- Fixes Rust test tasks showing up outside of tests

Piotr Osiewicz created

62fb555 Use "restore" more consistently in the git panel (#25780)

Click to expand commit body
This PR replaces almost all uses of "discard" in the git panel UI with
"restore", since that's the verb we settled on for the project diff.

The only exception is in the confirmation prompt for restoring files,
where I've kept the "discard changes" language. I think consistency is
less important here and it's helpful to rephrase the action that's being
taken to emphasize that it's destructive.

Release Notes:

- N/A

Cole Miller created

c0ecf86 Remove `once_cell` dependency (#25769)

Click to expand commit body
Release Notes:

- N/A

---------

Co-authored-by: Marshall Bowers <git@maxdeviant.com>

FalkWoldmann and Marshall Bowers created

df7beb4 Use active worktree's task sources (#25784)

Click to expand commit body
Follow-up of https://github.com/zed-industries/zed/pull/25605

Previous PR made global tasks with `ZED_WORKTREE_ROOT` available for
"nothing open" scenario, this PR also gets all related worktree task
templates, using the centralized `TextContexts`' active worktree
detection.

Release Notes:

- N/A

Kirill Bulatov created

6f30d5d Use consistent comment style in `default.json` (#25783)

Click to expand commit body
This PR updates the comments in the `default.json` file consistently use
`//`.

Some comments were using `///`, which doesn't make sense in JSONC.

Release Notes:

- N/A

Marshall Bowers created

b8387c6 docs: Clarify wording around `...` in `language_servers` setting (#25782)

Click to expand commit body
This PR clarifies the wording around how `...` is used in the
`language_servers` setting.

Closes https://github.com/zed-industries/zed/issues/25779.

Release Notes:

- N/A

Marshall Bowers created

c05ce88 docs: Add note about `path` in `extensions.toml` (#25778)

Click to expand commit body
This PR adds a note about the `path` field in `extensions.toml` and how
to use it.

Suggested in https://github.com/zed-industries/extensions/pull/2128.

Release Notes:

- N/A

Marshall Bowers created

eaf3949 edit predictions: Remove `enabled_in_assistant` docs for now (#25777)

Click to expand commit body
I shouldn't have added this because it's not out yet

Release Notes:

- N/A

Agus Zubiaga created

c47305d title_bar: Fix the order of the collab buttons (#25775)

Click to expand commit body
My previous #24761 and #25192 PR's changed the order of the buttons in
the title_bar for collab, the logic is kept the same but the order is
now as it was previously.

Release Notes:

- N/A

Co-authored-by: Marshall Bowers <git@maxdeviant.com>

Devzeth and Marshall Bowers created

482a45f Fix broken merge (#25776)

Click to expand commit body
Closes #ISSUE

Release Notes:

- N/A *or* Added/Fixed/Improved ...

Cole Miller created

7ec3702 Fix cursor position when navigating to a multibuffer's first excerpt (#25723)

Click to expand commit body
This PR fixes an unexpected cursor position when jumping to the
beginning of the project diff editor's first excerpt if that excerpt
starts with a deleted region. Previously, the cursor would end up in the
*following* region in this situation; now it ends up at the start of the
deleted region, as happens already for excerpts that are not the first.

Release Notes:

- N/A

---------

Co-authored-by: Max <max@zed.dev>

Cole Miller and Max created

91862dd markdown_preview: Fix markdown preview not updating on `AcceptEditPrediction` (#25772)

Click to expand commit body
Closes #25384

Markdown preview now subscribes to `ExcerptsEdited` event which is
emited when edit prediction is accepted.

Release Notes:

- Fixed markdown preview not updating when edit prediction is accepted.

smit created

eb4fad5 Fix panic when scrolling in project diff (#25771)

Click to expand commit body
It may happen that the column for the scroll anchor is nonzero, and the
adjustment we're doing here could result in an invalid point in that
case.

Release Notes:

- N/A

Co-authored-by: Max <max@zed.dev>

Cole Miller and Max created

541a5c0 edit predictions: Fix docs for `enabled_in_assistant` (#25770)

Click to expand commit body
Remove mention of "prompt editor" since that feature isn't out yet.

Release Notes:

- N/A

Agus Zubiaga created

82f7931 edit predictions: Add `enabled_in_assistant` setting (#25767)

Click to expand commit body
Release Notes:

- edit predictions: Add `enabled_in_assistant` setting

Agus Zubiaga created

6eb2ffe Support absolute `disabled_globs` (#25755)

Click to expand commit body
Closes: #25556

We were always comparing `disabled_globs` against the relative file
path, we'll now use the absolute path if the glob is also absolute.

Release Notes:

- Support absolute globs in `edit_predictions.disabled_globs`

Agus Zubiaga created

c5632f8 Revert "Add a way to toggle inlay hints with modifiers" (#25764)

Click to expand commit body
This PR caused inlay hints to show on every modifiers press

Reverts zed-industries/zed#25752

Release Notes:

- N/A

Mikayla Maki created

6856e86 Fix git panel's suggested commit message not updating (#25708)

Click to expand commit body
Closes #ISSUE

Release Notes:

- N/A

Cole Miller created

cc3b5c7 Keep cursor at top when diff view is first opened (#25682)

Click to expand commit body
Previously, we had the cursor at the bottom while the scroll stayed at
the top.

Now, if you run `git: diff`, the cursor will also be at the top.

The cursor moving to the end was possibly a side-effect of using
`Bias::Right` for selections.

---

Release Notes:

- N/A

Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>

João Marcos and Max Brunsfeld created